[PATCH] Modularizing key-test.c

I noticed key-test.c contained a lot of duplicate code so I modularized it
a bit by using an array of structs to process.

Here is the patch.

Regards,

	Shlomi Fish

----------------------------------------------------------------------
Shlomi Fish        shlomif <at> vipe.technion.ac.il
Home Page:         http://t2.technion.ac.il/~shlomif/

He who re-invents the wheel, understands much better how a wheel works.

--- subversion/subversion/tests/libsvn_fs/key-test.c.orig	2002-10-27 06:23:53.000000000 +0200
+++ subversion/subversion/tests/libsvn_fs/key-test.c	2002-10-27 06:56:30.000000000 +0200
 <at>  <at>  -28,161 +28,94  <at>  <at> 
 
 
 
-static svn_error_t *
-next_key (const char **msg, 
-          svn_boolean_t msg_only,
-          apr_pool_t *pool)
+struct next_key_struct
 {
-  apr_size_t len, olen;

Re: cvs2svn (r3200) problem

>>>>> "Will" == Will Andrews <will <at> csociety.org> writes:

Will> On Sat, Oct 26, 2002 at 07:21:33PM +0200, Michael Sperber [Mr.  Preprocessor] wrote:
>> 
>> For me, cvs2svn from 0.14.3 aka r3200 drops the ball with this:
>> 
>> Traceback (most recent call last):
>>   File "./cvs2svn.py", line 702, in ?
>>     main()
>>   File "./cvs2svn.py", line 699, in main
>>     util.run_app(convert, ctx, start_pass=start_pass)
>>   File
"/afs/informatik.uni-tuebingen.de/i386_fbsd46/subversion-0.14.3/lib/python2.2/site-packages/svn/util.py",
line 38, in run_app
>>     return apply(func, (pool,) + args, kw)
>>   File "./cvs2svn.py", line 632, in convert
>>     _passes[i](ctx)
>>   File "./cvs2svn.py", line 589, in pass4
>>     c.commit(t_fs, ctx)
>>   File "./cvs2svn.py", line 443, in commit
>>     conflicts, new_rev = fs.commit_txn(txn)
>> TypeError: svn_fs_commit_txn() takes exactly 2 arguments (1 given)
>> 
>> The type error seems real enough, but I'm not deep enough into
>> Subversion to figure out the Right Way to fix this.

Will> Yes, this was fixed with a later version of subversion.  I don't
Will> remember the exact revision, but I think it was around 3250 or
Will> 3275.  C-Mike fixed it when I nagged him so I know it's fixed. :)
Will> That, and I regularly convert a (small) repo with cvs2svn...

[PATCH] Correct long option parsing in cvs2svn.py

With python 2.2 the following command line with only exit with the
usage message

	cvs2svn -v --trunk /debian/debian-proxy/trunk \
	    --branches /debian/debian-proxy/branches \
	    --tags /debian/debian-proxy/tags \
	    -s svn cvs/debian/debian-proxy

The following patch adds "=" to the long options so that they will
expect a following argument.

Index: tools/cvs2svn/cvs2svn.py
===================================================================
--- tools/cvs2svn/cvs2svn.py
+++ tools/cvs2svn/cvs2svn.py	2002-10-27 10:49:11.000000000 +0000
 <at>  <at>  -665,7 +665,7  <at>  <at> 

   try:
     opts, args = getopt.getopt(sys.argv[1:], 'p:s:vn',
-                               [ "create", "trunk", "branches", "tags" ])
+                               [ "create", "trunk=", "branches=", "tags=" ])
   except getopt.GetoptError:
     usage(ctx)
   if len(args) != 1:

--

-- 
Jon

"First things first -- but not necessarily in that order"
                -- The Doctor, "Doctor Who"		

Doc patches (Was: Exciting news about the Subversion Handbook...)

Congrats and thanks for the book project to all involved parties!

Please let me take this opportunity to remind you of the doc patches I
sent in recently (Oct 18). I just verified on
   http://svnbook.red-bean.com/book.html
that the typos I fixed in these patches still need fixing.

Thanks,
--

-- 
andreas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe <at> subversion.tigris.org
For additional commands, e-mail: dev-help <at> subversion.tigris.org

networking repositories

I am trying to decide if subversion is going to meet my needs.  There is one 
sticking point I am not sure about from the documentation.  Can someone 
please advise me if I am correct or not.

Basically, I will be working at a mixture of my desktop machine and on a 
laptop.  At home, these are networked - but I work away from home with my 
laptop during the week not connected to any network, and want to version 
manage the software development I am working on whilst away.

I was thinking that I could set up a local repository on my laptop and another 
repository on my desktop (local or remote?).  The question I cannot really 
understand, is can I synchronise them in someway by doing

svnadmin dump <laptop-repos> | svnadmin load <desktop-repos>

and vica versa.

I think it must be more complex than that - in that I probably need to detect 
revision numbers in some way so ensure transactions don't get duplicated.

The other approach I was thinking of was just a raw dump of the repository 
files - but this has two disadvantages.  One that will be a lot of data to 
transfer, and secondly - what do I do if I have forgotten to do the transfer 
before I go away - I can't merge transactions when I get back.

Any advice?
--

-- 
Alan Chandler
alan <at> chandlerfamily.org.uk

Re: networking repositories

On Sun, Oct 27, 2002 at 12:43:47PM +0000, Alan Chandler wrote:

> Basically, I will be working at a mixture of my desktop machine and on a 
> laptop.  At home, these are networked - but I work away from home with my 
> laptop during the week not connected to any network, and want to version 
> manage the software development I am working on whilst away.
> 
> I was thinking that I could set up a local repository on my laptop and another 
> repository on my desktop (local or remote?).  The question I cannot really 
> understand, is can I synchronise them in someway by doing

What about a single repos on your laptop, and when on your home
computer, you just commit to the desktop (since they seem to be in a
network) ? :)

If, for any reason, this cannot be done, I think your case would be a
good example of distributed repositories, which is still under heavy
discussions ...

--

-- 
Sebastien Cevey <seb <at> cine7.net>
Cine7 - www.cine7.net
Milcis - www.milcis.net
ICQ: 48895760

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe <at> subversion.tigris.org
For additional commands, e-mail: dev-help <at> subversion.tigris.org

Re: networking repositories

On Sun, Oct 27, 2002 at 01:40:40PM +0100, Sebastien Cevey wrote:

> What about a single repos on your laptop, and when on your home
> computer, you just commit to the desktop (since they seem to be in a
> network) ? :)

Oops I meant "you commit to the laptop", sorry for the confusion.

--

-- 
Sebastien Cevey <seb <at> cine7.net>
Cine7 - www.cine7.net
Milcis - www.milcis.net
ICQ: 48895760

" You are not special. You are not a beautiful or unique snowflake. "
Brad Pitt (Tyler Durden) [ Fight Club ]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe <at> subversion.tigris.org
For additional commands, e-mail: dev-help <at> subversion.tigris.org

doc/book/tools/dblite?

the HACKING and README files in doc/book seem to imply that some 
docbook-lite documentation is part of our tree, but the 
'doc/book/tools/dblite/doc' directory doesn't seem to be there.  is 
this an oversite in README/HACKING, or did someone forget to add them?

-garrett

--

-- 
garrett rooney                    Remember, any design flaw you're
rooneg <at> electricjellyfish.net      sufficiently snide about becomes
http://electricjellyfish.net/     a feature.       -- Dan Sugalski

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe <at> subversion.tigris.org
For additional commands, e-mail: dev-help <at> subversion.tigris.org

Re: networking repositories

On Sunday 27 October 2002 12:42 pm, Sebastien Cevey wrote:
> On Sun, Oct 27, 2002 at 01:40:40PM +0100, Sebastien Cevey wrote:
> > What about a single repos on your laptop, and when on your home
> > computer, you just commit to the desktop (since they seem to be in a
> > network) ? :)
>
> Oops I meant "you commit to the laptop", sorry for the confusion.

Nice idea - but not quite what I need.  The problem is that the laptop doesn't 
get backed up with quite the same degree of automation and frequency.

But I'll see if I can work with it for a while.

Would still like an answer to the orginal question - does dump/load 
combination work 

--

-- 
Alan Chandler
alan <at> chandlerfamily.org.uk

Re: networking repositories

I, too, have thought about this problem.  In my case, I usually work
offline.  I can keep my repo here, at home.  The problem is, I want to
give read-only access to the repo to other people (I have webhosting at
a friend's place where I can run apache2+mod_svn).

I think I'll proably end up rsyncing the repository from my box to
the web server every so often.  I'll

- shut down apache2
- rsync from my home box over
- start apache2

since I don't think (know) it's safe to rsync when clients might be
accessing stuff.

Faried.
--

-- 
The Great GNU has arrived, infidels, behold his wrath !
"If a MOO runs on a port no one accesses, does it run?"

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe <at> subversion.tigris.org
For additional commands, e-mail: dev-help <at> subversion.tigris.org