headers
Jakub Narebski | 1 Feb 2008 01:17
Picon
Gravatar

Re: [PATCH] gitweb: Use config file or file for repository owner's name.

On Thu, 31 Jan 2008, Johannes "Dscho" Schindelin wrote:
> On Wed, 30 Jan 2008, Jakub Narebski wrote:
>> Junio C Hamano <gitster <at> pobox.com> writes:
>>> Junio C Hamano <gitster <at> pobox.com> writes:
>>> 
>>> Rephrasing to be constructive (but remember, this is all post 1.5.4).
>>> 
>>>  * we would need for historical reasons to keep supporting
>>>    description and cloneurl for some time.  There may be some
>>>    others, but the goal should be to deprecate and remove these
>>>    ad-hoc one-file-per-piece-of-information files.
>>> 
>>>  * we also need for historical reasons to keep supporting some
>>>    other stuff found in $git_dir/config of the project.
>>> 
>>> If the config reading interface in gitweb is reasonably fast and 
>>> cheap, we can move the existing description/cloneurl to gitweb config 
>>> when deprecating them.  New ones such as "owner" would naturally fit 
>>> there.
>> 
>> Currently gitweb parses repo config file _once_, using one call to 
>> git-config -z -l.
>> 
>> We could simply add description to the projects_list file, but it will 
>> be a bit backwards incompatibile change.
> 
> Not if you say "the config overrides the description/cloneurl file", i.e. 
> when there is a description or a cloneurl from the config, don't even 
> bother to stat the single-line files.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Tommy Thorn | 1 Feb 2008 02:18
Picon
Favicon

git-p4 runs out of memory

Trying to survive in a heavily Perforce dominated 
world, git-p4 looked like the perfect antidote. 
Unfortunately I have a few problems:

0. git-p4 swells until it runs out of virtual space!
It
   appears that the scripts tries to read everything 
   into memory:

 filedata = p4CmdList('-x - print',
                      stdin='\n'.join(['%s#%s' %
(f['path'], f['rev'])
                                       for f in
files]),
                      stdin_mode='w+')

  Short of rewriting git-p4, is it possible to clone
in
  multiple steps?

1. Short of full Perforce client support, support of 
   exclusion would have helped. Dmitry Kakurin
provided
   a good start. I'll try to generalize it such that
   multiple exclusion can be specified as 

     -//branch/file/blah

2. Having "git p4 commit" be an alias of 
   "git p4 submit" seems a mistake - this is not a
(Continue reading)

Permalink | Reply | 0 comments |
headers
Roger C. Soares | 1 Feb 2008 03:12
Picon

[EGIT PATCH] Use keyboard arrow keys to go to the next and previous find results.

On the history find toolbar, if the pattern text field has focus,
the down arrow key will generate a next event and the up arrow key
will generate the previous event.

Signed-off-by: Roger C. Soares <rogersoares <at> intelinet.com.br>
---
 .../src/org/spearce/egit/ui/FindToolbar.java       |   23 +++++++++++++++++++-
 1 files changed, 22 insertions(+), 1 deletions(-)

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java
index bc48371..5527453 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/FindToolbar.java
 <at>  <at>  -21,6 +21,8  <at>  <at>  import java.util.List;

 import org.eclipse.core.runtime.Preferences;
 import org.eclipse.swt.SWT;
+import org.eclipse.swt.events.KeyAdapter;
+import org.eclipse.swt.events.KeyEvent;
 import org.eclipse.swt.events.ModifyEvent;
 import org.eclipse.swt.events.ModifyListener;
 import org.eclipse.swt.events.SelectionAdapter;
 <at>  <at>  -193,7 +195,7  <at>  <at>  public class FindToolbar extends Composite {
 			}
 		});

-		Listener findButtonsListener = new Listener() {
+		final Listener findButtonsListener = new Listener() {
 			public void handleEvent(Event event) {
 				if (patternField.getText().length() > 0
(Continue reading)

Permalink | Reply | 1 comment |
headers
Robin Rosenberg | 1 Feb 2008 05:07
Favicon

[PATCH] Make blame accept absolute paths


Blame did not always use prefix_path.

Signed-off-by: Robin Rosenberg <robin.rosenberg <at> dewire.com>
---
 builtin-blame.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

This is a followup to "setup: sanitize absolute and funny paths in get_pathspec()"
Thanks Junio for fixing this wish of mine.

diff --git a/builtin-blame.c b/builtin-blame.c
index c7e6887..f88c32a 100644
--- a/builtin-blame.c
+++ b/builtin-blame.c
 <at>  <at>  -1894,9 +1894,7  <at>  <at>  static unsigned parse_score(const char *arg)

 static const char *add_prefix(const char *prefix, const char *path)
 {
-	if (!prefix || !prefix[0])
-		return path;
-	return prefix_path(prefix, strlen(prefix), path);
+	return prefix_path(prefix, prefix ? strlen(prefix) : 0, path);
 }

 /*
--

-- 
1.5.4.rc4.25.g81cc
(Continue reading)

Permalink | Reply | 0 comments |
headers
Robin Rosenberg | 1 Feb 2008 05:34
Favicon

[PATCH] More test cases for sanitized path names

Verify a few more commands and pathname variants.

Signed-off-by: Robin Rosenberg <robin.rosenberg <at> dewire.com>
---
 t/t7010-setup.sh |   39 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 39 insertions(+), 0 deletions(-)

These are a few testcases from my earlier attempt at this. The
log and commit cases succeeded with Junios version, but not 
blame and some of the nastier versions for git add (same
principle for all commands, just that I use add as an example)

-- robin

diff --git a/t/t7010-setup.sh b/t/t7010-setup.sh
index da20ba5..60c4a46 100755
--- a/t/t7010-setup.sh
+++ b/t/t7010-setup.sh
 <at>  <at>  -114,4 +114,43  <at>  <at>  test_expect_success 'git ls-files (relative #3)' '

 '

+test_expect_success 'commit using absolute path names' '
+	git commit -m "foo" &&
+	echo aa >>a/b/c/d &&
+	git commit -m "aa" "$(pwd)/a/b/c/d"
+'
+
+test_expect_success 'log using absolute path names' '
+	echo bb >>a/b/c/d &&
(Continue reading)

Permalink | Reply | 12 comments |
headers
Michael Witten | 1 Feb 2008 05:59
Picon
Favicon

[PATCH] git-send-email: ssh/login style password requests

Whilst convenient, it is most unwise to record passwords
in any place but one's brain. Moreover, it is especially
foolish to store them in configuration files, even with
access permissions set accordingly.

git-send-email has been amended, so that if it detects
an smtp username without a password, it promptly prompts
for the password and masks the input for privacy.

Furthermore, the argument to --smtp-pass has been rendered
optional.

The documentation has been updated to reflect these changes.

Signed-off-by: Michael Witten <mfwitten <at> mit.edu>
---

	This was sent with the updated git-send-email ;-)

 Documentation/git-send-email.txt |   19 +++++++++++++++----
 git-send-email.perl              |   23 +++++++++++++++++++----
 2 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0554f2b..6d5abf4 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
 <at>  <at>  -96,12 +96,23  <at>  <at>  The --cc option must be repeated for each user you want on the cc list.
 	servers typically listen to smtp port 25 and ssmtp port
 	465).
(Continue reading)

Permalink | Reply | 15 comments |
headers
Thomas Glanzmann | 1 Feb 2008 06:16
Picon

SLES 9 git packages [WAS: SLES 10 git packages]

Petr,

> > is there someone out there who maintains up2date git packages for SuSE
> > Linux Enterprise Server 10?

>   there seem to be some in the build service:

> 	http://download.opensuse.org/repositories/devel:tools:scm/SLE_10

now I am looking for packages for SLES 9. Anyone?

        Thomas
Permalink | Reply | 1 comment |
headers
Robin Rosenberg | 1 Feb 2008 06:37
Favicon

Re: SLES 9 git packages [WAS: SLES 10 git packages]

fredagen den 1 februari 2008 skrev Thomas Glanzmann:
> Petr,
> 
> > > is there someone out there who maintains up2date git packages for SuSE
> > > Linux Enterprise Server 10?
> 
> >   there seem to be some in the build service:
> 
> > 	http://download.opensuse.org/repositories/devel:tools:scm/SLE_10
> 
> now I am looking for packages for SLES 9. Anyone?

I think you can grab the src rpm in the SLE10/src directory and rpmbuild --rebuild it.
As git's dependencies are quite simple, that should work. 

-- robin
Permalink | Reply | 0 comments |
headers
Robin Rosenberg | 1 Feb 2008 06:48
Favicon

Re: [EGIT PATCH] Use keyboard arrow keys to go to the next and previous find results.

fredagen den 1 februari 2008 skrev Roger C. Soares:
> On the history find toolbar, if the pattern text field has focus,
> the down arrow key will generate a next event and the up arrow key

Wonderful. Pushed.

-- robin
Permalink | Reply | 0 comments |
headers
Junio C Hamano | 1 Feb 2008 08:17
Picon
Picon
Favicon
Gravatar

Re: [PATCH] More test cases for sanitized path names

Robin Rosenberg <robin.rosenberg.lists <at> dewire.com> writes:

> +test_expect_failure 'add a directory outside the work tree' '
> +	d1="$(cd .. ; pwd)" &&
> +	git add "$d1"
> +	echo $?
> +'

This test will always fail as the final exit status is that of
"echo", which will exit with success and you are expecting a
failure.

> +test_expect_failure 'add a file outside the work tree, nasty case 1' '(
> +	f="$(pwd)x" &&
> +	touch "$f" &&
> +	git add "$f"
> +)'

You are in the directory "t/trash", and try to add t/trashx, so
this should fail and you would want to make sure it fails.

But this has a few problems:

 * First, the obvious one.  You are creating a garbage file
   outside of t/trash directory.  Don't.  If you need to, dig a
   test directory one level lower inside t/trash and play around
   there.

 * In general you should stay away from test_expect_failure.  If
   any of the command in && chain fails, it fails the whole
(Continue reading)

Permalink | Reply | 9 comments |

Gmane