Stefan Schulte | 1 Jul 13:34 2011
Picon

[PATCH/puppet 1/2] (#8193) Support new keytypes for ssh_authorized_key

Recent versions of openssh (at least openssh 5.8) support the following
keytypes in in the authorized_keys file: ecdsa-sha2-nistp256,
ecdsa-sha2-nistp384, ecdsa-sha2-nistp521, ssh-dss or ssh-rsa.

Add support for ecdsa-sha2-nistp256, ecdsa-sha2-nistp384 and
ecdsa-sha2-nistp521.

Signed-off-by: Stefan Schulte <stefan.schulte <at> taunusstein.net>
---
Local-branch: ticket/2.7.x/8193
 lib/puppet/type/ssh_authorized_key.rb     |    7 +++----
 spec/unit/type/ssh_authorized_key_spec.rb |   19 ++++---------------
 2 files changed, 7 insertions(+), 19 deletions(-)

diff --git a/lib/puppet/type/ssh_authorized_key.rb b/lib/puppet/type/ssh_authorized_key.rb
index 170dc83..80bc60e 100644
--- a/lib/puppet/type/ssh_authorized_key.rb
+++ b/lib/puppet/type/ssh_authorized_key.rb
 <at>  <at>  -23,11 +23,10  <at>  <at>  module Puppet
     newproperty(:type) do
       desc "The encryption type used: ssh-dss or ssh-rsa."

-      newvalue("ssh-dss")
-      newvalue("ssh-rsa")
+      newvalues :'ssh-dss', :'ssh-rsa', :'ecdsa-sha2-nistp256', :'ecdsa-sha2-nistp384', :'ecdsa-sha2-nistp521'

-      aliasvalue(:dsa, "ssh-dss")
-      aliasvalue(:rsa, "ssh-rsa")
+      aliasvalue(:dsa, :'ssh-dss')
+      aliasvalue(:rsa, :'ssh-rsa')
(Continue reading)

Stefan Schulte | 1 Jul 13:34 2011
Picon

[PATCH/puppet 2/2] (#8193) Support new keytypes for sshkey

Recent versions of openssh (at least openssh 5.8) support the following
keytypes in in the authorized_keys file: ecdsa-sha2-nistp256,
ecdsa-sha2-nistp384, ecdsa-sha2-nistp521, ssh-dss or ssh-rsa.

Add support for ecdsa-sha2-nistp256, ecdsa-sha2-nistp384 and
ecdsa-sha2-nistp521.

Signed-off-by: Stefan Schulte <stefan.schulte <at> taunusstein.net>
---
Local-branch: ticket/2.7.x/8193
 lib/puppet/type/sshkey.rb     |    8 ++++----
 spec/unit/type/sshkey_spec.rb |   20 +++++++++-----------
 2 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/lib/puppet/type/sshkey.rb b/lib/puppet/type/sshkey.rb
index 59a1a12..41b3dde 100755
--- a/lib/puppet/type/sshkey.rb
+++ b/lib/puppet/type/sshkey.rb
 <at>  <at>  -9,10 +9,10  <at>  <at>  module Puppet
     newproperty(:type) do
       desc "The encryption type used.  Probably ssh-dss or ssh-rsa."

-      newvalue("ssh-dss")
-      newvalue("ssh-rsa")
-      aliasvalue(:dsa, "ssh-dss")
-      aliasvalue(:rsa, "ssh-rsa")
+      newvalues :'ssh-dss', :'ssh-rsa', :'ecdsa-sha2-nistp256', :'ecdsa-sha2-nistp384', :'ecdsa-sha2-nistp521'
+
+      aliasvalue(:dsa, :'ssh-dss')
+      aliasvalue(:rsa, :'ssh-rsa')
(Continue reading)

Stefan Schulte | 1 Jul 13:34 2011
Picon

ssh_authorized_keys should support new key types

Stig Sandbeck Mathisen reported:

    SSH now supports additional key types. From the sshd man page (openssh
    version 5.8p1 on ubuntu):

        For protocol version 2 the keytype is “ecdsa-sha2-nistp256”,
        “ecdsa-sha2-nistp384”, “ecdsa-sha2-nistp521”, “ssh-dss” or
        “ssh-rsa”.

    The puppet ssh_authorized_key and sshkey types only support “ssh-dss”
    and “ssh-rsa”.

First patch adds the new types to ssh_authorized_key, second patch adds
the new types to sshkey.

-Stefan

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Chetan | 1 Jul 15:36 2011
Picon

Custom type only works via 'puppet apply'

Hi,

I've written a custom type which works just fine when I run it
manually on some host via 'puppet apply' but via 'puppet agent' (using
puppetmaster) it doesn't seem to get executed at all. I've put debug
messages in various parts of the type's code and even tried raising an
error from my ensure block's retrieve() method and nothing happens. Is
there a better way to debug this?

chetan

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Stefan Schulte | 1 Jul 16:49 2011
Picon

Re: Custom type only works via 'puppet apply'

On Fri, Jul 01, 2011 at 06:36:24AM -0700, Chetan wrote:
> Hi,
> 
> I've written a custom type which works just fine when I run it
> manually on some host via 'puppet apply' but via 'puppet agent' (using
> puppetmaster) it doesn't seem to get executed at all. I've put debug
> messages in various parts of the type's code and even tried raising an
> error from my ensure block's retrieve() method and nothing happens. Is
> there a better way to debug this?
> 
> chetan

Do you use pluginsync to download the type on the agent? Is the type
known to the puppet master (copied to /var/lib/puppet/lib/puppet/type/)?
The latter is important because the master has to do the value validation.

-Stefan
Chetan | 1 Jul 17:34 2011
Picon

Re: Custom type only works via 'puppet apply'

On Jul 1, 10:49 am, Stefan Schulte <stefan.schu... <at> taunusstein.net>
wrote:
>
> Do you use pluginsync to download the type on the agent? Is the type
> known to the puppet master (copied to /var/lib/puppet/lib/puppet/type/)?
> The latter is important because the master has to do the value validation.

I'm using puppet 2.6.9. I've got all my modules in /etc/puppet/modules
and under svn control. My custom type is deployed the same as:

modules/dns_cname/lib/puppet/type/dme.rb
modules/dns_cname/manifests/init.pp

Will these types not get distributed to the nodes the same as
everything else in lib (i.e. custom facts, functions)?

chetan

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Chetan Sarva | 1 Jul 17:57 2011
Picon

Re: Custom type only works via 'puppet apply'

On Jul 1, 11:34 am, Chetan <csa... <at> gmail.com> wrote:
>
> Will these types not get distributed to the nodes the same as
> everything else in lib (i.e. custom facts, functions)?

Ok, I enabled pluginsync=true on both master & agent and it's working
now. Seems a bit less than obvious though. Shouldn't this be enabled
by default?

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Matthias Pigulla | 1 Jul 09:59 2011
Picon

PEAR package provider (feature #1823)

Hi all,

I'd like to make some improvements to the PEAR package provider
(http://projects.puppetlabs.com/issues/1823) which in the suggessted form insufficiently
supports channels.

1. Question: In the PEAR system, channels (DNS hostnames) are distribution points for packages. Package
names are unique only within a channel. As far as I can see, the current implementation relies on the "name"
to identify a package and gets the channel from "source". When querying, it only cares about the "name" and
so do other package providers I've looked at.

This approach fails for packages not in the "default" channel. So I'd like to make it mandatory for the name
to be qualified as "my.channel.net/MyPackage" and omit the "source". Would this be ok or violate some of
the contracts/practices regarding the Package type?

2. Question: The PEAR installer is a bit broken when it comes to checking for updates. You can tell it to
upgrade a package to its latest version and it will then cache for some time (configurable) that the
package is up to date. Further "upgrade" commands will not require any remote calls and tell you that
everything is up to date.

However, any attempt to figure out what the latest version of a package is or even running "upgrade" in
"simulate" mode (so see whether anything would be upgraded) leads to remote calls (HTTP requests against
the channel server) .

Under these conditions, would it be ok to perform the actual upgrade to the latest package version in the
"latest" method (possibly returning the *new* installed version with no additional costs) and do
nothing in the "upgrade" method?

3. Question: I use the "instances" method to create (what? Resources?) for all installed packages which
can be listed offline. Is it ok to return nil from the query method then because anything available should
(Continue reading)

Todd Zullinger | 1 Jul 18:23 2011
Picon

Re: Re: Custom type only works via 'puppet apply'

Chetan Sarva wrote:
> Ok, I enabled pluginsync=true on both master & agent and it's
> working now. Seems a bit less than obvious though. Shouldn't this be
> enabled by default?

http://projects.puppetlabs.com/issues/show/5521

--

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Statistics are like a lamp-post to a drunken man - more for leaning on
than illumination.

Pieter van de Bruggen | 1 Jul 20:24 2011

[PATCH/puppet-dashboard 1/3] (#8196) Clean up body class manipulation.

This enables partials to add classes to the body definition, which
makes certain styling operations simpler.

Reviewed-By: Randall Hansen

Signed-off-by: Pieter van de Bruggen <pieter <at> puppetlabs.com>
---
Local-branch: tickets/master/8196
 app/helpers/application_helper.rb       |    4 ++++
 app/views/layouts/application.html.haml |    7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 438eace..bf3f10f 100755
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
 <at>  <at>  -264,4 +264,8  <at>  <at>  module ApplicationHelper
      <at> unique_id_counter ||= 0
      <at> unique_id_counter += 1
   end
+
+  def add_body_class(klass)
+    ( <at> body_classes ||= []).push(klass).uniq!
+  end
 end
diff --git a/app/views/layouts/application.html.haml b/app/views/layouts/application.html.haml
index 1574cb4..040f3a3 100644
--- a/app/views/layouts/application.html.haml
+++ b/app/views/layouts/application.html.haml
 <at>  <at>  -16,9 +16,10  <at>  <at> 
(Continue reading)


Gmane