Re: [PATCH/puppet 1/1] Fix for #3114 (ruby's arbitrary limit on process groups too low)

Markus Roberts <Markus <at> reality.com> writes:

> In some circumstances ruby's arbitrary limit on process groups is too
> low (32).  This patch raises the limit in the recommended manner, to
> a value which should suffice in all practical cases (1024).
>
> +Process.maxgroups = 1024

ruby-doc.org says "Returns the maximum number of gids allowed in the
supplemental group access list", so there seems to be a disconnect
between the commit comment and the docs.  FWIW, few systems accept more
than 32 supplemental groups, indeed, if you're using NFS without
Kerberos, the practical limit is 16.  what was the problem you were
experiencing?

-- 
Kjetil T. Homme
Redpill Linpro AS - Changing the game

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Re: Re: [PATCH/puppet 1/1] Fix for #3114 (ruby's arbitrary limit on process groups too low)

> what was the problem you were
> experiencing?

it's in the bug report: http://projects.reductivelabs.com/issues/3114

cheers pete

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Re: [PATCH/puppet 1/1] Fix for #3114 (ruby's arbitrary limit on process groups too low)

Peter Meier <peter.meier <at> immerda.ch> writes:

>> what was the problem you were experiencing?
>
> it's in the bug report: http://projects.reductivelabs.com/issues/3114

ah, doh.  just misleading commit text, then.  (*boggles over users with
57 group memberships*)

BTW, you can check your OS' limit for supplemental file groups using
"getconf NGROUPS_MAX"
-- 
Kjetil T. Homme
Redpill Linpro AS - Changing the game

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

workaround modules which have a provider dependings on a custom type defined in the same plugin

I opened a ticket for this issue.
http://projects.reductivelabs.com/issues/3136

That is puppet-mysql uses a type it defines in its module provider.
But load_plugin is applied on the list of files sorted alphabetically
by the agent code.
Thus puppet/type is loaded after puppet/provider.

I workaround this by building the files array with puppet://plugins/puppet/type
added first.

From 5b9a2f91c34ef043023927a5d8a38b027be3f3b1 Mon Sep 17 00:00:00 2001
From: Alban Browaeys <prahal <at> yahoo.com>
Date: Mon, 1 Feb 2010 18:48:09 +0100
Subject: [PATCH] Load the plugins type first.

Fix providers which require a type defined in the same module.

Signed-off-by: Alban Browaeys <prahal <at> yahoo.com>
---
 lib/puppet/configurer/downloader.rb |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/lib/puppet/configurer/downloader.rb b/lib/puppet/
configurer/downloader.rb
index 7409fca..19861f0 100644
--- a/lib/puppet/configurer/downloader.rb
+++ b/lib/puppet/configurer/downloader.rb
 <at>  <at>  -30,8 +30,23  <at>  <at>  class Puppet::Configurer::Downloader
         begin

Re: workaround modules which have a provider dependings on a custom type defined in the same plugin

Alban --

As I noted on your ticket (#3136) I'm not seeing why adding a require
statement at the top of the provider wouldn't solve this issue.  See,
for example, lib/puppet/provider/package/appdmg.rb which starts thusly
(after the header comments):

require 'puppet/provider/package'
Puppet::Type.type(:package).provide(:appdmg, :parent =>
Puppet::Provider::Package) do
    desc "Package management which copies application bundles to a target."

This is the normal way of dealing with dependencies--make them explicit.

-- Markus

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

[PATCH/puppet 1/1] 2047: Add a not_include into match

From: Bryan Kearney <bkearney <at> redhat.com>

Signed-off-by: James Turnbull <james <at> lovedthanlost.net>
---
 lib/puppet/provider/augeas/augeas.rb |    4 ++++
 lib/puppet/type/augeas.rb            |    1 +
 spec/unit/provider/augeas/augeas.rb  |   10 ++++++++++
 3 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/lib/puppet/provider/augeas/augeas.rb b/lib/puppet/provider/augeas/augeas.rb
index 8dccb4e..ac11bbf 100644
--- a/lib/puppet/provider/augeas/augeas.rb
+++ b/lib/puppet/provider/augeas/augeas.rb
 <at>  <at>  -39,6 +39,7  <at>  <at>  Puppet::Type.type(:augeas).provide(:augeas) do
       "match" => [ :path, :glob ],
       "size" => [:comparator, :int],
       "include" => [:string],
+      "not_include" => [:string],
       "==" => [:glob],
       "!=" => [:glob]
     }
 <at>  <at>  -206,6 +207,9  <at>  <at>  Puppet::Type.type(:augeas).provide(:augeas) do
         when "include"
             arg = clause_array.shift
             return_value = result.include?(arg)
+        when "not_include"
+            arg = clause_array.shift
+            return_value = !result.include?(arg)
         when "=="
             begin

[PATCH/puppet 2/2] Fix for #2327, check the return types from augeas and fail where appropriate

From: Bryan Kearney <bkearney <at> redhat.com>

Signed-off-by: James Turnbull <james <at> lovedthanlost.net>
---
 lib/puppet/provider/augeas/augeas.rb |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/lib/puppet/provider/augeas/augeas.rb b/lib/puppet/provider/augeas/augeas.rb
index ac11bbf..d586fc1 100644
--- a/lib/puppet/provider/augeas/augeas.rb
+++ b/lib/puppet/provider/augeas/augeas.rb
 <at>  <at>  -197,6 +197,8  <at>  <at>  Puppet::Type.type(:augeas).provide(:augeas) do

         #Get the values from augeas
         result =  <at> aug.match(path) || []
+        fail("Error trying to match path '#{path}'") if (result == -1)
+
         # Now do the work
         case verb
         when "size"
 <at>  <at>  -321,13 +323,16  <at>  <at>  Puppet::Type.type(:augeas).provide(:augeas) do
                 case command
                     when "set"
                         debug("sending command '#{command}' with params #{cmd_array.inspect}")
-                        aug.set(cmd_array[0], cmd_array[1])
+                        rv = aug.set(cmd_array[0], cmd_array[1])
+                        fail("Error sending command '#{command}' with params #{cmd_array.inspect}/#{e.message}") if (rv)
                     when "rm", "remove"
                         debug("sending command '#{command}' with params #{cmd_array.inspect}")
-                        aug.rm(cmd_array[0])

[PATCH/puppet 1/2] 2047: Add a not_include into match

From: Bryan Kearney <bkearney <at> redhat.com>

Signed-off-by: James Turnbull <james <at> lovedthanlost.net>
---
 lib/puppet/provider/augeas/augeas.rb |    4 ++++
 lib/puppet/type/augeas.rb            |    1 +
 spec/unit/provider/augeas/augeas.rb  |   10 ++++++++++
 3 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/lib/puppet/provider/augeas/augeas.rb b/lib/puppet/provider/augeas/augeas.rb
index 8dccb4e..ac11bbf 100644
--- a/lib/puppet/provider/augeas/augeas.rb
+++ b/lib/puppet/provider/augeas/augeas.rb
 <at>  <at>  -39,6 +39,7  <at>  <at>  Puppet::Type.type(:augeas).provide(:augeas) do
       "match" => [ :path, :glob ],
       "size" => [:comparator, :int],
       "include" => [:string],
+      "not_include" => [:string],
       "==" => [:glob],
       "!=" => [:glob]
     }
 <at>  <at>  -206,6 +207,9  <at>  <at>  Puppet::Type.type(:augeas).provide(:augeas) do
         when "include"
             arg = clause_array.shift
             return_value = result.include?(arg)
+        when "not_include"
+            arg = clause_array.shift
+            return_value = !result.include?(arg)
         when "=="
             begin

Re: [PATCH/puppet 1/1] 2047: Add a not_include into match

+1

--

-- 
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To post to this group, send email to puppet-dev <at> googlegroups.com.
To unsubscribe from this group, send email to puppet-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

Re: workaround modules which have a provider dependings on a custom type defined in the same plugin