headers
Paul Eggert | 10 Feb 08:35
Favicon

[PATCH] maint: replace FSF snail-mail addresses with URLs

* tests/erlang.at, tests/go.at, tests/statesave.m4:
Replace FSF snail mail addresses with URLs, as per GNU coding
standards, and for consistency with other tests.
---
 tests/erlang.at    |    4 +---
 tests/go.at        |    4 +---
 tests/statesave.m4 |    4 +---
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/tests/erlang.at b/tests/erlang.at
index a73ad5f..58789b6 100644
--- a/tests/erlang.at
+++ b/tests/erlang.at
@@ -15,9 +15,7 @@ AT_BANNER([Erlang low level compiling and utility macros.])
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-# 02110-1301, USA.
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.

 
 # Since the macros which compile are required by most tests, check
diff --git a/tests/go.at b/tests/go.at
index b45c2b7..8733aee 100644
--- a/tests/go.at
+++ b/tests/go.at
@@ -15,9 +15,7 @@ AT_BANNER([Go low level compiling and utility macros.])
 # GNU General Public License for more details.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Blake | 25 Feb 04:48
Picon
Favicon
Gravatar

Re: [FYI] {master} maint: assume 'test -x' is portable

On 02/23/2012 05:13 PM, Eric Blake wrote:
> On 02/23/2012 04:50 PM, Paul Eggert wrote:
>> On 02/23/2012 03:05 PM, Stefano Lattarini wrote:
>>> +@samp{test -r}.  Do not use @samp{test -e} either, because Solaris 10
>>
>> The word "either" should be removed.  Otherwise looks OK.
> 
> I just thought of another issue worth documenting:
> 
> On systems where access(,X_OK) gives bogus results when run as root, it
> is also possible for 'test -x' to give those same bogus results (that
> is, POSIX allows but discourages test -x as root to always succeed,
> where no one can actually execute the file).  Also, in the presence of
> ACLs, it is unspecified whether test matches the ACLs or just the stat
> mode bits (POSIX recommends matching the ACLs, but that in turn can be
> surprising when a file mode 0600 owned by someone else passes 'test -r'
> for the current user due to an ACL).

Here's what I'm pushing for the doc side; I'm still working on the shell
probe for a working 'test -x'.  I also note that AS_TEST_X is
undocumented, although I don't want to delete it just yet.

From a66fcb0003e6d942dcda5d48860df0cff7e861e3 Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake <at> redhat.com>
Date: Fri, 24 Feb 2012 20:45:35 -0700
Subject: [PATCH] doc: mention more pitfalls of file mode tests

4.3BSD is museum-ware now, so we can assume that test -x exists;
however, we still can't assume that it always does what we want.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Blake | 25 Feb 05:39
Picon
Favicon
Gravatar

[PATCH] m4sh: require that 'test -x' works

4.3BSD is no longer a reasonable portability target; and we are
pretty sure that these days we can find at least one shell on any
platform that supports 'test -x'.  Drop a horribly unsafe use of
eval as a result. :)

Libtool still uses $as_executable_p without so much as calling
either AS_TEST_X or AS_EXECUTABLE_P, even though the latter has
existed, although undocumented, since at least 2.59; furthermore,
libtool uses it in a context where filtering out directories
would have been desirable.  Shame on them.

* lib/m4sugar/m4sh.m4 (_AS_TEST_X_WORKS): New probe.
(AS_SHELL_SANITIZE, AS_INIT): Use it in shell searching.
(AS_TEST_X, AS_EXECUTABLE_P): Simplify.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---
 lib/m4sugar/m4sh.m4 |   49 ++++++++++++++-----------------------------------
 1 files changed, 14 insertions(+), 35 deletions(-)

diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4
index 5d01f55..7cde34b 100644
--- a/lib/m4sugar/m4sh.m4
+++ b/lib/m4sugar/m4sh.m4
@@ -513,6 +513,7 @@ m4_define([AS_SHELL_SANITIZE],
 m4_provide_if([AS_INIT], [],
 [m4_provide([AS_INIT])
 _AS_DETECT_REQUIRED([_AS_SHELL_FN_WORK])
+_AS_DETECT_REQUIRED([_AS_TEST_X_WORKS])
 _AS_DETECT_BETTER_SHELL
(Continue reading)

Permalink | Reply | 1 comment |
headers
Eric Blake | 25 Feb 05:48
Picon
Favicon
Gravatar

Re: [PATCH] m4sh: require that 'test -x' works

On 02/24/2012 09:39 PM, Eric Blake wrote:
> 4.3BSD is no longer a reasonable portability target; and we are
> pretty sure that these days we can find at least one shell on any
> platform that supports 'test -x'.  Drop a horribly unsafe use of
> eval as a result. :)
> 
> Libtool still uses $as_executable_p without so much as calling
> either AS_TEST_X or AS_EXECUTABLE_P, even though the latter has
> existed, although undocumented, since at least 2.59; furthermore,
> libtool uses it in a context where filtering out directories
> would have been desirable.  Shame on them.
> 
> * lib/m4sugar/m4sh.m4 (_AS_TEST_X_WORKS): New probe.
> (AS_SHELL_SANITIZE, AS_INIT): Use it in shell searching.
> (AS_TEST_X, AS_EXECUTABLE_P): Simplify.
> 
> Signed-off-by: Eric Blake <eblake <at> redhat.com>
> ---
>  lib/m4sugar/m4sh.m4 |   49 ++++++++++++++-----------------------------------
>  1 files changed, 14 insertions(+), 35 deletions(-)

And here's why I'm waiting for a review on this one, rather than pushing
immediately:

> +[as_test_x='test x'

Obviously, that should be 'test -x'.

I'm also working on a followup patch that documents AS_EXECUTABLE_P, as
well as defines $as_executable_p as a shell function, so that libtool's
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Blake | 25 Feb 06:11
Picon
Favicon
Gravatar

[PATCH] m4sh: make AS_EXECUTABLE_P public

In the process of making it public, factor it into a reusable
function.  This makes constructs like AC_CHECK_PROGRAM smaller,
as well as making libtool's naughty use of $as_executable_p safer.

* lib/m4sugar/m4sh.m4 (_AS_TEST_PREPARE): Add a shell function.
(AS_EXECUTABLE_P): Forward to shell function.
* doc/autoconf.texi (Common Shell Constructs): Document it.
* NEWS: Mention this.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---

Any thoughts about this as a followup?  I will probably apply
it prior to cutting the pre-2.69 beta later this weekend.

 NEWS                |    2 ++
 doc/autoconf.texi   |    7 +++++++
 lib/m4sugar/m4sh.m4 |   10 +++++++---
 3 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index decad47..1a5f775 100644
--- a/NEWS
+++ b/NEWS
@@ -15,6 +15,8 @@ GNU Autoconf NEWS - User visible changes.
 ** AS_LITERAL_IF again treats '=' as a literal.  Regression introduced in
    2.66.

+** The macro AS_EXECUTABLE_P, present since 2.50, is now documented.
+
(Continue reading)

Permalink | Reply | 3 comments |
headers
Eric Blake | 25 Feb 15:16
Picon
Favicon
Gravatar

[PATCH 2/1] tests: add test for AS_EXECUTABLE_P

Now that this is public, we should regression test it.

* tests/m4sh.at (AS@&t <at> _EXECUTABLE): New test.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---
 tests/m4sh.at |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 52 insertions(+), 0 deletions(-)

diff --git a/tests/m4sh.at b/tests/m4sh.at
index e9da403..38667e4 100644
--- a/tests/m4sh.at
+++ b/tests/m4sh.at
@@ -552,6 +552,58 @@ AT_CLEANUP

+## ----------------- ##
+## AS_EXECUTABLE_P.  ##
+## ----------------- ##
+
+# Check for executable regular files.
+AT_SETUP([AS@&t <at> _EXECUTABLE_P])
+AT_KEYWORDS([m4sh])
+
+AT_DATA_M4SH([script.as],
+[[AS_INIT
+
+if AS_EXECUTABLE_P([/]); then
+  echo fail
+else
+  echo 1
(Continue reading)

Permalink | Reply | 2 comments |
headers
Eric Blake | 27 Feb 21:07
Picon
Favicon
Gravatar

Re: [PATCH 2/1] tests: add test for AS_EXECUTABLE_P

On 02/25/2012 07:16 AM, Eric Blake wrote:
> Now that this is public, we should regression test it.
> 
> * tests/m4sh.at (AS@&t <at> _EXECUTABLE): New test.
> 
> Signed-off-by: Eric Blake <eblake <at> redhat.com>
> ---
>  tests/m4sh.at |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 52 insertions(+), 0 deletions(-)

I've now pushed this and the two lead-up patches, based on my analysis
of the MSYS investigation making it look like we are not going to be
hurting that platform.

--

-- 
Eric Blake   eblake <at> redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Permalink | Reply | 1 comment |
headers
Stefano Lattarini | 27 Feb 21:31
Picon

Re: [PATCH 2/1] tests: add test for AS_EXECUTABLE_P

On 02/27/2012 09:07 PM, Eric Blake wrote:
> On 02/25/2012 07:16 AM, Eric Blake wrote:
>> Now that this is public, we should regression test it.
>>
>> * tests/m4sh.at (AS@&t <at> _EXECUTABLE): New test.
>>
>> Signed-off-by: Eric Blake <eblake <at> redhat.com>
>> ---
>>  tests/m4sh.at |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 52 insertions(+), 0 deletions(-)
> 
> I've now pushed this and the two lead-up patches, based on my analysis
> of the MSYS investigation making it look like we are not going to be
> hurting that platform.
> 
Thanks for tackling this,
  Stefano
Permalink | Reply | 0 comments |
headers
Eric Blake | 2 Mar 05:47
Picon
Favicon
Gravatar

[PATCH 1/3] maint: resync files from upstream

* GNUmakefile: Resync via 'make fetch'.
* build-aux/config.guess: Likewise.
* build-aux/config.sub: Likewise.
* build-aux/texinfo.tex: Likewise.
* build-aux/update-copyright: Likewise.
* doc/standards.texi: Likewise.
* lib/Autom4te/Channels.pm: Likewise.
* lib/Autom4te/Configure_ac.pm: Likewise.
* lib/Autom4te/FileUtils.pm: Likewise.
* lib/Autom4te/Getopt.pm: Likewise.
* lib/Autom4te/Struct.pm: Likewise.
* lib/Autom4te/XFile.pm: Likewise.
* maint.mk: Likewise.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---
 GNUmakefile                  |   14 +---
 build-aux/config.guess       |   16 +++-
 build-aux/config.sub         |   19 +++--
 build-aux/texinfo.tex        |  181 +++++++++++++++++++++++++++--------------
 build-aux/update-copyright   |   13 +++-
 doc/standards.texi           |    6 +-
 lib/Autom4te/Channels.pm     |   11 +--
 lib/Autom4te/Configure_ac.pm |    9 +-
 lib/Autom4te/FileUtils.pm    |   17 ++--
 lib/Autom4te/Getopt.pm       |    8 +-
 lib/Autom4te/Struct.pm       |    5 +-
 lib/Autom4te/XFile.pm        |   17 ++--
 maint.mk                     |   67 ++++++++++------
 13 files changed, 234 insertions(+), 149 deletions(-)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Blake | 2 Mar 05:47
Picon
Favicon
Gravatar

[PATCH 2/3] Release Version 2.68b.

It's been more than a year since 2.68; time for a beta release
to shake out any last minute bugs, before a release of 2.69
in the near future.

* NEWS: Mention the release.
* HACKING: Update some instructions.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---
 HACKING |   20 +++++++++-----------
 NEWS    |    3 ++-
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/HACKING b/HACKING
index 7a98fcb..58a50a9 100644
--- a/HACKING
+++ b/HACKING
@@ -50,14 +50,13 @@ release:

 - Run `make syntax-check'
   This makes sure that the source files follow some consistent rules.
-  The checks live in maint.mk, which is intended to be shared across
-  several projects.  (Help in merging this to use gnulib's maint.mk
-  would be appreciated).
+  The checks live in maint.mk, shared from gnulib, and customized in
+  cfg.mk.

-- Run `make maintainer-distcheck'
-  This is quite long.  It basically runs the test suite using a C++
-  compiler instead of a C compiler, and within a severe environment
(Continue reading)

Permalink | Reply | 0 comments |

Gmane