headers
Paul Eggert | 10 Feb 08:35
Favicon

[PATCH] maint: replace FSF snail-mail addresses with URLs

* tests/erlang.at, tests/go.at, tests/statesave.m4:
Replace FSF snail mail addresses with URLs, as per GNU coding
standards, and for consistency with other tests.
---
 tests/erlang.at    |    4 +---
 tests/go.at        |    4 +---
 tests/statesave.m4 |    4 +---
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/tests/erlang.at b/tests/erlang.at
index a73ad5f..58789b6 100644
--- a/tests/erlang.at
+++ b/tests/erlang.at
@@ -15,9 +15,7 @@ AT_BANNER([Erlang low level compiling and utility macros.])
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-# 02110-1301, USA.
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.

 
 # Since the macros which compile are required by most tests, check
diff --git a/tests/go.at b/tests/go.at
index b45c2b7..8733aee 100644
--- a/tests/go.at
+++ b/tests/go.at
@@ -15,9 +15,7 @@ AT_BANNER([Go low level compiling and utility macros.])
 # GNU General Public License for more details.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jim Meyering | 28 Jan 15:20

[PATCH] maint: avoid "make syntax-check" failure

FYI,

From a1a00a9768e6206feb8ca768d2aa66cdf3408c5c Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Sat, 28 Jan 2012 15:19:38 +0100
Subject: [PATCH] maint: avoid "make syntax-check" failure

* Makefile.am ($(srcdir)/INSTALL): Remove spurious space-before-TAB.
---
 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index a195241..bed0b6c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -50,7 +50,7 @@ $(srcdir)/INSTALL: $(top_srcdir)/doc/install.texi
 	echo @firstparagraphindent insert				\
 	  | cat - $(top_srcdir)/doc/install.texi > tmp.texi
 	$(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS)		\
-	     --plaintext tmp.texi			 		\
+	     --plaintext tmp.texi					\
 	  | sed -e $(CONVERT_QUOTES) -e $(OMIT_TRAILING_EMPTY_LINES)	\
 	     > $@-t && mv $@-t $@
 	rm -f tmp.texi
--
1.7.9.1.g63eb
Permalink | Reply | 0 comments |
headers
Eric Blake | 23 Jan 19:58
Picon
Favicon
Gravatar

[PATCH] tests: fix test regression due to additional output

This test has been failing since commit 5285ea8c (sadly, since
last July; thankfully, unreleased).

* tests/m4sugar.at (m4@&t <at> _require: nested): Fix test.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---

Pushing this now.  I guess the long lapse in fixing this is
a sad sign that I don't have as much time for autoconf as
I would personally like.

 tests/m4sugar.at |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tests/m4sugar.at b/tests/m4sugar.at
index 13ba2fa..997e2dd 100644
--- a/tests/m4sugar.at
+++ b/tests/m4sugar.at
@@ -618,6 +618,7 @@ c
 post
 ]],
 [[script.4s:15: warning: m4@&t <at> _require: `a' was expanded before it was required
+script.4s:15: http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
 script.4s:5: b is expanded from...
 script.4s:6: c is expanded from...
 script.4s:14: outer is expanded from...
--

-- 
1.7.7.5
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jim Meyering | 21 Jan 12:14

update maint.mk; fix syntax-check failures

I noticed that autoconf's maint.mk was out of date wrt gnulib's,
so updated it.  Also, even before the update, "make syntax-check"
was failing numerous tests.  With the update, even more (added tests)
rules were failing.  With this series, I've addressed some of the
issues and arranged to skip the remaining failing tests, so that now
"make syntax-check" succeeds once again.

Feel free to remove entries from cfg.mk's list of skipped
tests and address the failures, if you think it's appropriate.

[1/7] doc: fix grammar/doubled-word errors
[2/7] maint: remove empty lines at EOF
[3/7] maint: tweak to avoid triggering space-tab-prohibiting
[4/7] maint: placate syntax-check rules: exempt some false
[5/7] maint.mk: update from gnulib
[6/7] maint: also sync maint.mk and useless-if-before-free
[7/7] maint: fix or disable failing syntax-check rules
Permalink | Reply | 21 comments |
headers
Stefano Lattarini | 21 Jan 10:52
Picon

[PATCH 1/2] maint: make position of gnulib checkout configurable

Some gnulib-related tools (most prominently, the gnulib-provided
'bootstrap' script) allow the user to define the position of his
gnulib's repository checkout through the use of the 'GNULIB_SRCDIR'
environment variable.  We should do the same, for consistency and
to easily support slightly unusual layouts in developers' source
trees.

* cfg.mk (gnulib_dir): Define to "$GNULIB_SRCDIR" if that's set,
and to default value of "'$(abs_srcdir)'/../gnulib" otherwise.
Update comments.
---
 cfg.mk |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 6eb2fa4..a66c247 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -26,9 +26,11 @@ _autoreconf = autoreconf -i -v && rm -f INSTALL
 # Used in maint.mk's web-manual rule
 manual_title = Creating Automatic Configuration Scripts

-# The local directory containing the checked-out copy of gnulib used in this
-# release (override the default).
-gnulib_dir = '$(abs_srcdir)'/../gnulib
+# The local directory containing the checked-out copy of gnulib used
+# in this release (override the default).  The $GNULIB_SRCDIR variable
+# is also honored by the gnulib-provided bootstrap script, so using it
+# here is consistent.
+gnulib_dir = $${GNULIB_SRCDIR-'$(abs_srcdir)'/../gnulib}
(Continue reading)

Permalink | Reply | 4 comments |
headers
Stefano Lattarini | 20 Jan 18:05
Picon

[PATCH] build: fix automake error due to missing ChangeLog

Apparently, Automake does not accept the '$(srcdir)/ChangeLog'
target in Makefile.am as a declaration that ChangeLog is
automatically generated (and thus does not need to exist at
automake time).  One has to use a *literal* 'ChangeLog' target.

Problem introduced in commit v2.68-118-g6ed5195 of 2012-01-17,
"maint: generate ChangeLog from git log".

* Makefile.ma ($(srcdir)/ChangeLog): Renamed ...
(ChangeLog): ... to this.
---

I will push this shortly if there is no objection (as I think that
having a suboptimal patch is better than having broken bootstrap
on master).

Sorry for the mess-up,
  Stefano

 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 5bf4cb5..7608874 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -64,7 +64,7 @@ gen-ChangeLog:
 # bootstrap.  Creates a dummy ChangeLog (unless one is already present,
 # as might be the case for users of vc-dwim) that will be overridden
 # with a proper one at distribution time.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Stefano Lattarini | 18 Jan 19:09
Picon

[PATCH] getopt: sync from Automake repository

* lib/Autom4te/Getopt.am: The master copy of this file has
been moved to the  Automake repository (see Automake commit
'v1.11-662-g52246cc' 2012-01-18, "cmdline parsing: move into
a dedicated perl module").  So we now we sync it from there,
by listing it ...
* cfg.mk (autom4te_files): ... in this variable.
---
 cfg.mk                 |    1 +
 lib/Autom4te/Getopt.pm |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index f14737e..6eb2fa4 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -82,6 +82,7 @@ autom4te_files = \
   Autom4te/Configure_ac.pm \
   Autom4te/Channels.pm \
   Autom4te/FileUtils.pm \
+  Autom4te/Getopt.pm \
   Autom4te/Struct.pm \
   Autom4te/XFile.pm

diff --git a/lib/Autom4te/Getopt.pm b/lib/Autom4te/Getopt.pm
index 77f21db..f3fdf68 100644
--- a/lib/Autom4te/Getopt.pm
+++ b/lib/Autom4te/Getopt.pm
@@ -26,7 +26,7 @@ Autom4te::Getopt - GCS conforming parser for command line options
 =head1 DESCRIPTION
(Continue reading)

Permalink | Reply | 3 comments |
headers
Stefano Lattarini | 17 Jan 19:11
Picon

[PATCH] getopt: new Autom4te::Getopt module

* lib/Autom4te/General.pm (getopt): Move the guts of its
implementation ...
* lib/Autom4te/Getopt.pm (parse_options): .. into this function
in the new Autom4te::Getopt module.  This will make it simpler
for the implementation to be shared with other projects (right
now, Automake).
* lib/Automake/Makefile.am (dist_perllib_DATA): Add the new
module.
---
 lib/Autom4te/General.pm  |   49 +++----------------
 lib/Autom4te/Getopt.pm   |  118 ++++++++++++++++++++++++++++++++++++++++++++++
 lib/Autom4te/Makefile.am |    1 +
 3 files changed, 126 insertions(+), 42 deletions(-)
 create mode 100644 lib/Autom4te/Getopt.pm

diff --git a/lib/Autom4te/General.pm b/lib/Autom4te/General.pm
index f05042f..a7a1223 100644
--- a/lib/Autom4te/General.pm
+++ b/lib/Autom4te/General.pm
@@ -36,6 +36,7 @@ use 5.006_002;
 use Exporter;
 use Autom4te::ChannelDefs;
 use Autom4te::Channels;
+use Autom4te::Getopt ();
 use File::Basename;
 use File::Path ();
 use File::stat;
@@ -232,12 +233,10 @@ sub debug (@)

 =item C<getopt (%option)>
(Continue reading)

Permalink | Reply | 4 comments |
headers
Jim Meyering | 17 Jan 12:24

[PATCH] tests: avoid spurious failure for each gnu-fortran-using test

Surprised to see all fortran-running tests fail, I investigated...

From 905b85a2060f600dbc21e262262f77c8074f7db1 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Tue, 17 Jan 2012 12:22:59 +0100
Subject: [PATCH] tests: avoid spurious failure for each gnu-fortran-using
 test

The tests compare pre- and post-run lists of envvars, which must
be the same, modulo a list of known, filtered-out exceptions.
However, when running fortran-checking tests with GNU fortran, each
would fail due to the post-run addition of the GFC symbol added in
v2.68-97-gbd962ac.
* tests/local.at (AT_CHECK_ENV): Add GFC to the list of symbols
that we ignore in pre-/post-run environment diffs.
---
 tests/local.at |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/local.at b/tests/local.at
index 8b73c94..cce24f0 100644
--- a/tests/local.at
+++ b/tests/local.at
@@ -316,7 +316,7 @@ if test -f state-env.before && test -f state-env.after; then
       [(host|build|target)(_(alias|cpu|vendor|os))?],
       [cross_compiling|U],
       [interpval|PATH_SEPARATOR],
-      [F77_DUMMY_MAIN|f77_(case|underscore)],
+      [GFC|F77_DUMMY_MAIN|f77_(case|underscore)],
       [FC(_DUMMY_MAIN|FLAGS|LIBS|FLAGS_[fF]|_MODEXT|_MODINC|_MODOUT|_DEFINE)?],
(Continue reading)

Permalink | Reply | 2 comments |
headers
Jim Meyering | 17 Jan 11:45

[PATCH] maint: remove ChangeLog from version control; now we generate it

Having to deal with a version-controlled ChangeLog is an
unnecessary hassle, these days...

Does anyone object?

----------------------------
Notes about the patch:

FTR, choosing a generically-named file like "ChangeLog" for use in
AC_CONFIG_SRCDIR is a bad idea.  That file is too commonly found in
other directories.  Now that ChangeLog is gone, I've replaced it with
the eponymous bin/autoconf.as.

For now at least, I've simply git-added the new file,
gitlog-to-changelog, from gnulib.  Eventually we should
start using gnulib-tool.

From 13702a340debfef88a34ab753616df5ffcaf59b9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Tue, 17 Jan 2012 11:18:08 +0100
Subject: [PATCH] maint: remove ChangeLog from version control; now we
 generate it

Instead, generate it from git commit logs and insert it
into each distribution tarball.
* Makefile.am (EXTRA_DIST): Add ChangeLog.3.
(gen-ChangeLog): New rule.
(dist-hook): Depend on it.
(ChangeLog): New rule.
* build-aux/gitlog-to-changelog: New file, from gnulib.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stefano Lattarini | 15 Jan 19:55
Picon

[PATCH] maint: generate ChangeLog from git log

Following the practice set by various other GNU projects, we start
to automatically generate the ChangeLog file from the git commit
messages.  This will avoid duplication (as the ChangeLog entries
were always inserted both in the git commit message and in the
version-controlled ChangeLog file), and potential problems with
spurious merge conflicts (which, although greatly mitigated by
Bruno Haible's `git-merge-changelog' helper program, have never
been completely solved).

* ChangeLog: Moved ...
* ChangeLog.3: ... to this.
* build-aux/gitlog-to-changelog: New script, synced from gnulib.
* cfg.mk (gnulib-update): Also sync gitlog-to-changelog.
* Makefile.am (gen-ChangeLog): New .PHONY rule, generate the
ChangeLog for distribution.
(dist-hook): Depend on it.
($(srcdir)/ChangeLog): New dummy rule, to pacify automake "gnu"
strictness.  Creates a dummy ChangeLog, that will be overridden
by the proper one at distribution time.
(gen_start_date): New variable, the date starting from which the
git log entries are to be copied in the generated ChangeLog.
(EXTRA_DIST): Add ChangeLog.3 and gitlog-to-changelog.
* configure.ac (AC_CONFIG_SRCDIR): Use 'lib/autoconf/autoconf.m4'
instead of 'ChangeLog' as the sentinel file.
* .gitignore: Add ChangeLog.
---
 .gitignore                    |    1 +
 ChangeLog => ChangeLog.3      |    0
 Makefile.am                   |   22 +++-
 build-aux/gitlog-to-changelog |  377 +++++++++++++++++++++++++++++++++++++++++
(Continue reading)

Permalink | Reply | 1 comment |

Gmane