headers
mailer | 1 Aug 2011 10:38
Favicon

gevaerts: r30232 - trunk/apps

Date: 2011-08-01 10:38:32 +0200 (Mon, 01 Aug 2011)
New Revision: 30232

Log Message:
revert r30226, which is apparently broken.

Modified:
   trunk/apps/playback.c
   trunk/apps/playlist_viewer.c

Modified: trunk/apps/playback.c
===================================================================
--- trunk/apps/playback.c	2011-07-31 16:26:39 UTC (rev 30231)
+++ trunk/apps/playback.c	2011-08-01 08:38:32 UTC (rev 30232)
 <at>  <at>  -3796,8 +3796,4  <at>  <at> 
 #endif
     codec_thread_resume();
     thread_thaw(audio_thread_id);
-
-    /* Load the old playlist, to ensure that behaviour with and without
-     * rebooting is consistent */
-    playlist_resume();
 }

Modified: trunk/apps/playlist_viewer.c
===================================================================
--- trunk/apps/playlist_viewer.c	2011-07-31 16:26:39 UTC (rev 30231)
+++ trunk/apps/playlist_viewer.c	2011-08-01 08:38:32 UTC (rev 30232)
 <at>  <at>  -278,7 +278,7  <at>  <at> 
     size_t buffer_size;
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Aug 2011 15:03
Favicon

kugel: r30233 - trunk/apps

Date: 2011-08-01 15:03:21 +0200 (Mon, 01 Aug 2011)
New Revision: 30233

Log Message:
Remove dead rolo related code (boot_changed was never set to true).

Modified:
   trunk/apps/tree.c

Modified: trunk/apps/tree.c
===================================================================
--- trunk/apps/tree.c	2011-08-01 08:38:32 UTC (rev 30232)
+++ trunk/apps/tree.c	2011-08-01 13:03:21 UTC (rev 30233)
 <at>  <at>  -88,8 +88,6  <at>  <at> 
 #endif
 static struct tree_context tc;

-bool boot_changed = false;
-
 char lastfile[MAX_PATH];
 static char lastdir[MAX_PATH];
 #ifdef HAVE_TAGCACHE
 <at>  <at>  -655,16 +653,7  <at>  <at> 
         bool restore = false;
         if (tc.dirlevel < 0)
             tc.dirlevel = 0; /* shouldnt be needed.. this code needs work! */
-#ifdef BOOTFILE
-        if (boot_changed) {
-            static const char *lines[]={ID2P(LANG_BOOT_CHANGED), ID2P(LANG_REBOOT_NOW)};
-            static const struct text_message message={lines, 2};
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Aug 2011 20:10
Favicon

saratoga: r30234 - trunk/manual/getting_started

Date: 2011-08-01 20:10:42 +0200 (Mon, 01 Aug 2011)
New Revision: 30234

Log Message:
Mention that MSC mode is reset after installing rockbox on AMS players.

Modified:
   trunk/manual/getting_started/installation.tex

Modified: trunk/manual/getting_started/installation.tex
===================================================================
--- trunk/manual/getting_started/installation.tex	2011-08-01 13:03:21 UTC (rev 30233)
+++ trunk/manual/getting_started/installation.tex	2011-08-01 18:10:42 UTC (rev 30234)
 <at>  <at>  -158,7 +158,10  <at>  <at> 
   \opt{fuze,fuzev2,clipplus}{
     \note{The following steps require you to change the setting in
     \setting{Settings $\rightarrow$ System Settings $\rightarrow$ USB Mode} to
-    \setting{MSC} from within the original firmware.}
+    \setting{MSC} from within the original firmware.  Further note that
+     all original firmware settings will be lost immediately after patching
+     the bootloader, so you may need to correct this setting again after
+     installing rockbox.}
   }

   \opt{iriverh10,iriverh10_5gb}{

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Aug 2011 21:43
Favicon

gevaerts: r30235 - trunk/apps

Date: 2011-08-01 21:43:13 +0200 (Mon, 01 Aug 2011)
New Revision: 30235

Log Message:
Make scrobbler_flush_cache() static

Modified:
   trunk/apps/scrobbler.c
   trunk/apps/scrobbler.h

Modified: trunk/apps/scrobbler.c
===================================================================
--- trunk/apps/scrobbler.c	2011-08-01 18:10:42 UTC (rev 30234)
+++ trunk/apps/scrobbler.c	2011-08-01 19:43:13 UTC (rev 30235)
 <at>  <at>  -258,7 +258,7  <at>  <at> 
     return 1;
 }

-void scrobbler_flush_cache(void)
+static void scrobbler_flush_cache(void)
 {
     if (scrobbler_initialised)
     {

Modified: trunk/apps/scrobbler.h
===================================================================
--- trunk/apps/scrobbler.h	2011-08-01 18:10:42 UTC (rev 30234)
+++ trunk/apps/scrobbler.h	2011-08-01 19:43:13 UTC (rev 30235)
 <at>  <at>  -23,7 +23,6  <at>  <at> 
 #define __SCROBBLER_H__
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Aug 2011 22:07
Favicon

gevaerts: r30236 - trunk/apps/recorder

Date: 2011-08-01 22:07:05 +0200 (Mon, 01 Aug 2011)
New Revision: 30236

Log Message:
Suppress a "variable 'remote' set but not used" warning that some gcc versions (rightly) emit for the
m:robe 100 sim. The "correct" solution would be to add about twenty five more #ifdefs to a function that
already has way too many of them, or to rewrite the entire function.

Modified:
   trunk/apps/recorder/bmp.c

Modified: trunk/apps/recorder/bmp.c
===================================================================
--- trunk/apps/recorder/bmp.c	2011-08-01 19:43:13 UTC (rev 30235)
+++ trunk/apps/recorder/bmp.c	2011-08-01 20:07:05 UTC (rev 30236)
 <at>  <at>  -495,6 +495,11  <at>  <at> 

 #ifdef HAVE_REMOTE_LCD
     bool remote = false;
+    /* Thanks to the mass of #ifdefs in this function, there are cases where
+     * remote is never read, so we need to suppress the resulting warnings
+     * (or rewrite the lot)*/
+    (void)remote;
+
     if (format & FORMAT_REMOTE) {
         remote = true;
 #if LCD_REMOTE_DEPTH == 1
 <at>  <at>  -561,7 +566,7  <at>  <at> 
         resize |= IMG_NORESIZE;
 #endif
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Aug 2011 22:13
Favicon

gevaerts: r30237 - trunk/apps/recorder

Date: 2011-08-01 22:13:43 +0200 (Mon, 01 Aug 2011)
New Revision: 30237

Log Message:
Move the "warning suppression" down, so it comes after the last write to "remote", to ensure better warning avoidance

Modified:
   trunk/apps/recorder/bmp.c

Modified: trunk/apps/recorder/bmp.c
===================================================================
--- trunk/apps/recorder/bmp.c	2011-08-01 20:07:05 UTC (rev 30236)
+++ trunk/apps/recorder/bmp.c	2011-08-01 20:13:43 UTC (rev 30237)
 <at>  <at>  -495,11 +495,6  <at>  <at> 

 #ifdef HAVE_REMOTE_LCD
     bool remote = false;
-    /* Thanks to the mass of #ifdefs in this function, there are cases where
-     * remote is never read, so we need to suppress the resulting warnings
-     * (or rewrite the lot)*/
-    (void)remote;
-
     if (format & FORMAT_REMOTE) {
         remote = true;
 #if LCD_REMOTE_DEPTH == 1
 <at>  <at>  -863,5 +858,11  <at>  <at> 
         }
 #endif
     }
+#ifdef HAVE_REMOTE_LCD
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Aug 2011 22:21
Favicon

gevaerts: r30238 - trunk/apps/recorder

Date: 2011-08-01 22:21:34 +0200 (Mon, 01 Aug 2011)
New Revision: 30238

Log Message:
#ifdef hell makes effectively suppressing this warning impossible, so stop trying

Modified:
   trunk/apps/recorder/bmp.c

Modified: trunk/apps/recorder/bmp.c
===================================================================
--- trunk/apps/recorder/bmp.c	2011-08-01 20:13:43 UTC (rev 30237)
+++ trunk/apps/recorder/bmp.c	2011-08-01 20:21:34 UTC (rev 30238)
 <at>  <at>  -858,11 +858,5  <at>  <at> 
         }
 #endif
     }
-#ifdef HAVE_REMOTE_LCD
-    /* Thanks to the mass of #ifdefs in this function, there are cases where
-     * remote is never read, so we need to suppress the resulting warnings
-     * (or rewrite the lot)*/
-    (void)remote;
-#endif
     return totalsize; /* return the used buffer size. */
 }

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Aug 2011 16:35
Favicon

kugel: r30239 - trunk/apps

Date: 2011-08-02 16:35:10 +0200 (Tue, 02 Aug 2011)
New Revision: 30239

Log Message:
Tagcache: Rename global static variable for better readability.

Modified:
   trunk/apps/tagcache.c

Modified: trunk/apps/tagcache.c
===================================================================
--- trunk/apps/tagcache.c	2011-08-01 20:21:34 UTC (rev 30238)
+++ trunk/apps/tagcache.c	2011-08-02 14:35:10 UTC (rev 30239)
 <at>  <at>  -221,7 +221,7  <at>  <at> 
 # endif

 /* Pointer to allocated ramcache_header */
-static struct ramcache_header *hdr;
+static struct ramcache_header *ramcache_hdr;
 #endif

 /** 
 <at>  <at>  -413,7 +413,7  <at>  <at> 

     for (; i < current_tcmh.tch.entry_count; i++)
     {
-        if (hdr->indices[i].tag_seek[tag_filename] == dc)
+        if (ramcache_hdr->indices[i].tag_seek[tag_filename] == dc)
         {
             last_pos = MAX(0, i - 3);
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Aug 2011 21:08
Favicon

buschel: r30240 - trunk/apps/codecs/libmusepack

Date: 2011-08-02 21:08:29 +0200 (Tue, 02 Aug 2011)
New Revision: 30240

Log Message:
Sync rockbox to r475 of musepack's svn.

Modified:
   trunk/apps/codecs/libmusepack/internal.h
   trunk/apps/codecs/libmusepack/mpc_bits_reader.c
   trunk/apps/codecs/libmusepack/mpc_decoder.c
   trunk/apps/codecs/libmusepack/mpc_demux.c
   trunk/apps/codecs/libmusepack/mpc_types.h
   trunk/apps/codecs/libmusepack/streaminfo.c

Modified: trunk/apps/codecs/libmusepack/internal.h
===================================================================
--- trunk/apps/codecs/libmusepack/internal.h	2011-08-02 14:35:10 UTC (rev 30239)
+++ trunk/apps/codecs/libmusepack/internal.h	2011-08-02 19:08:29 UTC (rev 30240)
 <at>  <at>  -88,12 +88,12  <at>  <at> 
 /**
  * checks if a block key is valid
  *  <at> param key the two caracters key to check
- *  <at> return MPC_STATUS_INVALIDSV if the key is invalid, MPC_STATUS_OK else
+ *  <at> return MPC_STATUS_FAIL if the key is invalid, MPC_STATUS_OK else
  */
 static mpc_inline mpc_status mpc_check_key(char * key)
 {
     if (key[0] < 65 || key[0] > 90 || key[1] < 65 || key[1] > 90)
-        return MPC_STATUS_INVALIDSV;
+        return MPC_STATUS_FAIL;
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 3 Aug 2011 00:10
Favicon

sideral: r30241 - trunk/apps

Date: 2011-08-03 00:10:06 +0200 (Wed, 03 Aug 2011)
New Revision: 30241

Log Message:
Database: Fix to support case-sensitive file systems containing audio
files with names differing only in capitalization.  Thanks to Slasheri
for the fix.

Modified:
   trunk/apps/tagcache.c

Modified: trunk/apps/tagcache.c
===================================================================
--- trunk/apps/tagcache.c	2011-08-02 19:08:29 UTC (rev 30240)
+++ trunk/apps/tagcache.c	2011-08-02 22:10:06 UTC (rev 30241)
 <at>  <at>  -503,7 +503,7  <at>  <at> 
             return -3;
         }

-        if (!strcasecmp(filename, buf))
+        if (!strcmp(filename, buf))
         {
             last_pos = pos_history[pos_history_idx];
             found = true;

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
(Continue reading)

Permalink | Reply | 0 comments |

Gmane