headers
mailer | 1 Oct 2010 16:40
Favicon

teru: r28189 - trunk/apps/plugins

Date: 2010-10-01 16:40:28 +0200 (Fri, 01 Oct 2010)
New Revision: 28189

Log Message:
text editor: decrease size of extension to reduce stack usage.
this could solve crash in text editor (FS#10078).

Modified:
   trunk/apps/plugins/text_editor.c

Modified: trunk/apps/plugins/text_editor.c
===================================================================
--- trunk/apps/plugins/text_editor.c	2010-09-30 13:09:50 UTC (rev 28188)
+++ trunk/apps/plugins/text_editor.c	2010-10-01 14:40:28 UTC (rev 28189)
 <at>  <at>  -410,41 +410,40  <at>  <at> 
                 if (edit_colors_file && line_count)
                 {
                     char *name = temp_line, *value = NULL;
-                    char extension[MAX_LINE_LEN];
+                    char extension[16];
                     int color, old_color;
                     bool temp_changed = false;
+
+                    MENUITEM_STRINGLIST(menu, "Edit What?", NULL,
+                                        "Extension", "Colour");
+
                     rb->settings_parseline(temp_line, &name, &value);
-                    if (line_count)
+                    rb->strlcpy(extension, name, sizeof(extension));
+                    if (value)
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 1 Oct 2010 20:09
Favicon

Buschel: r28190 - trunk/firmware/target/arm/s5l8700/ipodnano2g

Date: 2010-10-01 20:09:10 +0200 (Fri, 01 Oct 2010)
New Revision: 28190

Log Message:
Submit FS#11646. Reduce voltage supply for iPod nano 2G LCD. Significantly reduces buzzing sound of 
LDS176 type displays.

Modified:
   trunk/firmware/target/arm/s5l8700/ipodnano2g/power-nano2g.c

Modified: trunk/firmware/target/arm/s5l8700/ipodnano2g/power-nano2g.c
===================================================================
--- trunk/firmware/target/arm/s5l8700/ipodnano2g/power-nano2g.c	2010-10-01 14:40:28 UTC (rev 28189)
+++ trunk/firmware/target/arm/s5l8700/ipodnano2g/power-nano2g.c	2010-10-01 18:09:10 UTC (rev 28190)
 <at>  <at>  -45,7 +45,8  <at>  <at> 

 void power_init(void)
 {
-    pmu_write(0x1e, 15);  /* Vcore = 1.000V */
+    pmu_write(0x1e, 0xf);         /* Vcore = 1.000V */
+    pmu_ldo_set_voltage(2, 0x11); /* LCD   = 2.600V */
 }

 #if CONFIG_CHARGING

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 16:11
Favicon

gevaerts: r28191 - in trunk: apps/plugins apps/plugins/bitmaps/native docs manual/plugins manual/plugins/images

Date: 2010-10-02 16:11:40 +0200 (Sat, 02 Oct 2010)
New Revision: 28191

Log Message:
New plugin: Resistor code calculator

Flyspray: FS#11585
Author: Calvin Walden


Added:
   trunk/apps/plugins/bitmaps/native/resistor.128x128x16.bmp
   trunk/apps/plugins/bitmaps/native/resistor.132x80x16.bmp
   trunk/apps/plugins/bitmaps/native/resistor.160x128x16.bmp
   trunk/apps/plugins/bitmaps/native/resistor.176x220x16.bmp
   trunk/apps/plugins/bitmaps/native/resistor.220x176x16.bmp
   trunk/apps/plugins/bitmaps/native/resistor.240x400x16.bmp
   trunk/apps/plugins/bitmaps/native/resistor.320x240x16.bmp
   trunk/apps/plugins/resistor.c
   trunk/manual/plugins/images/ss-resistor-112x64x1.png
   trunk/manual/plugins/images/ss-resistor-128x64x1-clip.png
   trunk/manual/plugins/images/ss-resistor-128x96x1.png
   trunk/manual/plugins/images/ss-resistor-132x80x16.png
   trunk/manual/plugins/images/ss-resistor-138x110x1.png
   trunk/manual/plugins/images/ss-resistor-160x128x1.png
   trunk/manual/plugins/images/ss-resistor-160x128x16.png
   trunk/manual/plugins/images/ss-resistor-160x128x2.png
   trunk/manual/plugins/images/ss-resistor-176x132x16.png
   trunk/manual/plugins/images/ss-resistor-176x220x16.png
   trunk/manual/plugins/images/ss-resistor-220x176x16.png
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 16:28
Favicon

teru: r28192 - trunk/apps/plugins/pictureflow

Date: 2010-10-02 16:28:46 +0200 (Sat, 02 Oct 2010)
New Revision: 28192

Log Message:
picture flow: clean up code. no functional changes.
-use upper case for enum constants.
-rename variables to match it's use.
-remove tabs and fix indents.

Modified:
   trunk/apps/plugins/pictureflow/pictureflow.c

Modified: trunk/apps/plugins/pictureflow/pictureflow.c
===================================================================
--- trunk/apps/plugins/pictureflow/pictureflow.c	2010-10-02 14:11:40 UTC (rev 28191)
+++ trunk/apps/plugins/pictureflow/pictureflow.c	2010-10-02 14:28:46 UTC (rev 28192)
 <at>  <at>  -122,7 +122,7  <at>  <at> 
     {PF_QUIT,         BUTTON_POWER,               BUTTON_NONE},
 #elif CONFIG_KEYPAD == SANSA_FUZE_PAD
     {PF_QUIT,         BUTTON_HOME|BUTTON_REPEAT,  BUTTON_NONE},
-    {PF_TRACKLIST,    BUTTON_RIGHT,  BUTTON_NONE},    
+    {PF_TRACKLIST,    BUTTON_RIGHT,  BUTTON_NONE},
 /* These all use short press of BUTTON_POWER for menu, map long POWER to quit
 */
 #elif CONFIG_KEYPAD == SANSA_C200_PAD || CONFIG_KEYPAD == SANSA_M200_PAD || \
 <at>  <at>  -237,6 +237,10  <at>  <at> 
 #define EMPTY_SLIDE_BMP PLUGIN_DEMOS_DIR "/pictureflow_emptyslide.bmp"
 #define SPLASH_BMP PLUGIN_DEMOS_DIR "/pictureflow_splash.bmp"

+/* some magic numbers for cache_version. */
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 16:43
Favicon

gevaerts: r28193 - in trunk/apps/plugins: . bitmaps/native

Date: 2010-10-02 16:43:23 +0200 (Sat, 02 Oct 2010)
New Revision: 28193

Log Message:
Resistor plugin: 
   crop the smallest bitmap so it's usable for any small screen and nut just the c200
   make the layout a bit more flexible

Added:
   trunk/apps/plugins/bitmaps/native/resistor.68x20x16.bmp
Removed:
   trunk/apps/plugins/bitmaps/native/resistor.132x80x16.bmp
Modified:
   trunk/apps/plugins/bitmaps/native/SOURCES
   trunk/apps/plugins/resistor.c

Modified: trunk/apps/plugins/bitmaps/native/SOURCES
===================================================================
--- trunk/apps/plugins/bitmaps/native/SOURCES	2010-10-02 14:28:46 UTC (rev 28192)
+++ trunk/apps/plugins/bitmaps/native/SOURCES	2010-10-02 14:43:23 UTC (rev 28193)
 <at>  <at>  -897,10 +897,10  <at>  <at> 
 resistor.176x220x16.bmp
 #elif (LCD_WIDTH >= 160)
 resistor.160x128x16.bmp
-#elif (LCD_WIDTH >= 132)
-resistor.132x80x16.bmp
-#elif (LCD_WIDTH >= 128)
+#elif (LCD_WIDTH >= 128) && (LCD_HEIGHT >= 96)
 resistor.128x128x16.bmp
+#else
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 16:46
Favicon

gevaerts: r28194 - trunk/apps/plugins

Date: 2010-10-02 16:46:33 +0200 (Sat, 02 Oct 2010)
New Revision: 28194

Log Message:
Fix typo, which should fix yellow

Modified:
   trunk/apps/plugins/resistor.c

Modified: trunk/apps/plugins/resistor.c
===================================================================
--- trunk/apps/plugins/resistor.c	2010-10-02 14:43:23 UTC (rev 28193)
+++ trunk/apps/plugins/resistor.c	2010-10-02 14:46:33 UTC (rev 28194)
 <at>  <at>  -82,7 +82,7  <at>  <at> 
 #define fourth_band_x              (3*BMPWIDTH_resistor/4 + RESISTOR_BMP_X - band_width/2)
 #define universal_y                (RESISTOR_BMP_Y+(BMPHEIGHT_resistor)/2 - band_height/2)

-#if LCD_WIDTHT <= 128
+#if LCD_WIDDHT <= 128
 #define total_resistance_str_x     1
 #define tolerance_str_x            1
 #define resistance_val_x           1

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 16:48
Favicon

gevaerts: r28195 - trunk/apps/plugins

Date: 2010-10-02 16:48:03 +0200 (Sat, 02 Oct 2010)
New Revision: 28195

Log Message:
Fix typo properly this time, to ensure all green

Modified:
   trunk/apps/plugins/resistor.c

Modified: trunk/apps/plugins/resistor.c
===================================================================
--- trunk/apps/plugins/resistor.c	2010-10-02 14:46:33 UTC (rev 28194)
+++ trunk/apps/plugins/resistor.c	2010-10-02 14:48:03 UTC (rev 28195)
 <at>  <at>  -82,7 +82,7  <at>  <at> 
 #define fourth_band_x              (3*BMPWIDTH_resistor/4 + RESISTOR_BMP_X - band_width/2)
 #define universal_y                (RESISTOR_BMP_Y+(BMPHEIGHT_resistor)/2 - band_height/2)

-#if LCD_WIDDHT <= 128
+#if LCD_WIDTH <= 128
 #define total_resistance_str_x     1
 #define tolerance_str_x            1
 #define resistance_val_x           1

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 18:03
Favicon

gevaerts: r28196 - trunk/firmware/usbstack

Date: 2010-10-02 18:03:31 +0200 (Sat, 02 Oct 2010)
New Revision: 28196

Log Message:
Fix outdated comment

Modified:
   trunk/firmware/usbstack/usb_storage.c

Modified: trunk/firmware/usbstack/usb_storage.c
===================================================================
--- trunk/firmware/usbstack/usb_storage.c	2010-10-02 14:48:03 UTC (rev 28195)
+++ trunk/firmware/usbstack/usb_storage.c	2010-10-02 16:03:31 UTC (rev 28196)
 <at>  <at>  -37,7 +37,7  <at>  <at> 
  * is useful for USBCV MSC tests, as those are destructive.
  * This won't work right if the device doesn't have a card slot.
  */
-//#define ONLY_EXPOSE_CARD_SLOT
+//#define HIDE_FIRST_DRIVE

 #ifdef USB_USE_RAMDISK
 #define RAMDISK_SIZE 2048

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 19:43
Favicon

Buschel: r28197 - trunk/apps/codecs/libmusepack

Date: 2010-10-02 19:43:36 +0200 (Sat, 02 Oct 2010)
New Revision: 28197

Log Message:
Finally fix FS#11476 (data abort when playing some sv8 mpc files on lowmem targets like
Clip+/Fuzev1/Fuzev2). This fix disables loading of seek tables from the sv8 bitstream. Those table are
located at the end of sv8-files. When playing sv8 files this resulted in seek to filebegin, then fileend,
then back to filebegin. Such seeking behaviour results in heavy rebuffering when playing files on
targets with low RAM.

Modified:
   trunk/apps/codecs/libmusepack/mpc_demux.c

Modified: trunk/apps/codecs/libmusepack/mpc_demux.c
===================================================================
--- trunk/apps/codecs/libmusepack/mpc_demux.c	2010-10-02 16:03:31 UTC (rev 28196)
+++ trunk/apps/codecs/libmusepack/mpc_demux.c	2010-10-02 17:43:36 UTC (rev 28197)
 <at>  <at>  -239,6 +239,7  <at>  <at> 
     return MPC_STATUS_OK;
 }

+/* rockbox: do not use
 static void mpc_demux_ST(mpc_demux * d)
 {
     mpc_uint64_t tmp;
 <at>  <at>  -300,15 +301,14  <at>  <at> 
     mpc_demux_seek(d, (ptr - size) * 8 + cur, 11);
     st_head_size = mpc_bits_get_block(&d->bits_reader, &b);
     if (memcmp(b.key, "ST", 2) == 0) {
-/* rockbox: not used
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Oct 2010 19:52
Favicon

Buschel: r28198 - trunk/apps/codecs/libmusepack

Date: 2010-10-02 19:52:12 +0200 (Sat, 02 Oct 2010)
New Revision: 28198

Log Message:
Optimization of mpc's buffering routines through using the maximum possible buffer size. This reduces
read access calls.

Modified:
   trunk/apps/codecs/libmusepack/mpc_demux.c

Modified: trunk/apps/codecs/libmusepack/mpc_demux.c
===================================================================
--- trunk/apps/codecs/libmusepack/mpc_demux.c	2010-10-02 17:43:36 UTC (rev 28197)
+++ trunk/apps/codecs/libmusepack/mpc_demux.c	2010-10-02 17:52:12 UTC (rev 28198)
 <at>  <at>  -47,8 +47,11  <at>  <at> 
 /// be adapted so this value is never exceeded.
 #define MAX_SEEK_TABLE_SIZE 8192

+// defines
+#define MAX_BUFFER_SIZE (DEMUX_BUFFER_SIZE + MAX_FRAME_SIZE)
+
 // globals
-static mpc_uint8_t g_buffer[DEMUX_BUFFER_SIZE + MAX_FRAME_SIZE];
+static mpc_uint8_t g_buffer[MAX_BUFFER_SIZE];
 static mpc_seek_t g_seek_table[MAX_SEEK_TABLE_SIZE];
 static mpc_demux g_mpc_demux IBSS_ATTR;

 <at>  <at>  -73,16 +76,16  <at>  <at> 
 mpc_demux_fill(mpc_demux * d, mpc_uint32_t min_bytes, int flags)
 {
(Continue reading)

Permalink | Reply | 0 comments |

Gmane