headers
mailer | 1 Jan 2008 14:54
Favicon

pixelma: r15984 - trunk/manual/plugins

Date: 2008-01-01 14:54:17 +0100 (Tue, 01 Jan 2008)
New Revision: 15984

Log Message:
First 'oops' commit of the year: on the e200 the macros are called 'ButtonScrollUp/Down' instead of
'ButtonScrollFwd/Back'. Thanks to Dave Chapman for noticing.

Modified:
   trunk/manual/plugins/brickmania.tex

Modified: trunk/manual/plugins/brickmania.tex
===================================================================
--- trunk/manual/plugins/brickmania.tex	2007-12-31 00:04:27 UTC (rev 15983)
+++ trunk/manual/plugins/brickmania.tex	2008-01-01 13:54:17 UTC (rev 15984)
 <at>  <at>  -27,8 +27,10  <at>  <at> 
     \ButtonLeft\ / \ButtonRight
     \opt{SANSA_C200_PAD}{\\
         \ButtonVolDown\ / \ButtonVolUp}
-    \opt{IPOD_4G_PAD,IPOD_3G_PAD,SANSA_E200_PAD}{\\
+    \opt{IPOD_4G_PAD,IPOD_3G_PAD}{\\
         \ButtonScrollBack\ / \ButtonScrollFwd}
+    \opt{SANSA_E200_PAD}{\\
+        \ButtonScrollDown\ / \ButtonScrollUp}
     & Moves the paddle\\
     \opt{RECORDER_PAD,IAUDIO_X5_PAD}{\ButtonPlay\ / \ButtonUp}
     \opt{ONDIO_PAD}{\ButtonMenu\ / \ButtonUp}

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Jan 2008 07:35
Favicon

stevenm: r15985 - trunk/apps/plugins/midi

Date: 2008-01-02 07:35:59 +0100 (Wed, 02 Jan 2008)
New Revision: 15985

Log Message:
MIDI player: Allow pause and seeking during pause. Print out the play/pause/seek position in seconds. 

Modified:
   trunk/apps/plugins/midi/midiplay.c
   trunk/apps/plugins/midi/midiutil.c

Modified: trunk/apps/plugins/midi/midiplay.c
===================================================================
--- trunk/apps/plugins/midi/midiplay.c	2008-01-01 13:54:17 UTC (rev 15984)
+++ trunk/apps/plugins/midi/midiplay.c	2008-01-02 06:35:59 UTC (rev 15985)
 <at>  <at>  -33,6 +33,7  <at>  <at> 
 #define BTN_UP       BUTTON_UP
 #define BTN_DOWN     BUTTON_DOWN
 #define BTN_LEFT     BUTTON_LEFT
+#define BTN_PLAY     BUTTON_PLAY

 #elif CONFIG_KEYPAD == ONDIO_PAD
 #define BTN_QUIT         BUTTON_OFF
 <at>  <at>  -40,15 +41,17  <at>  <at> 
 #define BTN_UP           BUTTON_UP
 #define BTN_DOWN         BUTTON_DOWN
 #define BTN_LEFT         BUTTON_LEFT
+#define BTN_PLAY         (BUTTON_MENU | BUTTON_OFF)

+
 #elif (CONFIG_KEYPAD == IRIVER_H100_PAD) || (CONFIG_KEYPAD == IRIVER_H300_PAD)
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Jan 2008 07:40
Favicon

stevenm: r15986 - trunk/apps/plugins/midi

Date: 2008-01-02 07:40:15 +0100 (Wed, 02 Jan 2008)
New Revision: 15986

Log Message:
MIDI player: fix a very unlikely (but possible) file descriptor leak.

Modified:
   trunk/apps/plugins/midi/midifile.c

Modified: trunk/apps/plugins/midi/midifile.c
===================================================================
--- trunk/apps/plugins/midi/midifile.c	2008-01-02 06:35:59 UTC (rev 15985)
+++ trunk/apps/plugins/midi/midifile.c	2008-01-02 06:40:15 UTC (rev 15986)
 <at>  <at>  -95,9 +95,10  <at>  <at> 
         {
             if(mfload->numTracks != track)
             {
-                printf("Error: file claims to have %d tracks. I only see %d here.",     mfload->numTracks, track);
+                printf("Warning: file claims to have %d tracks. I only see %d here.", mfload->numTracks, track);
                 mfload->numTracks = track;
             }
+            rb->close(file);
             return mfload;
         }

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Jan 2008 08:09
Favicon

stevenm: r15987 - trunk/apps/plugins/midi

Date: 2008-01-02 08:09:17 +0100 (Wed, 02 Jan 2008)
New Revision: 15987

Log Message:
MIDI player: print out track names, copyright info, song names, etc during load time. This includes 
lyrics... maybe we should print those while the song is playing?

Modified:
   trunk/apps/plugins/midi/midifile.c

Modified: trunk/apps/plugins/midi/midifile.c
===================================================================
--- trunk/apps/plugins/midi/midifile.c	2008-01-02 06:40:15 UTC (rev 15986)
+++ trunk/apps/plugins/midi/midifile.c	2008-01-02 07:09:17 UTC (rev 15987)
 <at>  <at>  -149,8 +149,71  <at>  <at> 
             /* Allocate and read in the data block */
             if(dest != NULL)
             {
-                ev->evData = readData(file, ev->len);
-/*                printf("\nDATA: <%s>", ev->evData); */
+                /* Null-terminate for text events */
+                ev->evData = malloc(ev->len+1); /* Extra byte for the null termination */
+
+                rb->read(file, ev->evData, ev->len);
+                ev->evData[ev->len] = 0;
+
+                switch(ev->d1)
+                {
+                    case 0x01:  /* Generic text */
+                    {
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 2 Jan 2008 08:44
Favicon

stevenm: r15988 - trunk/apps/plugins/midi

Date: 2008-01-02 08:44:03 +0100 (Wed, 02 Jan 2008)
New Revision: 15988

Log Message:
Oops, fix red.

Modified:
   trunk/apps/plugins/midi/midiplay.c

Modified: trunk/apps/plugins/midi/midiplay.c
===================================================================
--- trunk/apps/plugins/midi/midiplay.c	2008-01-02 07:09:17 UTC (rev 15987)
+++ trunk/apps/plugins/midi/midiplay.c	2008-01-02 07:44:03 UTC (rev 15988)
 <at>  <at>  -69,7 +69,7  <at>  <at> 
 #define BTN_LEFT         BUTTON_LEFT
 #define BTN_UP           BUTTON_UP
 #define BTN_DOWN         BUTTON_DOWN
-#define BTN_PAUSE        BUTTON_A
+#define BTN_PLAY         BUTTON_A

 
 #elif (CONFIG_KEYPAD == SANSA_E200_PAD) || \

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
Permalink | Reply | 0 comments |
headers
mailer | 3 Jan 2008 08:29
Favicon

pondlife: r15989 - in trunk: apps docs

Date: 2008-01-03 08:29:19 +0100 (Thu, 03 Jan 2008)
New Revision: 15989

Log Message:
FS#8375 - Fix division by zero using the random database selection in a near-empty subset.  Thanks to Henri Valta.

Modified:
   trunk/apps/tagtree.c
   trunk/docs/CREDITS

Modified: trunk/apps/tagtree.c
===================================================================
--- trunk/apps/tagtree.c	2008-01-02 07:44:03 UTC (rev 15988)
+++ trunk/apps/tagtree.c	2008-01-03 07:29:19 UTC (rev 15989)
 <at>  <at>  -1385,6 +1385,8  <at>  <at> 
     seek = dptr->extraseek;   
     if (seek == -1) 
     {
+        if(c->filesindir<=2)
+            return 0;
         srand(current_tick);
         dptr = (tagtree_get_entry(c, 2+(rand() % (c->filesindir-2))));
         seek = dptr->extraseek;

Modified: trunk/docs/CREDITS
===================================================================
--- trunk/docs/CREDITS	2008-01-02 07:44:03 UTC (rev 15988)
+++ trunk/docs/CREDITS	2008-01-03 07:29:19 UTC (rev 15989)
 <at>  <at>  -357,6 +357,7  <at>  <at> 
 Lee Kang Hyuk
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 3 Jan 2008 14:12
Favicon

pixelma: r15990 - trunk/manual/getting_started

Date: 2008-01-03 14:12:14 +0100 (Thu, 03 Jan 2008)
New Revision: 15990

Log Message:
Fix typo(s) and use British English.

Modified:
   trunk/manual/getting_started/installation.tex

Modified: trunk/manual/getting_started/installation.tex
===================================================================
--- trunk/manual/getting_started/installation.tex	2008-01-03 07:29:19 UTC (rev 15989)
+++ trunk/manual/getting_started/installation.tex	2008-01-03 13:12:14 UTC (rev 15990)
 <at>  <at>  -3,8 +3,8  <at>  <at> 

 \opt{ipodnano}{
   \note{Rockbox presently runs only on the original Ipod Nano. Rockbox does
-  \emph{not} run on the newer, second generation Ipod Nano (the all alumminum
-  verion). For information on identifying which Ipod you own, see this page on
+  \emph{not} run on the newer, second generation Ipod Nano (the all aluminium
+  version). For information on identifying which Ipod you own, see this page on
   Apple's website: \url{http://www.info.apple.com/kbnum/n61688}
   }
 }

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 3 Jan 2008 18:14
Favicon

jethead71: r15991 - in trunk: apps apps/plugins/bitmaps/mono apps/plugins/mpegplayer uisimulator/sdl

Date: 2008-01-03 18:14:28 +0100 (Thu, 03 Jan 2008)
New Revision: 15991

Log Message:
Initial WVS for mpegplayer. Adjusts to the user's preferred font and uses FF/RW preferences set for playback. Picked a random color for the base WVS color but it could be configured. Some engine tweaks to accomodate it since certain nescessities are clearer now. Fix a clipped YUV output bug in the SIM.

Added:
   trunk/apps/plugins/bitmaps/mono/mpegplayer_status_icons_12x12x1.bmp
   trunk/apps/plugins/bitmaps/mono/mpegplayer_status_icons_16x16x1.bmp
   trunk/apps/plugins/bitmaps/mono/mpegplayer_status_icons_8x8x1.bmp
Modified:
   trunk/apps/plugin.c
   trunk/apps/plugin.h
   trunk/apps/plugins/bitmaps/mono/SOURCES
   trunk/apps/plugins/mpegplayer/Makefile
   trunk/apps/plugins/mpegplayer/audio_thread.c
   trunk/apps/plugins/mpegplayer/disk_buf.h
   trunk/apps/plugins/mpegplayer/mpeg_parser.c
   trunk/apps/plugins/mpegplayer/mpegplayer.c
   trunk/apps/plugins/mpegplayer/stream_mgr.c
   trunk/apps/plugins/mpegplayer/stream_mgr.h
   trunk/apps/plugins/mpegplayer/stream_thread.h
   trunk/apps/plugins/mpegplayer/video_out.h
   trunk/apps/plugins/mpegplayer/video_out_rockbox.c
   trunk/apps/plugins/mpegplayer/video_thread.c
   trunk/uisimulator/sdl/lcd-bitmap.c

Modified: trunk/apps/plugin.c
===================================================================
--- trunk/apps/plugin.c	2008-01-03 13:12:14 UTC (rev 15990)
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 3 Jan 2008 18:30
Favicon

jethead71: r15992 - trunk/apps/plugins/mpegplayer

Date: 2008-01-03 18:30:50 +0100 (Thu, 03 Jan 2008)
New Revision: 15992

Log Message:
Fix some warnings/errors.

Modified:
   trunk/apps/plugins/mpegplayer/mpegplayer.c
   trunk/apps/plugins/mpegplayer/video_out_rockbox.c

Modified: trunk/apps/plugins/mpegplayer/mpegplayer.c
===================================================================
--- trunk/apps/plugins/mpegplayer/mpegplayer.c	2008-01-03 17:14:28 UTC (rev 15991)
+++ trunk/apps/plugins/mpegplayer/mpegplayer.c	2008-01-03 17:30:50 UTC (rev 15992)
 <at>  <at>  -303,11 +303,6  <at>  <at> 
 }
 #endif

-static void draw_fill_rect(int x, int y, int width, int height)
-{
-    rb->lcd_fillrect(_X, _Y, _W, _H);
-}
-
 #ifdef HAVE_LCD_COLOR
 static void draw_update_rect(int x, int y, int width, int height)
 {

Modified: trunk/apps/plugins/mpegplayer/video_out_rockbox.c
===================================================================
--- trunk/apps/plugins/mpegplayer/video_out_rockbox.c	2008-01-03 17:14:28 UTC (rev 15991)
(Continue reading)

Permalink | Reply | 0 comments |
headers
mailer | 3 Jan 2008 18:51
Favicon

jethead71: r15993 - trunk/apps/plugins/mpegplayer

Date: 2008-01-03 18:51:25 +0100 (Thu, 03 Jan 2008)
New Revision: 15993

Log Message:
Ok...really fix the red. :)

Modified:
   trunk/apps/plugins/mpegplayer/video_out_rockbox.c

Modified: trunk/apps/plugins/mpegplayer/video_out_rockbox.c
===================================================================
--- trunk/apps/plugins/mpegplayer/video_out_rockbox.c	2008-01-03 17:30:50 UTC (rev 15992)
+++ trunk/apps/plugins/mpegplayer/video_out_rockbox.c	2008-01-03 17:51:25 UTC (rev 15993)
 <at>  <at>  -507,7 +507,7  <at>  <at> 
 void vo_lock(void)
 {
 /* TODO: evaluate synchronization with graylib in the sim */
-#ifndef HAVE_LCD_COLOR && !defined(SIMULATOR)
+#if !defined(HAVE_LCD_COLOR) && !defined(SIMULATOR)
     set_irq_level(HIGHEST_IRQ_LEVEL);
 #endif
     video_lock();
 <at>  <at>  -516,7 +516,7  <at>  <at> 
 void vo_unlock(void)
 {
     video_unlock();
-#ifndef HAVE_LCD_COLOR && !defined(SIMULATOR)
+#if !defined(HAVE_LCD_COLOR) && !defined(SIMULATOR)
     set_irq_level(0);
 #endif
(Continue reading)

Permalink | Reply | 0 comments |

Gmane