gerrit | 28 Jun 17:55 2015

hwstub: Add completion and some pretty printing to the shell

commit e70ea5d21ff1aca5b8c534da8f3a1ccadd330a2e
Author: Marcin Bukat <marcin.bukat <at> gmail.com>
Date:   Sun Jun 28 17:51:43 2015 +0200

    hwstub: Add completion and some pretty printing to the shell

    This uses slightly hacked luaprompt to provide all the goodis.
    See https://github.com/dpapavas/luaprompt for original.

    Change-Id: Iedddb79abae5809299322bc215722dd928c35cca

diff --git a/utils/hwstub/tools/Makefile b/utils/hwstub/tools/Makefile
index 6db0c70..f718300 100644
--- a/utils/hwstub/tools/Makefile
+++ b/utils/hwstub/tools/Makefile
 <at>  <at>  -26,7 +26,7  <at>  <at>  $(REGTOOLS_LIB_DIR)/libsocdesc.a:
 %.o: %.cpp
 	$(CXX) $(CXXFLAGS) -c -o $ <at>  $<

-hwstub_shell: hwstub_shell.o $(LIBS)
+hwstub_shell: hwstub_shell.o prompt.o $(LIBS)
 	$(LD) -o $ <at>  $^ $(LDFLAGS)

 hwstub_load: hwstub_load.o $(LIBS)
diff --git a/utils/hwstub/tools/hwstub_shell.cpp b/utils/hwstub/tools/hwstub_shell.cpp
index 8b7a8b9..f59ca8b 100644
--- a/utils/hwstub/tools/hwstub_shell.cpp
+++ b/utils/hwstub/tools/hwstub_shell.cpp
 <at>  <at>  -29,6 +29,9  <at>  <at> 
 #include <lua.hpp>
(Continue reading)

gerrit | 20 Jun 23:09 2015

Fix rebuilding librbspeex on OS X and make rm work on Windows.

commit 465eb727a30fd1f4470ff6c172f7b41856775167
Author: Dominik Riebeling <Dominik.Riebeling <at> gmail.com>
Date:   Sat Jun 20 20:44:17 2015 +0200

    Fix rebuilding librbspeex on OS X and make rm work on Windows.

    OS X ar operates on fat libaries and cannot update existing archives. Remove it
    first to avoid this.
    Use a make function when removing files to allow calling the correct command on
    Windows, which doesn't know about rm.

    Change-Id: Ia0c13ef7907239a1e6f4abc26bb08238a226c476

diff --git a/tools/rbspeex/Makefile b/tools/rbspeex/Makefile
index 89e21f8..a4f337f 100644
--- a/tools/rbspeex/Makefile
+++ b/tools/rbspeex/Makefile
 <at>  <at>  -13,8 +13,10  <at>  <at>  endif

 ifeq ($(OS),Windows_NT)
 mkdir = if not exist $(subst /,\,$(1)) mkdir $(subst /,\,$(1))
+rm = if exist $(subst /,\,$(1)) del /q /s $(subst /,\,$(1))
 else
 mkdir = mkdir -p $(1)
+rm = rm -rf $(1)
 endif

 SPEEXSRC = ../../lib/rbcodec/codecs/libspeex
 <at>  <at>  -100,6 +102,7  <at>  <at>  $(TARGET_DIR)rbspeex.dll: $(OBJS) $(BUILD_DIR)/rbspeex.o

(Continue reading)

gerrit | 7 Jun 22:32 2015

Win32: fix possible crash when listing USB devices.

commit 4c4c645d828ab61f3eb8571f83dc1ac750317eb2
Author: Dominik Riebeling <Dominik.Riebeling <at> gmail.com>
Date:   Sun Jun 7 22:25:54 2015 +0200

    Win32: fix possible crash when listing USB devices.

    Make sure to handle if retrieving the device description ends up with a NULL
    data buffer pointer. Also switch handling the retrieved string using QString.

    Fixes a crash reported in the forums.

    Change-Id: I6e95a411308e85656cd78ddcecb1bcee165864d0

diff --git a/rbutil/rbutilqt/base/system.cpp b/rbutil/rbutilqt/base/system.cpp
index c36c95b..855d9e3 100644
--- a/rbutil/rbutilqt/base/system.cpp
+++ b/rbutil/rbutilqt/base/system.cpp
 <at>  <at>  -432,7 +432,7  <at>  <at>  QMap<uint32_t, QString> System::listUsbDevices(void)
         DWORD buffersize = 0;
         QString description;

-        // get device desriptor first
+        // get device descriptor first
         // for some reason not doing so results in bad things (tm)
         while(!SetupDiGetDeviceRegistryProperty(deviceInfo, &infoData,
             SPDRP_DEVICEDESC, &data, (PBYTE)buffer, buffersize, &buffersize)) {
 <at>  <at>  -445,6 +445,11  <at>  <at>  QMap<uint32_t, QString> System::listUsbDevices(void)
                 break;
             }
         }
(Continue reading)

gerrit | 2 Jun 02:13 2015

AS3543: Fix recording volume setting and voice

commit 3e5e9cf7d7daaf5db194040662ff3d6e97edd116
Author: Mihail Zenkov <mihail.zenkov <at> gmail.com>
Date:   Sun Feb 15 00:26:02 2015 +0000

    AS3543: Fix recording volume setting and voice

    Fix regressions introduced by 42219b6e7

    Change-Id: I1f3edb5f269f60e9431b45a43c4370836ecac733

diff --git a/firmware/drivers/audio/as3514.c b/firmware/drivers/audio/as3514.c
index 6cad825..11eb14c 100644
--- a/firmware/drivers/audio/as3514.c
+++ b/firmware/drivers/audio/as3514.c
 <at>  <at>  -299,7 +299,8  <at>  <at>  void audiohw_set_volume(int vol_l, int vol_r)
     }

 #ifdef HAVE_AS3543
-    if (!(as3514_regs[AS3514_HPH_OUT_R] & 0x40)) { /*if not radio or recording*/
+    /*if not radio or recording*/
+    if (!(as3514_regs[AS3514_AUDIOSET1] & (AUDIOSET1_ADC_on | AUDIOSET1_LIN1_on))) {
         if (!hph_l || !hph_r) { /*if volume higher, disable the mixer to slightly improve noise*/
             as3514_write(AS3514_AUDIOSET1, AUDIOSET1_DAC_on | AUDIOSET1_DAC_GAIN_on);
             as3514_write(AS3514_AUDIOSET2, AUDIOSET2_AGC_off | AUDIOSET2_HPH_QUALITY_LOW_POWER);
 <at>  <at>  -484,7 +485,7  <at>  <at>  void audiohw_set_monitor(bool enable)
 {
     if (enable) {
 #ifdef HAVE_AS3543
-        as3514_write_masked(AS3514_HPH_OUT_R, HPH_OUT_R_HP_OUT_LINE, HPH_OUT_R_HP_OUT_MASK);
+        as3514_write_masked(AS3514_HPH_OUT_R, HPH_OUT_R_HP_OUT_SUM, HPH_OUT_R_HP_OUT_MASK);
(Continue reading)

gerrit | 2 Jun 02:03 2015

AMS: fix usb initialization in bootloader

commit 2ec6fbc827b559847b4f0d54d44de5299b8ab6cc
Author: Mihail Zenkov <mihail.zenkov <at> gmail.com>
Date:   Mon Jun 1 23:41:15 2015 +0000

    AMS: fix usb initialization in bootloader

    Regression after 8b8b85433f6e9ac673adb

    Change-Id: I86389be0b85c5c2ad8a32d7089a6a79a6b7c8708

diff --git a/bootloader/sansa_as3525.c b/bootloader/sansa_as3525.c
index 14cb2ab..fb3ba98 100644
--- a/bootloader/sansa_as3525.c
+++ b/bootloader/sansa_as3525.c
 <at>  <at>  -137,6 +137,7  <at>  <at>  void main(void)
     {
 #ifdef HAVE_BOOTLOADER_USB_MODE
         error(EDISK, ret, false);
+        usb_start_monitoring();
         usb_mode();
 #else
         error(EDISK, ret, true);
 <at>  <at>  -152,6 +153,7  <at>  <at>  void main(void)
     {
 #ifdef HAVE_BOOTLOADER_USB_MODE
         error(EBOOTFILE, ret, false);
+        usb_start_monitoring();
         usb_mode();
 #else
         error(EBOOTFILE, ret, true);
(Continue reading)

gerrit | 1 Jun 18:24 2015

AMS: Change DMA transfer size for audio.

commit e7550a4f6e77deffe45a00e3546fea431f672972
Author: Mihail Zenkov <mihail.zenkov <at> gmail.com>
Date:   Sat Feb 14 19:01:14 2015 +0100

    AMS: Change DMA transfer size for audio.

    Slightly reduces power consumption due to DMA overhead.

    Change-Id: I8576e9e243ce13a71cde710c3a726dce19bafb97

diff --git a/firmware/target/arm/as3525/pcm-as3525.c b/firmware/target/arm/as3525/pcm-as3525.c
index 0f077b8..ddb4d86 100644
--- a/firmware/target/arm/as3525/pcm-as3525.c
+++ b/firmware/target/arm/as3525/pcm-as3525.c
 <at>  <at>  -83,7 +83,7  <at>  <at>  static void play_start_pcm(void)

     dma_enable_channel(0, (void*)addr, (void*)I2SOUT_DATA, DMA_PERI_I2SOUT,
                 DMAC_FLOWCTRL_DMAC_MEM_TO_PERI, true, false, size >> 2,
-                DMA_S1, dma_callback);
+                DMA_S16, dma_callback);
 }

 static void dma_callback(void)
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 30 May 19:16 2015

Make lrelease detection work on Windows.

commit e606ee42c20dbed0a41cf6d676dcf4833be9df9b
Author: Dominik Riebeling <Dominik.Riebeling <at> gmail.com>
Date:   Sat May 30 19:16:11 2015 +0200

    Make lrelease detection work on Windows.

    Make sure to expand variable before testing.

    Change-Id: I6b6f11782677c178fe3f2209f84887084940976a

diff --git a/rbutil/rbutilqt/rbutilqt.pro b/rbutil/rbutilqt/rbutilqt.pro
index 71ab77a..243e592 100644
--- a/rbutil/rbutilqt/rbutilqt.pro
+++ b/rbutil/rbutilqt/rbutilqt.pro
 <at>  <at>  -111,11 +111,11  <at>  <at>  win32:!cross {
 }
 lrelease.commands = $$LRELEASE -silent $$_PRO_FILE_
 QMAKE_EXTRA_TARGETS += lrelease
-exists(LRELEASE) {
+exists($$LRELEASE) {
     message("using lrelease at $$LRELEASE")
     PRE_TARGETDEPS += lrelease
 }
-!exists(LRELEASE) {
+!exists($$LRELEASE) {
     warning("could not find lrelease. Skipping translations.")
 }

_______________________________________________
rockbox-cvs mailing list
(Continue reading)

gerrit | 30 May 19:03 2015

Make lrelease detection work on Windows.

commit ef21b304547a20569e95df782e29759b5f9ee44a
Author: Dominik Riebeling <Dominik.Riebeling <at> gmail.com>
Date:   Sat May 30 19:01:33 2015 +0200

    Make lrelease detection work on Windows.

    Windows doesn't have which, so building natively on Windows didn't create
    translations anymore. Use a which-less approach instead.

    Change-Id: I7b4c40b26d68da54277a148e8e2d76ac81061c8b

diff --git a/rbutil/rbutilqt/rbutilqt.pro b/rbutil/rbutilqt/rbutilqt.pro
index d4cf504..71ab77a 100644
--- a/rbutil/rbutilqt/rbutilqt.pro
+++ b/rbutil/rbutilqt/rbutilqt.pro
 <at>  <at>  -105,14 +105,17  <at>  <at>  tags.depends = $(SOURCES)
 QMAKE_EXTRA_TARGETS += tags

 # add a custom rule for making the translations
-LRELEASE = $$system(which $$[QT_INSTALL_BINS]/lrelease)
+LRELEASE = $$[QT_INSTALL_BINS]/lrelease
+win32:!cross {
+    LRELEASE = $$[QT_INSTALL_BINS]/lrelease.exe
+}
 lrelease.commands = $$LRELEASE -silent $$_PRO_FILE_
 QMAKE_EXTRA_TARGETS += lrelease
-!isEmpty(LRELEASE) {
+exists(LRELEASE) {
     message("using lrelease at $$LRELEASE")
     PRE_TARGETDEPS += lrelease
(Continue reading)

gerrit | 18 May 23:07 2015

Initially scroll to changelog end.

commit 47d053735be0233a9821fdfdfd1d0a4651b6e61f
Author: Dominik Riebeling <Dominik.Riebeling <at> gmail.com>
Date:   Mon May 18 22:48:54 2015 +0200

    Initially scroll to changelog end.

    Since currently new entries are at the bottom scroll down when opening the
    changelog window.

    Change-Id: I3cec84f5d9251e268c34335d8032dd11f42098ae

diff --git a/rbutil/rbutilqt/gui/changelog.cpp b/rbutil/rbutilqt/gui/changelog.cpp
index 1de2723..54d6fa6 100644
--- a/rbutil/rbutilqt/gui/changelog.cpp
+++ b/rbutil/rbutilqt/gui/changelog.cpp
 <at>  <at>  -26,7 +26,7  <at>  <at>  Changelog::Changelog(QWidget *parent) : QDialog(parent)
     ui.browserChangelog->setOpenExternalLinks(true);
     // FIXME: support translated changelog file (changelog.de.txt etc)
     ui.browserChangelog->setHtml(parseChangelogFile(":/docs/changelog.txt"));
-    ui.browserChangelog->moveCursor(QTextCursor::Start, QTextCursor::MoveAnchor);
+    ui.browserChangelog->moveCursor(QTextCursor::End, QTextCursor::MoveAnchor);
     ui.checkBoxShowAlways->setChecked(RbSettings::value(RbSettings::ShowChangelog).toBool());
     connect(ui.buttonOk, SIGNAL(clicked()), this, SLOT(accept()));
 }
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 13 May 23:05 2015

Fix libs path for building with MSVC.

commit 44fcebb9888baf5a99d93dc43161c2e8cc179ef5
Author: Dominik Riebeling <Dominik.Riebeling <at> gmail.com>
Date:   Wed May 13 23:00:49 2015 +0200

    Fix libs path for building with MSVC.

    Change-Id: Iaa0a20c8bff1faaa191de70d6f02c62dafec1591

diff --git a/rbutil/rbutilqt/rbutilqt.pro b/rbutil/rbutilqt/rbutilqt.pro
index a69c56d..47cdae1 100644
--- a/rbutil/rbutilqt/rbutilqt.pro
+++ b/rbutil/rbutilqt/rbutilqt.pro
 <at>  <at>  -95,7 +95,7  <at>  <at>  RBLIBS = rbspeex ipodpatcher sansapatcher mkamsboot mktccboot \
 }
 win32-msvc* {
     INCLUDEPATH += msvc
-    LIBS += -L$$_PRO_FILE_/msvc
+    LIBS += -L$$_PRO_FILE_PWD_/msvc
     LIBS += -ladvapi32 # required for MSVC / Qt Creator combination
 }

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 21 Apr 16:31 2015

Fix html manual for the Packard Bell Vibe 500.

commit c3c2c919d820c01cbad04e76ba329919f2827e8a
Author: Szymon Dziok <b0hoon <at> o2.pl>
Date:   Tue Apr 21 16:28:20 2015 +0200

    Fix html manual for the Packard Bell Vibe 500.

    Change-Id: I1f39cb93081738e757101cdf6aeb5e3a1ca0e42c

diff --git a/manual/plugins/xworld.tex b/manual/plugins/xworld.tex
index 4ea7559..cd48601 100644
--- a/manual/plugins/xworld.tex
+++ b/manual/plugins/xworld.tex
 <at>  <at>  -18,7 +18,7  <at>  <at>  Additionally, ``extra'' data files that modify the in-game strings and font can
     \opt{IPOD_4G_PAD,IPOD_3G_PAD,IPOD_1G2G_PAD}{\ButtonMenu}
     \opt{IRIVER_H10_PAD}{\ButtonScrollUp}
     \opt{HAVE_TOUCHSCREEN}{\TouchTopMiddle}
-    \opt{PBELL_VIBE500_PAD}{\ButtonOk}
+    \opt{PBELL_VIBE500_PAD}{\ButtonOK}
        \opt{HAVEREMOTEKEYMAP}{& }
     & Up and Jump \\
     %
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs

Gmane