gerrit | 20 Aug 12:08 2014

Make sure load_context is the last thing in switch_thread.

commit 5fb370267f81a8429a76f0237767804b849d1f81
Author: Michael Sevakis <jethead71 <at> rockbox.org>
Date:   Wed Aug 20 05:58:59 2014 -0400

    Make sure load_context is the last thing in switch_thread.

    This should fix the android crash issue (fingers crossed).

    Change-Id: I9d3f773dbdf7dde60bd76962dcf66a3bad8b0925

diff --git a/firmware/kernel/thread.c b/firmware/kernel/thread.c
index bbd6101..01395a9 100644
--- a/firmware/kernel/thread.c
+++ b/firmware/kernel/thread.c
 <at>  <at>  -254,18 +254,18  <at>  <at>  static NO_INLINE void thread_stkov(struct thread_entry *thread)

 static FORCE_INLINE void thread_store_context(struct thread_entry *thread)
 {
+    store_context(&thread->context);
 #if (CONFIG_PLATFORM & PLATFORM_HOSTED)
     thread->__errno = errno;
 #endif
-    store_context(&thread->context);
 }

 static FORCE_INLINE void thread_load_context(struct thread_entry *thread)
 {
-    load_context(&thread->context);
 #if (CONFIG_PLATFORM & PLATFORM_HOSTED)
     errno = thread->__errno;
(Continue reading)

gerrit | 19 Aug 23:04 2014

Added Clip/+ to 2048 targets

commit 9fed5fd9e944ce255f4df0ac2ada233ae5f58ec2
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Tue Aug 19 16:48:23 2014 -0400

    Added Clip/+ to 2048 targets

    Change-Id: I9fb5a50f214e9dd87d1f1f62f4324876bdd94fe8
    Reviewed-on: http://gerrit.rockbox.org/918
    Reviewed-by: Michael Giacomelli <giac2000 <at> hotmail.com>

diff --git a/apps/plugins/SOURCES b/apps/plugins/SOURCES
index 9b7436a..a051e2d 100644
--- a/apps/plugins/SOURCES
+++ b/apps/plugins/SOURCES
 <at>  <at>  -144,6 +144,7  <at>  <at>  metronome.c

 #ifdef HAVE_LCD_BITMAP             /* Not for the Archos Player */

+2048.c
 /* Lua needs at least 160 KB to work in */
 #if PLUGIN_BUFFER_SIZE >= 0x80000
 boomshine.lua
 <at>  <at>  -209,12 +210,8  <at>  <at>  euroconverter.c
 nim.c
 #endif /* HAVE_LCD_CHARCELLS */

-
-
 #if LCD_DEPTH > 1                  /* non-mono bitmap targets */

(Continue reading)

gerrit | 19 Aug 22:37 2014

2048: service pack 1 :) - fixed some bugs - added 1-bit LCD support

commit 7ac0056beb327d7f208deb7bb3de95e08dcb704f
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Tue Aug 19 15:20:19 2014 -0400

    2048: service pack 1 :)
    - fixed some bugs
    - added 1-bit LCD support

    Change-Id: I7bb458d79d799dcd6b11d9d538773404f9a7f97c
    Reviewed-on: http://gerrit.rockbox.org/917
    Reviewed-by: Michael Giacomelli <giac2000 <at> hotmail.com>

diff --git a/apps/plugins/2048.c b/apps/plugins/2048.c
index 30f8899..7c2fd85 100644
--- a/apps/plugins/2048.c
+++ b/apps/plugins/2048.c
 <at>  <at>  -83,10 +83,10  <at>  <at> 
 #define SCORE_Y (max_numeral_height)
 #define BEST_SCORE_X 0
 #define BEST_SCORE_Y (2*max_numeral_height)
-#endif
+#endif /* LCD_WIDTH<LCD_HEIGHT */

-#define BACKGROUND_X (BASE_X-MIN_SPACE)
-#define BACKGROUND_Y (BASE_Y-MIN_SPACE)
+#define BACKGROUND_X (int)(BASE_X-MIN_SPACE)
+#define BACKGROUND_Y (int)(BASE_Y-MIN_SPACE)

 /* key mappings */

(Continue reading)

gerrit | 18 Aug 16:44 2014

thread-unix patchup!

commit a9713d89e76158c6b7be4d8873a921e30efe688f
Author: Michael Sevakis <jethead71 <at> rockbox.org>
Date:   Mon Aug 18 09:44:55 2014 -0400

    thread-unix patchup!

    The changed thread code may not wish to save the old context under
    certain circumstances but thread-unix.c assumed it would, cached it
    and used it unconditionally.

    Also, prevent it from leaking away all the jump buffers (old problem).
    Creating and removing threads would eventually run it out of buffers
    and then it would crash after that. Plugins, like Pictureflow, which
    have worker threads could only be started a few times. Implement a
    simple O(1) allocator that will reuse them and stays self-contained
    to its own types (as it appears the original author intended).

    Change-Id: Icf65413c086b346fb79bf827102b725269e2812c

diff --git a/firmware/asm/thread-unix.c b/firmware/asm/thread-unix.c
index 3c5e7c9..8538515 100644
--- a/firmware/asm/thread-unix.c
+++ b/firmware/asm/thread-unix.c
 <at>  <at>  -41,12 +41,31  <at>  <at>  static pthread_t main_thread;
 static struct ctx {
     jmp_buf thread_buf;
 } thread_bufs[MAXTHREADS];
+static threadbit_t free_thread_bufs;
 static struct ctx* thread_context, *target_context;
-static int curr_uc;
(Continue reading)

gerrit | 18 Aug 04:12 2014

Always unboost at exit

commit ec844f8b6dbd0af6489661615dfb7aba3f251ad1
Author: Avi Eisenberg <613ike <at> gmail.com>
Date:   Sun Aug 17 21:56:08 2014 -0400

    Always unboost at exit

    Change-Id: I8b4a2d61a5f4491265888d84c0f2c684bcf38edb
    Reviewed-on: http://gerrit.rockbox.org/915
    Reviewed-by: Jonathan Gordon <rockbox <at> jdgordon.info>

diff --git a/apps/plugins/2048.c b/apps/plugins/2048.c
index 9a74b0f..30f8899 100644
--- a/apps/plugins/2048.c
+++ b/apps/plugins/2048.c
 <at>  <at>  -703,6 +703,9  <at>  <at>  static void exit_handler(void)
     cleanup();
     if(abnormal_exit)
         save_game();
+#ifdef HAVE_ADJUSTABLE_CPU_FREQ
+    rb->cpu_boost(false); /* back to idle */
+#endif
     return;
 }
 static bool check_hs;
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 16 Aug 12:41 2014

Oops. Broke an egg. Restore wrongly removed code in mutex.c.

commit 030f51ce818e06cd35f2e5ada0e7cebb98bfe2d5
Author: Michael Sevakis <jethead71 <at> rockbox.org>
Date:   Sat Aug 16 06:37:29 2014 -0400

    Oops. Broke an egg. Restore wrongly removed code in mutex.c.

    Nice colorful diffs reveals some lines that should NOT have been
    removed when !defined(HAVE_PRIORITY_SCHEDULING) in mutex_unlock.

    Change-Id: I4152ea864b7706217c670e1b99250b09e69c5858

diff --git a/firmware/kernel/mutex.c b/firmware/kernel/mutex.c
index fc49cc6..876b704 100644
--- a/firmware/kernel/mutex.c
+++ b/firmware/kernel/mutex.c
 <at>  <at>  -103,6 +103,12  <at>  <at>  void mutex_unlock(struct mutex *m)
     }

     const int oldlevel = disable_irq_save();
+    /* Tranfer of owning thread is handled in the wakeup protocol
+     * if priorities are enabled otherwise just set it from the
+     * queue head. */
+#ifndef HAVE_PRIORITY_SCHEDULING
+    m->blocker.thread = thread;
+#endif
     unsigned int result = wakeup_thread(thread, WAKEUP_TRANSFER);
     restore_irq(oldlevel);

_______________________________________________
rockbox-cvs mailing list
(Continue reading)

gerrit | 16 Aug 12:02 2014

Fix warnings from 6ed0087

commit 528715a672a53156d7cb1382c344954d4d59cfc6
Author: Michael Sevakis <jethead71 <at> rockbox.org>
Date:   Sat Aug 16 05:52:05 2014 -0400

    Fix warnings from 6ed0087

    Forgot to (void) an unused parameter when priorityless.

    usb-drv-rl27xx.c was using a compound init to initialize a semaphore
    but the structure changed so that it is no longer correct. Use
    designated initializers to avoid having to complete all fields.

    Forgot to break compatibility on all plugins and codecs since the
    kernel objects are now different. Take care of that too and do the
    sort thing.

    Change-Id: Ie2ab8da152d40be0c69dc573ced8d697d94b0674

diff --git a/apps/plugin.c b/apps/plugin.c
index d0e6ade..8edc773 100644
--- a/apps/plugin.c
+++ b/apps/plugin.c
 <at>  <at>  -697,6 +697,7  <at>  <at>  static const struct plugin_api rockbox_api = {
 #endif
     plugin_get_buffer,
     plugin_get_audio_buffer,     /* defined in plugin.c */
+    plugin_release_audio_buffer, /* defined in plugin.c */
     plugin_tsr,                  /* defined in plugin.c */ 
     plugin_get_current_filename,
 #if defined(DEBUG) || defined(SIMULATOR)
(Continue reading)

gerrit | 16 Aug 11:19 2014

Base scheduler queues off linked lists and do cleanup/consolidation

commit 6ed00870abd566d7267d2436c2693f5a281cda2f
Author: Michael Sevakis <jethead71 <at> rockbox.org>
Date:   Fri Aug 8 06:33:51 2014 -0400

    Base scheduler queues off linked lists and do cleanup/consolidation
    
    Abstracts threading from itself a bit, changes the way its queues are
    handled and does type hiding for that as well.
    
    Do alot here due to already required major brain surgery.
    
    Threads may now be on a run queue and a wait queue simultaneously so
    that the expired timer only has to wake the thread but not remove it
    from the wait queue which simplifies the implicit wake handling.
    
    List formats change for wait queues-- doubly-linked, not circular.
    Timeout queue is now singly-linked. The run queue is still circular
    as before.
    
    Adds a better thread slot allocator that may keep the slot marked as
    used regardless of the thread state. Assists in dumping special tasks
    that switch_thread was tasked to perform (blocking tasks).
    
    Deletes alot of code yet surprisingly, gets larger than expected.
    Well, I'm not not minding that for the time being-- omlettes and break
    a few eggs and all that.
    
    Change-Id: I0834d7bb16b2aecb2f63b58886eeda6ae4f29d59

diff --git a/apps/debug_menu.c b/apps/debug_menu.c
(Continue reading)

gerrit | 13 Aug 12:45 2014

hwpatcher: fix horrible typo in the makefile

commit 278e8664a7393f2ca3050660c85d2142c38a4790
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Wed Aug 13 12:44:26 2014 +0200

    hwpatcher: fix horrible typo in the makefile

    Change-Id: I6e8d8ae3a5f6e1111a6b7d910a1a6b94e2733ca6

diff --git a/utils/hwpatcher/Makefile b/utils/hwpatcher/Makefile
index c64ff30..77b7092 100644
--- a/utils/hwpatcher/Makefile
+++ b/utils/hwpatcher/Makefile
 <at>  <at>  -15,7 +15,7  <at>  <at>  all: $(EXEC)
 %.o: $(SBTOOLS_DIR)/%.c
 	$(CC) $(CFLAGS) -c -o $ <at>  $<
 	
-%.o: $%.c
+%.o: %.c
 	$(CC) $(CFLAGS) -c -o $ <at>  $<

 hwpatcher: hwpatcher.o md5.o $(SBTOOLS_OBJ)
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 12 Aug 18:25 2014

Added highscore highlight to xobox game

commit df99ef2c7b95462bdb1f00e345529b3d4d270b55
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Fri Jul 11 12:38:02 2014 -0400

    Added highscore highlight to xobox game

    Change-Id: Idf6848fc80a56398889d5deeb16bf3707fcd3e30
    Reviewed-on: http://gerrit.rockbox.org/893
    Reviewed-by: Michael Giacomelli <giac2000 <at> hotmail.com>

diff --git a/apps/plugins/xobox.c b/apps/plugins/xobox.c
index 77f0110..3cf3b2a 100644
--- a/apps/plugins/xobox.c
+++ b/apps/plugins/xobox.c
 <at>  <at>  -1233,7 +1233,7  <at>  <at>  static int xobox_loop (void)
                     rb->splashf(HZ, "New High Score: %d", player.score);
                 }

-                highscore_show(-1, highscores, NUM_SCORES, true);
+                highscore_show(pos, highscores, NUM_SCORES, true);
             }

             if (xobox_menu(false)) {
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 12 Aug 00:01 2014

Added 2048 game

commit b61553c2b18d37566b6561e413ef1b49de39c0a7
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Sun Jun 29 14:49:07 2014 -0400

    Added 2048 game

    Change-Id: I4012dca4f93ca0db386a454635534f648ba906e9
    Reviewed-on: http://gerrit.rockbox.org/888
    Reviewed-by: Michael Giacomelli <giac2000 <at> hotmail.com>
    Tested: Michael Giacomelli <giac2000 <at> hotmail.com>

diff --git a/apps/plugins/2048.c b/apps/plugins/2048.c
new file mode 100644
index 0000000..9a74b0f
--- /dev/null
+++ b/apps/plugins/2048.c
 <at>  <at>  -0,0 +1,916  <at>  <at> 
+/***************************************************************************
+ *             __________               __   ___.
+ *   Open      \______   \ ____   ____ |  | _\_ |__   _______  ___
+ *   Source     |       _//  _ \_/ ___\|  |/ /| __ \ /  _ \  \/  /
+ *   Jukebox    |    |   (  <_> )  \___|    < | \_\ (  <_> > <  <
+ *   Firmware   |____|_  /\____/ \___  >__|_ \|___  /\____/__/\_ \
+ *                     \/            \/     \/    \/            \/
+ * $Id$
+ *
+ * Copyright (C) 2014 Franklin Wei
+ *
+ * Clone of 2048 by Gabriele Cirulli
+ *
(Continue reading)


Gmane