gerrit | 24 Feb 23:02 2015

Fix warnings in firmware/screendump.c

commit 55f1d9486fcff6ae7af6cac3a0200a996c194c6c
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Tue Feb 24 16:55:26 2015 -0500

    Fix warnings in firmware/screendump.c

    Change-Id: If01caf8a124e925b308bdefc6327420dde355ac9

diff --git a/firmware/screendump.c b/firmware/screendump.c
index e27360b..226d08a 100644
--- a/firmware/screendump.c
+++ b/firmware/screendump.c
 <at>  <at>  -140,7 +140,11  <at>  <at>  void screen_dump(void)
     }
     else
     {
-        write(fd, bmpheader, sizeof(bmpheader));
+        if(write(fd, bmpheader, sizeof(bmpheader)) != sizeof(bmpheader))
+        {
+            close(fd);
+            return;
+        }

         /* BMP image goes bottom up */
         for (y = LCD_HEIGHT - 1; y >= 0; y--)
 <at>  <at>  -243,7 +247,11  <at>  <at>  void screen_dump(void)
             while (dst < dst_end);

 #endif /* LCD_DEPTH */
-            write(fd, linebuf, DUMP_BMP_LINESIZE);
(Continue reading)

gerrit | 24 Feb 23:01 2015

Fix whitespace in firmware/screendump.c

commit 17ee90ccdb75f5e707604a1f4b28340aab072ec1
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Tue Feb 24 16:35:17 2015 -0500

    Fix whitespace in firmware/screendump.c

    Change-Id: Id3b4f259a6ae77bde02c040fe67fd21e29e2aa04

diff --git a/firmware/screendump.c b/firmware/screendump.c
index 2916cc1..e27360b 100644
--- a/firmware/screendump.c
+++ b/firmware/screendump.c
 <at>  <at>  -1,10 +1,10  <at>  <at> 
 /***************************************************************************
- *             __________               __   ___.                  
- *   Open      \______   \ ____   ____ |  | _\_ |__   _______  ___  
- *   Source     |       _//  _ \_/ ___\|  |/ /| __ \ /  _ \  \/  /  
- *   Jukebox    |    |   (  <_> )  \___|    < | \_\ (  <_> > <  <   
- *   Firmware   |____|_  /\____/ \___  >__|_ \|___  /\____/__/\_ \  
- *                     \/            \/     \/    \/            \/ 
+ *             __________               __   ___.
+ *   Open      \______   \ ____   ____ |  | _\_ |__   _______  ___
+ *   Source     |       _//  _ \_/ ___\|  |/ /| __ \ /  _ \  \/  /
+ *   Jukebox    |    |   (  <_> )  \___|    < | \_\ (  <_> > <  <
+ *   Firmware   |____|_  /\____/ \___  >__|_ \|___  /\____/__/\_ \
+ *                     \/            \/     \/    \/            \/
  * $Id$
  *
  * Copyright (C) 2009 by Jens Arnold
 <at>  <at>  -32,7 +32,7  <at>  <at> 
(Continue reading)

gerrit | 24 Feb 22:40 2015

Fix warning in firmware/common/structec.c

commit e4108a37263040336ba02df1d69f996cc3b20d0d
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Tue Feb 24 16:23:17 2015 -0500

    Fix warning in firmware/common/structec.c

    Change-Id: I3de9891042b7ae7ce695209c651bd075c861928d

diff --git a/firmware/common/structec.c b/firmware/common/structec.c
index 3f220b0..fb13eaa 100644
--- a/firmware/common/structec.c
+++ b/firmware/common/structec.c
 <at>  <at>  -164,8 +164,8  <at>  <at>  ssize_t ecwrite(int fd, const void *buf, size_t scount,
                 const char *ecinst, bool ec)
 {
     char tmp[MAX_STRUCT_SIZE];
-    size_t member_size = structec_size(ecinst);
-    
+    ssize_t member_size = structec_size(ecinst);
+
     if (ec)
     {
         const char *p = (const char *)buf;
 <at>  <at>  -178,7 +178,11  <at>  <at>  ssize_t ecwrite(int fd, const void *buf, size_t scount,

             memcpy(tmp, p, member_size * amount);
             structec_convert(tmp, ecinst, amount, true);
-            write(fd, tmp, amount * member_size);
+            ssize_t ret = write(fd, tmp, amount * member_size);
+
(Continue reading)

gerrit | 22 Feb 13:41 2015

German language update (FS#13024)

commit c4bf2e3cfde6215727387530124a1b70ef6f60c5
Author: Torsten Schrainer <schrator <at> gmx.de>
Date:   Sun Feb 22 13:40:34 2015 +0100

    German language update (FS#13024)

    Change-Id: Ic079929c0aebc06746d8a2221ac5db465c6de9b2

diff --git a/apps/lang/deutsch.lang b/apps/lang/deutsch.lang
index d0e0c92..acbdf99 100644
--- a/apps/lang/deutsch.lang
+++ b/apps/lang/deutsch.lang
 <at>  <at>  -12168,15 +12168,15  <at>  <at> 
   user: core
   <source>
     *: none
-    gigabeats: "Band %d Gain"
+    gigabeats,samsungypr1: "Band %d Gain"
   </source>
   <dest>
     *: none
-    gigabeats: "Verstärkung Band %d"
+    gigabeats,samsungypr1: "Band %d Verstärkung"
   </dest>
   <voice>
     *: none
-    gigabeats: "Bandverstärkung"
+    gigabeats,samsungypr1: "Band %d Verstärkung"
   </voice>
 </phrase>
(Continue reading)

gerrit | 22 Feb 13:31 2015

Update Russian and French rbutil translations.

commit 1865efc021e828ea62b14192c9ec091c8c493d29
Author: Семён Жуковский <mrjl <at> xmppnet.de>
Date:   Sun Feb 22 13:30:48 2015 +0100

    Update Russian and French rbutil translations.
    
    Change-Id: I52a42309b27b44463061f36a98b131d82a58a293

diff --git a/rbutil/rbutilqt/lang/rbutil_fr.ts b/rbutil/rbutilqt/lang/rbutil_fr.ts
index 7ec6b22..f2104e1 100644
--- a/rbutil/rbutilqt/lang/rbutil_fr.ts
+++ b/rbutil/rbutilqt/lang/rbutil_fr.ts
 <at>  <at>  -1121,7 +1121,7  <at>  <at>  Veuillez sélectionner manuellement le type de périphérique et le point de mon
     <message>
         <location filename="../configure.cpp" line="665"/>
         <source>%1 (%2 GiB of %3 GiB free)</source>
-        <translation type="unfinished"></translation>
+        <translation>%1 (%2 GiB libres sur %3 GiB)</translation>
     </message>
     <message>
         <location filename="../configure.cpp" line="739"/>
 <at>  <at>  -1141,7 +1141,7  <at>  <at>  Veuillez sélectionner manuellement le type de périphérique et le point de mon
     <message>
         <location filename="../configure.cpp" line="749"/>
         <source>%1 at %2</source>
-        <translation type="unfinished"></translation>
+        <translation>%1 à %2</translation>
     </message>
     <message>
         <location filename="../configure.cpp" line="755"/>
(Continue reading)

gerrit | 22 Feb 13:22 2015

Romanian language update (FS#13021)

commit a7fa25d928373d6f445e91e5af78d90f9063bb47
Author: Stefan Moisei <vortex <at> sdf-eu.org>
Date:   Sun Feb 22 13:19:48 2015 +0100

    Romanian language update (FS#13021)

    Change-Id: I2938e77ba1a83ec46656156dd36ed5252aafeed7

diff --git a/apps/lang/romaneste.lang b/apps/lang/romaneste.lang
index 1523f04..e1f2fea 100644
--- a/apps/lang/romaneste.lang
+++ b/apps/lang/romaneste.lang
 <at>  <at>  -11176,15 +11176,15  <at>  <at> 
   user: core
   <source>
     *: none
-    gigabeats: "Wide"
+    gigabeats,samsungypr1: "Wide"
   </source>
   <dest>
     *: none
-    gigabeats: "Largă"
+    gigabeats,samsungypr1: "Lăgime"
   </dest>
   <voice>
     *: none
-    gigabeats: "Largă"
+    gigabeats,samsungypr1: "Lărgime"
   </voice>
 </phrase>
(Continue reading)

gerrit | 22 Feb 12:23 2015

Lamp plugin: Allow toggling the button light using "select".

commit 272b5586397ebc4479b3ef247775723ddb8a5bd8
Author: Frank Gevaerts <frank <at> gevaerts.be>
Date:   Sun Feb 22 12:22:40 2015 +0100

    Lamp plugin: Allow toggling the button light using "select".

    Change-Id: I0f276a74010ef463ebdb0eb0cc00fc50123966f0

diff --git a/apps/plugins/lamp.c b/apps/plugins/lamp.c
index fa7027e..6c9ae66 100644
--- a/apps/plugins/lamp.c
+++ b/apps/plugins/lamp.c
 <at>  <at>  -45,6 +45,7  <at>  <at>  static const struct button_mapping *plugin_contexts[] = { pla_main_ctx };
 #   define LAMP_DOWN              PLA_SCROLL_BACK
 #   define LAMP_UP_REPEAT         PLA_SCROLL_FWD_REPEAT
 #   define LAMP_DOWN_REPEAT       PLA_SCROLL_BACK_REPEAT
+#   define LAMP_TOGGLE_BUTTON     PLA_SELECT
 #else
 #   define LAMP_LEFT              PLA_LEFT
 #   define LAMP_RIGHT             PLA_RIGHT
 <at>  <at>  -52,6 +53,7  <at>  <at>  static const struct button_mapping *plugin_contexts[] = { pla_main_ctx };
 #   define LAMP_DOWN              PLA_DOWN
 #   define LAMP_UP_REPEAT         PLA_UP_REPEAT
 #   define LAMP_DOWN_REPEAT       PLA_DOWN_REPEAT
+#   define LAMP_TOGGLE_BUTTON     PLA_SELECT
 #endif/* HAVE_SCROLLWHEEL */

 
 <at>  <at>  -87,6 +89,9  <at>  <at>  enum plugin_status plugin_start(const void* parameter)
     int cs = 0;
(Continue reading)

gerrit | 21 Feb 15:18 2015

iBasso DX50/DX90 added as "unstable" to builds.pm

commit b84fd878d3fa7512d93e692f97723007df2939be
Author: Simon Rothen <rothen <at> gmx.net>
Date:   Sat Feb 21 15:05:16 2015 +0100

    iBasso DX50/DX90 added as "unstable" to builds.pm

    Change-Id: If6c906c363341aa8c80b6c5010274ce07daef4c8

diff --git a/tools/builds.pm b/tools/builds.pm
index f36358a..d9d14b2 100644
--- a/tools/builds.pm
+++ b/tools/builds.pm
 <at>  <at>  -105,6 +105,14  <at>  <at>  $releasenotes="/wiki/ReleaseNotes313";
         name => 'iAudio X5',
         status => 3,
     },
+    'ibassodx50' => {
+        name => 'iBasso DX50',
+        status => 2,
+    },
+    'ibassodx90' => {
+        name => 'iBasso DX90',
+        status => 2,
+    },
     'ipod1g2g' => {
         name => 'iPod 1st and 2nd gen',
         status => 3,
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
(Continue reading)

gerrit | 16 Feb 14:07 2015

Revert "usb_storage: make it a bit more correct"

commit 27c7e477caeb2f79cc577b66ef59005481dd63ec
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Mon Feb 16 14:06:28 2015 +0100

    Revert "usb_storage: make it a bit more correct"

    Clearly this was a stupid commit, no idea why I did that.

    This reverts commit 074e911859a0d3464fde9b701b3cff712c5826e0.

diff --git a/firmware/usbstack/usb_storage.c b/firmware/usbstack/usb_storage.c
index 48e9442..59ec191 100644
--- a/firmware/usbstack/usb_storage.c
+++ b/firmware/usbstack/usb_storage.c
 <at>  <at>  -1161,7 +1161,6  <at>  <at>  static void handle_scsi(struct command_block_wrapper* cbw)

         default:
             logf("scsi unknown cmd %x",cbw->command_block[0x0]);
-            usb_drv_stall(ep_in, true,true);
             send_csw(UMS_STATUS_FAIL);
             cur_sense_data.sense_key=SENSE_ILLEGAL_REQUEST;
             cur_sense_data.asc=ASC_INVALID_COMMAND;
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 16 Feb 11:32 2015

zen*: fix yes/no dialog string

commit 7d91f8a1a8f126dd0ce268f765096106fe0383cf
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Mon Feb 16 11:31:53 2015 +0100

    zen*: fix yes/no dialog string

    Change-Id: I3d73027a9c8a8f885ffbc5cb28dd210ecf2f4285

diff --git a/apps/lang/english.lang b/apps/lang/english.lang
index 67b8d01..e8fc5fc 100644
--- a/apps/lang/english.lang
+++ b/apps/lang/english.lang
 <at>  <at>  -336,6 +336,7  <at>  <at> 
     mrobe500: "PLAY, POWER, or top-right = Yes"
     archosplayer: "(PLAY/STOP)"
     vibe500: "OK = Yes"
+    creativezen*: "Select = Yes"
   </source>
   <dest>
     *: "PLAY = Yes"
 <at>  <at>  -345,6 +346,7  <at>  <at> 
     mrobe500: "PLAY, POWER, or top-right = Yes"
     archosplayer: "(PLAY/STOP)"
     vibe500: "OK = Yes"
+    creativezen*: "Select = Yes"
   </dest>
   <voice>
     *: ""
_______________________________________________
rockbox-cvs mailing list
(Continue reading)

gerrit | 15 Feb 21:03 2015

Prevent configure from being run in the root of the tree, fix a typo in the configure script

commit 74fc3efb60ed7844c8f7dbd0bd66f666e611dcfb
Author: Franklin Wei <frankhwei536 <at> gmail.com>
Date:   Sun Feb 15 14:12:48 2015 -0500

    Prevent configure from being run in the root of the tree, fix a typo in the configure script

    Change-Id: I61205c2f00edbdcd726ca455a67c810fafe3ca92

diff --git a/tools/configure b/tools/configure
index 2dd1bf3..13cd599 100755
--- a/tools/configure
+++ b/tools/configure
 <at>  <at>  -1287,7 +1287,7  <at>  <at>  fi
 echo Using temporary directory $tmpdir

 if test -r "configure"; then
- # this is a check for a configure script in the current directory, it there
+ # this is a check for a configure script in the current directory, if there
  # is one, try to figure out if it is this one!

  if { grep "^#   Jukebox" configure >/dev/null 2>&1 ; } then
 <at>  <at>  -1304,6 +1304,23  <at>  <at>  if test -r "configure"; then
  fi
 fi

+if test -r "tools/configure"; then
+ # this is a check for a configure script in the tools/ directory, if there
+ # is one, try to figure out if it is this one!
+
+ if { grep "^#   Jukebox" tools/configure >/dev/null 2>&1 ; } then
(Continue reading)


Gmane