gerrit | 19 Sep 12:38 2014

regtools: reg-rk27xx.xml description file rework and cleanup

commit f9be1ef021fe0b5b1e924474f51c4201e437738e
Author: Marcin Bukat <marcin.bukat <at> gmail.com>
Date:   Fri Sep 19 10:35:43 2014 +0200

    regtools: reg-rk27xx.xml description file rework and cleanup

    Change-Id: I0a2e45eb1b4aa03122382cc93bbc0c292b3249be

diff --git a/utils/regtools/desc/regs-rk27xx.xml b/utils/regtools/desc/regs-rk27xx.xml
index fc866bc..3fa87a5 100644
--- a/utils/regtools/desc/regs-rk27xx.xml
+++ b/utils/regtools/desc/regs-rk27xx.xml
 <at>  <at>  -2,74 +2,167  <at>  <at> 
 <soc name="rk27xx" desc="Rockchip rk27xx">
   <dev name="A2A_DMA" long_name="AHB-to-AHB bridge" desc="AHB-to-AHB bridge with DMA" version="1.0">
     <addr name="A2A_DMA" addr="0x18094000"/>
-    <reg name="CON0" desc="">
+    <reg name="CON" desc="">
       <addr name="CON0" addr="0x0"/>
-    </reg>
-    <reg name="ISRC0" desc="">
-      <addr name="ISRC0" addr="0x4"/>
-    </reg>
-    <reg name="IDST0" desc="">
-      <addr name="IDST0" addr="0x8"/>
-    </reg>
-    <reg name="ICNT0" desc="">
-      <addr name="ICNT0" addr="0xc"/>
-    </reg>
-    <reg name="CSRC0" desc="">
(Continue reading)

gerrit | 19 Sep 11:00 2014

qeditor: Implement clock analyzer for rk27xx

commit b888743cac9c0af26632672796934fe9eaaa471d
Author: Marcin Bukat <marcin.bukat <at> gmail.com>
Date:   Thu Sep 18 10:04:14 2014 +0200

    qeditor: Implement clock analyzer for rk27xx

    Change-Id: Ib8f53d32120893b6c1054299ed434a6650a0d7c2
    Reviewed-on: http://gerrit.rockbox.org/971
    Reviewed-by: Marcin Bukat <marcin.bukat <at> gmail.com>

diff --git a/utils/regtools/lib/soc_desc.cpp b/utils/regtools/lib/soc_desc.cpp
index 3904f6a..1b1cd61 100644
--- a/utils/regtools/lib/soc_desc.cpp
+++ b/utils/regtools/lib/soc_desc.cpp
 <at>  <at>  -982,4 +982,3  <at>  <at>  public:
 };

 xml_parser_init __xml_parser_init;
-}
diff --git a/utils/regtools/qeditor/std_analysers.cpp b/utils/regtools/qeditor/std_analysers.cpp
index f278c2a..8aae007 100644
--- a/utils/regtools/qeditor/std_analysers.cpp
+++ b/utils/regtools/qeditor/std_analysers.cpp
 <at>  <at>  -33,7 +33,7  <at>  <at>  QWidget *ClockAnalyser::GetWidget()

 bool ClockAnalyser::SupportSoc(const QString& soc_name)
 {
-    return soc_name == "imx233";
+    return soc_name == "imx233" || soc_name == "rk27xx";
 }
(Continue reading)

gerrit | 19 Sep 10:58 2014

qeditor: rework modified indicator, register tab names depend on content

commit 970c2482dd22a84a5973b73621d0dd06e6f45a25
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 21:36:17 2014 +0200

    qeditor: rework modified indicator, register tab names depend on content

    Because Qt doesn't support QObject multiple inherance, it is a bit tricky
    to have a base class which interact with the UI. The register tab name
    now display:
    - file dump name (for dumps)
    - hwstub device path (for hwstub)
    And the register editor display the filename
    Change-Id: If2579992098c02627c67d560c824f1668e73bc45
    Reviewed-on: http://gerrit.rockbox.org/979
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/backend.h b/utils/regtools/qeditor/backend.h
index e876e9d..de45014 100644
--- a/utils/regtools/qeditor/backend.h
+++ b/utils/regtools/qeditor/backend.h
 <at>  <at>  -99,6 +99,7  <at>  <at>  public:
         { Q_UNUSED(addr); Q_UNUSED(value); Q_UNUSED(mode); return false; }
     virtual bool IsDirty() { return m_dirty; }
     virtual bool Commit();
+    QString GetFileName() { return m_filename; }

 protected:
     QString m_filename;
 <at>  <at>  -164,6 +165,7  <at>  <at>  public:
     virtual bool WriteRegister(soc_addr_t addr, soc_word_t value, WriteMode mode);
(Continue reading)

gerrit | 19 Sep 10:58 2014

qeditor: implement usb device list refresh (if supported)

commit dbb59291e745c7cc640a35fc40faa083648793bf
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 19:46:26 2014 +0200

    qeditor: implement usb device list refresh (if supported)

    Change-Id: Iaf05cad0e057f767dcde963d194027b2e290dbea
    Reviewed-on: http://gerrit.rockbox.org/978
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/utils.cpp b/utils/regtools/qeditor/utils.cpp
index 0719eec..036f159 100644
--- a/utils/regtools/qeditor/utils.cpp
+++ b/utils/regtools/qeditor/utils.cpp
 <at>  <at>  -829,6 +829,8  <at>  <at>  BackendSelector::BackendSelector(Backend *backend, QWidget *parent)
 #ifdef HAVE_HWSTUB
     connect(m_dev_selector, SIGNAL(currentIndexChanged(int)),
         this, SLOT(OnDevChanged(int)));
+    connect(&m_hwstub_helper, SIGNAL(OnDevListChanged(bool, struct libusb_device *)),
+        this, SLOT(OnDevListChanged2(bool, struct libusb_device *)));
 #endif
     OnDataSelChanged(0);
 }
 <at>  <at>  -883,6 +885,13  <at>  <at>  void BackendSelector::OnDataSelChanged(int index)
 }

 #ifdef HAVE_HWSTUB
+void BackendSelector::OnDevListChanged2(bool arrived, struct libusb_device *dev)
+{
+    Q_UNUSED(arrived);
(Continue reading)

gerrit | 19 Sep 10:58 2014

qeditor: fix UI to update register/analyser view on each tree/list click

commit 57d6db6ff597c692e3d35a4ddffc86189268f8f6
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 13:01:35 2014 +0200

    qeditor: fix UI to update register/analyser view on each tree/list click

    Change-Id: Idaceb7ffaf33c2184a43353dd9d7dee20ac807a9
    Reviewed-on: http://gerrit.rockbox.org/972
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/regtab.cpp b/utils/regtools/qeditor/regtab.cpp
index 9292248..132308e 100644
--- a/utils/regtools/qeditor/regtab.cpp
+++ b/utils/regtools/qeditor/regtab.cpp
 <at>  <at>  -143,12 +143,12  <at>  <at>  RegTab::RegTab(Backend *backend, QWidget *parent)
     connect(m_soc_selector, SIGNAL(currentIndexChanged(int)),
         this, SLOT(OnSocChanged(int)));
     connect(m_backend, SIGNAL(OnSocListChanged()), this, SLOT(OnSocListChanged()));
-    connect(m_reg_tree, SIGNAL(currentItemChanged(QTreeWidgetItem*, QTreeWidgetItem*)),
-        this, SLOT(OnRegItemChanged(QTreeWidgetItem*, QTreeWidgetItem*)));
+    connect(m_reg_tree, SIGNAL(itemClicked(QTreeWidgetItem*, int)),
+        this, SLOT(OnRegItemClicked(QTreeWidgetItem*, int)));
     connect(m_data_soc_label, SIGNAL(linkActivated(const QString&)), this,
         SLOT(OnDataSocActivated(const QString&)));
-    connect(m_analysers_list, SIGNAL(currentItemChanged(QListWidgetItem *, QListWidgetItem *)),
-        this, SLOT(OnAnalyserChanged(QListWidgetItem *, QListWidgetItem *)));
+    connect(m_analysers_list, SIGNAL(itemClicked(QListWidgetItem *)),
+        this, SLOT(OnAnalyserClicked(QListWidgetItem *)));
     connect(m_backend_selector, SIGNAL(OnSelect(IoBackend *)),
         this, SLOT(OnBackendSelect(IoBackend *)));
(Continue reading)

gerrit | 19 Sep 10:58 2014

qeditor: fix horrible out of bound bug

commit 79c5a07b4d067c00fa5ad4decf1d269bae2cb72f
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 19:04:05 2014 +0200

    qeditor: fix horrible out of bound bug

    Change-Id: I1b34b1cd7be83d90e38559e386d0c6c64797b707
    Reviewed-on: http://gerrit.rockbox.org/977
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/std_analysers.cpp b/utils/regtools/qeditor/std_analysers.cpp
index 5847e39..f278c2a 100644
--- a/utils/regtools/qeditor/std_analysers.cpp
+++ b/utils/regtools/qeditor/std_analysers.cpp
 <at>  <at>  -468,7 +468,7  <at>  <at>  void EmiAnalyser::FillTable()
         ports.erase(ports.begin() + value / 6);
         int ord[6][3] = { {0, 1, 2}, {2, 0, 1}, {1, 2, 0}, {2, 1, 0}, {1, 0, 2}, {0, 2, 1} };
         for(int i = 0; i < 3; i++)
-            order += ", " + ports[ord[value][i]];
+            order += ", " + ports[ord[value % 6][i]];
         AddLine("Port Priority Order", value, "", order);
     }

_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 19 Sep 10:57 2014

qeditor: when switching type tab, automagically switch view, implement reload

commit 0c633db98017e3aa6eb6acac5dbb3a28ced6f020
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 19:03:25 2014 +0200

    qeditor: when switching type tab, automagically switch view, implement reload

    Change-Id: I7360af3b5dd7380151732687d6d8de3dbd503f20
    Reviewed-on: http://gerrit.rockbox.org/976
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/regtab.cpp b/utils/regtools/qeditor/regtab.cpp
index b3f8832..9292248 100644
--- a/utils/regtools/qeditor/regtab.cpp
+++ b/utils/regtools/qeditor/regtab.cpp
 <at>  <at>  -372,3 +372,20  <at>  <at>  void RegTab::OnDumpRegs(bool c)
             "There was an error when dumping the registers");
     }
 }
+
+void RegTab::OnBackendReload(bool c)
+{
+    Q_UNUSED(c);
+    m_io_backend->Reload();
+    OnDataChanged();
+}
+
+void RegTab::OnTypeChanged(int index)
+{
+    if(index == -1)
+        return;
(Continue reading)

gerrit | 19 Sep 10:57 2014

qeditor: avoid memory leak in RegTab

commit e1f1f22b66350dff529d72270b9e0f7067488584
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 19:03:08 2014 +0200

    qeditor: avoid memory leak in RegTab

    Change-Id: Ib7cd87b66c0ceb3d3ff93714709a43e2a97ce79a
    Reviewed-on: http://gerrit.rockbox.org/975
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/regtab.cpp b/utils/regtools/qeditor/regtab.cpp
index 4c78c9e..b3f8832 100644
--- a/utils/regtools/qeditor/regtab.cpp
+++ b/utils/regtools/qeditor/regtab.cpp
 <at>  <at>  -138,7 +138,7  <at>  <at>  RegTab::RegTab(Backend *backend, QWidget *parent)
     this->addWidget(w);
     this->setStretchFactor(1, 2);

-    m_io_backend = m_backend->CreateDummyIoBackend();
+    m_io_backend = m_backend_selector->GetBackend();

     connect(m_soc_selector, SIGNAL(currentIndexChanged(int)),
         this, SLOT(OnSocChanged(int)));
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs
gerrit | 19 Sep 10:57 2014

qeditor: move backend selector to its own class, that's cleaner

commit a01bf8d93c2289c50fa4f24c15f6255e942ee82b
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 19:02:54 2014 +0200

    qeditor: move backend selector to its own class, that's cleaner

    Change-Id: I7f3fa66a8f67639b4b64cf9f6acc5fb10e227653
    Reviewed-on: http://gerrit.rockbox.org/974
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/regtab.cpp b/utils/regtools/qeditor/regtab.cpp
index 9fba9e9..4c78c9e 100644
--- a/utils/regtools/qeditor/regtab.cpp
+++ b/utils/regtools/qeditor/regtab.cpp
 <at>  <at>  -113,14 +113,7  <at>  <at>  RegTab::RegTab(Backend *backend, QWidget *parent)
     m_right_panel = new QVBoxLayout;
     QGroupBox *data_sel_group = new QGroupBox("Data selection");
     QHBoxLayout *data_sel_layout = new QHBoxLayout;
-    m_data_selector = new QComboBox;
-    m_data_selector->addItem(QIcon::fromTheme("text-x-generic"), "Explore", QVariant(DataSelNothing));
-    m_data_selector->addItem(QIcon::fromTheme("document-open"), "File...", QVariant(DataSelFile));
-#ifdef HAVE_HWSTUB
-    m_data_selector->addItem(QIcon::fromTheme("multimedia-player"), "Device...", QVariant(DataSelDevice));
-#endif
-    m_data_sel_edit = new QLineEdit;
-    m_data_sel_edit->setReadOnly(true);
+    m_backend_selector = new BackendSelector(m_backend, this);
     m_readonly_check = new QCheckBox("Read-only");
     m_readonly_check->setCheckState(Qt::Checked);
     m_data_soc_label = new QLabel;
(Continue reading)

gerrit | 19 Sep 10:56 2014

qeditor: initialise libusb once in a static ctor

commit b2ef4a806bd5f8f81917a7c93d210cee123191af
Author: Amaury Pouly <amaury.pouly <at> gmail.com>
Date:   Thu Sep 18 19:00:56 2014 +0200

    qeditor: initialise libusb once in a static ctor

    Change-Id: Ic93def2b3633c498c9863b0dada3281853be8c6c
    Reviewed-on: http://gerrit.rockbox.org/973
    Reviewed-by: Amaury Pouly <amaury.pouly <at> gmail.com>

diff --git a/utils/regtools/qeditor/backend.cpp b/utils/regtools/qeditor/backend.cpp
index 86e4d60..570ae4d 100644
--- a/utils/regtools/qeditor/backend.cpp
+++ b/utils/regtools/qeditor/backend.cpp
 <at>  <at>  -356,7 +356,6  <at>  <at>  bool HWStubIoBackend::Reload()
  */
 HWStubBackendHelper::HWStubBackendHelper()
 {
-    libusb_init(NULL);
 #ifdef LIBUSB_NO_HOTPLUG
     m_hotplug = false;
 #else
 <at>  <at>  -371,7 +370,7  <at>  <at>  HWStubBackendHelper::HWStubBackendHelper()
             &HWStubBackendHelper::HotPlugCallback, reinterpret_cast< void* >(this),
             &m_hotplug_handle);
     }
-#endif
+#endif /* LIBUSB_NO_HOTPLUG */
 }

(Continue reading)

gerrit | 18 Sep 19:17 2014

Add Ilia Sergachev to credits for his work on the DX50 port.

commit 7d112053abefb9574e922b467ccf2f04a49591e3
Author: Michael Giacomelli <giac2000 <at> hotmail.com>
Date:   Thu Sep 18 19:15:30 2014 +0200

    Add Ilia Sergachev to credits for his work on the DX50 port.

    Change-Id: Ic82e67a5514263995f24f86aa2b4d61470b8ffad

diff --git a/docs/CREDITS b/docs/CREDITS
index 4d23e2c..865a63b 100644
--- a/docs/CREDITS
+++ b/docs/CREDITS
 <at>  <at>  -641,6 +641,7  <at>  <at>  Franklin Wei
 Serhij Kyryljan
 Yifu Huang
 Jonathan Bettencourt
+Ilia Sergachev

 The libmad team
 The wavpack team
_______________________________________________
rockbox-cvs mailing list
rockbox-cvs <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox-cvs

Gmane