Re: clamav-milter patch

Here's the patch I spoke of:

Joe

-- 
Be still like a mountain and flow like a great river.
                                            --Lao Tse

--- clamav-milter.c	2003-09-30 07:53:55.000000000 -0400
+++ clamav-milter.c.new	2003-10-02 15:22:15.000000000 -0400
 <at>  <at>  -163,6 +163,8  <at>  <at> 

 #include <stdio.h>
 #include <sysexits.h>
+#include <fcntl.h>
+#include <paths.h>
 #ifndef TARGET_OS_FREEBSD
 #include <malloc.h>
 #endif
 <at>  <at>  -299,6 +301,7  <at>  <at> 
 	extern char *optarg;
 	char *port = NULL, *ptr;
 	FILE *clamd;
+	int fd;
 	const char *cfgfile = CL_DEFAULT_CFG;
 	struct cfgstruct *cpt;
 	char cmd[64];
 <at>  <at>  -527,6 +530,36  <at>  <at> 
 		*ptr = '\0';

clamav-milter patch

Here is a patch for clamav-milter.c that fixes forking a daemon on
Debian, sets 'port' to an unsigned short, calls clamfi_cleanup () in
clamfi_close () and checks for integer underflow in clamfi_cleanup ().
The patch is for the clamav-devel-20031001 snapshot.

I'm still seeing instability in clamd and clamav-milter.  I get
segmentation faults if I run clamav-devel-20031001 without
--max-children with MaxThreads set in clamav.conf.  I'll keep the list
posted.

Joe

--

-- 
Be still like a mountain and flow like a great river.
                                            --Lao Tse

-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php

Re: clamav-milter patch

On Thursday 02 Oct 2003 9:13 pm, Joe Talbott wrote:
> Here is a patch for clamav-milter.c that fixes forking a daemon on
> Debian,

This patch has not been relevant since version 0.60f. I would strongly advise you
all to check with code's authors before undertaking work, the number of times I see people
re-inventing the wheel is depressingly large.

-Nigel

--

-- 
Nigel Horne. Arranger, Composer, Typesetter.
NJH Music, Barnsley, UK.  ICQ#20252325
njh <at> despammed.com http://www.bandsman.co.uk

Re: clamav-milter patch

On Thursday 02 Oct 2003 9:13 pm, Joe Talbott wrote:

> I'm still seeing instability in clamd and clamav-milter.  I get
> segmentation faults if I run clamav-devel-20031001 without
> --max-children with MaxThreads set in clamav.conf.  I'll keep the list
> posted.

This was fixed a week ago in CVS. Please upgrade.

> Joe

-Nigel Horne

--

-- 
Nigel Horne. Arranger, Composer, Typesetter.
NJH Music, Barnsley, UK.  ICQ#20252325
njh <at> despammed.com http://www.bandsman.co.uk

Re: clamav-milter patch

On Thu, 9 Oct 2003, Nigel Horne wrote:

> On Thursday 02 Oct 2003 9:13 pm, Joe Talbott wrote:
> > Here is a patch for clamav-milter.c that fixes forking a daemon on
> > Debian,
>
> This patch has not been relevant since version 0.60f. I would strongly advise you
> all to check with code's authors before undertaking work, the number of times I see people
> re-inventing the wheel is depressingly large.

Perhaps it would be reasonable to release a new version of clamav if there
are indeed a significant number of stability fixes since 0.60.  Telling
people to use CVS snapshots only works for so long.

-Rob

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Rob Siemborski | Andrew Systems Group * Research Systems Programmer
PGP:0x5CE32FCC | Cyert Hall 207 * rjs3 <at> andrew.cmu.edu * 412.268.7456
-----BEGIN GEEK CODE BLOCK----
Version: 3.12
GCS/IT/CM/PA d- s+: a-- C++++$ ULS++++$ P+++$ L+++(++++) E W+ N o? K-
w O- M-- V-- PS+ PE++ Y+ PGP+ t+ <at>  5+++ R <at>  tv- <at>  b+ DI+++ G e h r- y?
------END GEEK CODE BLOCK-----

-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php

Re: clamav-milter patch

On Wednesday, October 8, 2003, at 11:09  PM, Nigel Horne wrote:
> This patch has not been relevant since version 0.60f. I would strongly 
> advise you
> all to check with code's authors before undertaking work, the number 
> of times I see people
> re-inventing the wheel is depressingly large.

Why isn't 0.60f available on SourceForge?  I'm assuming (hoping) that 
it corrects a lot of the problems I'm seeing with MIME parsing.

In Joe's original message, it sounded like he was using a CVS snapshot 
from October 1.  Is 0.60f newer than October 1st?

SourceForge is having problems, so I can't browse it right now.  Is 
0.60f tagged in the CVS tree?  Is there a place where various CVS 
snapshots have been recommended based on stability?

--
Tom Collins  -  tom <at> tomlogic.com
Note: The Tom Logic offices will be closed October 23 to November 18.
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/

-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php

Re: clamav-milter patch

On Thu, 9 Oct 2003 14:35:28 -0400 (EDT)
Rob Siemborski <rjs3 <at> andrew.cmu.edu> wrote:

> On Thu, 9 Oct 2003, Nigel Horne wrote:
> 
> > On Thursday 02 Oct 2003 9:13 pm, Joe Talbott wrote:
> > > Here is a patch for clamav-milter.c that fixes forking a daemon on
> > > Debian,
> >
> > This patch has not been relevant since version 0.60f. I would
> > strongly advise you all to check with code's authors before
> > undertaking work, the number of times I see people re-inventing the
> > wheel is depressingly large.
> 
> Perhaps it would be reasonable to release a new version of clamav if
> there are indeed a significant number of stability fixes since 0.60. 
> Telling people to use CVS snapshots only works for so long.

New version is almost finished but we need more cvd testing on different
systems and architectures before we switch freshclam to use it.

Best regards,
Tomasz Kojm
--

-- 
      oo    .....      	zolw <at> konarski.edu.pl
     (\/)\.........    	http://www.konarski.edu.pl/~zolw
        \..........._  	I nie zapomnij kliknac w brzuszek... 
          //\   /\\ 	<- C. Amboinensis    www.pajacyk.pl   	   

-------------------------------------------------------

[PATCH] libclamav: empty content-disposition causes crash

Hi there,

Please find attached a small patch against snapshot 20031009 (SF seem to be
having some problems else it would be against current CVS) which fixes a problem
in mbox.c insert() where an empty content-disposition causes a crash.

Also a fix for cases where header args flow to the next line.  It seems that
inMimeHead is incorrectly set to TRUE and thus whole header lines are incorrectly
considered arguments rather than new headers e.g. consider this:

 1:  Content-Type:
 2:  	base64
 3:  Content-Disposition:
 4:  	attachment; filename="info.rtf"

Content-Type is set correctly but lines 3 & 4 are added as arguments with
messageAddArgument() at approx. line 530 of mbox.c since inMimeHead remains TRUE
after setting of Content-type and thus Content-Disposition is never actually set.

Regards,
Matt.

diff -ruN clamav-0.60.cvs20031009.orig/libclamav/mbox.c clamav-0.60.cvs20031009/libclamav/mbox.c
--- clamav-0.60.cvs20031009.orig/libclamav/mbox.c	Wed Oct  1 21:27:42 2003
+++ clamav-0.60.cvs20031009/libclamav/mbox.c	Fri Oct 10 16:20:47 2003
 <at>  <at>  -596,16 +596,50  <at>  <at> 
 							if(t_line->t_next) {
 								t_line = t_line->t_next;
 								messageSetEncoding(aMessage, t_line->t_text);

Re: [PATCH] libclamav: empty content-disposition causes crash

On Friday 10 Oct 2003 6:09 am, Matt Sullivan wrote:

> Also a fix for cases where header args flow to the next line.

A quick e-mail to me before undertaking this would have saved you so
much time since I could have told you it's already been done uploaded to CVS
some two or three weeks ago.

Please ensure you always work on the latest code to avoid duplicating
effort. 

-Nigel

--

-- 
Nigel Horne. Arranger, Composer, Typesetter.
NJH Music, Barnsley, UK.  ICQ#20252325
njh <at> despammed.com http://www.bandsman.co.uk

Re: clamav-milter patch

On Thursday 09 Oct 2003 7:35 pm, Rob Siemborski wrote:

> Perhaps it would be reasonable to release a new version of clamav if there
> are indeed a significant number of stability fixes since 0.60.  Telling
> people to use CVS snapshots only works for so long.

It is perfectly reasonable to expect developers to work from the same code and/or to
check if the code they're about to work on has already been fixed by the author/maintainer. After
all this is clamav-devel, not clamav-users.

> -Rob

-Nigel

--

-- 
Nigel Horne. Arranger, Composer, Typesetter.
NJH Music, Barnsley, UK.  ICQ#20252325
njh <at> despammed.com http://www.bandsman.co.uk