Re: [liberationtech] New Anonymity Network for Short Messages
Eugen Leitl <eugen@...
2013-06-11 19:04:24 GMT
----- Forwarded message from Sean Cassidy
Date: Tue, 11 Jun 2013 10:47:21 -0700
From: Sean Cassidy <sean.a.cassidy@...>
To: liberationtech <liberationtech@...>
Subject: Re: [liberationtech] New Anonymity Network for Short Messages
Reply-To: liberationtech <liberationtech@...>
On Tue, Jun 11, 2013 at 10:29 AM, Steve Weis <steveweis@...> wrote:
> Hi. I took a quick look while procrastinating at work and found a few
> potential issues:
Thanks for taking a look. I'll be sure to incorporate your feedback.
> - What's up with this hard-coded salt?
Lack of love for the text client. I should just delete that code. The
primary user interface is the HTTP endpoint.
> - Any specific reason you picked CTR?
CTR is widely recommended. Cryptography Engineering specifically recommends it.
> - Use mlock here? I don't think that will help you if you run within a guest
> VM though.
> - Buffer overflow on password input
> - Is this safe for non-terminated strings?
Gah, must have missed that in my review.
> - Why do you have this checksum if you just HMACed the ciphertext?
This checksum is an important part of DiNet. Each packet comes with a
checksum that each router uses to verify the message integrity (not
authenticate, mind you) and to make sure it hasn't seen this message
before. As each router sends every packet it hasn't seen recently to
every machine that is connected to it, it is important to not re-send
> - HMAC verification is vulnerable to a timing attack. Since you're using
> CTR, it's that much easier to forge messages.
have any recommendations?
> - There's no forward security.
> This is by no means comprehensive. I've only been looking at a couple files.
Thanks for looking! I appreciate the feedback.
> On Tue, Jun 11, 2013 at 9:52 AM, Sean Cassidy <sean.a.cassidy@...>
>> Hello all,
>> I have created a simple anonymity network that broadcasts all messages
>> to participants so that you cannot associate chatters.
>> There is a simple sample client available, but you could write your
>> own client to build your own features atop the network.
>> Please let me know if you have any comments.
>> Too many emails? Unsubscribe, change to digest, or change password by
>> emailing moderator at companys@... or changing your
> Too many emails? Unsubscribe, change to digest, or change password by
> emailing moderator at companys@... or changing your settings at
Too many emails? Unsubscribe, change to digest, or change password by emailing moderator at
companys@... or changing your settings at https://mailman.stanford.edu/mailman/listinfo/liberationtech
----- End forwarded message -----
Eugen* Leitl <a href="http://leitl.org">leitl</a> http://leitl.org
ICBM: 48.07100, 11.36820 http://ativel.com http://postbiota.org
AC894EC5: 38A5 5F46 A4FF 59B8 336B 47EE F46E 3489 AC89 4EC5