Re: github: sympy pull requests
On Aug 31, 2010, at 10:54 PM, Ondrej Certik wrote:
> On Tue, Aug 31, 2010 at 9:26 PM, Aaron S. Meurer <asmeurer@...> wrote:
>> I am not saying that we should move our issue tracker to GitHub (I would be opposed to doing that unless
there were some way to import existing issues from Google Code, and even then only if it could be shown that
it has all the already existing features plus more to make it worth it).
> I agree that we should keep the issues where they are. I meant that
> maybe we can use github for code reviews instead of sympy-patches.
Oh, OK. Yes, let's try it.
>> What I was saying is that there are 78 NeedsReview issues, and no way to tell which ones are ones that I have a
branch up for. I think if we just add the person's user name as a label to an issue whenever they add a
patch/branch, it will make things easier (I would use Owner, but that is already used for other things, and
can only have one person at a time).
>> Unless there are any opposed to this idea, I will go ahead and do it.
> Go ahead, that'd be awesome!
OK. So from now on, whenever an issue has the NeedsReview tag or the PassedReview tag, add the Google Code
username of the person who has the patch/branch for review to the issue. It will warn you that you are using
an uncommon label, but that is just because I don't want to add everyone's username as an official label.
Only problem: for some people who are not members of the sympy Google Code project, their username appears
as an obfuscated email address. What do you think we should do for these people?