Stéfan van der Walt | 1 Feb 2012 05:39
Picon
Picon
Favicon

Re: Scikit Signal or similar

Hi Stuart

On Tue, Jan 31, 2012 at 5:20 AM, Stuart Mumford <stuart <at> mumford.me.uk> wrote:
> I am interested in contributing to the scikit-signal project, I have been
> working on a wavelet package recently which I believe would be useful.
> https://github.com/Cadair/scikit-signal

We'd also be interested in having wavelet code in scikits-image
(http://skimage.org), since we need it for denoising (I was planning
on just incorporating pywavelets).  An advantage is that you'd get a
"free" vehicle for distribution and packaging, but  since we focus on
image processing, there may be reasons why you'd rather have it in a
stand-alone package.

Regards
Stéfan
Ralf Gommers | 1 Feb 2012 07:33
Gravatar

Re: Scikit Signal or similar



2012/2/1 Stéfan van der Walt <stefan <at> sun.ac.za>
Hi Stuart

On Tue, Jan 31, 2012 at 5:20 AM, Stuart Mumford <stuart <at> mumford.me.uk> wrote:
> I am interested in contributing to the scikit-signal project, I have been
> working on a wavelet package recently which I believe would be useful.
> https://github.com/Cadair/scikit-signal

We'd also be interested in having wavelet code in scikits-image
(http://skimage.org), since we need it for denoising (I was planning
on just incorporating pywavelets).  An advantage is that you'd get a
"free" vehicle for distribution and packaging, but  since we focus on
image processing, there may be reasons why you'd rather have it in a
stand-alone package.

Don't really understand the stand-alone bit, since that is a scikit-signal fork. But I think the above shows that this really belongs in scipy. I think we should either improve scipy.signal.wavelets or look at merging pywavelets into scipy. This particular wheel gets reinvented way too often.

Ralf
_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
Travis Oliphant | 1 Feb 2012 08:53
Favicon
Gravatar

Re: Scikit Signal or similar


On Feb 1, 2012, at 12:33 AM, Ralf Gommers wrote:



2012/2/1 Stéfan van der Walt <stefan <at> sun.ac.za>
Hi Stuart

On Tue, Jan 31, 2012 at 5:20 AM, Stuart Mumford <stuart <at> mumford.me.uk> wrote:
> I am interested in contributing to the scikit-signal project, I have been
> working on a wavelet package recently which I believe would be useful.
> https://github.com/Cadair/scikit-signal

We'd also be interested in having wavelet code in scikits-image
(http://skimage.org), since we need it for denoising (I was planning
on just incorporating pywavelets).  An advantage is that you'd get a
"free" vehicle for distribution and packaging, but  since we focus on
image processing, there may be reasons why you'd rather have it in a
stand-alone package.

Don't really understand the stand-alone bit, since that is a scikit-signal fork. But I think the above shows that this really belongs in scipy. I think we should either improve scipy.signal.wavelets or look at merging pywavelets into scipy. This particular wheel gets reinvented way too often.


+1  --- I've wanted to see a wavelets package in SciPy for a long time. 

-Travis

Ralf
_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev

_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
Stuart Mumford | 1 Feb 2012 10:53
Picon
Gravatar

Re: scikit-signal or Similar

Hello all,
 
That's great. Have you been following the discussion that's happened about this package earlier on this list? Here's a summary I made - http://brocabrain.blogspot.in/2012/01/scikit-signal-python-for-signal.html

I have read the discussion and your blog post. I think that development in scikit-signal is a good thing as long as we keep open the possibility of merging bits (all) of it into other places later. It really depends on where the project goes, as you said in your blog post, I don't really understand the intricacies of namespaces either so I am just happy to work on some code.

But I think the above shows that this really belongs in scipy. I think we should either improve scipy.signal.wavelets or look at merging pywavelets into scipy. This particular wheel gets reinvented way too often.

I agree that scipy.signal.wavelets needs improving, the reason myself and my friend started developing this wavelet code, was the only piece of Continuous Wavelet Transform code we could find was the piece we based what is now in the GitHub on. Even that had major omissions to what we needed and therefore we have spent time making the code fit our needs.

As for pyWavelets that seems to be a good standalone project and appears to be good at Discrete Wavelet Transforms, which I have not looked into. Again there is no need to reinvent the wheel so I don't think implementing a DWT into SciPy is necessary, however with the amount of applications for CWT I feel it would be better off in SciPy when it is ready.

We'd also be interested in having wavelet code in scikits-image (http://skimage.org), since we need it for denoising 
 
I am interested in this application for wavelets, and how to expand the current 1D CWT into 2D. Do you know the advantages / disadvantages for CWT / DWT for your applications?

Wow, I took a look at the wavelet.py code. I, for one would learn like to learn from you. I want to learn to start coding like that.

I am flattered! I have never been taught OOP I just sort of blunder through so I hope what I produce is decent code!

I don't think pyHHT will be a part of scikit-signal for some time, both are projects in their infancy.

pyHHT certainly needs a lot of work and scikit-signal needs some code, but I think eventually this could be the aim.

Right now I'm working on time-frequency analysis (for the scikit-signal).

Cool, what?

Although HHT too is ultimately a tool for time-frequency analysis, we need to create enough motivation for using the HHT over other conventional methods.

From my (very limited) knowledge of what is good for what in signal processing, HHT to me is pretty impressive in what it can do. But as for using something like that it's all about what data you have and what you want to learn from it. I am studying the Sun for my PhD and the primary reason I wish to use HHT (well EMD) is to calculate the periods of oscillation in my very short data sets. [And I will go to extreme lengths to avoid using IDL]

But of course, as an independent project, you are welcome to contribute. I've put a crude version up at https://github.com/jaidevd/pyhht

I have already cloned it and started tinkering, but I need to do some more theoretical research first as I don't fully understand it.

Stuart
_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
Travis Oliphant | 1 Feb 2012 16:10
Favicon
Gravatar

Re: scikit-signal or Similar


On Feb 1, 2012, at 3:53 AM, Stuart Mumford wrote:

Hello all,
 
That's great. Have you been following the discussion that's happened about this package earlier on this list? Here's a summary I made - http://brocabrain.blogspot.in/2012/01/scikit-signal-python-for-signal.html

I have read the discussion and your blog post. I think that development in scikit-signal is a good thing as long as we keep open the possibility of merging bits (all) of it into other places later. It really depends on where the project goes, as you said in your blog post, I don't really understand the intricacies of namespaces either so I am just happy to work on some code.

But I think the above shows that this really belongs in scipy. I think we should either improve scipy.signal.wavelets or look at merging pywavelets into scipy. This particular wheel gets reinvented way too often.

I agree that scipy.signal.wavelets needs improving, the reason myself and my friend started developing this wavelet code, was the only piece of Continuous Wavelet Transform code we could find was the piece we based what is now in the GitHub on. Even that had major omissions to what we needed and therefore we have spent time making the code fit our needs.

As for pyWavelets that seems to be a good standalone project and appears to be good at Discrete Wavelet Transforms, which I have not looked into. Again there is no need to reinvent the wheel so I don't think implementing a DWT into SciPy is necessary, however with the amount of applications for CWT I feel it would be better off in SciPy when it is ready.

The DWT is exactly the kind of tool SciPy needs.   The goal would not be to re-invent DWT with SciPy, but simply integrate pywavelets into SciPy if that is at all possible.    Having so many packages is good for developers, but not very good for consumers as people have to collect a lot of different packages together to get what they want.   Some of this pressure is being alleviated by "distributions" of Python, and I expect that trend will continue.   But, it is still useful for SciPy to grow "fundamental" libraries like a DWT.   

Thanks for your contributions an comments. 

Best regards,

-Travis




We'd also be interested in having wavelet code in scikits-image (http://skimage.org), since we need it for denoising 
 
I am interested in this application for wavelets, and how to expand the current 1D CWT into 2D. Do you know the advantages / disadvantages for CWT / DWT for your applications?

Wow, I took a look at the wavelet.py code. I, for one would learn like to learn from you. I want to learn to start coding like that.

I am flattered! I have never been taught OOP I just sort of blunder through so I hope what I produce is decent code!

I don't think pyHHT will be a part of scikit-signal for some time, both are projects in their infancy.

pyHHT certainly needs a lot of work and scikit-signal needs some code, but I think eventually this could be the aim.

Right now I'm working on time-frequency analysis (for the scikit-signal).

Cool, what?

Although HHT too is ultimately a tool for time-frequency analysis, we need to create enough motivation for using the HHT over other conventional methods.

From my (very limited) knowledge of what is good for what in signal processing, HHT to me is pretty impressive in what it can do. But as for using something like that it's all about what data you have and what you want to learn from it. I am studying the Sun for my PhD and the primary reason I wish to use HHT (well EMD) is to calculate the periods of oscillation in my very short data sets. [And I will go to extreme lengths to avoid using IDL]

But of course, as an independent project, you are welcome to contribute. I've put a crude version up at https://github.com/jaidevd/pyhht

I have already cloned it and started tinkering, but I need to do some more theoretical research first as I don't fully understand it.

Stuart
_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev

_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
Ralf Gommers | 1 Feb 2012 21:43
Gravatar

Re: scikit-signal or Similar



On Wed, Feb 1, 2012 at 4:10 PM, Travis Oliphant <travis <at> continuum.io> wrote:

On Feb 1, 2012, at 3:53 AM, Stuart Mumford wrote:

Hello all,
 
That's great. Have you been following the discussion that's happened about this package earlier on this list? Here's a summary I made - http://brocabrain.blogspot.in/2012/01/scikit-signal-python-for-signal.html

I have read the discussion and your blog post. I think that development in scikit-signal is a good thing as long as we keep open the possibility of merging bits (all) of it into other places later. It really depends on where the project goes, as you said in your blog post, I don't really understand the intricacies of namespaces either so I am just happy to work on some code.

But I think the above shows that this really belongs in scipy. I think we should either improve scipy.signal.wavelets or look at merging pywavelets into scipy. This particular wheel gets reinvented way too often.

I agree that scipy.signal.wavelets needs improving, the reason myself and my friend started developing this wavelet code, was the only piece of Continuous Wavelet Transform code we could find was the piece we based what is now in the GitHub on. Even that had major omissions to what we needed and therefore we have spent time making the code fit our needs.

There is http://projects.scipy.org/scipy/ticket/922 which the author has kept on developing despite the unfortunate lack of feedback. It looks quite far along and may be useful for you: https://github.com/lesserwhirls/scipy-cwt

There is also a cwt function in signal.wavelets, but it's very limited.
As for pyWavelets that seems to be a good standalone project and appears to be good at Discrete Wavelet Transforms, which I have not looked into. Again there is no need to reinvent the wheel so I don't think implementing a DWT into SciPy is necessary, however with the amount of applications for CWT I feel it would be better off in SciPy when it is ready.
Agreed.

The DWT is exactly the kind of tool SciPy needs.   The goal would not be to re-invent DWT with SciPy, but simply integrate pywavelets into SciPy if that is at all possible.    Having so many packages is good for developers, but not very good for consumers as people have to collect a lot of different packages together to get what they want.   Some of this pressure is being alleviated by "distributions" of Python, and I expect that trend will continue.   But, it is still useful for SciPy to grow "fundamental" libraries like a DWT.   

I'll send the pywavelets author an email, would be great to get his input on this.

Ralf
_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
Charles R Harris | 1 Feb 2012 22:01
Picon

Heads up and macro deprecation.

Hi All,


Two things here.

1) Some macros for threading and the iterator now require a trailing semicolon. This change will be reverted before the 1.7 release so that scipy 0.10 will compile, but because it is desirable in the long term it would be helpful if folks maintaining c extensions using numpy would try compiling them against current development and adding the semicolon where needed. The added semicolon will be backward compatible with earlier versions of numpy.

2) It is proposed to deprecate all of the macros in the old_defines.h file and require the use of their replacements. Numpy itself will have made this change after pull-189 is merged and getting rid of the surplus macros will help clean up the historical detritus that has built up over the years, easing maintenance, clarifying code, and making the eventual transition to 2.0 a bit easier. There is a sed script in the tools directory as part of the pull request that can be used to make the needed substitutions.

Thoughts?

Chuck

_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
David Cournapeau | 1 Feb 2012 23:43
Picon
Gravatar

Re: Heads up and macro deprecation.

On Wed, Feb 1, 2012 at 9:01 PM, Charles R Harris
<charlesr.harris <at> gmail.com> wrote:
> Hi All,
>
> Two things here.
>
> 1) Some macros for threading and the iterator now require a trailing
> semicolon. This change will be reverted before the 1.7 release so that scipy
> 0.10 will compile, but because it is desirable in the long term it would be
> helpful if folks maintaining c extensions using numpy would try compiling
> them against current development and adding the semicolon where needed. The
> added semicolon will be backward compatible with earlier versions of numpy.
>
> 2) It is proposed to deprecate all of the macros in the old_defines.h file
> and require the use of their replacements. Numpy itself will have made this
> change after pull-189 is merged and getting rid of the surplus macros will
> help clean up the historical detritus that has built up over the years,
> easing maintenance, clarifying code, and making the eventual transition to
> 2.0 a bit easier. There is a sed script in the tools directory as part of
> the pull request that can be used to make the needed substitutions.
>
> Thoughts?

Long needed cleanup, thanks for taking care of this.

Is there a need to review anything, or has this already been merged ?

David
Charles R Harris | 2 Feb 2012 00:01
Picon

Re: Heads up and macro deprecation.



On Wed, Feb 1, 2012 at 3:43 PM, David Cournapeau <cournape <at> gmail.com> wrote:
On Wed, Feb 1, 2012 at 9:01 PM, Charles R Harris
<charlesr.harris <at> gmail.com> wrote:
> Hi All,
>
> Two things here.
>
> 1) Some macros for threading and the iterator now require a trailing
> semicolon. This change will be reverted before the 1.7 release so that scipy
> 0.10 will compile, but because it is desirable in the long term it would be
> helpful if folks maintaining c extensions using numpy would try compiling
> them against current development and adding the semicolon where needed. The
> added semicolon will be backward compatible with earlier versions of numpy.
>
> 2) It is proposed to deprecate all of the macros in the old_defines.h file
> and require the use of their replacements. Numpy itself will have made this
> change after pull-189 is merged and getting rid of the surplus macros will
> help clean up the historical detritus that has built up over the years,
> easing maintenance, clarifying code, and making the eventual transition to
> 2.0 a bit easier. There is a sed script in the tools directory as part of
> the pull request that can be used to make the needed substitutions.
>
> Thoughts?

Long needed cleanup, thanks for taking care of this.

Is there a need to review anything, or has this already been merged ?


It hasn't been merged yet. The main question has been if/how we should deprecate the old macros. The announcement also serves notice ;)

I've got a patch doing this for scipy put haven't put it up yet.

Chuck

_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev
Ralf Gommers | 2 Feb 2012 07:32
Gravatar

commit rights for Jake Vanderplas

Hi,

I propose to give Jake Vanderplas commit rights. He has been been making a lot of small fixes recently, as well as larger contributions on Arpack and now graph algorithms.

Ralf

_______________________________________________
SciPy-Dev mailing list
SciPy-Dev <at> scipy.org
http://mail.scipy.org/mailman/listinfo/scipy-dev

Gmane