Tim Starling | 2 Jun 09:02 2010
Picon

Python Wikipedia Robot Framework in CodeReview

I've added the Python Wikipedia Robot Framework to MediaWiki.org code
review:

http://www.mediawiki.org/wiki/Special:Code/pywikipedia

The post-commit hook is set up but untested. We'll see if it works when
someone commits something.

-- Tim Starling
Siebrand Mazeland | 2 Jun 09:22 2010
Picon
Picon

Can has pywikipediabot code review? Yes!

Pywikipediabot now has code review in the same way as MediaWiki[1]. Tim has implemented this a few hours
ago. Thanks Tim!

Below you can find a description of the new functionality. I hope we can discuss whatever you may see
differently or whatever I may have left out.

Please mind the following if you wish to participate in the code review:
* anyone can use the tool in a read-only mode (right: codereview-use)
* registered users can submit comments on revisions (right: codereview-post-comment)
* coders can link committers to mediawiki.org user accounts. All committers should have an account on
mediawiki.org with a confirmed e-mail address and linked their user to their committer identity[2].
This allows you to get e-mails on your revs and follow-up revs. (right: codereview-link-user, role: coder)
* coders can add and remove tags for revisions in the review module. For MediaWiki this feature isn't used
that much, but it can be used to group revisions (rights: codereview-add-tag, codereview-remove-tag,
role: coder)
* coders can change the status of revisions (right: codereview-set-status, role coder). Possible states are:
** new: default state
** fixme: something needs to be done for this revision is broken - the original committer should feel
responsible for doing this
** reverted: this revision has been reverted
** resolved: this revision was marked fixme, but the issue has been resolved in a later revision
** ok: this revision has been reviewed by a coder able to assess the revision and no issues have been found
** verified: uncertain, as not used in MediaWiki code review. I propose not to use this tag until we need it
for whatever
* coders can add new coders[3] (role: coder). This is supposed to be a web of trust. Only change state to ok for
revisions that you really understand, and keep comments to the point. If you have the coder role, you can do
code review also on MediaWiki; please only stick to the project you develop on with regards to code review functionality.

If you make follow-up revisions, please mention to which revision (with r#####) you are following up to in
your commit summary. This will automatically link the new revision in the code review page of the
(Continue reading)

info | 2 Jun 09:29 2010
Picon

Re: Python Wikipedia Robot Framework in CodeReview

 I got this Error while committing a new version:

Fertig: In Revision: 8232  
Fehler: post-commit hook failed (exit code 2) with output:  
Fehler: /svnroot/pywikipedia/hooks/deferred-updates.sh: line 4: unexpected EOF while looking for
matching `"'  
Fehler: /svnroot/pywikipedia/hooks/deferred-updates.sh: line 7: syntax error: unexpected end of
file  

xqt

----- Original Nachricht ----
Von:     Tim Starling <tstarling <at> wikimedia.org>
An:      pywikipedia-l <at> lists.wikimedia.org, wikitech-l <at> lists.wikimedia.org
Datum:   02.06.2010 09:02
Betreff: [Pywikipedia-l] Python Wikipedia Robot Framework in CodeReview

> I've added the Python Wikipedia Robot Framework to MediaWiki.org code
> review:
> 
> http://www.mediawiki.org/wiki/Special:Code/pywikipedia
> 
> The post-commit hook is set up but untested. We'll see if it works when
> someone commits something.
> 
> -- Tim Starling
> 
> _______________________________________________
> Pywikipedia-l mailing list
> Pywikipedia-l <at> lists.wikimedia.org
(Continue reading)

Tim Starling | 2 Jun 10:42 2010
Picon

Re: Python Wikipedia Robot Framework in CodeReview

On 02/06/10 17:29, info <at> gno.de wrote:
>  I got this Error while committing a new version:
> 
> Fertig: In Revision: 8232  
> Fehler: post-commit hook failed (exit code 2) with output:  
> Fehler: /svnroot/pywikipedia/hooks/deferred-updates.sh: line 4: unexpected EOF while looking for
matching `"'  
> Fehler: /svnroot/pywikipedia/hooks/deferred-updates.sh: line 7: syntax error: unexpected end of
file  
> 
> xqt

This is fixed, and xqt tested it.

-- Tim Starling
info | 2 Jun 10:47 2010
Picon

Re: Can has pywikipediabot code review? Yes!

The last reported bug has been fixed and all works fine.

There is the point svn should lead to the right code review for pwb instead to MediaWiki. See https://bugzilla.wikimedia.org/show_bug.cgi?id=23177

xqt

----- Original Nachricht ----
Von:     Siebrand Mazeland <s.mazeland <at> xs4all.nl>
An:      'Pywikipedia discussion list' <pywikipedia-l <at> lists.wikimedia.org>
Datum:   02.06.2010 09:22
Betreff: [Pywikipedia-l] Can has pywikipediabot code review? Yes!

> Pywikipediabot now has code review in the same way as MediaWiki[1]. Tim has
> implemented this a few hours ago. Thanks Tim!
> 
> Below you can find a description of the new functionality. I hope we can
> discuss whatever you may see differently or whatever I may have left out.
> 
> Please mind the following if you wish to participate in the code review:
> * anyone can use the tool in a read-only mode (right: codereview-use)
> * registered users can submit comments on revisions (right:
> codereview-post-comment)
> * coders can link committers to mediawiki.org user accounts. All committers
> should have an account on mediawiki.org with a confirmed e-mail address and
> linked their user to their committer identity[2]. This allows you to get
> e-mails on your revs and follow-up revs. (right: codereview-link-user, role:
> coder)
> * coders can add and remove tags for revisions in the review module. For
> MediaWiki this feature isn't used that much, but it can be used to group
> revisions (rights: codereview-add-tag, codereview-remove-tag, role: coder)
(Continue reading)

stanlekub | 2 Jun 13:35 2010
Picon

Re: Access to the 'site' attribute in rewrite branch

From: "Russel Blau" <russblau <at> imapmail.org>:
>> My favorite would be to use  <at> property on both, but it's one more step
>> against backward compatibility.
>
>That would be my favorite, too, but I didn't do it for the very reason you 
>suggest.
>
>> PS: I can work on a patch for this upon request, if needed.
>
>I'll take you up on that offer.  :-)
>
>Russ

So, after some time spent checking that eveything (hopefully) works correctly,
I've uploaded the patch on sourceforge's tracker[1]. This is quite a huge one,
but as long as my tests were complete, it seems ok.

stan.

[1] https://sourceforge.net/tracker/?func=detail&aid=3010404&group_id=93107&atid=603140
Chris Watkins | 8 Jun 22:00 2010

Re: match and list, but not replace

Hi Bináris,

Thanks - this looks very promising.

I wonder if you could post a copy of your replace2.py, so I can follow the instructions more clearly - I'm a bit confused by a couple of points.

Thanks again!

On Sat, May 1, 2010 at 22:36, Bináris <wikiposta <at> gmail.com> wrote:
2010/4/1 Chris Watkins <chriswaterguy <at> appropedia.org>

I want to generate a list of matches for a search, but not do anything to the page.


I tell you the trick. This is not my own wisdom, I have learnt it from hu:user:Pasztilla.

For example, you have a user:MyBot/try subpage. You copy replace.py to replace2.py, and then modify as itt follows:

1.  Look for "    def run(self):" line, and write under it:
        list =''
This will start a new list. Alternatively,
        list = wikipedia.Page(wikipedia.getSite(), 'User:MyBot/try').get()
will continue your existing list.

2. Under "                if choice == 'y':"
look for                     page.put_async(new_text, self.editSummary)
and comment it out:                     #page.put_async(new_text, self.editSummary)

and write just below this line:
                    list+= u'# [[%s]]\n' %page.title()
                    listsite = wikipedia.Page(wikipedia.getSite(), 'User:MyBot/try')
                    listsite.put(list, self.editSummary)
This will write the title of the page to your subpage.

3. Under the "            if self.acceptall and new_text != original_text:" line
make the same changes as in step 2.

Enjoy!
 

--
Bináris

_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l <at> lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l




--
Chris Watkins

Appropedia.org - Sharing knowledge to build rich, sustainable lives.

blogs.appropedia.org
community.livejournal.com/appropedia
identi.ca/appropedia
twitter.com/appropedia
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l <at> lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
info | 9 Jun 17:41 2010
Picon

Re: Can has pywikipediabot code review? Yes!


----- Original Nachricht ----
Von:     Siebrand Mazeland <s.mazeland <at> xs4all.nl>
An:      'Pywikipedia discussion list' <pywikipedia-l <at> lists.wikimedia.org>
Datum:   02.06.2010 09:22
Betreff: [Pywikipedia-l] Can has pywikipediabot code review? Yes!

> * registered users can submit comments on revisions (right:
> codereview-post-comment)

I am wondering: this is no longer availlable on most reviews.

Regards xqt

--

-- 
WM 2010: Top News, Spielpläne, Public Viewing-Termine, E-Cards und alles, 
was der Fan sonst noch braucht, gibt´s im Sport-Channel auf arcor.de.
http://www.arcor.de/rd/footer.wm2010
info | 10 Jun 08:05 2010
Picon

Re: Can has pywikipediabot code review? Yes!

Please forget it! I wasn't logged in.
Sorry for disturbing you.

Greetings 
xqt 

----- Original Nachricht ----
Von:     info <at> gno.de
An:      pywikipedia-l <at> lists.wikimedia.org
Datum:   09.06.2010 17:41
Betreff: Re: [Pywikipedia-l] Can has pywikipediabot code review? Yes!

>  
> 
> 
> ----- Original Nachricht ----
> Von:     Siebrand Mazeland <s.mazeland <at> xs4all.nl>
> An:      'Pywikipedia discussion list' <pywikipedia-l <at> lists.wikimedia.org>
> Datum:   02.06.2010 09:22
> Betreff: [Pywikipedia-l] Can has pywikipediabot code review? Yes!
> 
> > * registered users can submit comments on revisions (right:
> > codereview-post-comment)
> 
> I am wondering: this is no longer availlable on most reviews.
> 
> Regards xqt
> 
> -- 
> WM 2010: Top News, Spielpläne, Public Viewing-Termine, E-Cards und alles, 
> was der Fan sonst noch braucht, gibt´s im Sport-Channel auf arcor.de.
> http://www.arcor.de/rd/footer.wm2010
> 
> _______________________________________________
> Pywikipedia-l mailing list
> Pywikipedia-l <at> lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
> 

--

-- 
WM 2010: Top News, Spielpläne, Public Viewing-Termine, E-Cards und alles, 
was der Fan sonst noch braucht, gibt´s im Sport-Channel auf arcor.de.
http://www.arcor.de/rd/footer.wm2010
Patrol110 | 12 Jun 11:00 2010
Picon

unlink.py - new translation

Hello! Please add a new Polish translation to unlink.py due to the lack of it :D

'pl':u'Robot odlinkowuje "%s"',

Thanks in advance!
Patrol

Gmane