Hi everyone, I discovered ftputil because I wanted to index ftp servers. So I have to list directories with walk. But the current code make too many requests (1 per file). In a directory with thousands of files it is unusable.

To this is a patch which use retrlines("LIST"). It makes only one request per dir.

    def walk(self, top, topdown=True, onerror=None):
        """
        Iterate over directory tree and return a tuple (dirpath,
        dirnames, filenames) on each iteration, like the `os.walk`
        function (see http://docs.python.org/lib/os-file-dir.html ).
        """
        # Hack with retrlines("LIST"). 
       
        # The following code is copied from `os.walk` in Python 2.4
        #  and adapted to ftputil.
        dirs, nondirs = [], []
        def callback(line):
            #example of a line :
            #drwxrwxrwx   2 ftp      nogroup    159744 Oct 22 04:48 Upload
            #their neither is . and ..
            name = line[55:] #Ugly hack, must check that is correct. It work ith proftpd.
            if line.startswith("d"):
                dirs.append(name)
            elif not line.startswith("l"): #No links
                nondirs.append(name)
        try:
            raw = self._session.retrlines("LIST "+ top, callback)
        except ftp_error.FTPOSError:
            if onerror is not None:
                onerror(err)
            return
        if topdown:
            yield top, dirs, nondirs
        for name in dirs:
            path = self.path.join(top, name)
            for item in self.walk(path, topdown, onerror):
                yield item
        if not topdown:
            yield top, dirs, nondirs

Matthieu Bizien