Re: [Cython] OpenMP problem

mark florisson, 31.07.2011 22:08:
> I pushed it to release, should I rebase master on release now?

Well, so far, the release branch hasn't been used and rc1 was created from 
master. All current changes in master are either considered safe (by me :) 
or just fixes that should go into the release. So I think it's best to just 
rebase your single commit in the current release branch back on the master, 
delete the release branch and recreate it from the tip of the master branch.

Stefan

Re: [Cython] OpenMP problem

On 1 August 2011 08:48, Stefan Behnel <stefan_ml@...> wrote:
> mark florisson, 31.07.2011 22:08:
>>
>> I pushed it to release, should I rebase master on release now?
>
> Well, so far, the release branch hasn't been used and rc1 was created from
> master. All current changes in master are either considered safe (by me :)
> or just fixes that should go into the release. So I think it's best to just
> rebase your single commit in the current release branch back on the master,
> delete the release branch and recreate it from the tip of the master branch.
>
> Stefan
> _______________________________________________
> cython-devel mailing list
> cython-devel@...
> http://mail.python.org/mailman/listinfo/cython-devel
>

Ok, thanks Dag and Stefan, I suspected the danger, but if Stefan's
changes are to go in I'll just do as Stefan suggested.

Re: [Cython] Cython 0.15 release candidate

2011-07-31 09:45:15 Robert Bradshaw napisał(a):
> On Thu, Jul 21, 2011 at 4:14 PM, Robert Bradshaw
> <robertwb@...> wrote:
> > Cython has seen an enormous amount of development since 0.14.1. If you
> > are not already using the latest version from the development
> > repository, we encourage you to try out the release candidate:
> > http://cython.org/release/Cython-0.15rc0.tar.gz
> 
> Thanks for all the feedback. Here's another release candidate:
> http://cython.org/release/Cython-0.15rc0.tar.gz Unless something major
> is found, this is likely to be the release.

Cython-0.15rc1.tar.gz contains tests/imports/cimport_on_import.srctree, which was
absent in Cython-0.15rc0.tar.gz and is absent on https://github.com/cython/cython.
The test from this file fails:

End-to-end cimport_on_import ... /usr/bin/python2.6 setup.py build_ext --inplace
Compiling cy_module.pyx because it changed.
Compiling main.pyx because it changed.

Error compiling Cython file:
------------------------------------------------------------
...

from cy_module import A, B
from py_module import py_object

assert typeof(A) == "type object", typeof(A)
cdef A a = A()
    ^

Re: [Cython] Cython 0.15 release candidate

On Mon, Aug 1, 2011 at 3:04 PM, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta <at> gmail.com> wrote:
> 2011-07-31 09:45:15 Robert Bradshaw napisał(a):
>> On Thu, Jul 21, 2011 at 4:14 PM, Robert Bradshaw
>> <robertwb <at> math.washington.edu> wrote:
>> > Cython has seen an enormous amount of development since 0.14.1. If you
>> > are not already using the latest version from the development
>> > repository, we encourage you to try out the release candidate:
>> > http://cython.org/release/Cython-0.15rc0.tar.gz
>>
>> Thanks for all the feedback. Here's another release candidate:
>> http://cython.org/release/Cython-0.15rc0.tar.gz Unless something major
>> is found, this is likely to be the release.
>
> Cython-0.15rc1.tar.gz contains tests/imports/cimport_on_import.srctree, which was
> absent in Cython-0.15rc0.tar.gz and is absent on https://github.com/cython/cython.
> The test from this file fails:

And this is why I should always make sdists in a clean client...
Thanks for catching this. A clean tarball is up at
http://cython.org/release/Cython-0.15rc2.tar.gz . (I also took a quick
look at what's been pushed since rc1, and they all look like safe
changes worth getting in.)

- Robert
_______________________________________________
cython-devel mailing list
cython-devel <at> python.org
http://mail.python.org/mailman/listinfo/cython-devel

Re: [Cython] OpenMP problem

On Sun, Jul 31, 2011 at 11:48 PM, Stefan Behnel <stefan_ml@...> wrote:
> mark florisson, 31.07.2011 22:08:
>>
>> I pushed it to release, should I rebase master on release now?
>
> Well, so far, the release branch hasn't been used and rc1 was created from
> master. All current changes in master are either considered safe (by me :)
> or just fixes that should go into the release.

I looked at them and I'd say they're both safe and worthy of going in.
In general, if we have a distinct release branch (e.g if anything
really interesting had gone in since the last rc), I'd say we should
push release fixes to that and then merge into master.

> So I think it's best to just
> rebase your single commit in the current release branch back on the master,
> delete the release branch and recreate it from the tip of the master branch.

Yep, I'm seeing it. Thanks.

- Robert

Re: [Cython] Cython 0.15 release candidate

2011/8/2 Robert Bradshaw <robertwb <at> math.washington.edu>:
> On Mon, Aug 1, 2011 at 3:04 PM, Arfrever Frehtes Taifersar Arahesis
> <arfrever.fta <at> gmail.com> wrote:
>> 2011-07-31 09:45:15 Robert Bradshaw napisał(a):
>>> On Thu, Jul 21, 2011 at 4:14 PM, Robert Bradshaw
>>> <robertwb <at> math.washington.edu> wrote:
>>> > Cython has seen an enormous amount of development since 0.14.1. If you
>>> > are not already using the latest version from the development
>>> > repository, we encourage you to try out the release candidate:
>>> > http://cython.org/release/Cython-0.15rc0.tar.gz
>>>
>>> Thanks for all the feedback. Here's another release candidate:
>>> http://cython.org/release/Cython-0.15rc0.tar.gz Unless something major
>>> is found, this is likely to be the release.
>>
>> Cython-0.15rc1.tar.gz contains tests/imports/cimport_on_import.srctree, which was
>> absent in Cython-0.15rc0.tar.gz and is absent on https://github.com/cython/cython.
>> The test from this file fails:
>
> And this is why I should always make sdists in a clean client...
> Thanks for catching this. A clean tarball is up at
> http://cython.org/release/Cython-0.15rc2.tar.gz . (I also took a quick
> look at what's been pushed since rc1, and they all look like safe
> changes worth getting in.)
>

Maybe it's better to use "git archive"?

--

-- 
vitja.

Re: [Cython] OpenMP problem

Robert Bradshaw, 02.08.2011 02:42:
> In general, if we have a distinct release branch (e.g if anything
> really interesting had gone in since the last rc), I'd say we should
> push release fixes to that and then merge into master.

+1

Stefan

Re: [Cython] Cython 0.15 release candidate

On 08/02/2011 07:44 AM, Vitja Makarov wrote:
> 2011/8/2 Robert Bradshaw<robertwb <at> math.washington.edu>:
>> On Mon, Aug 1, 2011 at 3:04 PM, Arfrever Frehtes Taifersar Arahesis
>> <arfrever.fta <at> gmail.com>  wrote:
>>> 2011-07-31 09:45:15 Robert Bradshaw napisał(a):
>>>> On Thu, Jul 21, 2011 at 4:14 PM, Robert Bradshaw
>>>> <robertwb <at> math.washington.edu>  wrote:
>>>>> Cython has seen an enormous amount of development since 0.14.1. If you
>>>>> are not already using the latest version from the development
>>>>> repository, we encourage you to try out the release candidate:
>>>>> http://cython.org/release/Cython-0.15rc0.tar.gz
>>>>
>>>> Thanks for all the feedback. Here's another release candidate:
>>>> http://cython.org/release/Cython-0.15rc0.tar.gz Unless something major
>>>> is found, this is likely to be the release.
>>>
>>> Cython-0.15rc1.tar.gz contains tests/imports/cimport_on_import.srctree, which was
>>> absent in Cython-0.15rc0.tar.gz and is absent on https://github.com/cython/cython.
>>> The test from this file fails:
>>
>> And this is why I should always make sdists in a clean client...
>> Thanks for catching this. A clean tarball is up at
>> http://cython.org/release/Cython-0.15rc2.tar.gz . (I also took a quick
>> look at what's been pushed since rc1, and they all look like safe
>> changes worth getting in.)
>>
>
> Maybe it's better to use "git archive"?
>

Re: [Cython] Cython 0.15 release candidate

Dag Sverre Seljebotn, 02.08.2011 08:28:
> On 08/02/2011 07:44 AM, Vitja Makarov wrote:
>> Maybe it's better to use "git archive"?
>
> If it's only about creating a tarball, then 'git tag' (or, I assume, a
> commit hash) will suffice -- GitHub automatically tarballs for you:
>
> https://github.com/cython/cython/tarball/0.15rc2
>
> However I believe sdist does some more stuff (generates some files before
> tarballing or similar); although as I don't know the specifics I can't tell
> you whether we need to do it for Cython. E.g., for libraries written in
> Cython one could hook sdist to Cythonize to C files; of course, with Cython
> we bootstrap instead so that's not an issue.

It wouldn't be the first time we miss files in the MANIFEST.in of a 
(pre-)release, and yes, it prepares a couple of things for us, so 
especially for release candidates, it's a very good idea to use distutils' 
sdist - obviously from a clean working copy.

BTW, Jenkins builds sdists for us all the time, so as long as it's taken 
from a branch that it builds anyway, you can just grab it from there, e.g.

https://sage.math.washington.edu:8091/hudson/job/cython-devel-sdist/lastSuccessfulBuild/

We also still have the old "cython-release" build jobs that are now picking 
up the new release branch, it seems:

https://sage.math.washington.edu:8091/hudson/view/release/

Re: [Cython] Cython 0.15 release candidate

2011-08-02 00:58:56 Robert Bradshaw napisał(a):
> A clean tarball is up at
> http://cython.org/release/Cython-0.15rc2.tar.gz .

All tests now pass.

-- 
Arfrever Frehtes Taifersar Arahesis

2011-08-02 00:58:56 Robert Bradshaw napisał(a):
> A clean tarball is up at
> http://cython.org/release/Cython-0.15rc2.tar.gz .

All tests now pass.

--

-- 
Arfrever Frehtes Taifersar Arahesis