Ned Deily | 1 Jul 01:11 2011

[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python


Ned Deily <nad <at> acm.org> added the comment:

Victor, I don't understand what your patch is trying to accomplish.  The problem is not that Tkinter isn't
built; the problem is simply at execution time.  Yes, you'll see exactly the same behavior if you are logged
in via ssh and the usename you are running under is not logged in as the main GUI user.  The solution is to not
run Tkinter stuff in that situation.

----------

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue8716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

STINNER Victor | 1 Jul 01:13 2011

[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python


STINNER Victor <victor.stinner <at> haypocalc.com> added the comment:

> Victor, I don't understand what your patch is trying to accomplish.

It skips test_tk and test_ttk_guionly if the DISPLAY environment variable is not set.

----------

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue8716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

Ned Deily | 1 Jul 01:24 2011

[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python


Ned Deily <nad <at> acm.org> added the comment:

> It skips test_tk and test_ttk_guionly if the DISPLAY environment variable is not set.

Whether DISPLAY is set or not isn't relevant.  What's relevant is whether I'm logged in as the GUI user.  In
this example, I'm logging in through ssh using the same user name that is currently logged in as the main GUI user.

   $ ssh xxxx
   $ echo $DISPLAY

   $ /usr/local/bin/python3.2 -m test -u gui test_ttk_guionly
   [1/1] test_ttk_guionly
   1 test OK. 

It's really not worth trying to fix the tests.  The buildbot configuration is incorrect.

----------

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue8716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

STINNER Victor | 1 Jul 01:29 2011

[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python


STINNER Victor <victor.stinner <at> haypocalc.com> added the comment:

 <at> pitrou: How can we fix the configuration of the buildbot?

----------
nosy: +pitrou

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue8716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

Vinay Sajip | 1 Jul 02:16 2011

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3


Changes by Vinay Sajip <vinay_sajip <at> yahoo.co.uk>:

Added file: http://bugs.python.org/file22528/c3ba4f7b5db1.diff

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue12291>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

STINNER Victor | 1 Jul 02:16 2011

[issue8716] test_tk/test_tkk_guionly fails on OS X if run from buildbot slave daemon -- crashes Python


STINNER Victor <victor.stinner <at> haypocalc.com> added the comment:

As discussed on IRC, updated patch skipping test_tk and test_ttk_guionly very early if the gui resource is
not set.

----------
Added file: http://bugs.python.org/file22529/requires_tkinter-2.patch

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue8716>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

Vinay Sajip | 1 Jul 02:35 2011

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3


Vinay Sajip <vinay_sajip <at> yahoo.co.uk> added the comment:

> Antoine Pitrou <pitrou <at> free.fr> added the  comment:

> It's not proscribed, but trying to remove the "self." because  it's
> supposed to be more readable is a bit of a strange thing to do.
> Also,  people reading the test suite should be accustomed to
> "self.assertEqual"  anyway, so there's no point trying to hide it.

It wasn't particularly about self - I'm not against it. Anyway, it's not a big 
deal for me, so I've added the selves back :-)

> Error checking can't  just be probabilistic. Perhaps there's a bug in the
> file-like object; or  perhaps it is a non-blocking IO object and read()
> will return None at  times.

You're right, so I've raised a TypeError if PyBytes_Check fails in r_string.

> Well, it  wouldn't fail any slower if you didn't do it, since you need to
> call read()  very soon anyway (presumably as part of the same call to
> marshal.load()).  Failing "fast" doesn't seem to bring anything here. My
> vote is for removing  the  complication.

Actually I misremembered the complete reason for the call - it was there to 
additionally check that the passed object has a read method. I also realised - 
duh - that I can read zero bytes and still get an empty bytes object back, so 
I've done that, and it does look cleaner. I've also reorganised the marshal_load 
function a little so it flows better.

(Continue reading)

Ram Rachum | 1 Jul 02:44 2011

[issue12449] Add accelerator "F" to button "Finish" in all MSI installers made by bdist_msi


Ram Rachum <cool-rr <at> cool-rr.com> added the comment:

I can only do wxPython, I have no idea how Python's MSI installers work. I did a quick search for "Finish" in
the codebase but could find any obvious place to add the accelerator.

"As a new feature, this cannot go into distutils."

Seriously? Why?

----------

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue12449>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

Vinay Sajip | 1 Jul 03:12 2011

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3


Changes by Vinay Sajip <vinay_sajip <at> yahoo.co.uk>:

Added file: http://bugs.python.org/file22530/9993567039c0.diff

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue12291>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org

Vinay Sajip | 1 Jul 03:17 2011

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3


Vinay Sajip <vinay_sajip <at> yahoo.co.uk> added the comment:

As a result of the changes to marshal.c, test_importlib needs a small change: the test_bad_marshal raises
an EOFError now, whereas it raised ValueError before.

I think it's because the earlier code in marshal didn't properly check for EOF conditions in some places.

So I've changes the assertRaises(ValueError) to assertRaises(EOFError).

All tests now pass, other than test_ftplib (not related).

----------

_______________________________________
Python tracker <report <at> bugs.python.org>
<http://bugs.python.org/issue12291>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/python-python-bugs-list%40m.gmane.org


Gmane