Re: SCC bindings missing AUXPATH support?
Hi Robert,
I reviewed the patch, and I am not sure vsAuxPath should be a
requirement. As I stated earlier, we've gotten the binding to work
acceptably without it and I assume others have as well. Further, some
users may prefer to enter their connection information in to the
perforce dialog on first invocation instead of having to configure the
cmake cache to setup their bindings.
To be clear, I have no objections to adding AuxPath support (not that
my objections count for anything around here). Its that just as it
stands now, if you don't supply it, you won't get any bindings.
Also, you may have better results getting your patch integrated by
opening a defect in cmake's bug tracker and attaching the patch to
that. The preferred patch generation method is also described here:
http://www.mail-archive.com/cmake-wChDC6UyXvPYtjvyW6yDsg <at> public.gmane.org/msg36619.html
By the way, as I stated in an earlier mail, if you wish to pursue this
further, if you change "C:/Code/work/sandbox" to "..\..\.." where that
path points to "C:\Code\work\sandbox" relative to the target being
bound, you should have better results.
Thanks,
Steven
On Mon, Oct 31, 2011 at 8:20 PM, Robert Dailey <rcdailey@...> wrote:
> I forgot to explain why I made the change to begin with. Basically this all
> comes down to Perforce binding support. SccAuxPath is used to specify the
> Perforce connection string. Without this, each project opened will prompt
> the user for the information via modal dialog. This gets very annoying...
> Here is an example of how I have setup each of my projects:
> set_target_properties(
> "${project_name}" PROPERTIES
> VS_SCC_AUXPATH
> "P4SCC#${PERFORCE_SERVER}##${PERFORCE_USER}##${PERFORCE_WORKSPACE}"
> VS_SCC_LOCALPATH "${CMAKE_SOURCE_DIR}"
> VS_SCC_PROJECTNAME "Perforce Project"
> VS_SCC_PROVIDER "MSSCCI:Perforce SCM"
> )
> All of the PERFORCE_ variables are cache variables, so that the user can
> specify their credentials, server, and workspace. These are all formatted
> into the connection string perforce expects.
> The resulting XML in the VCPROJ looks like so:
> SccProjectName="Perforce Project"
> SccLocalPath="C:/Code/work/sandbox"
> SccAuxPath="P4SCC#perforce.mycompany.com:3666##rdailey##rdailey-t510-sandbox"
> SccProvider="MSSCCI:Perforce SCM"
> When I open the generated solution, all projects load perfectly with no
> prompts and everything is binded to source control :)
> ---------
> Robert Dailey
>
>
> On Mon, Oct 31, 2011 at 7:06 PM, Robert Dailey <rcdailey@...> wrote:
>>
>> I fiddled around with TortoiseGit and managed to create the patch. It is
>> attached.
>> Please integrate this into your repository so it is included in version
>> 2.8.7 :)
>>
>> ---------
>> Robert Dailey
>>
>>
>> On Mon, Oct 31, 2011 at 5:41 PM, Robert Dailey <rcdailey@...> wrote:
>>>
>>> I have added source code support for this myself. I updated the following
>>> files:
>>> cmLocalVisualStudio7Generator.cxx
>>> cmLocalVisualStudio10TargetGenerator.cxx
>>> The existing SCC support code was already in these files, I just added
>>> the SccAuxPath support to it.
>>> I'm not an expert at creating patch files outside of TortoiseSVN on
>>> Windows, so could someone explain how to create a patch file for these on
>>> Windows 7? Also how would you like me to deliver the code? I hope to see it
>>> introduced in version 2.8.7
>>> Thanks.
>>>
>>> ---------
>>> Robert Dailey
>>>
>>>
>>> On Mon, Oct 31, 2011 at 4:10 PM, Robert Dailey <rcdailey@...>
>>> wrote:
>>>>
>>>> There are actually 4 SCC related key/value pairs used in VS2003 VCPROJ
>>>> files:
>>>> SccProjectName="SAK"
>>>> SccAuxPath="SAK"
>>>> SccLocalPath="SAK"
>>>> SccProvider="SAK"
>>>> CMake supports these 3 via set_target_properties():
>>>> VS_SCC_LOCALPATH
>>>> VS_SCC_PROJECTNAME
>>>> VS_SCC_PROVIDER
>>>> Apparently one more is needed to support "SccAuxPath":
>>>> VS_SCC_AUXPATH
>>>> Can someone add support for this? Thanks.
>>>>
>>>> ---------
>>>> Robert Dailey
>>>
>>
>
>
> --
>
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
>
--
Powered by www.kitware.com
Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
RSS Feed