Re: [PHP-DEV] New run-tests.php feature

Hi,

On Thu, 2011-09-01 at 13:35 +0200, Hannes Magnusson wrote:
> Throw qa and internals <at>  into the loop to.
> 
> I'd also like to move the XFAIL section (printed out in the end) above
> the FAIL section.
> We have bucketloads of xfailed tests, I actually have to scroll up to
> see the failed tests which is really annoying and silly.

Good thing to do!

johannes

> Anyone have strong opinion on the printout order?
> 
> -Hannes
> 
> 
> ---------- Forwarded message ----------
> From: Hannes Magnusson <bjori <at> php.net>
> Date: Thu, Sep 1, 2011 at 13:32
> Subject: Re: [PHP-CVS] svn: /php/php-src/
> branches/PHP_5_3/run-tests.php branches/PHP_5_4/run-tests.php
> trunk/run-tests.php
> To: Pierre Joye <pierre.php <at> gmail.com>
> Cc: php-cvs <at> lists.php.net
> 
> 
> I did want to use -v at first, but that has a completely different

Re: [PHP-DEV] New run-tests.php feature

2011/9/1 Ferenc Kovacs <tyra3l <at> gmail.com>:
> On Thu, Sep 1, 2011 at 1:35 PM, Hannes Magnusson <bjori <at> php.net> wrote:
>> Throw qa and internals <at>  into the loop to.
>>
>> I'd also like to move the XFAIL section (printed out in the end) above
>> the FAIL section.
>> We have bucketloads of xfailed tests, I actually have to scroll up to
>> see the failed tests which is really annoying and silly.
>>
>> Anyone have strong opinion on the printout order?
>
> yeah, strongly agree

Great addition.
While you're at it, could you also add an option to print a list of
skipped tests (maybe above XFAIL section), that's also currently can't
be done with other options in run-tests.php.
It could also be useful because some skipped tests maybe skipped for
the wrong reason and be actually failed. It's also a great spot to
notice obsolete tests that need to be removed from the suite and make
running all process faster.

-- 
Regards,
Shein Alexey

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] New run-tests.php feature

On Thu, 2011-09-01 at 17:53 +0400, Alexey Shein wrote:
> Great addition.
> While you're at it, could you also add an option to print a list of
> skipped tests (maybe above XFAIL section), that's also currently can't
> be done with other options in run-tests.php.
> It could also be useful because some skipped tests maybe skipped for
> the wrong reason and be actually failed. It's also a great spot to
> notice obsolete tests that need to be removed from the suite and make
> running all process faster.

Let's open a can of worms: When designing this I'd like to keep in mind
a feature I had on the list for the rewrite of run-tests by Zoe (anybody
knows the status of that?) which is skipping entire directories with a
single skipif.
Benefit there is that for instance we don't have to create two PHP
process for each and every test and don't have to try connecting to
databases two times for each test (during skipif and the actual test).

johannes

> -- 
> Regards,
> Shein Alexey
> 

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] New run-tests.php feature

2011/9/1 Johannes Schlüter <johannes <at> schlueters.de>:
> On Thu, 2011-09-01 at 17:53 +0400, Alexey Shein wrote:
>> Great addition.
>> While you're at it, could you also add an option to print a list of
>> skipped tests (maybe above XFAIL section), that's also currently can't
>> be done with other options in run-tests.php.
>> It could also be useful because some skipped tests maybe skipped for
>> the wrong reason and be actually failed. It's also a great spot to
>> notice obsolete tests that need to be removed from the suite and make
>> running all process faster.
>
> Let's open a can of worms: When designing this I'd like to keep in mind
> a feature I had on the list for the rewrite of run-tests by Zoe (anybody
> knows the status of that?) which is skipping entire directories with a
> single skipif.
> Benefit there is that for instance we don't have to create two PHP
> process for each and every test and don't have to try connecting to
> databases two times for each test (during skipif and the actual test).

Create a magical "run-me-first" file which run-tests will execute
first, and if it fails it will skip all the tests in that directory..
should be relatively easy to implement.

Being able to run the tests for two directories in parallel however..
that would be awesome.

-Hannes

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>

Re: [PHP-DEV] New run-tests.php feature

On Thu, 2011-09-01 at 16:17 +0200, Hannes Magnusson wrote:
> Create a magical "run-me-first" file which run-tests will execute
> first, and if it fails it will skip all the tests in that directory..
> should be relatively easy to implement.

See patch at
http://schlueters.de/~johannes/php/run-tests-directory-skip.diff 

This will look for a file called SKIP, which has to be a PHP file, in
each directory while looking for tests. There's at least one bug left:
INI options aren't passed to the SKIP run so shared modules etc. will
not be found. If somebody could extend it accordingly: great. 

> Being able to run the tests for two directories in parallel however..
> that would be awesome.

Ack. While that's a bit more complex as we can't run tests for a native
database and the corresponding PDO driver at the same time, most likely.
So we need some locking mechanism. 

johannes

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] New run-tests.php feature

2011/9/1 Kalle Sommer Nielsen <kalle <at> php.net>:
> Hi
>
> 2011/9/1 Hannes Magnusson <bjori <at> php.net>:
>> Create a magical "run-me-first" file which run-tests will execute
>> first, and if it fails it will skip all the tests in that directory..
>> should be relatively easy to implement.
>>
>> Being able to run the tests for two directories in parallel however..
>> that would be awesome.
>
> I reckon Felipe had a patch for this back in the early 5.3 development
> days, Felipe?
>
>
>
> --
> regards,
>
> Kalle Sommer Nielsen
> kalle <at> php.net
>

Here's the patch: http://felipe.ath.cx/diff/run-tests.diff

-- 
Regards,
Felipe Pena

--

-- 

Re: [PHP-DEV] New run-tests.php feature

On Thu, Sep 1, 2011 at 17:37, Felipe Pena <felipensp <at> gmail.com> wrote:
> 2011/9/1 Kalle Sommer Nielsen <kalle <at> php.net>:
>> Hi
>>
>> 2011/9/1 Hannes Magnusson <bjori <at> php.net>:
>>> Create a magical "run-me-first" file which run-tests will execute
>>> first, and if it fails it will skip all the tests in that directory..
>>> should be relatively easy to implement.
>>>
>>> Being able to run the tests for two directories in parallel however..
>>> that would be awesome.
>>
>> I reckon Felipe had a patch for this back in the early 5.3 development
>> days, Felipe?
>>
>>
>
> Here's the patch: http://felipe.ath.cx/diff/run-tests.diff

Hmh. This patch seems to be similar to johannes' patch, being able to
skip entire directories based on a "configure file".
I don't see a way to execute a check though.
f.e. running the mysql tests won't do you any good unless you have the
environment properly setup, so the skipif section needs to be able to
check if it can connect to a db, and if not then you can skip the
entire folder..

-Hannes

--

-- 

svn: /web/qa/trunk/include/ release-qa.php

johannes                                 Thu, 01 Sep 2011 22:13:01 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=316011

Log:
5.3.9 will be next

Changed paths:
    U   web/qa/trunk/include/release-qa.php

Modified: web/qa/trunk/include/release-qa.php
===================================================================
--- web/qa/trunk/include/release-qa.php	2011-09-01 21:49:22 UTC (rev 316010)
+++ web/qa/trunk/include/release-qa.php	2011-09-01 22:13:01 UTC (rev 316011)
 <at>  <at>  -50,7 +50,7  <at>  <at> 

 $QA_RELEASES = array(

-	'5.3.8' => array(
+	'5.3.9' => array(
 		'active'		=> false,
 		'snaps'			=> array(
 			'prefix'	=> 'php5.3-latest',

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

svn: /web/qa/trunk/include/ release-qa.php

johannes                                 Thu, 01 Sep 2011 22:21:44 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=316012

Log:
- Philip says this has to be active 

Changed paths:
    U   web/qa/trunk/include/release-qa.php

Modified: web/qa/trunk/include/release-qa.php
===================================================================
--- web/qa/trunk/include/release-qa.php	2011-09-01 22:13:01 UTC (rev 316011)
+++ web/qa/trunk/include/release-qa.php	2011-09-01 22:21:44 UTC (rev 316012)
 <at>  <at>  -51,7 +51,7  <at>  <at> 
 $QA_RELEASES = array(

 	'5.3.9' => array(
-		'active'		=> false,
+		'active'		=> true,
 		'snaps'			=> array(
 			'prefix'	=> 'php5.3-latest',
 			'baseurl'	=> 'http://snaps.php.net/',

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

How to have a smooth hairless skin

How to have a smooth hairless skin. 
       Hairless in the bikini zone.
            Click  here:

                   http://www.removehair.tk

--

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php