Template Attribute Language for PHP ()

headers Łukasz Palka | 5 Aug 2009 11:47

_______________________________________________
PHPTAL mailing list
PHPTAL@...
http://lists.motion-twin.com/mailman/listinfo/phptal

On 05-08-2009 at 10:47:49 Łukasz Palka <lukasz.palka2@...> wrote:

> I recently started using PHPTAL and Doctrine. Unfrotunatly I cannot  
> access
> some properties like:
>
> <div tal:repeat="comment post/Comment">
>
> but this works:
>
> <div tal:repeat="comment php:post.Comment">
>
> After deleting "else" from PHPTAL\Context.php, line: 279:
>             // ask __get and discard if it returns null
>             /*else*/ if (method_exists($base,'__get') &&
> is_callable(array($base, '__get')))
>             {
>                 $tmp = $base->$current;
>                 if (NULL !== $tmp){
>                     $base = $tmp;
>                     continue;
>                 }
>             }
>
> it works fine.

This will introduce bugs in code that implements __isset() and __get()  
properly.

> Is this a bug in PHPTAL or maybe Doctrine programmers made something  
> strange
> or...? I am not a pro php programmer, so maybe I am wrong :)

IMHO this is bug in the framework - it implements __isset() which returns  
invalid information.

If __isset() returns false it means that property doesn't exist, PHPTAL  
believes it and won't try to read "non-existent" property.

I suggest changing the framework so that __isset() always returns true for  
all properties that are allowed to be read.

--

-- 
regards, Kornel

>> I recently started using PHPTAL and Doctrine. Unfrotunatly I cannot access
>> some properties like:
>
> This will introduce bugs in code that implements __isset() and __get() properly.

I thought so :-/

Thanks

Hi Łukasz!

I had the same problem as You, but I am using PHPTAL with Kohana 
Framework. There are an ORM models, which are representing tables in 
database, this handles also relationships, for example: I have 
User_Model object in $user, then when I want to get all his comments, i 
use: $user->comments  But in PHPTAL templates "user/comments" doesn't 
work, only "php: user.comments", as in your case.

To handle also ORM relations via PHPTAL templates, I modified 
phptal_path function in PHPTAL/Context.php, I added there just:

if ($base instanceof ORM) {
     $base = $base->$current;
     continue;
}

And now ORM relations works correctly, so in Your case you have to 
enable equivalent of ORM models in Doctrine 

Cheers!
Szymek

Hi,

  I'm at a loss to find a method to disable PHPTAL parsing for a block of
XML/HTML. I am aware that there placing anything in a comment removes it exempts
it from being parsed, but I have not found another method.

What I'm wanting to do is as follows:

<div tal:no-parse="true">
${abc}
</div>

Am I totally missing this?

Thanks!
Richard Cernava

_______________________________________________
PHPTAL mailing list
PHPTAL@...
http://lists.motion-twin.com/mailman/listinfo/phptal

Ionut Matei <johnutzm <at> ...> writes:

> 
> 
> If a template contains php code, it gets into the compiled template and will
be executed...I think a pre-filter can be created for stripping php code, but Is
there a feature or setting in PHPTAL for preventing executing php code placed
inside php tags (e.g. like $php_handling in smarty)?thanks.
> 

Hi,

  My solution was to do modify the XML parser to add this support.

In XmlParser.php

1. Disable ST_PREPROC
  comment out $builder->onProcessingInstruction(substr($src, $mark, $i-$mark+1));

2. remove any language attribute with the value of php in a script tag
                case self::ST_ATTR_QUOTE:
                    if ($c === $quoteStyle) {
			$value = $this->sanitizeEscapedText(substr($src, $mark, $i-$mark));
			if (!(strtolower($tagname) == 'script' && strtolower($attribute) ==
'language' && strtolower($value) == 'php'))
                        	$attributes[$attribute] = $value;

3. Filter CDATA and comments through a remove php functions
$builder->onCDATASection($this->removePHP(substr($src, $mark, $i-$mark-2)));
$builder->onComment($this->removePHP(substr($src, $mark, $i-$mark+1)));

    private function removePHP($source)
    {
		if (preg_match_all('/(<\?(php|=)?|\?>|language\s*=\s*["\']?php["\']?)/is',
$source, $matches)) {
			$matches[1] = array_unique($matches[1]);

			foreach ($matches[1] as $key => $value) {
				$source = str_replace($value, '', $source);
			}
		}
		return $source;
    }

The other way to handle the comment and CDATA would be to encapsulate them in a
php echo statement:

<?echo <<<NOPHPALLOWED
...CDATA OR COMMENTS...
NOPHPALLOWED;
?>

Or you could add a pre-filter like so:

class removePHP implements PHPTAL_Filter {
	public function filter($source){
		if (preg_match_all('/(<\?(php|=)?|\?>|language\s*=\s*["\']?php["\']?)/is',
$source, $matches)) {
			$matches[1] = array_unique($matches[1]);

			foreach ($matches[1] as $key => $value) {
				$source = str_replace($value, '', $source);
			}
		}
        	return $source;
	}
}

Richard Cernava <cernava <at> ...> writes:

Oh yeah, you do have to filter the attribute values as well because the are
allowed to have php in them.

On 06-08-2009 at 22:53:22 Ionut Matei <johnutzm@...> wrote:

> If a template contains php code, it gets into the compiled template and  
> will be executed...
>
> I think a pre-filter can be created for stripping php code, but Is there  
> a feature or setting in PHPTAL for preventing executing php code placed  
> inside php tags (e.g. like
> *$php_handling*<http://www.smarty.net/manual/en/variable.php.handling.php>in
> smarty)?

Currently there isn't such option. PHPTAL has been designed with  
assumption that template authors can be trusted.

With few small changes you can disable <?php ?> blocks in templates and  
php: prefix, but I cannot guarantee that there are no other ways to  
execute arbitrary PHP in PHPTAL.

--

-- 
regards, Kornel

On 06-08-2009 at 18:48:46 Richard Cernava <cernava@...> wrote:

>   I'm at a loss to find a method to disable PHPTAL parsing for a block of
> XML/HTML. I am aware that there placing anything in a comment removes it  
> exempts
> it from being parsed, but I have not found another method.
>
> What I'm wanting to do is as follows:
>
> <div tal:no-parse="true">
> ${abc}
> </div>
>
> Am I totally missing this?

I'm not sure what exactly do you want.

If you want to output ${abc} literally on the page, then write $${abc}.  
There's no attribute for this.

If you want to hide content of an element, then <div tal:replace=""> will  
work (and if you wrap content in <![CDATA[ ]]>, you won't need to worry  
about closing tags, etc. inside the element).

--

-- 
regards, Kornel

Mon	Tue	Wed	Thu	Fri	Sat	Sun

					1	2
3	4	5	6	7	8	9
10	11	12	13	14	15	16
17	18	19	20	21	22	23
24	25	26	27	28	29	30
31

4	June 2013
4	May 2013
2	January 2013
1	December 2012
2	October 2012
3	September 2012
14	August 2012
13	June 2012
22	May 2012
15	April 2012
12	March 2012
3	February 2012
2	December 2011
18	November 2011
9	October 2011
9	September 2011
23	August 2011
59	July 2011
44	June 2011
24	May 2011
12	April 2011
5	March 2011
11	February 2011
14	January 2011
8	December 2010
50	November 2010
40	October 2010
37	September 2010
30	August 2010
17	July 2010
39	June 2010
17	May 2010
12	April 2010
29	March 2010
8	February 2010
28	January 2010
69	December 2009
46	November 2009
45	October 2009
77	September 2009
76	August 2009
28	July 2009
82	June 2009
50	May 2009
55	April 2009
45	March 2009
53	February 2009
106	January 2009
24	December 2008
72	November 2008
58	October 2008
28	September 2008
36	August 2008
14	July 2008
18	June 2008
68	May 2008
56	April 2008
30	March 2008
24	February 2008
47	January 2008
7	December 2007
21	November 2007
4	October 2007
2	September 2007
1	August 2007

Accessing properties

Re: Accessing properties

Re: Accessing properties

Re: Accessing properties

disabling PHPTal parsing for blocks

Fwd: stripping or escaping php code in templates

Re: Fwd: stripping or escaping php code in templates

Re: Fwd: stripping or escaping php code in templates

Re: Fwd: stripping or escaping php code in templates

Re: disabling PHPTal parsing for blocks