Development discussion about phpMyAdmin, a tool to handle the administration of MySQL over the WWW

Willian Gustavo Veiga | 1 May 2012 02:37

Re: Coding style checks

I would like to help in this task. How should I run phpcs to get these 
warnings?
Thank you very much.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

headers

Rouslan Placella | 1 May 2012 11:32

Re: Coding style checks

Hi Willian,

You don't need to run phpcs yourself, we have a continuous integration  
server that runs it every 10 minutes provided that there are new  
commits on master. Just select "checkstyle warnings" in the left menu  
on this page: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/

Bye,
Rouslan

Quoting Willian Gustavo Veiga <wiltave <at> gmail.com>:

> I would like to help in this task. How should I run phpcs to get these
> warnings?
> Thank you very much.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

headers

Madhura Jayaratne | 1 May 2012 17:13

Re: Coding style checks

On Tue, May 1, 2012 at 3:02 PM, Rouslan Placella <rouslan <at> placella.com> wrote:

Hi Willian,

You don't need to run phpcs yourself, we have a continuous integration
server that runs it every 10 minutes provided that there are new
commits on master. Just select "checkstyle warnings" in the left menu
on this page: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/

Bye,
Rouslan

If you are using Eclipse or NetBeans as the IDE, you can install CodeSniffer plugin and identify violations. Here are two tutorials on how to install and configure the plugins [1], [2]. But be aware that we use slightly modified version of the standards as mentioned in this mail thread.

I think this is a good way to ensure coding style compliance for GSoC projects. This would make it possible to identify violations while coding rather than waiting to see the code get merged and violations being reflected on the Jenkins server page.

[1] http://www.websitefactors.co.uk/php/2011/10/installing-php-codesniffer-properly-in-eclipse/

[2] http://www.amaxus.com/cms-blog/coding-standards-netbeans-php-codesniffer

--
Thanks and Regards,

Madhura Jayaratne

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

headers

Willian Gustavo Veiga | 1 May 2012 19:11

Re: Coding style checks

>  Hi Willian,

>  You don't need to run phpcs yourself, we have a continuous integration
>  server that runs it every 10 minutes provided that there are new
>  commits on master. Just select "checkstyle warnings" in the left menu
>  on this page:http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/

>  Bye,
>  Rouslan

Hi Rouslan,
But how should i test my changes in localhost before a pull request ?
Are there any way?
Thank you very much.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

headers

Marc Delisle | 1 May 2012 19:27

Re: Coding style checks

Le 2012-05-01 13:11, Willian Gustavo Veiga a écrit :
>>  Hi Willian,
> 
>>  You don't need to run phpcs yourself, we have a continuous integration
>>  server that runs it every 10 minutes provided that there are new
>>  commits on master. Just select "checkstyle warnings" in the left menu
>>  on this page:http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/
> 
>>  Bye,
>>  Rouslan
> 
> Hi Rouslan,
> But how should i test my changes in localhost before a pull request ?
> Are there any way?
> Thank you very much.

Willian,
I am not familiar with PHP_CodeSniffer but maybe this link [0] can help.
See also, in phpMyAdmin source, the PMAStandard directory.

[0] http://pear.php.net/manual/en/package.php.php-codesniffer.php

--

-- 
Marc Delisle
http://infomarc.info

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

headers

Michal Čihař | 2 May 2012 11:17

Re: Coding style checks

Hi

Dne Tue, 01 May 2012 14:11:55 -0300
Willian Gustavo Veiga <wiltave <at> gmail.com> napsal(a):

> >  Hi Willian,
> 
> >  You don't need to run phpcs yourself, we have a continuous integration
> >  server that runs it every 10 minutes provided that there are new
> >  commits on master. Just select "checkstyle warnings" in the left menu
> >  on this page:http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/
> 
> >  Bye,
> >  Rouslan
> 
> Hi Rouslan,
> But how should i test my changes in localhost before a pull request ?
> Are there any way?

Sure there is . Once you install PHP CodeSniffer you can run it with
our customized standard in phpMyAdmin's directory:

phpcs --standard=PMAStandard file.php

--

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

headers

Michal Čihař | 2 May 2012 11:18

Re: GSoC student repositories and branching

Hi

Dne Sat, 28 Apr 2012 15:49:19 +0530
Atul Pratap Singh <atulpratapsingh05 <at> gmail.com> napsal(a):

> Thanks for clearing up my doubt related to using separate branch. As my
> GSoC project includes refactoring, I would prefer to use the master branch
> only. I have updated my Git repo information on the wiki page [0]. Please
> update my demo server [1] to point to the new repository.

Done.

--

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

headers

Michal Čihař | 2 May 2012 11:29

Re: Checkstyle warning for <at> subpackage

Hi

Dne Sun, 29 Apr 2012 03:19:01 +0200
"J.M." <me <at> mynetx.net> napsal(a):

> File comments for  <at> subpackage should not trigger as 'unknown tag/wrong
> indentation'.
> 
> Issue like this:
> http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1346/checkstyleResult/HIGH/file.752771460/

Well it's how PEAR coding standards do it.

This is wrong:

 *  <at> package PhpMyAdmin
 *  <at> subpackage Example

This is correct:

 *  <at> package    PhpMyAdmin
 *  <at> subpackage Example

Fixed all occurrences in git.

--

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

headers

Michal Čihař | 2 May 2012 11:32

Re: Automated Testing - GSoC 2012

Hi

Dne Sun, 29 Apr 2012 07:58:28 +0530
yasitha pandithawatta <yasitha4 <at> gmail.com> napsal(a):

> In the community bonding period I would like to sort out the issues I face
> when I install the Jenkins server. I refer to this tutorial [0] for
> installation. Once I installed the Jenkins server I couldn't restart
> the Apache server. So I re-installed Apache. Can you suggest any manual
> installing instruction or a tutorial that can I use and get familiar with
> Jenkins.

We have also own tutorial for setting up Jenkins (I've done it on
Debian, so it should not be that different):

http://wiki.phpmyadmin.net/pma/Jenkins_Setup

--

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

headers

Thilina Buddika Abeyrathna | 2 May 2012 15:09

Git repo update

Hi Marc,
I used following command to update my git repo in GitHub.

git remote add upstream git://github.com/thilinaa/phpmyadmin.git
git fetch upstream

But it did not work for my repo. Please give me some suggestions.

--
Regards.

Thilina Buddika Abeyrathna,
Department of Computer Engineering,
Faculty Of Engineering,
University of Peradeniya,

Sri Lanka.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

150	May 2013
205	April 2013
71	March 2013
145	February 2013
181	January 2013
100	December 2012
84	November 2012
40	October 2012
51	September 2012
111	August 2012
206	July 2012
166	June 2012
252	May 2012
271	April 2012
267	March 2012
119	February 2012
65	January 2012
55	December 2011
68	November 2011
106	October 2011
34	September 2011
361	August 2011
413	July 2011
491	June 2011
384	May 2011
166	April 2011
358	March 2011
184	February 2011
115	January 2011
87	December 2010
29	November 2010
25	October 2010
53	September 2010
111	August 2010
232	July 2010
81	June 2010
85	May 2010
269	April 2010
514	March 2010
49	February 2010
24	January 2010
22	December 2009
24	November 2009
10	October 2009
13	September 2009
67	August 2009
205	July 2009
90	June 2009
34	May 2009
23	April 2009
17	March 2009
14	February 2009
2	January 2009
25	December 2008
25	November 2008
16	October 2008
34	September 2008
10	August 2008
22	July 2008
71	June 2008
25	May 2008
27	April 2008
38	March 2008
11	February 2008
43	January 2008
34	December 2007
17	November 2007
86	October 2007
28	September 2007
15	August 2007
40	July 2007
41	June 2007
49	May 2007
38	April 2007
89	March 2007
121	February 2007
41	January 2007
45	December 2006
52	November 2006
141	October 2006
61	September 2006
254	August 2006
85	July 2006
43	June 2006
67	May 2006
105	April 2006
62	March 2006
85	February 2006
111	January 2006
139	December 2005
186	November 2005
160	October 2005
104	September 2005
11	August 2005
25	July 2005
27	June 2005
4	May 2005
19	April 2005
30	March 2005
27	February 2005
41	January 2005
21	December 2004
39	November 2004
59	October 2004
49	September 2004
26	August 2004
15	July 2004
72	June 2004
63	May 2004
141	April 2004
7	March 2004
18	February 2004
19	January 2004
30	December 2003
35	November 2003
35	October 2003
53	September 2003
44	August 2003
66	July 2003
95	June 2003
99	May 2003
55	April 2003
149	March 2003
193	February 2003
77	January 2003
27	December 2002
27	November 2002
85	October 2002
44	September 2002
131	August 2002

Mon	Tue	Wed	Thu	Fri	Sat	Sun

	1	2	3	4	5	6
7	8	9	10	11	12	13
14	15	16	17	18	19	20
21	22	23	24	25	26	27
28	29	30	31