michal | 23 May 14:36
Favicon
Gravatar

Build failed in Jenkins: phpMyAdmin-continuous #1493

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1493/changes>

Changes:

[weblate] Translated using Weblate.

[mcihar] Wrap some long lines

[mcihar] Calcualte include path only once

[mcihar] Calculate function name only once

------------------------------------------
Started by an SCM change
Started by an SCM change
Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel <at> 1494a05c
Using strategy: Default
Last Built Revision: Revision def75ac09f904b1f796dbdb1569b5825be8d0fd7 (origin/master)
Fetching changes from 1 remote Git repository
Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git
Commencing build of Revision d54c77b613888f101cc680bb1f03cb8434194937 (origin/master)
Checking out Revision d54c77b613888f101cc680bb1f03cb8434194937 (origin/master)
[workspace] $ /bin/sh -xe /tmp/hudson3321461921807073330.sh
+ ./scripts/generate-mo --quiet
[workspace] $ ant clean phpunit phpcpd phpcs phploc
Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar
Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>

clean:
(Continue reading)

Michal Čihař | 21 May 15:09
Favicon
Gravatar

GSoC Git repos

Hi all (especially students)

I've made some clarifications to GSoC student guide about git
repositories [1].

To make it short: We want to merge your code as soon as possible.

So try to keep your repository in good shape all the time and whenever
you've completed some bigger part, just file a pull request on Github
or tell your mentor to merge your changes.

[1]:http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_repository

--

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Alex Marin | 21 May 13:50
Picon
Gravatar

GSoC: github tree

Hello,

I have a question regarding [1]. In our tree, should we only add
our own commits regarding the GSoC project we are assigned?
The problem I see here is that there are chances that the files
we modify in our tree will also be modified in PMA/master,
so merge conflicts will appear that will have to be solved at
the final merge at the end of GSoC. And also, the local tree
will be a little out of date.

The alternative would be to merge [2] continuously to our tree
and mix our commits with the ones from the PMA master branch,
but then again if someone modifies a file you committed changes
to, you have to locally solve conflicts or rebase your commit.
Will the final merge be safe in this case?

Or is there no such thing as a final merge, and our good commits
will be merged to PMA/master periodically? I can imagine that
would be more difficult in some cases where some functionalities
can't be partially merged if they are more complex.

[1] http://wiki.phpmyadmin.net/pma/GSoC_2012_Student_Guide#Publish_a_Git_repository
[2] https://github.com/phpmyadmin/phpmyadmin/commits/master

Thanks,
Alex

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
(Continue reading)

Picon

Automated Testing - GSoC 2012

Hi Michal,


I had my semester exams for last two weeks. Today onward I can give priority to my GSoC project. 
I'll start writing the test cases for mail libraries. Any re-factored classes committed to the master branch? If so I can straight away start writing the test cases for those classes.  

Regards,
--
Yasitha Pandithawatta 
Undergraduate
Computer Science and Engineering Department
University of Moratuwa
Sri Lanka

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Atul Pratap Singh | 16 May 11:21
Picon
Gravatar

Table zoom search option is broken

Hi Madhura,

The Table zoom search option is broken after function name fixes done in the commit 60f84a045ec53be94c4cb837d8f70ad210990f7a.
Please fix the function names in tbl_zoom_select.php (line 178).

Regards
--
Atul Pratap Singh
Senior Undergraduate Student
Institute Of Technology,
Banaras Hindu University, Varanasi,
India.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Marc Delisle | 15 May 12:53
Gravatar

refactoring insert/edit: BLOB upload

Thilina,

I made an insert test with a table that contains a BLOB; the maximum
size for the upload is not displayed.

--

-- 
Marc Delisle
http://infomarc.info

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
Michal Čihař | 14 May 13:58
Favicon
Gravatar

Duplicate code in CSS themes

Hi all

I think it is pretty obvious that all themes will share quite big load
of CSS. Originally I though about extracting these bits to Theme class
methods, but now I think it would make things even harder to maintain.

What I feel would be better to create core CSS file, which would be
always included and theme authors will just override/extend it.

This way, we can make changes in core without breaking older themes too
much - maybe some things will not look 100% intergrated, but at least
the layout won't be broken.

Currently original and pmahomme themes share about 2500 lines, they
differ in 1000/500 (pmahomme/original) lines.

--

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Picon
Gravatar

Refactoring insert-edit

Hi Marc,

when I'm writing functions for columns of insertForm I need to pass all the following parameters to the functions.
$field, $backup_field, $field_name_appendix, $unnullify_trigger, $tabindex, $tabindex_for_value, $idindex, $data
So function signature is very long which is somewhat ugly, Is it ok to have a global parameter array for insert_edit.lib.php file. Does this break the refactoring?

--
Regards.

Thilina Buddika Abeyrathna,
Department of Computer Engineering,
Faculty Of Engineering,
University of Peradeniya,
Sri Lanka.


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Tyron Madlener | 12 May 15:22
Picon

Can't log in to pma?

After a update on my server I can't seem to log in to phpMyAdmin. Whatever user or pass I type in, it just reloads the page without showing any errors.


It seems as if the session is not being saved, because I can see a new token being generated every time. Anyone had a similar problem like this?
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Chanaka Dharmarathna | 12 May 06:51
Picon

Naming convention standard for methods

Hi All,

While I'm refactoring some files relating to display query results (currently display_tbl.lib.php, common.lib.php), I can method names are used regardless of the inside functionality.

Ex :- "PMA_displayHtmlRadio" in common.lib.php method return a string of HTML content.
But the name tells the function displays HTML itself.
As I feel these things should be modified.

As library files, they never should render HTML inside the functions themselves.
Better thing is to return a string of PHP having the HTML content.

So my suggestion is to use the phrase "get" for the every method which return any data type.
So that developer can understand it returns something just looking at the name.
Following are some suggested names. (Some of them are already discussed in this mailing list)

Ex:
PMA_displayHtmlRadio -> PMA_getRadioFields
PMA_generateSliderEffect -> PMA_getDivForSliderEffect
PMA_generateHtmlDropdown -> PMA_getDropdown
PMA_displayTableNavigationButton -> getTableNavigationButton
(All above functions return strings)

Hope to join a discussion on this.

Regards !
--
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Marc Delisle | 9 May 14:13
Gravatar

refactoring insert/edit

Thilina,
with commit 1d7f48b966c66b06f9a9ef6e5c78178d645d4bdf I still see this
problem:

1. Browse a table
2. Click the checkbox for two rows
3. At the botton, click the With selected...change link

--

-- 
Marc Delisle
http://infomarc.info

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Gmane