Mohamed Ashraf | 19 Jun 2013 21:17
Picon
Gravatar

collecting info for error report

When an error report happens now I collect certain relevant info about
the error and current phpmyadmin configuration.

I currently collect error message, line number, file_name, stacktrace
if available, phpmyadmin version, user browser name and version, user
os and steps for reproduction by the user.

do you think any other thing is relevant to the report. I can easily
add any more info if required I just cant seem to find what is
important for debugging. I thought I would ask you since you have a
lot of experience debugging problems in phpmyadmin

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
Mohamed Ashraf | 19 Jun 2013 21:05
Picon
Gravatar

surrounding functions by try and catch

Using window.onerror I don't have access to the stacktrace. to get the
stacktrace I need to surround code by try and catch.

I may be able to use javascript to change all references to global
functions and surround them by try and catch statements. surrounding
each and every global function in the window namespace would probably
create a performance hit. however doing the same for only a subset of
functions may be easier. I may for example surround only functions
that start with PMA_ and the functions in the AJAX object.

According to this test [0] the performance hit is not that great so it
may not hurt to add try and catch to all methods but I don't like to
play with code that I donot own since it may cause problems that I may
not be able to understand.

What I am trying to ask is should I surround only PMA_ and AJAX
functions or should I add some extra functions (such as jquery
functions) to the list or should I skip this entirely and rely only on
line number and file name from the window.onerror

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
Mohamed Ashraf | 19 Jun 2013 20:46
Picon
Gravatar

redirect after js error caught

Since I catch uncaught exceptions there is a chance that the page
would be unusable. should I refresh the page or redirect to the
homepage or should I just leave it as is.

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
michal | 19 Jun 2013 09:17
Favicon
Gravatar

Build failed in Jenkins: phpMyAdmin-continuous #3649

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3649/changes>

Changes:

[madhura.cj] Fix indentation

[weblate] Translated using Weblate (Traditional Chinese)

------------------------------------------
Started by GitHub push by madhuracj
Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel <at> 5143f787
Using strategy: Default
Last Built Revision: Revision 09e2cc1f0121140dfe410e63dbe037c4ce2d35f4 (origin/master)
Fetching changes from 1 remote Git repository
Fetching upstream changes from origin
Commencing build of Revision 5ce7afdca41758bf43c1b215b41a5de6e88c98f5 (origin/master)
Checking out Revision 5ce7afdca41758bf43c1b215b41a5de6e88c98f5 (origin/master)
[workspace] $ /bin/sh -xe /tmp/hudson9036036752168794028.sh
+ ./scripts/generate-mo --quiet
po/zh_TW.po:10937: a format specification for argument 2, as in 'msgstr[0]', doesn't exist in 'msgid_plural'
po/zh_TW.po:10946: a format specification for argument 2, as in 'msgstr[0]', doesn't exist in 'msgid_plural'
msgfmt: found 2 fatal errors
Build step 'Execute shell' marked build as failure
[CHECKSTYLE] Skipping publisher since build result is FAILURE
[DRY] Collecting duplicate code analysis files...
[DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml
[DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
[DRY] Successfully parsed file
<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module 
(Continue reading)

Mohamed Ashraf | 18 Jun 2013 15:22
Picon
Gravatar

error report form mockup

I have attached some screenshots [0] of the current implementation of the
error report dialog. when an error occurs a small notification appears
at the bottom asking the user if he wants to submit an error report.
if he does the modal dialog is opened showing him the info that would
be sent and asking him for any additional info he might have.

what do you think?

[0] http://imgur.com/a/IJ7iW/all

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
Marc Delisle | 18 Jun 2013 14:55
Gravatar

Improving the navigation bar in 4.1

Hi,
The navigation bar permits to navigate within a results set; it contains 
the page number selector, the begin/previous/next/end arrows, etc.

Reading [0], I noticed that there is much room for improvement. Based on 
this feature request, here are my recommendations:

1. Remove the "Headers every __ rows" dialog; it's too prominent, is not 
often changed and is configurable via normal config and user prefs

2. Change the default number of rows from 30 to 25 (related to the next 
suggestion)

3. Replace the input field in "Number of rows" with a dropdown 
containing preset values 25/50/100/250/500. Selecting a value would 
immediately have an effect. I never felt the need to display, say, 37 
rows in a page. This flexibility harms usability.

4. Remove the "Show" button and the Start row dialog. I rarely have to 
change the starting row value. Arrows and page selectors are sufficient 
to navigate (not mentionning Search).

Comments are more than welcome.

[0] https://sourceforge.net/p/phpmyadmin/feature-requests/1434/

--

-- 
Marc Delisle
http://infomarc.info

(Continue reading)

Ayush Chaudhary | 18 Jun 2013 10:34
Picon
Gravatar

Overriding functions

Hi, 

I was writing some unit tests for the native string functions. However, since some of the functions are declared twice (with different implementations), for e.g., PMA_strlen, PMA_strpos, etc. have different implementations in string_mb.lib.php and string_native.lib.php, it causes phpunit to throw fatal errors of the form "Cannot redeclare function … already declared in …"

Possible solutions could be to use namespaces or to use polymorphism in some way.

Please advice.

Thanks.

-- 
Ayush Chaudhary

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Supun Nakandala | 18 Jun 2013 05:51
Picon
Gravatar

Identifying a call to a stored procedure

Hi devs,
 I am refactoring sql.php and I realized in line 389 of file the check for a call to a stored procedure is done by using regexp. I would like to know is it ok to keep it like that or is there any better approach to handle that.

Regards Supun.
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Mohamed Ashraf | 17 Jun 2013 19:39
Picon
Gravatar

javascript caching

The javascript files seem to be cached pretty aggressively in my
phpmyadmin. I have to clear the cache on each code change so that it
is reflected. Is there some setting in phpmyadmin to help me with the
cache problem or is the problem with my server configuration

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
Marc Delisle | 17 Jun 2013 18:36
Gravatar

phpMyAdmin 4.0.4 is released

Welcome to phpMyAdmin 4.0.4, a bugfix version.

Details will appear on http://phpmyadmin.net. In a hurry? you can visit
https://sourceforge.net/projects/phpmyadmin/files to download.

Marc Delisle, for the team

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
Mohamed Ashraf | 16 Jun 2013 21:45
Picon
Gravatar

not uglifying js for production

Uglifying js code would prevent any meaningful reports from reaching
us in the error reporting system since all function and variable names
are useless and all the scripts are inlined. I am suggesting that we
refrain from uglifing js code in production. Since bandwidth is now
sufficiently large to handle pretty js code in production. It would
give us access to a wealth of info to help us diagnose and reproduce
error reports that may not be feasible with ugly js scripts.

what do you think?

------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev

Gmane