headers
adrian15 | 1 Dec 16:22
Picon
Gravatar

Re: 2.10.10 initial patches for svn revision 1703

Michiel Dethmers escribió:

> I won't reply to all your other emails, but if you can organise them in 
> mantis, and then send the issues by email, that would be great.

There are three emails which I think you can answer here because they 
are not designed to be handled by mantis.

* second subscribe appear when re subscribing patch	doubt
* unsubscribe reason still asked when disabled bug svn	status?
* attributes order on subscribe cannot be saved bug svn	status?

Thank you very much!

adrian15
--

-- 
Support free software. Donate to Super Grub Disk. Apoya el software 
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/index.php?pid=10
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 0 comments |
headers
Tim Holliefield | 2 Dec 14:58

phplist rewrite started?

Hi list,

While looking over the list archives I saw a thread from August 2009 
discussing a rewrite of phplist. Did anything actually happen as a 
result of that thread? There have been no further messages on the topic 
on this list and what seems to be a low level of activity in svn. Am I 
not looking in the correct location, or has there really been no further 
work done on a rewrite?

--

-- 
Tim Holliefield
System Administrator
Information Technology
UMUC Europe
+49(0)6221-378281
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 3 comments |
headers
Jaime Gómez Obregón | 3 Dec 09:55

Re: phplist rewrite started?

Tim Holliefield escribió:
> While looking over the list archives I saw a thread from August 2009 
> discussing a rewrite of phplist. Did anything actually happen as a 
> result of that thread? There have been no further messages on the topic 
> on this list and what seems to be a low level of activity in svn. Am I 
> not looking in the correct location, or has there really been no further 
> work done on a rewrite?

I started a rewrite and cleaned and simplified lots of code in the 
frontend part. After some days I posted my progress, including a demo:

http://mail.tincan.co.uk/pipermail/phplist-developers/2009-August/000072.html

Sadly, nobody replied nor gave feedback nor showed interest in the 
effort, so I didn't go on.

--

-- 
Jaime GÓMEZ OBREGÓN
jaime <at> iteisa.com
ITEISA
http://www.iteisa.com
+34 902055277
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 2 comments |
headers
Tim Holliefield | 3 Dec 11:57

Re: phplist rewrite started?

Jaime Gómez Obregón wrote:
> Tim Holliefield escribió:
>> While looking over the list archives I saw a thread from August 2009 
>> discussing a rewrite of phplist. Did anything actually happen as a 
> 
> I started a rewrite and cleaned and simplified lots of code in the 
> frontend part. After some days I posted my progress, including a demo:
> 
> http://mail.tincan.co.uk/pipermail/phplist-developers/2009-August/000072.html 
> 
> 
> Sadly, nobody replied nor gave feedback nor showed interest in the 
> effort, so I didn't go on.

I looked at your demo and found it interesting but didn't do any 
extensive testing, just clicked around a bit to see how things looked 
compared to the demo at http://demo.phplist.com/lists/admin. The revised 
menu structure does seem to simplify the overall appearance.

My interest is more in the backend part, specifically the database. We 
are an Oracle shop and even with adodb there appears to be a lot of 
MySql-specific code that seems to prevent Oracle (and any other 
database?) from being used with PHPList. The 2.10.10 release seems 
hopeless but the version from svn trunk includes a function to 
encapsulate the MySql REPLACE INTO statement so I haven't given up yet.

If anyone has further suggestions, or code that works with Oracle, I 
would be happy to receive them. Likewise, if my efforts are successful I 
would be happy to share the result.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michiel Dethmers | 3 Dec 12:45
Picon
Favicon

Re: phplist rewrite started?


I remember your posting and I think it was very interesting, but I think 
it was just before the discussion on the rewrite. I've been too busy to 
be able to give it much attention, but recently I've been able to free a 
bit more time for phpList.

First of all there's the recoding of some of the html output of phpList. 
It's very old and clunky and can do with a good make-over. Any of that 
should be done on the svn trunk. I don't want to mess around with the 
2.10 branch too much, as it's important to be able to respond to 
security issues quickly.

But then there's the idea of a "from the ground up" recoding. There was 
a lot of enthousiasm to work on that, but it will require someone to 
plan and manage the group and by default this falls back to me, and at 
the moment I don't have time for that. But it's still on the agenda. I 
think it's more a plan for the years to come. Let's make sure to plan it 
more thoroughly and avoid duplicating efforts. As it stands, there 
should be two routes that can be taken simultaneously, one to rewrite 
some of the existing code and the other one to rewrite it from the 
ground up. For now, let's concentrate on the former whilst keeping an 
eye on the latter. The rewrite will require loads more discussion before 
a single line of code is written. If you read back in the archives, 
there were some conflicting points of view, which I think require more 
attention. I'd be very happy if the rewrite would become more of a team 
effort than the current code is.

If you have code contributions, particularly on cosmetic changes, then 
they're very welcome. Best is to code them against the trunk and to send 
patches, just like adrian15 has been doing. That makes it easier to
(Continue reading)

Permalink | Reply | 0 comments |
headers
Alberto Granzotto | 9 Dec 16:26
Picon

ver. 2.10.10 - error handling in processqueue.php

PHPList version: 2.10.10
PHP version: 5
Hosting: tophost.it

I had a problem sending a message, after pressing "Process Queue" I had
a lot of "MySQL server has gone away" errors.
  I have took a look to [b]processqueue.php[/b], the common pattern in
errors handling is:
  $userids = Sql_query($query);
  if (Sql_Has_Error($database_connection)) {
ProcessError(Sql_Error($database_connection)); }

  More or less:
 * do the query;
 * if some error happens, do ProcessError (which [b]exits[/b] from the
script).

  Sql_Has_Error w/ ProcessError are not used -- as far as I can see, and
only in the "sending loop" -- in those lines:

528: $userids = Sql_Query(sprintf('select * from %s where id =
0',$tables["user"]));

559: $um = Sql_query("select entered from {$tables['usermessage']} where
userid = $userdata[0] and messageid = $messageid");

564: $users = Sql_query("select
id,email,uniqid,htmlemail,rssfrequency,confirmed,blacklisted from
{$tables['user']} where id = $userid");
(Continue reading)

Permalink | Reply | 4 comments |
headers
Tim Holliefield | 9 Dec 17:37

Re: ver. 2.10.10 - error handling in processqueue.php

Alberto Granzotto wrote:
> 
> P.S.: sometimes the function Sql_affected_rows() is used, other times
> Sql_Affected_Rows() (with different "case"), why?

I think Sql_affected_rows() is an error because no function with that 
case is defined.

--

-- 
Tim Holliefield
System Administrator
Information Technology
UMUC Europe
+49(0)6221-378281
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 2 comments |
headers
Michiel Dethmers | 9 Dec 17:48
Picon
Favicon

Re: ver. 2.10.10 - error handling in processqueue.php


http://php.net/manual/en/functions.user-defined.php

Note:  Function names are case-insensitive

On 12/09/2009 01:37 PM, Tim Holliefield wrote:
> Alberto Granzotto wrote:
>>
>> P.S.: sometimes the function Sql_affected_rows() is used, other times
>> Sql_Affected_Rows() (with different "case"), why?
>
> I think Sql_affected_rows() is an error because no function with that
> case is defined.
>
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 1 comment |
headers
Tim Holliefield | 9 Dec 18:23

Re: ver. 2.10.10 - error handling in processqueue.php

/me turns red in the face
Shall I get off the dev mailing list now? :-)

Apparently, variable names are case-sensitive and I assumed that applied 
to function names too.

Michiel Dethmers wrote:
> http://php.net/manual/en/functions.user-defined.php
> 
> Note:  Function names are case-insensitive
> 
> On 12/09/2009 01:37 PM, Tim Holliefield wrote:
>> Alberto Granzotto wrote:
>>> P.S.: sometimes the function Sql_affected_rows() is used, other times
>>> Sql_Affected_Rows() (with different "case"), why?
>> I think Sql_affected_rows() is an error because no function with that
>> case is defined.

--

-- 
Tim Holliefield
System Administrator
Information Technology
UMUC Europe
+49(0)6221-378281
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michiel Dethmers | 10 Dec 12:43
Picon
Favicon

Re: ver. 2.10.10 - error handling in processqueue.php


These kinds of things are best reported in mantis. If you have
suggestions how to fix it, eg a patch against the trunk code, that would
be even better ;-)

Michiel

On 12/09/2009 12:26 PM, Alberto Granzotto wrote:
> PHPList version: 2.10.10
> PHP version: 5
> Hosting: tophost.it
>
> I had a problem sending a message, after pressing "Process Queue" I had
> a lot of "MySQL server has gone away" errors.
>   I have took a look to [b]processqueue.php[/b], the common pattern in
> errors handling is:
>   $userids = Sql_query($query);
>   if (Sql_Has_Error($database_connection)) {
> ProcessError(Sql_Error($database_connection)); }
>
>   More or less:
>  * do the query;
>  * if some error happens, do ProcessError (which [b]exits[/b] from the
> script).
>
>   Sql_Has_Error w/ ProcessError are not used -- as far as I can see, and
> only in the "sending loop" -- in those lines:
>
> 528: $userids = Sql_Query(sprintf('select * from %s where id =
> 0',$tables["user"]));
(Continue reading)

Permalink | Reply | 0 comments |

Gmane