headers
Saurabh Nanda | 10 Oct 05:54
Picon
Gravatar

Archives?

Hi,

I'm new to PHPList development and have spent the last few days
reading through the entire code base. I have a lot questions and
wanted to see if they've been answered earlier before I ask them on
the mailing list. However, the archives available at
http://mail.tincan.co.uk/pipermail/phplist-developers/ don't seem to
be complete.

Where can I find a complete version of the developer list archive?

Thanks,
Saurabh.
--
http://nandz.blogspot.com
http://foodieforlife.blogspot.com
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 1 comment |
headers
Saurabh Nanda | 10 Oct 07:27
Picon
Gravatar

An assorted list of questions (mostly around click tracking)

Hi,

As I've mentioned in my previous mail, I've been going through the
PHPList source code for the past couple of days, for largely two
reasons:

(a) The email delivery seems to be too slow for my liking and I was
looking at ways to fix it. (I need to send approx 0.6 million emails)
(b) The click tracking feature is marked as experimental so I wanted
to make sure that it's working correctly.

1. Any particular reason why individual functions are generally so
big? For example, replacing all A HREF links with trackable links
should be a function, IMO, which takes the HTML and text parts of the
message and returns the modified text. I'm referring to the code in
sendEmail() inside the "if (CLICKTRACK && $hash != 'forwarded')"
block.

2. sendEmail() -- Can anyone explain what this condition actually
matches and why is it required?

     if ((preg_match('/^http|ftp/',$link) ||
preg_match('/^http|ftp/',$urlbase))
         && $link != 'http://www.phplist.com'
         && !strpos($link,$clicktrack_root))

3. sendEmail() -- Why are two calls to cleanUrl being made for each link?

        $link = cleanUrl($links[2][$i]);
(Continue reading)

Permalink | Reply | 4 comments |
headers
Saurabh Nanda | 10 Oct 07:30
Picon
Gravatar

Re: An assorted list of questions (mostly around click tracking)

> 4. sendEmail() -- Isn't mysql_insert_id a better way to do the following?
>
>    $req = Sql_Fetch_Row_Query(sprintf('select linkid from %s where
> messageid = %s and userid = %d and forward = "%s"

Or whatever is the equivalent in AdoDB. And any particular reason for
using AdoDB instead of the native mysql_ functions?

Saurabh.
--

-- 
http://nandz.blogspot.com
http://foodieforlife.blogspot.com
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 0 comments |
headers
Michiel Dethmers | 10 Oct 12:28
Picon
Favicon

Re: Archives?


There's a list archive going back longer at gmane.org:
http://news.gmane.org/gmane.comp.php.phplist.devel

Michiel

Saurabh Nanda wrote:
> Hi,
>
> I'm new to PHPList development and have spent the last few days
> reading through the entire code base. I have a lot questions and
> wanted to see if they've been answered earlier before I ask them on
> the mailing list. However, the archives available at
> http://mail.tincan.co.uk/pipermail/phplist-developers/ don't seem to
> be complete.
>
> Where can I find a complete version of the developer list archive?
>
> Thanks,
> Saurabh.
> --
> http://nandz.blogspot.com
> http://foodieforlife.blogspot.com
> _______________________________________________
> Phplist-developers mailing list
> Phplist-developers <at> tincan.co.uk
> http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
>   

--

--
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michiel Dethmers | 10 Oct 12:29
Picon
Favicon

Re: An assorted list of questions (mostly around click tracking)


If you're planning to use click tracking with more than 1000 users, it
will be better to use version 2.11.3. In the 2.10 versions, your
database is likely to blow up into several Gbs after a few mailouts.

Michiel

Saurabh Nanda wrote:
> Hi,
>
> As I've mentioned in my previous mail, I've been going through the
> PHPList source code for the past couple of days, for largely two
> reasons:
>
> (a) The email delivery seems to be too slow for my liking and I was
> looking at ways to fix it. (I need to send approx 0.6 million emails)
> (b) The click tracking feature is marked as experimental so I wanted
> to make sure that it's working correctly.
>
> 1. Any particular reason why individual functions are generally so
> big? For example, replacing all A HREF links with trackable links
> should be a function, IMO, which takes the HTML and text parts of the
> message and returns the modified text. I'm referring to the code in
> sendEmail() inside the "if (CLICKTRACK && $hash != 'forwarded')"
> block.
>
> 2. sendEmail() -- Can anyone explain what this condition actually
> matches and why is it required?
>
>      if ((preg_match('/^http|ftp/',$link) ||
(Continue reading)

Permalink | Reply | 2 comments |
headers
Saurabh Nanda | 10 Oct 13:38
Picon
Gravatar

Re: An assorted list of questions (mostly around click tracking)

> If you're planning to use click tracking with more than 1000 users, it
> will be better to use version 2.11.3. In the 2.10 versions, your
> database is likely to blow up into several Gbs after a few mailouts.

What's the difference between the click tracking implementation of
v2.11 and v2.10? (I've been looking at v2.10 till now).

Could you please find some time to answers the other questions I've asked?

Thanks,
Saurabh.
--

-- 
http://nandz.blogspot.com
http://foodieforlife.blogspot.com
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 1 comment |
headers
Michiel Dethmers | 10 Oct 12:54
Picon
Favicon

Re: An assorted list of questions (mostly around click tracking)


2.11 stores the data across three tables and as a result handles large amount better.

To be honest, the other questions, it's been a while, so I wouldn't really know of the top of my head and look into it. The only thing I can tell, which you'll find more discussion about in the archives is that I've tried to speed up the process as well, and I put timings in all the parts, and I found that the phpList parsing the email takes 10% of the time and passing the email on to the MTA takes 90%. So, the best improvement would be made at the final bits where phpList is ready with the email to send and it passes it on to the MTA.

Quite a bit of that will involve advanced system administration tweaking more than clever and fast php coding.

Michiel

Saurabh Nanda wrote:
If you're planning to use click tracking with more than 1000 users, it will be better to use version 2.11.3. In the 2.10 versions, your database is likely to blow up into several Gbs after a few mailouts.
What's the difference between the click tracking implementation of v2.11 and v2.10? (I've been looking at v2.10 till now). Could you please find some time to answers the other questions I've asked? Thanks, Saurabh.

-- Michiel -- Michiel Dethmers Tincan Limited London, Buenos Aires & Machynlleth Tel: +44 (0)1654 702413 Email: michiel <at> tincan.co.uk pgp: http://tincan.co.uk/michiel.asc 
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 0 comments |
headers
Saurabh Nanda | 16 Oct 13:51
Picon
Gravatar

Why html_mime_mail?

With PHPMailer (and PHPListMailer) classes already available, why is
PHPList using the html_mime_mail class? Doesn't the former provide
more features than the latter?

In fact, the config file recommends using PHPMailer in case one wants
to send out HTML mail.

Saurabh.
--

-- 
http://nandz.blogspot.com
http://foodieforlife.blogspot.com
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 7 comments |
headers
Michiel Dethmers | 16 Oct 14:42
Picon
Favicon

Re: Why html_mime_mail?


yes, but the latter was there before the former. It's just some old code
hanging around, and at times interestingly enough it works better than
phpmailer.

Michiel

Saurabh Nanda wrote:
> With PHPMailer (and PHPListMailer) classes already available, why is
> PHPList using the html_mime_mail class? Doesn't the former provide
> more features than the latter?
>
> In fact, the config file recommends using PHPMailer in case one wants
> to send out HTML mail.
>
> Saurabh.
>   
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 6 comments |
headers
Saurabh Nanda | 17 Oct 15:49
Picon
Gravatar

Re: Why html_mime_mail?

> yes, but the latter was there before the former. It's just some old code
> hanging around, and at times interestingly enough it works better than
> phpmailer.

For which cases does it work better than PHPMailer? I'm planning to
remove html_mime_mail from my patch.

Saurabh.
--

-- 
http://nandz.blogspot.com
http://foodieforlife.blogspot.com
_______________________________________________
Phplist-developers mailing list
Phplist-developers <at> tincan.co.uk
http://mail.tincan.co.uk/mailman/listinfo/phplist-developers
Permalink | Reply | 5 comments |

Gmane