headers
Rich Schumacher | 1 May 2009 20:02
Picon
Gravatar

[PEPr] Changes in proposal for Web Services::Services_Scribd


Rich Schumacher (http://pear.php.net/user/richid) has edited the proposal for Web Services::Services_Scribd.

Change comment:

Added the GitHub download URL.

Please review the proposal:
http://pear.php.net/pepr/pepr-proposal-show.php?id=595

--

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Kornel Lesiński | 3 May 2009 06:11
Picon
Favicon
Gravatar

Re: [PEPr] +1 for HTML::PHPTAL

On 28.04.2009, at 20:16, Till Klampaeckel wrote:

> Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the  
> proposal for HTML::PHPTAL.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=597
> Vote information:
> http://pear.php.net/pepr/pepr-vote-show.php?id=597&handle=till
>
> This vote is conditional. The condition is:
>
> All reasons have been stated in previous comments and by Michael.

I think I've fixed these issues:
2, 3, 4, 5, 6, 7, 8, 11, 12, 14, 15

http://phptal.org/latest-pear.tar.gz

1.) phpcs, specifically
- line length
- whitespace, space around operators
- required docblocks
- required doc tags in docblocks

I've went trough code and fixed all important problems that I've  
noticed. I've also fixed "low-hanging fruit" that I could safely do  
with regular expressions.

However number of issues that phpcs reports is daunting. Many of them
(Continue reading)

Permalink | Reply | 1 comment |
headers
Christian Weiske | 3 May 2009 13:03
Picon
Favicon
Gravatar

Brett, your manual build is down

Hi Brett,

Your periodic manual builds are not running anymore as it seems. I
updated the documentation docs [1] today and linked to you - it'd be
great if you could get it running again.

[1]
http://cvs.php.net/viewvc.cgi/peardoc/en/guide/developers/documentation.xml?view=log

--

-- 
Regards/Mit freundlichen Grüßen
Christian Weiske

-= Geeking around in the name of science since 1982 =-
Permalink | Reply | 4 comments |
headers
Alexey Borzov | 3 May 2009 14:50
Picon
Favicon

[PEPr] +1 for HTML::PHPTAL


Alexey Borzov (http://pear.php.net/user/avb) has voted +1 on the proposal for HTML::PHPTAL.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=597
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=597&handle=avb

Comment:

Looks good, though it shows that the package has long development history,
it had certainly grown some cruft over the years.

Anyway, it's also a lot more complex than numerous Services_Whatever we
are getting these days, so I don't see a point in not allowing the package
in, the cruft may be addressed later, if needed.

--

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Michael Gauthier | 3 May 2009 19:24
Favicon
Gravatar

Re: [PEPr] +1 for HTML::PHPTAL

On Sun, 2009-05-03 at 05:11 +0100, Kornel Lesiński wrote:
> On 28.04.2009, at 20:16, Till Klampaeckel wrote:
> 
> > Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the  
> > proposal for HTML::PHPTAL.
> >
> > Proposal information:
> > http://pear.php.net/pepr/pepr-proposal-show.php?id=597
> > Vote information:
> > http://pear.php.net/pepr/pepr-vote-show.php?id=597&handle=till
> >
> > This vote is conditional. The condition is:
> >
> > All reasons have been stated in previous comments and by Michael.
> 
> I think I've fixed these issues:
> 2, 3, 4, 5, 6, 7, 8, 11, 12, 14, 15
> 
> http://phptal.org/latest-pear.tar.gz
> 
> 1.) phpcs, specifically
> - line length
> - whitespace, space around operators
> - required docblocks
> - required doc tags in docblocks
> 
> I've went trough code and fixed all important problems that I've  
> noticed. I've also fixed "low-hanging fruit" that I could safely do  
> with regular expressions.
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Christian Weiske | 4 May 2009 11:37
Picon
Gravatar

[PEPr] +1 for HTML::PHPTAL


Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for HTML::PHPTAL.

Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=597
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=597&handle=cweiske

This vote is conditional. The condition is:

+1 if you fix the issues already mentioned.

--

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Michael Gauthier | 4 May 2009 16:45
Favicon
Gravatar

[PEPr] Comment on Web Services::Services_Scribd


Looks pretty good to me. I have a few suggestions:

1.) Docblocks should not repeat the method name on the first line. First
line should be a short summary sentence with no period. Summaries for
methods should use 3rd person declarative rather than 2nd person
imperative, beginning with a verb phrase. For example, instead of:

* signup

*

* Create a new Scribd account.

use

* Creates a new Scribd account

2.) Consider using HTTP_Request2 for the HTTP code. HTTP_Request2 already
has methods to handle GET/POST argument building and file uploads.

3.) Making the username/password/key static in the main class will
restrict you to one Scribd class at a time. If that's intentional, the
class should be made a singleton. If not, the properties should not be
static.

4.) Use of mb_convert_case() requires the mbstring extension, but it is
not specified in the package.xml.

5.) Consider more specific exception classes for different error
(Continue reading)

Permalink | Reply | 0 comments |
headers
Brett Bieber | 4 May 2009 16:03
Picon
Gravatar

Re: Brett, your manual build is down

Heya,

On Sun, May 3, 2009 at 6:03 AM, Christian Weiske <cweiske <at> cweiske.de> wrote:
> Your periodic manual builds are not running anymore as it seems. I
> updated the documentation docs [1] today and linked to you - it'd be
> great if you could get it running again.

Ahh, I lost phd in my include path. Fixed!

Evidently the output is in a different place now as well, so I've
updated the entity to the correct url.

http://ucommbieber.unl.edu/peardoc/build/en/pear_manual_en/

-- 
Brett Bieber

--

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 3 comments |
headers
Laurent Laville | 4 May 2009 21:02

Re: Brett, your manual build is down

Hello Brett,
> Heya,
> 
> On Sun, May 3, 2009 at 6:03 AM, Christian Weiske <cweiske <at> cweiske.de> wrote:
>> Your periodic manual builds are not running anymore as it seems. I
>> updated the documentation docs [1] today and linked to you - it'd be
>> great if you could get it running again.
> 
> Ahh, I lost phd in my include path. Fixed!
> 
> Evidently the output is in a different place now as well, so I've
> updated the entity to the correct url.

Are you sure url is correct ;-)

Should be rather
> 
> http://ucommbieber.unl.edu/peardoc/build/en/pear_manual_en/
> 

http://ucommbieber.unl.edu/peardoc/build/en/pear_manual_en.html

--

-- 
PEAR Development Mailing List (http://pear.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 2 comments |
headers
Brett Bieber | 4 May 2009 21:10
Picon
Gravatar

Re: Brett, your manual build is down

On Mon, May 4, 2009 at 2:02 PM, Laurent Laville
<pear <at> laurent-laville.org> wrote:
> Hello Brett,
>>
>> Heya,
>>
>> On Sun, May 3, 2009 at 6:03 AM, Christian Weiske <cweiske <at> cweiske.de>
>> wrote:
>>>
>>> Your periodic manual builds are not running anymore as it seems. I
>>> updated the documentation docs [1] today and linked to you - it'd be
>>> great if you could get it running again.
>>
>> Ahh, I lost phd in my include path. Fixed!
>>
>> Evidently the output is in a different place now as well, so I've
>> updated the entity to the correct url.
>
> Are you sure url is correct ;-)
>
> Should be rather
>>
>> http://ucommbieber.unl.edu/peardoc/build/en/pear_manual_en/
>>
>
> http://ucommbieber.unl.edu/peardoc/build/en/pear_manual_en.html

Both work. One is to the big HTML file the other is to the chunked out html.

Keep in mind it is built every two hours, so the chunked version may
(Continue reading)

Permalink | Reply | 1 comment |

Gmane