Daniel Convissor | 1 Jun 03:11 2006

Re: [PHP-DEV] CVS Account request: takagi (was Re: [PHP-DEV] internals <at> lists.php.net)

On Thu, Jun 01, 2006 at 07:17:48AM +0900, TAKAGI Masahiro wrote:
> > Currently, I have karma for phpdoc only.
> > Now I'd like to maintain not only php-doc but peardoc.
> > Could anyone give me karma for peardoc ?
>
> TAKAGI Masahiro mailto:takagi <at> php.net

Agreed.

--Dan

-- 
 T H E   A N A L Y S I S   A N D   S O L U T I O N S   C O M P A N Y
            data intensive web and database programming
                http://www.AnalysisAndSolutions.com/
 4015 7th Ave #4, Brooklyn NY 11232  v: 718-854-0335 f: 718-854-0409

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

nhan ho van | 1 Jun 06:20 2006
Picon

[PHP-DEV] CVS Account Request: hovannhan

Need extendsion

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Andi Gutmans | 1 Jun 06:24 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

At 04:28 AM 5/31/2006, Steph Fox wrote:
>>Probably some other bug that is the reason of the crash was masked by
>>omitting FreeLibrary().
>>I know Tony fixed some kind of such bugs in ext/tidy and ext/sybase.
>
>Yes, he gave those extensions the ts_free_id() workaround I 
>mentioned a looooooooooong time ago when I first started looking into this.

I'm a bit behind so sorry if this has been answered already. I don't 
think ts_free_id() is a workaround but it's actually correct. We 
should free the resources of the extension during MSHUTDOWN and 
that's the way to do it in ZTS. Good chance that the crash is 
actually a bug which needs fixing although there could also be a bug lurking.

Andi 

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Andi Gutmans | 1 Jun 06:25 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

At 08:23 AM 5/31/2006, Steph Fox wrote:
>Hi Frank,
>
>>tsrm_shutdown() is already comented out in the CGI version, most likely as
>>a fix to the same kind of problem there. Perhaps enabling that again will
>>show the same kind of problems?
>
>Yes, it would, given the root cause - but would you really want to 
>break the whole of PHP for an academic exercise?

It's not really an academic exercise. If we know there's a bug 
someplace we should at least look into it and try and understand it. 
Then if we decide to remove the trsm_shutdown call for a good reason 
(circular dependency, blah blah blah) then we can do that and put a 
nice fat comment on why it's the right thing to do. But I do think 
it's benefical to try and understand what's happening.

Andi

>The more interesting thing is that none of this happens under CLI 
>debug. I've still no clue why.
>
>I also think I've somehow corrupted something here with my debug 
>lines, I'm crashing 'differently' now <sigh />.
>
>- Steph
>
>>- Frank

--

-- 
(Continue reading)

Steph Fox | 1 Jun 06:47 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

> I'm a bit behind so sorry if this has been answered already. I don't think 
> ts_free_id() is a workaround but it's actually correct.

ts_free_id() would be a correct workaround if it came from zend_shutdown(). 
How's it right to suddenly force EVERY extension author to add it to their 
code individually?

We
> should free the resources of the extension during MSHUTDOWN and that's the 
> way to do it in ZTS. Good chance that the crash is actually a bug which 
> needs fixing although there could also be a bug lurking.
>
> Andi 

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Steph Fox | 1 Jun 06:50 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

>>Yes, it would, given the root cause - but would you really want to break 
>>the whole of PHP for an academic exercise?
>
> It's not really an academic exercise. If we know there's a bug someplace 
> we should at least look into it and try and understand it.

Frank's referring to Zeev's three-years-ago decision to simply opt out of 
tsrm_shutdown() here... he's suggesting we revert it.

> Then if we decide to remove the trsm_shutdown call for a good reason 
> (circular dependency, blah blah blah) then we can do that and put a nice 
> fat comment on why it's the right thing to do. But I do think it's 
> benefical to try and understand what's happening.

Fine, but breaking working code while you're trying to understand what's 
happening is far from beneficial to our users. Can't we at least #0 it?

>
> Andi

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Frank M. Kromann | 1 Jun 07:19 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI


> > I'm a bit behind so sorry if this has been answered already. I don't
think 
> > ts_free_id() is a workaround but it's actually correct.
> 
> ts_free_id() would be a correct workaround if it came from
zend_shutdown(). 
> How's it right to suddenly force EVERY extension author to add it to
their 
> code individually?

This was only reqiured in extensions registering custom dtor's like tidy
and printer.

- Frank

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Frank M. Kromann | 1 Jun 07:21 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI


> >>Yes, it would, given the root cause - but would you really want to
break 
> >>the whole of PHP for an academic exercise?
> >
> > It's not really an academic exercise. If we know there's a bug
someplace 
> > we should at least look into it and try and understand it.
> 
> Frank's referring to Zeev's three-years-ago decision to simply opt out
of 
> tsrm_shutdown() here... he's suggesting we revert it.
> 
> > Then if we decide to remove the trsm_shutdown call for a good reason 
> > (circular dependency, blah blah blah) then we can do that and put a
nice 
> > fat comment on why it's the right thing to do. But I do think it's 
> > benefical to try and understand what's happening.
> 
> Fine, but breaking working code while you're trying to understand what's

> happening is far from beneficial to our users. Can't we at least #0 it?

There is no need to break code. The shutdown function was commented out
for a reason (crash) when that's fixed we can enable that code again.

- Frank

--

-- 
PHP Internals - PHP Runtime Development Mailing List
(Continue reading)

Andi Gutmans | 1 Jun 08:28 2006

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

As we are not planning to release a new version within the next 
couple of weeks, I suggest before jumping to conclusions we take a look at it.

If you really need to comment out that line in the meanwhile that's OK with me.

Andi

At 09:50 PM 5/31/2006, Steph Fox wrote:
>>>Yes, it would, given the root cause - but would you really want to 
>>>break the whole of PHP for an academic exercise?
>>
>>It's not really an academic exercise. If we know there's a bug 
>>someplace we should at least look into it and try and understand it.
>
>Frank's referring to Zeev's three-years-ago decision to simply opt 
>out of tsrm_shutdown() here... he's suggesting we revert it.
>
>>Then if we decide to remove the trsm_shutdown call for a good 
>>reason (circular dependency, blah blah blah) then we can do that 
>>and put a nice fat comment on why it's the right thing to do. But I 
>>do think it's benefical to try and understand what's happening.
>
>Fine, but breaking working code while you're trying to understand 
>what's happening is far from beneficial to our users. Can't we at least #0 it?
>
>>
>>Andi

--

-- 
PHP Internals - PHP Runtime Development Mailing List
(Continue reading)

Dmitry Stogov | 1 Jun 08:34 2006

RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

I agree.
I'll try to make it work from inside zend_shudown() but probably it will
requre modification of EVERY extension that uses module_globals in any case.

Thanks. Dmitry.

> -----Original Message-----
> From: Steph Fox [mailto:steph <at> zend.com] 
> Sent: Thursday, June 01, 2006 8:48 AM
> To: Dmitry Stogov; 'Xuefer'; Andi Gutmans
> Cc: 'internals'; Antony Dovgal
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
> 
> 
> > I'm a bit behind so sorry if this has been answered 
> already. I don't 
> > think
> > ts_free_id() is a workaround but it's actually correct.
> 
> ts_free_id() would be a correct workaround if it came from 
> zend_shutdown(). 
> How's it right to suddenly force EVERY extension author to 
> add it to their 
> code individually?
> 
> We
> > should free the resources of the extension during MSHUTDOWN 
> and that's 
> > the
> > way to do it in ZTS. Good chance that the crash is actually 
(Continue reading)


Gmane