headers
Jani Taskinen | 1 Mar 2005 01:09
Picon
Picon
Favicon

[PHP-DEV] bison/flex generated files not in CVS


     Is there some good reason not to commit these files in CVS
     so people would not necessarily need the 'correct' versions
     of bison/flex (as they don't need re2c either):

     Zend/zend_ini_scanner.c
     Zend/zend_ini_parser.c
     Zend/zend_ini_parser.h
     Zend/zend_language_scanner.c
     Zend/zend_language_parser.c
     Zend/zend_language_parser.h

     ext/standard/parsedate.c

     ??? (e.g. sqlite seems to bundle it's parse.c :)

     --Jani

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Alan Knowles | 1 Mar 2005 04:11
Favicon
Gravatar

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?

I think derick does something like this in SRM,
but basically if you want to load something in the global thread,  and 
let the children inherit the data / classes /function etc.
AFAIR you need to serialize the opcodes, and copy them for each thread. 
(or use something like bcompiler to load cached opcodes for you..)

Basically the engine does thread saftey by having a seperate data store 
for each thread. As far as the engine goes, it treats each thread pretty 
much as a seperate process.. 
There was some code in the threads extension to pass variables between 
threads.., cant remember the status of it though.

The code I posted works pretty well, but I include a file as soon as the 
new thread starts up, and dont have any thread global data at present.

Regards
Alan

Bob Beaty wrote:

> Which is my concern.
>
> I've looked at the code differences, and it appears that this 
> modification works for running different source files through the 
> engine, but I'm concerned about the safety of zend_eval_string() if I 
> initialize the engine in one thread and then try to have several 
> threads calling zend_eval_string() on different strings.
>
> I'm not convinced that simply making the php_embed_module thread-local 
> is going to work either. I'm concerned that the engine was written
(Continue reading)

Permalink | Reply | 1 comment |
headers
Wez Furlong | 1 Mar 2005 06:56
Picon
Gravatar

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?

ZTS enabled PHP has "strong thread affinity".
Calls into the engine are thread-safe provided that you have
previously initialized the engine on that thread.

Note that you should not efree() memory allocated on one thread from
outside of that thread, on pain of segfault.  eg: resources from one
thread cannot be safely passed on to another thread.

--Wez.

On Mon, 28 Feb 2005 14:24:05 -0600, Bob Beaty <drbobbeaty <at> gmail.com> wrote:
> Which is my concern.
> 
> I've looked at the code differences, and it appears that this
> modification works for running different source files through the
> engine, but I'm concerned about the safety of zend_eval_string() if I
> initialize the engine in one thread and then try to have several
> threads calling zend_eval_string() on different strings.
> 
> I'm not convinced that simply making the php_embed_module thread-local
> is going to work either. I'm concerned that the engine was written with
> the idea that only one thread can be initializing the php_embed_module
> and making calls to zend_eval_string(). If this is the case, then I'd
> have to re-write a lot more than php_embed.c to get thread-safety out
> of the engine.
> 
> Or am I on the wrong track?
> 
>                 Bob
>
(Continue reading)

Permalink | Reply | 3 comments |
headers
Marc Villemade | 1 Mar 2005 10:24
Picon

[PHP-DEV] Readfile() security breach

Hi everyone,

I just wanted to let you know about this breach unveiled by Secunia
today. Well, actually i'm pretty sure you know about it, but i wanted
to know if it was already being investigated and if there was a plan
to release a patch soon.

here's the link at secunia .. 
http://secunia.com/advisories/14409/

Thanks for any information.

-- 
Chand

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Bob Beaty | 1 Mar 2005 11:35
Picon

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?

Wez,
   OK, I'm with you on this so far, but how do you differentiate 
ub_write, log_message, and sapi_error on different threads? It would 
seem to me that you'd need to have different functions for each thread 
as the calls to ub_write don't include some indication of the thread 
that this is being called under.
   Then again, maybe it's in the php_embed_module if it's tightly bound 
to the thread... For example, if I set the title in the thread-bound 
php_embed_module to something specific for each thread then check that 
within the call to ub_write() I can see who this 'write' belongs to.
   If I'm missing the boat on these function callbacks, or there's an 
easier way to capture stdout, stderr, etc. in a ZTS-enabled PHP/Zend 
environment, please let me know.
   I'm sorry if I seem a bit dense, but I'm trying to figure things out 
and design the code before I start writing it.

		Bob

On Feb 28, 2005, at 11:56 PM, Wez Furlong wrote:

> ZTS enabled PHP has "strong thread affinity".
> Calls into the engine are thread-safe provided that you have
> previously initialized the engine on that thread.
>
> Note that you should not efree() memory allocated on one thread from
> outside of that thread, on pain of segfault.  eg: resources from one
> thread cannot be safely passed on to another thread.
>
> --Wez.
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Wez Furlong | 1 Mar 2005 15:52
Picon
Gravatar

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?

The TSRMLS_DC magic parameter passes around the thread-local storage
pointer for the thread;   the SG() macro uses that information to get
at the sapi_globals struct for your thread.

You can also stuff your own SAPI related information into
SG(server_context), if you are writing a SAPI:

... in my thread init code ...
struct my_globals *g = calloc(1, sizeof(*g));
SG(server_context) = g;

... in the ub write callback ...
struct my_globals *g = (struct my_globals*)SG(server_context);

If TSRMLS_DC is not present in the function declaration, you can use
TSRMLS_FETCH() to summon it out of thread-local-storage.

--Wez.

On Tue, 1 Mar 2005 04:35:43 -0600, Bob Beaty <drbobbeaty <at> gmail.com> wrote:
> Wez,
>    OK, I'm with you on this so far, but how do you differentiate
> ub_write, log_message, and sapi_error on different threads? It would
> seem to me that you'd need to have different functions for each thread
> as the calls to ub_write don't include some indication of the thread
> that this is being called under.
>    Then again, maybe it's in the php_embed_module if it's tightly bound
> to the thread... For example, if I set the title in the thread-bound
> php_embed_module to something specific for each thread then check that
> within the call to ub_write() I can see who this 'write' belongs to.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Vadka | 1 Mar 2005 18:57
Picon

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?

On Tue, 1 Mar 2005, Wez Furlong wrote:

> ZTS enabled PHP has "strong thread affinity".
> Calls into the engine are thread-safe provided that you have
> previously initialized the engine on that thread.
Hm...
The problem is when we create a thread and call_user_function for the 
function from the parent thread.

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Vadka | 1 Mar 2005 18:54
Picon

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?


On Tue, 1 Mar 2005, Alan Knowles wrote:

> I think derick does something like this in SRM,
> but basically if you want to load something in the global thread,  and let 
> the children inherit the data / classes /function etc.
> AFAIR you need to serialize the opcodes, and copy them for each thread. (or 
> use something like bcompiler to load cached opcodes for you..)
For me, inter-threads variables api is working (separated table, holding 
references between threads; must be synched by mutexes).
it will take some time to make that available...

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |
headers
Vadka | 2 Mar 2005 19:08
Picon

Re: [PHP-DEV] How to embed PHP5 into multi-threaded C app?

On Mon, 28 Feb 2005, Bob Beaty wrote:

> Which is my concern.
>
> I've looked at the code differences, and it appears that this modification 
> works for running different source files through the engine, but I'm 
> concerned about the safety of zend_eval_string() if I initialize the engine 
> in one thread and then try to have several threads calling zend_eval_string() 
> on different strings.
It will not work, as I can see.
It works fine, when I do some preparations, like:

thr=pthread_self();
tsrml=ts_resource_ex(0, &thr);
php_request_startup(tsrml);
zend_eval_string("

But, I must note, that there are no waits for the "thread to start
current thread" in the parent thread in my situation.
Maybe, the code above is not correct (I'm new to PHP's internals), but it 
works correctly.

> I'm not convinced that simply making the php_embed_module thread-local is 
> going to work either. I'm concerned that the engine was written with the idea 
> that only one thread can be initializing the php_embed_module and making 
> calls to zend_eval_string(). If this is the case, then I'd have to re-write a 
> lot more than php_embed.c to get thread-safety out of the engine.
> Or am I on the wrong track?
Imagine, we have (usually) situation, when we are running a function in a 
separate thread (such idea is partially realized in pecl/threads).
(Continue reading)

Permalink | Reply | 1 comment |
headers
D.Walsh | 2 Mar 2005 21:29

[PHP-DEV] LOGO_GUID

How do I select an appropriate LOGO_GUID?

-- Dale

--

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Permalink | Reply | 0 comments |

Gmane