Bug reports for Bison, the GNU parser generator

Csaba Raduly | 5 Feb 17:01

Picon

yyprint does not work with glr-parser

The C code generated from the following grammar will not compile,
because yytoknum is not defined when glr-parser is in use.

%{
// C header part
#include <stdio.h>

static int yylex();

#define YYERROR_VERBOSE

void yyerror(const char *s)
{
puts(s);
}

union YYSTYPE;
static void yyprint(FILE *file, int type, const YYSTYPE& value);
#define YYPRINT(f,t,v) yyprint(f,t,v)

//static int yytoknum[500] = {0};
// Hack to get it  compile
%}

%verbose
%glr-parser

%start GrammarRoot

%token foo

(Continue reading)

Joel E. Denny | 6 Feb 23:05

Re: yyprint does not work with glr-parser

*

On Fri, 5 Feb 2010, Csaba Raduly wrote:

> The C code generated from the following grammar will not compile,
> because yytoknum is not defined when glr-parser is in use.

You should have better luck with %printer, which is the modern version of 
YYPRINT.  Actually, our %printer documentation is poor.  It has the same 
syntax as %destructor.  You print to yyoutput, which is a FILE*.  For 
example:

  %printer { fprintf (yyoutput, "%d", $$); } BOOL <integer>

It's not clear to me whether we should add YYPRINT support to GLR or if we 
should just document the lack of support.

Csaba Raduly | 8 Feb 19:37

Picon

Re: yyprint does not work with glr-parser

On Sat, Feb 6, 2010 at 11:05 PM, Joel E. Denny <jdenny <at> clemson.edu> wrote:
> On Fri, 5 Feb 2010, Csaba Raduly wrote:
>
>> The C code generated from the following grammar will not compile,
>> because yytoknum is not defined when glr-parser is in use.
>
> You should have better luck with %printer, which is the modern version of
> YYPRINT.  Actually, our %printer documentation is poor.

Make that non-existent, bar some examples :)

> It has the same
> syntax as %destructor.  You print to yyoutput, which is a FILE*.  For
> example:
>
>  %printer { fprintf (yyoutput, "%d", $$); } BOOL <integer>
>
> It's not clear to me whether we should add YYPRINT support to GLR or if we
> should just document the lack of support.
>

At least it (seems to) work with 2.3 too so I don't have to hack yyprint.
Pity that only 2.4 seems to accept the "<integer>" form.

--

-- 
Life is complex, with real and imaginary parts

Joel E. Denny | 8 Feb 19:59

Re: yyprint does not work with glr-parser

*

On Mon, 8 Feb 2010, Csaba Raduly wrote:

> >  %printer { fprintf (yyoutput, "%d", $$); } BOOL <integer>

> Pity that only 2.4 seems to accept the "<integer>" form.

Right, that was added in 2.3a.

Albert Chin | 1 Feb 21:06

Test 52 failure on AIX, HP-UX, Solaris

Test 52 fails on AIX, HP-UX, and Solaris:
52. output.at:159: testing ...
./output.at:159: VALGRIND_OPTS="$VALGRIND_OPTS --leak-check=summary --show-reachable=no";
export VALGRIND_OPTS; bison -o foo.y foo.y
2c2,3
< 
---
> /opt/TWWfsw/m414/bin/gm4:/opt/build/bison-2.4.1a/data/yacc.c:694: ERROR: copying inserted
file: Broken pipe
> /opt/TWWfsw/m414/bin/gm4: write error
52. output.at:159: 52. Conflicting output files:  -o foo.y (output.at:159): FAILED (output.at:159)

We're seeing the same failure on AIX and HP-UX.

--

-- 
albert chin (china <at> thewrittenword.com)

Joel E. Denny | 2 Feb 00:56

Re: Test 52 failure on AIX, HP-UX, Solaris

On Mon, 1 Feb 2010, Albert Chin wrote:

> Test 52 fails on AIX, HP-UX, and Solaris:
> 52. output.at:159: testing ...
> ./output.at:159: VALGRIND_OPTS="$VALGRIND_OPTS --leak-check=summary --show-reachable=no";
export VALGRIND_OPTS; bison -o foo.y foo.y
> 2c2,3
> < 
> ---
> > /opt/TWWfsw/m414/bin/gm4:/opt/build/bison-2.4.1a/data/yacc.c:694: ERROR: copying inserted
file: Broken pipe
> > /opt/TWWfsw/m414/bin/gm4: write error
> 52. output.at:159: 52. Conflicting output files:  -o foo.y (output.at:159): FAILED (output.at:159)
> 
> We're seeing the same failure on AIX and HP-UX.

I'm pretty sure this means your m4 is broken.  Please confirm that you're 
running at least GNU M4 1.4.6.

Albert Chin | 2 Feb 06:27

Re: Test 52 failure on AIX, HP-UX, Solaris

On Mon, Feb 01, 2010 at 06:56:03PM -0500, Joel E. Denny wrote:
> On Mon, 1 Feb 2010, Albert Chin wrote:
> 
> > Test 52 fails on AIX, HP-UX, and Solaris:
> > 52. output.at:159: testing ...
> > ./output.at:159: VALGRIND_OPTS="$VALGRIND_OPTS --leak-check=summary --show-reachable=no";
export VALGRIND_OPTS; bison -o foo.y foo.y
> > 2c2,3
> > < 
> > ---
> > > /opt/TWWfsw/m414/bin/gm4:/opt/build/bison-2.4.1a/data/yacc.c:694: ERROR: copying inserted
file: Broken pipe
> > > /opt/TWWfsw/m414/bin/gm4: write error
> > 52. output.at:159: 52. Conflicting output files:  -o foo.y (output.at:159): FAILED (output.at:159)
> > 
> > We're seeing the same failure on AIX and HP-UX.
> 
> I'm pretty sure this means your m4 is broken.  Please confirm that you're 
> running at least GNU M4 1.4.6.

We're running 1.4.12.

--

-- 
albert chin (china <at> thewrittenword.com)

Joel E. Denny | 2 Feb 06:42

Re: Test 52 failure on AIX, HP-UX, Solaris

On Mon, 1 Feb 2010, Albert Chin wrote:

> On Mon, Feb 01, 2010 at 06:56:03PM -0500, Joel E. Denny wrote:
> > On Mon, 1 Feb 2010, Albert Chin wrote:
> > 
> > > Test 52 fails on AIX, HP-UX, and Solaris:
> > > 52. output.at:159: testing ...
> > > ./output.at:159: VALGRIND_OPTS="$VALGRIND_OPTS --leak-check=summary --show-reachable=no";
export VALGRIND_OPTS; bison -o foo.y foo.y
> > > 2c2,3
> > > < 
> > > ---
> > > > /opt/TWWfsw/m414/bin/gm4:/opt/build/bison-2.4.1a/data/yacc.c:694: ERROR: copying inserted
file: Broken pipe
> > > > /opt/TWWfsw/m414/bin/gm4: write error
> > > 52. output.at:159: 52. Conflicting output files:  -o foo.y (output.at:159): FAILED (output.at:159)
> > > 
> > > We're seeing the same failure on AIX and HP-UX.
> > 
> > I'm pretty sure this means your m4 is broken.  Please confirm that you're 
> > running at least GNU M4 1.4.6.
> 
> We're running 1.4.12.

You're saying that /opt/TWWfsw/m414/bin/gm4, which is mentioned in the 
error message, is GNU M4 1.4.12?

I should point out that M4 in your environment would cause Bison to use a 
different m4 than the one discovered by configure.

Do any other test cases fail?  Attaching a complete tests/testsuite.log 
and config.log might help us debug this.

(Continue reading)

Joel E. Denny | 2 Feb 07:19

Re: Test 52 failure on AIX, HP-UX, Solaris

On Tue, 2 Feb 2010, Joel E. Denny wrote:

> On Mon, 1 Feb 2010, Albert Chin wrote:
> 
> > On Mon, Feb 01, 2010 at 06:56:03PM -0500, Joel E. Denny wrote:
> > > On Mon, 1 Feb 2010, Albert Chin wrote:
> > > 
> > > > Test 52 fails on AIX, HP-UX, and Solaris:
> > > > 52. output.at:159: testing ...
> > > > ./output.at:159: VALGRIND_OPTS="$VALGRIND_OPTS --leak-check=summary --show-reachable=no";
export VALGRIND_OPTS; bison -o foo.y foo.y
> > > > 2c2,3
> > > > < 
> > > > ---
> > > > > /opt/TWWfsw/m414/bin/gm4:/opt/build/bison-2.4.1a/data/yacc.c:694: ERROR: copying
inserted file: Broken pipe
> > > > > /opt/TWWfsw/m414/bin/gm4: write error
> > > > 52. output.at:159: 52. Conflicting output files:  -o foo.y (output.at:159): FAILED (output.at:159)
> > > > 
> > > > We're seeing the same failure on AIX and HP-UX.
> > > 
> > > I'm pretty sure this means your m4 is broken.  Please confirm that you're 
> > > running at least GNU M4 1.4.6.
> > 
> > We're running 1.4.12.
> 
> You're saying that /opt/TWWfsw/m414/bin/gm4, which is mentioned in the 
> error message, is GNU M4 1.4.12?
> 
> I should point out that M4 in your environment would cause Bison to use a 
> different m4 than the one discovered by configure.

Never mind.  I think I see the problem now.  This test group produces a 
fatal error, which invokes exit, while the m4 subpipe is still open.  
Apparently that causes ugly error messages on some platforms.

We should probably change bison not to do this... and there are many other 
places where fatal errors might occur while the m4 subpipe is open.  For 
release 2.4.2, it might be better just to detect the problem and skip the 
associated test groups.  I'll have to give it more thought.

> Do any other test cases fail?  Attaching a complete tests/testsuite.log 
> and config.log might help us debug this.

That would still be helpful.

While the following patch is obviously not a good solution, would you 
please confirm that it does allow the test group to pass on the affected 
platforms?

diff --git a/src/files.c b/src/files.c
index 9761de9..63c9e2a 100644
--- a/src/files.c
+++ b/src/files.c
@@ -350,11 +350,15 @@ compute_output_file_names (void)
   free (header_extension);
 }

-void
+bool

(Continue reading)

Albert Chin | 2 Feb 07:37

Re: Test 52 failure on AIX, HP-UX, Solaris

*

On Tue, Feb 02, 2010 at 01:19:38AM -0500, Joel E. Denny wrote:
> While the following patch is obviously not a good solution, would you
> please confirm that it does allow the test group to pass on the
> affected platforms?

Confirmed on RHEL4/x86-64.

--

-- 
albert chin (china <at> thewrittenword.com)

Joel E. Denny | 2 Feb 10:30

Re: Test 52 failure on AIX, HP-UX, Solaris

On Tue, 2 Feb 2010, Albert Chin wrote:

> On Tue, Feb 02, 2010 at 01:19:38AM -0500, Joel E. Denny wrote:
> > While the following patch is obviously not a good solution, would you
> > please confirm that it does allow the test group to pass on the
> > affected platforms?
> 
> Confirmed on RHEL4/x86-64.

Thanks.

Here's an attempt at fixing this.  Not yet pushed.  I now need to decide 
whether this fix is too much for 2.4.2.  If so, I suppose I could just 
comment out the affected test group for 2.4.2, but I'm suspicious that 
there's a race condition that could sometimes affect other test groups.  
I'd appreciate comments from anyone.

>From 09f99a629f7aa0d696646d28d23cde47588f4e38 Mon Sep 17 00:00:00 2001
From: Joel E. Denny <jdenny <at> clemson.edu>
Date: Tue, 2 Feb 2010 04:10:30 -0500
Subject: [PATCH] portability: don't exit before reaping m4 child.

This was happening at fatal errors during scan_skel.  Broken
pipe messages were seen on at least AIX, HP-UX, Solaris, and
RHEL4, and this caused failures in the test suite.  Is this more
a race condition than a portability issue?
Reported by Albert Chin at
<http://lists.gnu.org/archive/html/bug-bison/2010-02/msg00004.html>.
* NEWS (2.4.2): Document.
* lib/subpipe.c, lib/subpipe.h (reap_subpipe): Add
ignore_failure argument to avoid a redundant error message after
already reporting a fatal error.
* src/complain.c, src/complain.h (fatal_at_delayed,
fatal_delayed): New functions.
* src/files.c (compute_output_file_names): Update invocations
of output_file_name_check.
(output_file_name_check): In the case that the grammar file
would be overwritten, use complain instead of fatal, but replace

(Continue reading)

Group

gmane.comp.parsers.bison.bugs.

Advertisement

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11

February 2010

Language

Change language

Options

Current view: All messages / Showing only 20 lines / Hiding cited text.
Change to Threads only, whole messages, or show cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

yyprint does not work with glr-parser (5 Feb 17:01)
Test 52 failure on AIX, HP-UX, Solaris (1 Feb 21:06)
2.4.1a testsuite failures on Solaris 2.7 (1 Feb 17:52)
Key used to sign bison-2.4.1.tar.bz2.sig expired (31 Jan 21:14)
Building bison 2.4.1 in Solaris 8 (22 Jan 10:45)
configure missing files (22 Jan 22:38)
configure missing files (22 Jan 07:25)
bison 2010 (21 Jan 14:32)
License exception wording has not been updated for parse-gram.h (13 Jan 18:16)
error: else without a previous if (13 Jan 20:59)
problem with automake and bison (11 Jan 21:03)
Precedence and "overloaded" operators (3 Jan 21:43)
Precedence and "overloaded" operators (2 Jan 23:22)
%prec using undefined token (30 Dec 01:03)
Bug Using GLR parser. Symptom is an occasional incorrect pattern match (10 Dec 19:48)
Bug Using GLR parser. Symptom is an occasional incorrect pattern match (9 Dec 19:08)
problem with union and type in file.y (25 Nov 11:54)
xgettext messages when compiling bison git repo (18 Nov 01:53)
Hello, to make documentation? (26 Oct 19:30)
[PATCH] build: avoid printf format mismatch warnings (29 Sep 08:20)
[GNU Bison 2.4.1] testsuite: 51 failed (i686-cygwin) (17 Sep 14:41)

Archives

24	February 2010
22	January 2010
9	December 2009
5	November 2009
3	October 2009
15	September 2009
20	August 2009
28	July 2009
10	June 2009
7	May 2009
9	April 2009
11	March 2009
15	February 2009
6	January 2009
7	December 2008
58	November 2008
5	October 2008
3	September 2008
9	August 2008
28	July 2008
5	June 2008
6	May 2008
49	April 2008
7	March 2008
8	February 2008
17	January 2008
6	December 2007
17	November 2007
12	October 2007
1	September 2007
28	August 2007
36	July 2007
11	June 2007
13	May 2007
14	April 2007
5	March 2007
41	February 2007
16	January 2007
5	December 2006
5	November 2006
11	October 2006
21	September 2006
11	August 2006
29	July 2006
19	June 2006
61	May 2006
25	April 2006
14	March 2006
60	February 2006
69	January 2006
77	December 2005
22	November 2005
81	October 2005
32	September 2005
10	August 2005
66	July 2005
43	June 2005
79	May 2005
80	April 2005
57	March 2005
13	February 2005
103	January 2005
77	December 2004
17	November 2004
17	October 2004
14	September 2004
23	August 2004
27	July 2004
27	June 2004
51	May 2004
35	April 2004
32	March 2004
26	February 2004
18	January 2004
12	December 2003
23	November 2003
61	October 2003
15	September 2003
6	August 2003
30	July 2003
21	June 2003
50	May 2003
49	April 2003
50	March 2003
49	February 2003
93	January 2003
32	December 2002
125	November 2002
151	October 2002
30	September 2002
29	August 2002
33	July 2002
26	June 2002
67	May 2002
78	April 2002
6	March 2002

Design

Zawodny | Right Menu | Left Menu | My CSS

Your Own Design

Paste the URL of your CSS below. Download CSS template