[PATCH] maint: force "make syntax-check" to pass by skipping failing tests

There are a few failing syntax-check tests.
For now, I propose to simply skip them.
If folks have time/desire to address the issues
or exempt the offending files, these tests can
easily be reenabled later.

I've just addressed the sole violation of the m4 quote check
in the 2nd patch below:

From bffa42b866e7d4b2d6257904679d77b905ab5fca Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Sat, 28 Jan 2012 17:11:43 +0100
Subject: [PATCH 1/2] maint: force "make syntax-check" to pass by skipping
 failing tests

* cfg.mk (local-checks-to-skip): Skip all currently-failing tests.
Remove changelog-check; it's long gone.
---
 cfg.mk |   24 ++++++++++++++++++------
 1 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 6b3deb9..2a4d711 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -33,12 +33,24 @@ url_dir_list = \
   ftp://$(gnu_rel_host)/gnu/bison

 # Tests not to run as part of "make distcheck".
-# Exclude changelog-check here so that there's less churn in ChangeLog

[PATCH] do not ignore errors like ENOSPC,EIO when writing to stdout

This is incomplete in that I haven't added a test for it
and haven't updated NEWS -- since its effect is limited,
I'm not sure it's worthy of a NEWS entry.

Before:

    $ bison --print-datadir > /dev/full
    $ bison --print-datadir >&-
    $

After:

    $ bison --print-datadir > /dev/full
    bison: write error: No space left on device
    [Exit 1]
    $ bison --print-datadir >&-
    bison: write error: Bad file descriptor
    [Exit 1]
    $

From 581dfdb383842aced19443db6f910fbd02736e23 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Sun, 29 Jan 2012 12:50:32 +0100
Subject: [PATCH] do not ignore errors like ENOSPC,EIO when writing to stdout

Standard output was never explicitly closed, so we could not
detect failure.  Thus, bison would ignore the errors of writing
to a full file system and getting an I/O error on write, but only
for standard output, e.g., for --print-localedir, --print-datadir,
--help and some verbose output.

[GNU Bison 2.5] testsuite: 247 failed on Solaris 10 on SPARC(sun4v)

Hi, I'm getting a "make check" failure on bison-2.5.
bison-2.4.3 doesn't have the problem.

OS:Solaris 10 on SPARC(sun4v)

I attach the testsuite.log and config.log.

-----
# uname -a
SunOS moore 5.10 Generic_147440-04 sun4v sparc SUNW,SPARC-Enterprise-T1000

# /usr/local/bin/gcc --version
gcc (GCC) 4.2.4
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

# make check
.....
Regression tests.

223: Trivial grammars                                ok
224: YYSTYPE typedef                                 ok
225: Early token definitions with --yacc             ok
226: Early token definitions without --yacc          ok
227: Braces parsing                                  ok
228: Duplicate string                                ok
229: Rule Line Numbers                               ok
230: Mixing %token styles                            ok
231: Invalid inputs                                  ok

[PATCH] build: generalize etc/prefix-gnulib-mk

I mentioned that I'm using etc/prefix-gnulib-mk also from
cppi, as an experiment.  In doing that, I had to factor out
at least the hard-coded "libbison" in etc/prefix-gnulib-mk.
It also hard-coded the "lib/" prefix and the file name,
${prefix}gnulib.mk.  I factored those out, too.

This is a no-semantic-change commit.

From 28d216d092f16914eff70fd66a1215e9c082ad49 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Sat, 21 Jan 2012 22:43:09 +0100
Subject: [PATCH] build: generalize etc/prefix-gnulib-mk

This script hard-coded "libbison" and lib/gnulib.mk.
Adjust the script to require a --lib-name=$gnulib_name option
and a FILE argument like lib/$gnulib_mk.
Also add support for --help and --version.
* etc/prefix-gnulib-mk: Generalize.
* bootstrap.conf (bootstrap_post_import_hook): Update its invocation.
---
 bootstrap.conf       |    2 +-
 etc/prefix-gnulib-mk |   76 +++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 73 insertions(+), 5 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index e47b550..599b778 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -66,7 +66,7 @@ gnulib_tool_option_extras='--symlink --makefile-name=gnulib.mk'
 bootstrap_post_import_hook()

[GNU Bison 2.4.3] testsuite: 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 53 54 55 56 57 58 59 60 61 failed

Greetings,
attempting to upgrade Bison:
it failed when performing testsuite - over the most tests for 'Output
file names'
And it skipped those for Java Calculator and Parameters

Operating System: Gentoo Linux

If you need further informations please tell me. (see attached files)
Note: as long as i'm not subscribed, you may reply with my contact on Cc

Salut,
Matias

[PATCH] maint: generate ChangeLog from git log

I pushed the preceding changes without ChangeLog entries
knowing that this change will ensure that their git log
entries will make it into the distribution tarball's ChangeLog file.

Please don't push a commit with a ChangeLog entry before this
commit is pushed.

From 098882421d873ce8035ba6f6dd69770528d80f01 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Thu, 19 Jan 2012 09:07:02 +0100
Subject: [PATCH] maint: generate ChangeLog from git log

* Makefile.am (gen-ChangeLog): New rule.
(dist-hook): Depend on it.
(EXTRA_DIST): Distribute the two ChangeLog-* files.
* bootstrap.conf (gnulib_modules): Add gitlog-to-changelog.
(bootstrap_post_import_hook): Ensure that ChangeLog exists.
* build-aux/git-log-fix: New file.
* ChangeLog-2012: Renamed ...
* ChangeLog: ... from this.
* ChangeLog-1998: Renamed ...
* OChangeLog: ...from this
* .gitignore: Add ChangeLog.
---
 .gitignore                   |    3 +--
 OChangeLog => ChangeLog-1998 |    0
 ChangeLog => ChangeLog-2012  |    0
 Makefile.am                  |   17 ++++++++++++++---
 bootstrap.conf               |    6 +++++-
 build-aux/.gitignore         |    3 +--

syntax-check, update bootstrap, update gnulib

Here's a heads-up, so no one wastes time duplicating the not-insignificant
effort of updating to both the latest bootstrap and the latest gnulib.
The ChangeLog entries of the later commits are not complete, but "make
distcheck" does pass.

I've left the update-gnulib commit separate from the two following ones
that first make "make check" pass, and then make quoting more consistent.
There are doubtless a few more places where quoting can be adjusted to
conform to the new style, but for now, I'll stop with this series.

On the other hand, "make syntax-check" has been failing for some time,
and the first few changes address some of those failures.

Joel, if you now agree to the use gitlog-to-changelog (with --no-clump),
let me know and I'll add it and adapt this series not to update the
ChangeLog file.

Oh, also, I'll refresh the "update to gnulib" commit to use
the latest, rather than what was the latest when I wrote that.

[01/11] doc: correct typo: s/can not/cannot/
[02/11] maint: get gpl-3.0 from gnulib
[03/11] maint: remove final trailing space
[04/11] maint: placate the space-TAB syntax-check
[05/11] maint: list djgpp/subpipe.c in po/POTFILES.in
[06/11] build: include <config.h> from lib/yyerror.c
[07/11] maint: include <config.h> first
[08/11] build: manually update bootstrap from gnulib, and
[09/11] build: update gnulib submodule to latest
[10/11] quote consistently and make tests pass with new

begin addressing "make syntax-check" failures

Here are some obviously uncontroversial changes
prompted by my running "make syntax-check".
I've gone ahead and pushed them.

From 1b7c95b4c582a20357fa5d70f7cf286012d835c0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Fri, 13 Jan 2012 10:18:26 +0100
Subject: [PATCH 1/3] maint: avoid "the the"

* djgpp/README.in: s/the the/the/
* src/parse-gram.c (lloc_default): Likewise.
* src/parse-gram.y (lloc_default): Likewise, and remove a
trailing space.
---
 ChangeLog        |    8 ++++++++
 djgpp/README.in  |    2 +-
 src/parse-gram.c |    2 +-
 src/parse-gram.y |    4 ++--
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c49741d..771aa3e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-01-13  Jim Meyering  <meyering <at> redhat.com>
+
+	maint: avoid "the the"
+	* djgpp/README.in: s/the the/the/
+	* src/parse-gram.c (lloc_default): Likewise.

[PATCH] build: avoid warning from coverity about lbitset_elt_find

Coverity complained about "Dereferencing "elt" before a null check",
here, since just prior it is always dereferenced.  Thus, it is
an unnecessary test.

On a related note, is there any objection to my running update-copyright
so that changes like these aren't polluted (and we're not prompted
to update copyright year numbers) by copyright year updates?

From 5a850177bd4dff350ca98eec1b54cabafd815d57 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Thu, 12 Jan 2012 14:52:26 +0100
Subject: [PATCH] build: avoid warning from coverity about lbitset_elt_find

* lib/lbitset.c (lbitset_elt_find): Remove unnecessary test of "elt",
at a point where we know it is non-NULL, due to prior dereference.

Copyright (C) 1987-1988, 1991-2012 Free Software Foundation,
---
 ChangeLog     |    8 +++++++-
 lib/lbitset.c |    5 ++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 234df12..cf63ace 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-01-12  Jim Meyering  <meyering <at> redhat.com>
+
+	build: avoid warning from coverity about lbitset_elt_find

Java parser throws ArrayIndexOutOfBoundsException if first token leads to syntax error

Hi,

given the attached grammar, the generated parser throws
java.lang.ArrayIndexOutOfBoundsException if the first token
leads to a syntax error:

| [tim <at> passepartout ~/src/bison-2.5]$ src/bison --version
| bison (GNU Bison) 2.5
| Written by Robert Corbett and Richard Stallman.

| Copyright (C) 2011 Free Software Foundation, Inc.
| This is free software; see the source for copying conditions.  There is NO
| warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
| [tim <at> passepartout ~/src/bison-2.5]$ BISON_PKGDATADIR=data src/bison java-test.y
| [tim <at> passepartout ~/src/bison-2.5]$ gcj -o java-test --main=YYParser java-test.java
| java-test.java:247: warning: The field YYParser.YYRETURN is never read locally
|         private static final int YYRETURN = 8;
|                                  ^^^^^^^^
| java-test.java:380: warning: The local variable yyresult is never read
|         int yyresult;
|             ^^^^^^^^
| java-test.java:745: warning: The field YYParser.yytoken_number_ is never read locally
|         yytoken_number_[] =
|         ^^^^^^^^^^^^^^^
| java-test.java:849: warning: The field YYParser.yynnts_ is never read locally
|         private static final int yynnts_ = 2;
|                                  ^^^^^^^
| java-test.java:853: warning: The field YYParser.yyerrcode_ is never read locally
|         private static final int yyerrcode_ = 256;
|                                  ^^^^^^^^^^

[PATCH] Small typo in src/scan-skel.l

Hi,

see subject line.

Tim

From 6a6d5d0218f613f8d1ed79063a60e091875a9c14 Mon Sep 17 00:00:00 2001
From: Tim Landscheidt <tim <at> tim-landscheidt.de>
Date: Sun, 8 Jan 2012 01:20:08 +0000
Subject: [PATCH] Fix small typo.

---
 src/scan-skel.l |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/scan-skel.l b/src/scan-skel.l
index a89e13c..eb3c90a 100644
--- a/src/scan-skel.l
+++ b/src/scan-skel.l
@@ -72,7 +72,7 @@ static void fail_for_invalid_at (char const *at);
 "@@" fputc ('@', yyout);
 "@{" fputc ('[', yyout);
 "@}" fputc (']', yyout);
-"@`" /* Emtpy.  Used by b4_cat in ../data/bison.m4.  */
+"@`" /* Empty.  Used by b4_cat in ../data/bison.m4.  */
 @\n  /* Likewise.  */

 "@oline@"  fprintf (yyout, "%d", out_lineno + 1);
--

--