I'd like to know if there are some rules that the project follows regarding how issues on bugzilla and pull requests on github are tied together. I assumed something like a "patch available" state along with a link to the github pull request or something similar. -- -- Cordially, Noufal http://nibrahim.net.in
Ehsan Akhgari <ehsan.akhgari@...> writes: [...] > That's not a stupid question at all! We usually don't grant bugzilla > permissions to edit a bug to new users, and we grant such permissions > (which we call "editbugs") to those who show interest in contributing > to the project. I just granted editbugs to your Bugzilla account, so > you should now be able to assign the bug to yourself! [...] Thank you Ehsan. It works now. -- -- Cordially, Noufal http://nibrahim.net.in
Erik Rose <erik@...> writes: > Don't let me stop you!Get a Bugzilla account if you don't already > have one, and assign a bug to yourself so we don't conflict. Kudos on > your initiative! At the risk of sounding stupid, how exactly do assign a bug to myself? I can't seem to find a way to do so in Bugzilla. [...] -- -- Cordially, Noufal http://nibrahim.net.in
I can see a few bugs relating to multiple trees on bugzilla (e.g. 850479). If it's something that's been nagging people, I can jump on them starting with the search scoping problem I noticed earlier. I'll file a new bug for that. -- -- Cordially, Noufal http://nibrahim.net.in
'ello everyone,
While working on https://github.com/mozilla/dxr/pull/130, I was
testing out multiple trees on dxr.
I have two trees. One called "code" (the default name in the
test directory) and another called "git".
After creating the indices and starting the web app, the initial dxr
page offers me a drop down from which I can select "code" or "git" and
an input field. After that, two links to browse code or git. These two
links work fine. My complaint is with the search behaviour.
If I select the "git" tree (which is not the default) and then
type something into the search field and hit enter, the URL called is
/code/search?tree=git&q=fish&redirect=true which searches the "code"
tree (rather than the selected "git") and then shows me a "no results"
page. This is, of course, wrong - there is a function called "fish" in
the git tree.
If however, I start to browse the "git" tree and then use the
search bar, the URL called out to is
/git/search?tree=git&q=fish&redirect=true
and this gives me the results I'm looking for.
This is the behaviour I see on master. It looks like a bug. I'm
willing to work on it but I'd like to know if someone else can replicate
this on their setup so that I can confirm that it's not a local issue.
Thanks.
(Continue reading)
In a really old and ancient version of dxr, one could configure it to pull in changes from version control as part of the build. Is that still in there somewhere and I'm not seeing it? -- -- Chris Cleeland
Has anybody done any testing on the DXR clang plugin with clang 3.3? It's currently in RC stage and it would be great if we can fix our plugin to work with 3.3 and ensure that there are no upstream bugs on the 3.3 release that would prevent us from switching to it when it's released. Thanks! Ehsan
I have a hankering to try to use dxr to evaluate a body of software for things like: 1. unused #include (i.e., stuff from that #include isn't ever used in that source file) 2. unnecessary #include (i.e., types from the #include could be used with a forward decl rather than full decl) 3. lazy #include (type used, but neither #include'd nor forward decl'd) Obviously, doing this requires that include files be tracked. Does dxr do that? If not, could it, i.e., does the plugin model for clang provide hooks for capturing that information, or is that all done too far upstream? -- -- Chris Cleeland
I think I've got a decent compromise. I'll do it and run a tiny instance on my server tomorrow (hopefully) for you folks to look at. Ehsan Akhgari <ehsan.akhgari@...> writes: > This looks great! CCing Erik. > > On 2013-05-07 3:17 PM, Noufal Ibrahim wrote: >> >> Hello everyone, >> I've taken a stab at bug-758628 and implemented it. I've not >> pushed the code yet but wanted some comments. >> >> I did a simple version that just displays the complete path to >> the file being browsed at the top. You can simply select it and paste it >> into a text editor or whatever. It looks something like this >> http://noufalibrahim.name/normal.png >> >> Then I tried to make the individual path components clickable >> like so http://noufalibrahim.name/clickable.png so that it's navigable >> similar to >> http://lxr.free-electrons.com/source/block/blk-cgroup.c. This is more >> navigable via. the browser but not as cut/paste able as required in the >> bug description. >> >> Any comments? >> >> Thanks. >>(Continue reading)
James Abbatiello <abbeyj@...> writes: > On Sun, May 5, 2013 at 12:36 PM, <noufal@...>wrote: > >> I think the documentation (README) is lacking in some respects. I've >> tried to add all the stuff I hit and put in a pull request. >> >> https://github.com/mozilla/dxr/pull/129 >> > > A few comments: > > Step 2 says to run "python setup.py develop". Step 3 says to set up a >virtualenv first, then to run "python setup.py develop". This a bit >confusing and anybody who doesn't read ahead isn't going to do this >properly. I'll clean this up. > Step 4: did running make from the top-level directory not > automatically build trilite for you? I never tried. I tried to follow the instructions in the README but didn't notice this there. I'll check and if it works, add it. > > Step 5: we should make it so that hacking the makefile is not >required. Why did you have to do this? I initially tried to compile this against llvm-3.1 and the config script(Continue reading)
Hello everyone,
I've taken a stab at bug-758628 and implemented it. I've not
pushed the code yet but wanted some comments.
I did a simple version that just displays the complete path to
the file being browsed at the top. You can simply select it and paste it
into a text editor or whatever. It looks something like this
http://noufalibrahim.name/normal.png
Then I tried to make the individual path components clickable
like so http://noufalibrahim.name/clickable.png so that it's navigable
similar to
http://lxr.free-electrons.com/source/block/blk-cgroup.c. This is more
navigable via. the browser but not as cut/paste able as required in the
bug description.
Any comments?
Thanks.
--
--
Cordially,
Noufal
http://nibrahim.net.in
RSS Feed30 | |
|---|---|
14 | |
3 | |
37 | |
20 | |
9 | |
13 | |
2 | |
4 | |
1 | |
8 | |
26 | |
22 | |
43 | |
32 | |
33 | |
6 | |
1 | |
12 | |
8 | |
3 | |
3 | |
11 | |
3 | |
4 | |
7 | |
8 | |
12 | |
2 | |
1 | |
13 | |
3 | |
2 | |
21 | |
4 | |
8 | |
12 | |
6 | |
11 | |
15 | |
25 | |
18 | |
36 | |
4 | |
2 | |
7 | |
17 | |
46 | |
4 | |
7 | |
16 | |
5 | |
23 | |
20 | |
19 |
