Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

> Hi,
> 
> attached is a patch with a bunch of fixes for NSBezierPath to make arcs being  
> displayed.
> With the patch arcs should now work in any direction and angle.
> I also added a few lines of discription which I found in the ghostscript code.

Thanks - I read your patch and it made lot of sense - so I applied it.  I
did not test it nor did I check on books the formula used to build the
bezier path for the last bit of the arc, so I hope you did. 

Ahm - just a quick note - before committing, I sligthly simplified the
formula used for F - not that I changed it (unless I made a typo) - just
did some trivial algebraic/trigonometric simplifications.  But as I didn't
test it, please tell me if I did something wrong.

> 2001-02-26 Georg Fleischmann
> 
> 	* gui/Source/NSBezierPath.m
> 	[NSBezierPath appendBezierPathWithArcWithCenter: ...]:
> 	several fixes to make it work

Re: Fix: XGGState, DPSarc and DPSarcn

Thanks - I applied your patch.

Re: --with-x-*

Juliusz Chroboczek wrote:
> 
> Configure ignores --with-x-includes and --with-x-libraries.  It still
> uses the standard locations, even if I point it at a different one.
> 
> Explanation: I'm running a system with a stable version of XFree86 in
> /usr/X11R6 and a locally-modefied current CVS in /usr/local/X11R6.
> I'd like to get GNUstep to use the current libraries instead of the
> stable ones.
> 

I fixed this.

Re: Win32 DLL's and libobjc (was: install make, libobjc, base on cygwin/mingw32)

I found some great great problem with libobjc. I tried to load a bundle with
NSBundle. On Windows it is a DLL. After debugging I found out, why my
program crashes:

- gnustep-base, objc-load.m, objc_load_module:

_objc_load_callback = objc_load_callback;

- libobjc, objc-api.h:
/*
** This is a hook which is called by __objc_exec_class every time a class
** or a category is loaded into the runtime.  This may e.g. help a
** dynamic loader determine the classes that have been loaded when
** an object file is dynamically linked in.
*/
extern void (*_objc_load_callback)(Class class, Category* category);

When libobjc is a DLL and gnustep-base is a DLL, this assignment in
objc-load.m causes the program to abort immediately. I don't know if there
is any possibility to make _objc_load_callback changeable from another DLL.
I used following hack for this specific situation, but I think there are
more of those hooks.

- gnustep-base, objc-load.m, objc_load_module:

Instead of assignment:
__objc_set_load_callback(objc_load_callback);
And later:
__objc_set_load_callback(0);

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

Hi Nicola,

> Thanks - I read your patch and it made lot of sense - so I applied it.  I
> did not test it nor did I check on books the formula used to build the
> bezier path for the last bit of the arc, so I hope you did. 

Yes, I have tested it.
Anyway, I had to realized another little problem in the same method, so since  
it isn't committed yet, I will send a new patch covering this remaining issue  
too.

> Ahm - just a quick note - before committing, I sligthly simplified the
> formula used for F - not that I changed it (unless I made a typo) - just
> did some trivial algebraic/trigonometric simplifications.  But as I didn't
> test it, please tell me if I did something wrong.

Can you send me your changes, so I can test it ?
Or did I miss something ?

Thanks,
Georg

Re: Fix: NSBezierPath, appendBezierPathWithArcWithCenter:

> Hi Nicola,
> 
> > Thanks - I read your patch and it made lot of sense - so I applied it.  I
> > did not test it nor did I check on books the formula used to build the
> > bezier path for the last bit of the arc, so I hope you did. 
> 
> Yes, I have tested it.
> Anyway, I had to realized another little problem in the same method, so since  
> it isn't committed yet, I will send a new patch covering this remaining issue  
> too.

Well - I already committed your patch, anyway we enjoy further patches. 
 

 
> > Ahm - just a quick note - before committing, I sligthly simplified the
> > formula used for F - not that I changed it (unless I made a typo) - just
> > did some trivial algebraic/trigonometric simplifications.  But as I didn't
> > test it, please tell me if I did something wrong.
> 
> Can you send me your changes, so I can test it ?

They should be on CVS already - anyway in case you don't have CVS or
whatever, in attach you find the diff against the original sources (not
against your patch).

Index: NSBezierPath.m

[Resend]

[Resend]  Was Not Able To Take Last Entry..  Please Fill Out Again.

Hey... We Haven't Talked In So Long!!  How Have You Been?
Thought I would Forward you this email!

I usually delete these but I opened this one, like what I saw, 
and thought you would like to see this.

http://www.geocities.com/newest8989/

IF THE LINK IS NOT HIGHLIGHTED OR YOU CANNOT CLICK ON IT.
COPY AND PASTE IT IN YOUR BROWSER.

problem in [NSFileManager fileSystemRepresentationWithPath] on mingw32/cygwin

e.g. path="/usr/GNUstep/System/Library"

  else if (c_path[0] == '/')
    {
      NSDictionary  *env;
      env = [[NSProcessInfo processInfo] environment];
      if ([env objectForKey:  <at> "CYGWIN"])
        {
          /* FIXME: Find cygwin drive? */
          newpath =  <at> "c:/cygwin";
          newpath = [newpath stringByAppendingPathComponent: path];
          newpath = [newpath stringByReplacingString:  <at> "/" withString:
 <at> "\\"];
        }
    }

I don't have an environment variable named CYGWIN in my CYGWIN bash! Even if
I would export it, my cygwin dir is e:/cygwin. I suggest to export
CYGWIN_HOME as home directory for cygwin:

  else if (c_path[0] == '/')
    {
      NSDictionary  *env;
      NSString      *cyghome;
      env = [[NSProcessInfo processInfo] environment];

      cyghome = [env objectForKey:  <at> "CYGWIN_HOME"];
      if (cyghome)
        {
          /* FIXME: Find cygwin drive? */

bug in NSUser.m:NSHomeDirectoryForUser() on mingw32

HOMEPATH only delivers path without drive. The correct "path" is HOMEDRIVE +
HOMEPATH.

  /* Then environment variable HOMEPATH holds the home directory
     for the user on Windows NT; Win95 has no concept of home. */
  char buf[1024], *nb;
  DWORD n;
  NSString *s;

  [gnustep_global_lock lock];
  n = GetEnvironmentVariable("HOMEPATH", buf, 1024);
  if (n > 1024)
    {
      /* Buffer not big enough, so dynamically allocate it */
      nb = (char *)NSZoneMalloc(NSDefaultMallocZone(), sizeof(char)*(n+1));
      n = GetEnvironmentVariable("HOMEPATH", nb, n+1);
      nb[n] = '\0';
      s = [NSString stringWithCString: nb];
      NSZoneFree(NSDefaultMallocZone(), nb);
    }
  else if (n > 0)
    {
      /* null terminate it and return the string */
      buf[n] = '\0';
      s = [NSString stringWithCString: buf];
    }
  else
    s = nil;

  /* BUGFIX begins here (suggestion): */

xgps configure.in patch for wraster

Seems a recent change to configure.in broke wraster support (causing
font_cacher to fail the link with undefined reference to RLoadImage, because
the X check is erasing GRAPHIC_xxx). Attached is a patch to fix this (I fixed
it here by moving the X check to be done first).

-- 
| Jeff Teunissen - Pres., Dusk To Dawn Computing - deek at dusknet.dhs.org
| GPG: 1024D/9840105A   7102 808A 7733 C2F3 097B  161B 9222 DAB8 9840 105A
| Core developer, The QuakeForge Project        http://www.quakeforge.net/
| Specializing in Debian GNU/Linux           http://dusknet.dhs.org/~deek/

Index: configure.in
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/xgps/configure.in,v
retrieving revision 1.5
diff -u -r1.5 configure.in
--- configure.in	2001/03/01 03:44:31	1.5
+++ configure.in	2001/03/03 06:22:03
 <at>  <at>  -32,64 +32,15  <at>  <at> 
 AC_PATH_X

 #--------------------------------------------------------------------
-# Look for WindowMaker's wraster library
-#--------------------------------------------------------------------
-SYSTEM_DEFS=
-AC_ARG_WITH(wraster, 
-           [  --with-wraster=PREFIX wraster directory prefix])
-if test "x$with_wraster" = "x"; then
- wprefix=""
-else