1 Nov 01:07
Re: [system] Problem with error_code.hpp dependency on winerror.h
Christopher Kohlhoff <chris <at> kohlhoff.com>
2007-11-01 00:07:03 GMT
2007-11-01 00:07:03 GMT
On Wed, 31 Oct 2007 19:50:04 -0400, "Beman Dawes" <bdawes <at> acm.org> said: > Emil Dotchevski wrote: > > Perhaps the enum should be placed in a platform-specific header, for > > example "boost/system/windows/error_code.hpp"? ... > I'll go ahead and put in the BOOST_SYSTEM_NO_ENUM #ifndef. That will at > least allow users to avoid the system-specific enums if they wish. But > the enums provide a really nice facility for dealing with > system-specific errors, so I don't recommend using BOOST_SYSTEM_NO_ENUM > except in unusual circumstances. I find the suggestion of separate header files a nice idea. We can restrict system/error_code.hpp to only those interfaces specified for C++0x, and have a header file for each of the OS-specific namespaces (with the same name as the namespace for convenience), i.e. system/windows_error.hpp, system/linux_error.hpp, system/cygwin_error.hpp, and so on. Developers have to use the OS-specific namespace qualification to refer to those error codes anyway, so it doesn't seem like much extra burden to include the additional header file. Cheers, Chris _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
After closer examination, it turned out to be a typo in
interprocess_recursive_mutex.hpp -- see patch below.
Ok to commit?
Index: posix/interprocess_recursive_mutex.hpp
===================================================================
--- posix/interprocess_recursive_mutex.hpp (revision 40632)
+++ posix/interprocess_recursive_mutex.hpp (working copy)
@@ -112,7 +112,7 @@
int res = 0;
res = pthread_mutex_lock(&m_mut);
if(res != 0){
- throw inteprocess_exception(system_error_code());
+ throw interprocess_exception(system_error_code());
}
assert(res == 0);
Thanks,
Boris
----- Original Message -----
From: "Ion Gaztañaga" <igaztanaga <at> gmail.com>
To: <boost <at> lists.boost.org>
Sent: Wednesday, October 31, 2007 11:15 AM
Subject: Re: [boost] [interprocess] inteprocess_exception is not defined
>
> Developers, now is a great time to clear your outstanding patches!
IMO, promising patches that are merely new features that haven't been
in testing for some time should be assigned to the 1.36.0 milestone
rather than "cleared" by either integrating them or rejecting them.
Patches should only be a high priority if they fix bugs... and in that
case they should come with a test that breaks until the bug is fixed.
RSS Feed