[boost] [Polynomial] Review Result
John Maddock <john <at> johnmaddock.co.uk>
2009-04-09 16:19:17 GMT
Apologies for the delay in putting this together...
First off I'd like to thank the author for submitting this for review
- I wish all our SOC students were similarly diligent! 
We received a number of reviews of this library, but none were in
favor of acceptance in its current form, and most thought that there
was still a fair bit of work to do to get the library into shape.
However, most thought that the library could be accepted into Boost
given sufficient changes/enhancements.
Therefore the library is not accepted into Boost at this time, but I
would like to encourage the author to continue to work on the library
and resubmit at a future time.
In no particular order the main review comments are summarized below:
Principal comments:
* Documentation, especially the background is inadequate and needs a
good proofreading
a) From the examples are nothing that a competent programmer couldn't
figure out from the declarations. Some more interesting or useful
examples would be nice, particularly for things like the special forms.
It's not exactly clear what I would do with those functions.
b) There is no documentation or references to the various algorithms
used. Those, too, would be nice.
c) Doc.html appear to have been created 'the Hard Way'. Would be much
more useful and look nicer if produced with the Quickbook, Doxygen...
toolchain. And make it maintainable by other people.
(Continue reading)
RSS Feed