headers
Michael G Schwern | 2 Jun 2005 04:28
Picon
Favicon
Gravatar

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency

On Sun, May 29, 2005 at 06:00:51PM +0200, demerphq wrote:
> At a bare minimum M::B needs to have a prerequisite on a version of
> File::Spec late enough not to have a broken abs2rel().

FWIW  MakeMaker avoids using abs2rel() entirely (except when building in the
core when we can rely on having a working File::Spec).  MakeMaker needs
only File::Spec 0.8.

There's only two uses of abs2rel() in Module::Build.  Maybe they can be
eliminated.

--

-- 
Michael G Schwern     schwern <at> pobox.com     http://www.pobox.com/~schwern
Don't try the paranormal until you know what's normal.
	-- "Lords and Ladies" by Terry Prachett

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 0 comments |
headers
Ken Williams | 2 Jun 2005 06:12
Favicon

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency

Hi Yves,

I left a couple of your original points unaddressed.

On May 27, 2005, at 8:55 AM, demerphq wrote:

> Look into why, get totally horrified by all the hard coded references
> to File::Spec::Unix in Module::Build::Base.

All those File::Spec::Unix references are in htmlify_pods(), and I 
honestly have no idea why they're there.  I accepted that entire code 
block as a patch from someone.  On quick inspection, it looks like I 
can just remove the ::Unix parts, but it might be that Pod::Html itself 
can only deal with Unix-style paths.

Actually, the final File::Spec::Unix should just be a join('/', ...), 
since it's creating a URL, not a file spec.

> Try to upgrade F::S. It blows up totally while trying to compile
> Cwd.xs, discover that the tainting code in "Perl_getcwd_sv" breaks the
> routine as it conditional sticks a statement in from of a bunch of
> variable declarations, which is illegal. (I wonder why its doing
>
>   #define getcwd_sv(a) Perl_getcwd_sv(aTHX_ a)
>   int Perl_getcwd_sv(pTHX_ register SV *sv)
>
> internally. This makes no sense to me. Whats with the define and Perl
> prefix in a routine not in the core?!)

Cwd was always distributed only in the core until I sucked it out and
(Continue reading)

Permalink | Reply | 7 comments |
headers
Michael G Schwern | 2 Jun 2005 07:54
Picon
Favicon
Gravatar

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency

On Wed, Jun 01, 2005 at 11:12:45PM -0500, Ken Williams wrote:
> >Fix Cwd.xs to function properly while wondering loudly why this module
> >was released without testing it on 5.6. (when I release
> >Data::Dump::Streamer i test it on at least every 5.6.x and every
> >5.8.x, why is a critical module like Cwd not tested equivelently!?
> 
> Whoa there - I absolutely *do* test it on 5.6, but the problem exists 
> on some platforms and not others (related to whether the platforms 
> define the getcwd() C library function).  What I don't have is some 
> kind of compile farm to test it out on various combinations of 
> platforms & perl versions before I release it.  If you know of such a 
> farm, please let me know.  It would be very handy.

SourceForge has a compile farm and there's the handy www.testdrive.hp.com.

--

-- 
Michael G Schwern     schwern <at> pobox.com     http://www.pobox.com/~schwern
You are wicked and wrong to have broken inside and peeked at the
implementation and then relied upon it.
	-- tchrist in <31832.969261130 <at> chthon>

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 2 comments |
headers
Randy Kobes | 2 Jun 2005 07:54
Picon
Favicon

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency

On Wed, 1 Jun 2005, Ken Williams wrote:

> Hi Yves,
>
> I left a couple of your original points unaddressed.
>
> On May 27, 2005, at 8:55 AM, demerphq wrote:
>
> > Look into why, get totally horrified by all the hard
> > coded references to File::Spec::Unix in
> > Module::Build::Base.
>
> All those File::Spec::Unix references are in
> htmlify_pods(), and I honestly have no idea why they're
> there.  I accepted that entire code block as a patch from
> someone.  On quick inspection, it looks like I can just
> remove the ::Unix parts, but it might be that Pod::Html
> itself can only deal with Unix-style paths.
>
> Actually, the final File::Spec::Unix should just be a
> join('/', ...), since it's creating a URL, not a file
> spec.

If I remember correctly, part of the reason for using
File::Spec::Unix was indeed for Pod::Html, and also for
creating portable pages that have '/' as the directory
separator in links.

--

-- 
best regards,
(Continue reading)

Permalink | Reply | 0 comments |
headers
demerphq | 2 Jun 2005 08:44
Picon

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency

On 6/2/05, Ken Williams <ken <at> mathforum.org> wrote:
> Hi Yves,
> 
> I left a couple of your original points unaddressed.
> 
> 
> On May 27, 2005, at 8:55 AM, demerphq wrote:
> 
> > Look into why, get totally horrified by all the hard coded references
> > to File::Spec::Unix in Module::Build::Base.
> 
> All those File::Spec::Unix references are in htmlify_pods(), and I
> honestly have no idea why they're there.  I accepted that entire code
> block as a patch from someone.  On quick inspection, it looks like I
> can just remove the ::Unix parts, but it might be that Pod::Html itself
> can only deal with Unix-style paths.
> 
> Actually, the final File::Spec::Unix should just be a join('/', ...),
> since it's creating a URL, not a file spec.

Im not sure that you can remove the Unix parts.... I think that it
fails a bunch of things if you do.

IMO the simplest thing to do is to define a var with File::Spec::Unix
in it and then comment that var. That way folks from other OS'es dont
get very confused (as I did) about why its there.

> 
> > Try to upgrade F::S. It blows up totally while trying to compile
> > Cwd.xs, discover that the tainting code in "Perl_getcwd_sv" breaks the
(Continue reading)

Permalink | Reply | 2 comments |
headers
Ken Williams | 2 Jun 2005 14:34
Favicon

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency


On Jun 2, 2005, at 12:54 AM, Michael G Schwern wrote:
>
> SourceForge has a compile farm and there's the handy 
> www.testdrive.hp.com.

Have you been able to use testdrive consistently?  I signed up for an 
account but I have lots of access problems (FTP timeouts, rejected 
access, etc.).

  -Ken

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 1 comment |
headers
Ken Williams | 2 Jun 2005 14:48
Favicon

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency


On Jun 2, 2005, at 1:44 AM, demerphq wrote:

> On 6/2/05, Ken Williams <ken <at> mathforum.org> wrote:
>> All those File::Spec::Unix references are in htmlify_pods(), and I
>> honestly have no idea why they're there.  I accepted that entire code
>> block as a patch from someone.  On quick inspection, it looks like I
>> can just remove the ::Unix parts, but it might be that Pod::Html 
>> itself
>> can only deal with Unix-style paths.
>>
>> Actually, the final File::Spec::Unix should just be a join('/', ...),
>> since it's creating a URL, not a file spec.
>
> Im not sure that you can remove the Unix parts.... I think that it
> fails a bunch of things if you do.

There were five cases of File::Spec::Unix-ism.  In two of the cases, 
the code creates a directory using the constructed pathname, so it 
really needs to be local syntax.  In two more of the cases, it's 
passing the pathnames to Pod::Html as 'infile' and 'outfile' 
parameters, so they need to be local syntax too.  The remaining case is 
constructing an URL, so that should just be join('/',...).

If Pod::Html chokes on that input, we need to fix Pod::Html or find a 
better workaround.

> Well, IMO its better to go the other way. make a define that maps to
> the real Perl_get_cwd_sv() or the Pathtools_get_cwd_sv() as needed.
> The Perl prefix should be dopped. Nothing is going to link to this
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michael G Schwern | 2 Jun 2005 20:57
Picon
Favicon
Gravatar

Re: [Module::Build] M::B v0.26 and v0.27_01Install fails on Perl 5.6 on with Win2k because of Pathtools dependency

On Thu, Jun 02, 2005 at 07:34:25AM -0500, Ken Williams wrote:
> >SourceForge has a compile farm and there's the handy 
> >www.testdrive.hp.com.
> 
> Have you been able to use testdrive consistently?  I signed up for an 
> account but I have lots of access problems (FTP timeouts, rejected 
> access, etc.).

Yes, though I generally only use one machine.  When there are problems I
email the testdrive folks and they have been responsive.

--

-- 
Michael G Schwern     schwern <at> pobox.com     http://www.pobox.com/~schwern
You are wicked and wrong to have broken inside and peeked at the
implementation and then relied upon it.
	-- tchrist in <31832.969261130 <at> chthon>

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 0 comments |
headers
Yitzchak Scott-Thoennes | 2 Jun 2005 21:37
Favicon
Gravatar

Re: [Module::Build] PREFIX-like support

On Fri, May 27, 2005 at 02:40:21PM -0700, Michael G Schwern wrote:
> On Fri, May 27, 2005 at 02:22:38PM -0400, Rob Kinyon wrote:
> > On 5/25/05, Michael G Schwern <schwern <at> pobox.com> wrote:
> > > On Tue, May 24, 2005 at 10:19:18PM -0400, Rob Kinyon wrote:
> > > > Two files attached. One is MB.patch and the other is destinations.t
> > > 
> > > I've only glanced at it but this seems really too simple to be
> > > prefixification.  I'll look further.
> > 
> > Any progress? Did I royally screw something up?
> 
> Not sure.  There's a lot of stuff missing that might not be necessary
> in Module::Build.  Here's the list I'm investigating.

Does it look good enough to warrant a (development) release with the
patch so people can try it out while you finish your investigation?

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 1 comment |
headers
Michael G Schwern | 2 Jun 2005 21:37
Picon
Favicon
Gravatar

Re: [Module::Build] PREFIX-like support

On Thu, Jun 02, 2005 at 12:37:10PM -0700, Yitzchak Scott-Thoennes wrote:
> > Not sure.  There's a lot of stuff missing that might not be necessary
> > in Module::Build.  Here's the list I'm investigating.
> 
> Does it look good enough to warrant a (development) release with the
> patch so people can try it out while you finish your investigation?

No.  It would at least have to handle all three directory types for that.

--

-- 
Michael G Schwern     schwern <at> pobox.com     http://www.pobox.com/~schwern
Reality is that which, when you stop believing in it, doesn't go away.
	-- Phillip K. Dick

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 0 comments |

Gmane