headers
Sven Panne | 1 Apr 2005 09:01
Picon

Re: cvs commit: fptools/ghc/includes Block.h Bytecodes.h ClosureMacros.h ClosureTypes.h Closures.h Cmm.h Constants.h GranSim.h Hooks.h HsFFI.h InfoTables.h Linker.h MachRegs.h Makefile Parallel.h README Regs.h RtsExternal.h RtsFlags.h ...

Simon Marlow wrote:
> Actually I would have gone the other way and converted them all to //.
> I rather like //, especially since /*...*/ doesn't nest properly.  The
> coding style document (in the commentary) also mentions that the use of
> // is encouraged. [...]

Hmmm, I wasn't aware about that style issue, sorry. But anyway, code like

    #if BLAH
    ...
    #endif // BLAH

simply doesn't work with all CPPs, one has to use /* */ here to avoid
compatibility issues.

Cheers,
    S.
Permalink | Reply | 0 comments |
headers
Simon Marlow | 1 Apr 2005 10:25
Picon
Favicon

RE: cvs commit: fptools/ghc/includes Block.h Bytecodes.h ClosureMacros.h ClosureTypes.h Closures.h Cmm.h Constants.h GranSim.h Hooks.h HsFFI.h InfoTables.h Linker.h MachRegs.h Makefile Parallel.h README Regs.h RtsExternal.h RtsFlags.h ...

On 01 April 2005 08:02, Sven Panne wrote:

> Simon Marlow wrote:
>> Actually I would have gone the other way and converted them all to
>> //. I rather like //, especially since /*...*/ doesn't nest
>> properly.  The coding style document (in the commentary) also
>> mentions that the use of // is encouraged. [...]
> 
> Hmmm, I wasn't aware about that style issue, sorry. But anyway, code
> like 
> 
>     #if BLAH
>     ...
>     #endif // BLAH
> 
> simply doesn't work with all CPPs, one has to use /* */ here to avoid
> compatibility issues.

That's probably something we ought to mention in the coding style doc
then - would you mind adding a wee note?

Cheers,
	Simon
Permalink | Reply | 0 comments |
headers
Ross Paterson | 1 Apr 2005 15:21
Favicon

cvs commit: fptools/libraries/Cabal/Distribution PreProcess.hs

ross        2005/04/01 05:21:01 PST

  Modified files:        (Branch: ghc-6-4-branch)
    libraries/Cabal/Distribution PreProcess.hs 
  Log:
  merge rev. 1.31

  Revision  Changes    Path
  1.23.2.8  +1 -1      fptools/libraries/Cabal/Distribution/PreProcess.hs
Permalink | Reply | 0 comments |
headers
Don Stewart | 2 Apr 2005 06:39
Favicon

cvs commit: fptools/libraries/base/GHC ForeignPtr.hs

dons        2005/04/01 20:39:36 PST

  Modified files:
    libraries/base/GHC   ForeignPtr.hs 
  Log:
  Typo in comment only:
  	"Causes a the finalizers associated with a foreign pointer..."
  to
  	"Causes the finalizers associated with a foreign pointer..."

  Revision  Changes    Path
  1.20      +1 -1      fptools/libraries/base/GHC/ForeignPtr.hs
Permalink | Reply | 0 comments |
headers
Simon Marlow | 4 Apr 2005 10:02
Favicon

cvs commit: fptools/libraries/base/Control/Monad ST.hs

simonmar    2005/04/04 01:02:53 PDT

  Modified files:
    libraries/base/Control/Monad ST.hs 
  Log:
  doc fix

  Revision  Changes    Path
  1.20      +1 -1      fptools/libraries/base/Control/Monad/ST.hs
Permalink | Reply | 0 comments |
headers
Simon Peyton Jones | 4 Apr 2005 12:23
Favicon

cvs commit: fptools/libraries/template-haskell/Language/Haskell/TH Ppr.hs

simonpj     2005/04/04 03:23:03 PDT

  Modified files:
    libraries/template-haskell/Language/Haskell/TH Ppr.hs 
  Log:
  Indent where clauses

  Revision  Changes    Path
  1.7       +1 -1      fptools/libraries/template-haskell/Language/Haskell/TH/Ppr.hs
Permalink | Reply | 0 comments |
headers
Simon Peyton Jones | 4 Apr 2005 14:08
Favicon

cvs commit: fptools/libraries/template-haskell/Language/Haskell/TH Lib.hs

simonpj     2005/04/04 05:08:27 PDT

  Modified files:
    libraries/template-haskell/Language/Haskell/TH Lib.hs 
  Log:
  Match changes in DsMeta

  Revision  Changes    Path
  1.8       +4 -4      fptools/libraries/template-haskell/Language/Haskell/TH/Lib.hs
Permalink | Reply | 0 comments |
headers
Simon Peyton Jones | 4 Apr 2005 14:16
Favicon

cvs commit: fptools/libraries/base/GHC Arr.lhs

simonpj     2005/04/04 05:16:45 PDT

  Modified files:
    libraries/base/GHC   Arr.lhs 
  Log:
  Default method for unsafeRangeSize should use unsafeIndex!

  Revision  Changes    Path
  1.15      +1 -1      fptools/libraries/base/GHC/Arr.lhs
Permalink | Reply | 0 comments |
headers
Malcolm Wallace | 4 Apr 2005 15:13
Favicon

cvs commit: fptools/libraries Makefile.common

malcolm     2005/04/04 06:13:23 PDT

  Modified files:
    libraries            Makefile.common 
  Log:
  wibble.

  Revision  Changes    Path
  1.20      +1 -1      fptools/libraries/Makefile.common
Permalink | Reply | 0 comments |
headers
Simon Marlow | 5 Apr 2005 10:38
Favicon

cvs commit: fptools/libraries/base/include HsBase.h fptools/libraries/base/System/Process Internals.hs

simonmar    2005/04/05 01:38:24 PDT

  Modified files:
    libraries/base/include HsBase.h 
    libraries/base/System/Process Internals.hs 
  Log:
  Determine the location of CMD.EXE (or COMMAND.COM) using the same
  algorithm as system() from msvcrt.

  Revision  Changes    Path
  1.71      +4 -0      fptools/libraries/base/include/HsBase.h
  1.11      +46 -7     fptools/libraries/base/System/Process/Internals.hs
Permalink | Reply | 0 comments |

Gmane