[groovy-dev] Missing package declaration in many unit tests

Hi,

in dir groovy-core/src/test/groovy and subdirs, most (but not all) 
groovy unit tests don't have a package declaration. This causes the 
Groovy plugin to complain about "Invalid package declaration".

Russel said yesterday in the user mailing list that a discussion already 
took place for some time about that. As I can't find it, I have to start 
the discussion again.

I think that all unit tests should have a package declaration. First 
this is the "normal java way" to organize classes and second (and 
therefore) it would allow the Groovy Eclipse Plugin to work correctly 
with the Groovy source code.

Additional remark: shouldn't the Groovy compiler complain about this 
failing package declaration too? This would surely allow to find some 
errors earlier.

Any comments?

Marc.

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Re: [groovy-dev] Missing package declaration in many unit tests

Go ahead and fix the packages 

On 2/1/07, Marc Guillemot <mguillemot@...> wrote:
> Hi,
>
> in dir groovy-core/src/test/groovy and subdirs, most (but not all)
> groovy unit tests don't have a package declaration. This causes the
> Groovy plugin to complain about "Invalid package declaration".
>
> Russel said yesterday in the user mailing list that a discussion already
> took place for some time about that. As I can't find it, I have to start
> the discussion again.
>
> I think that all unit tests should have a package declaration. First
> this is the "normal java way" to organize classes and second (and
> therefore) it would allow the Groovy Eclipse Plugin to work correctly
> with the Groovy source code.
>
> Additional remark: shouldn't the Groovy compiler complain about this
> failing package declaration too? This would surely allow to find some
> errors earlier.
>
> Any comments?
>
> Marc.
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>     http://xircles.codehaus.org/manage_email

[groovy-dev] Dark Corners of the Groovy Syntax - Decisions Made in Paris

Re: [groovy-dev] Missing package declaration in many unit tests

Marc Guillemot schrieb:
[...]
> Additional remark: shouldn't the Groovy compiler complain about this 
> failing package declaration too? This would surely allow to find some 
> errors earlier.

the package directory structure is only important for finding an source 
file. I remember that at last older versions of javac do not complain 
about having the source files in the same directory with different 
packages. As long as you give the compiler all needed source files, 
there won't be really a probelem. And for the groovy compiler... the 
compiler may not know the origin of the source, it is just a InputStream 
for the compiler.

bye blackdrag

--

-- 
Jochen "blackdrag" Theodorou
Groovy Tech Lead (http://groovy.codehaus.org)
http://blackdragsview.blogspot.com/

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Re: [groovy-dev] JIRA client

I tried (just once) to setup access to JIRA through mylar without success. Could you post a quick step-by-step?

Scott

----- Original Message ----
From: Edward Povazan <epovazan@...>
To: dev@...s.org
Sent: Wednesday, January 31, 2007 12:56:07 PM
Subject: Re: [groovy-dev] JIRA client

Interesting. For the Eclipse users among us, I have been playing with  
Mylar in Eclipse, and have connected and retrieved issues assigned to  
me from JIRA. I also created a new issue. I have only started using  
Mylar so I don't know much more, though it is a nice tool in many  
other ways.

-Ed

On 31-Jan-07, at 1:03 AM, Guillaume Laforge wrote:

> Hi,
>
> It seems that some progress has been made on a JIRA desktop client:
> http://www.theserverside.com/news/thread.tss?thread_id=44045
>
> This tool offers a nice client interface over JIRA.
> And they also seem to provide a special license for OSS projects:
> http://almworks.com/opensource.html?product=jiraclient
>
> Look at some of the screenshots here:
> http://almworks.com/jiraclient/screenshots.html
>
> We might probably ask for an OSS license?
>
> -- 
> Guillaume Laforge
> Groovy Project Manager
> http://glaforge.free.fr/blog/groovy
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>    http://xircles.codehaus.org/manage_email
>

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

[groovy-dev] Date and Time support in Groovy 1.1

At the Paris meeting we discussed moving the work I have started on  
Date and Duration support into the main development tree for release  
as part of Groovy 1.1.

I would propose the following process.

I move the code and unit test into the SVN Trunk "as is" (i.e. there  
are some  classes in the new package groovy.time and a class that  
goes in org.codehaus.groovy.runtime)

At this point the functionality is only available via a category.

I tidy up the code a bit and improve the test coverage.

I then move the methods from the category into DGM and add a page to  
the wiki describing the functionality(probably two weeks from now)

Users then do usability tests and we resolve issues like the  
treatment of java.sql.Date.

Comments?

John Wilson
The Wilson Partnership
web http://www.wilson.co.uk
blog http://eek.ook.org

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

RE: [groovy-dev] Date and Time support in Groovy 1.1

perfectly reasonable

Dierk

> -----Original Message-----
> From: John Wilson [mailto:tug@...]
> Sent: Donnerstag, 1. Februar 2007 16:33
> To: Groovy Developers
> Subject: [groovy-dev] Date and Time support in Groovy 1.1
> 
> 
> At the Paris meeting we discussed moving the work I have started on  
> Date and Duration support into the main development tree for release  
> as part of Groovy 1.1.
> 
> I would propose the following process.
> 
> I move the code and unit test into the SVN Trunk "as is" (i.e. there  
> are some  classes in the new package groovy.time and a class that  
> goes in org.codehaus.groovy.runtime)
> 
> At this point the functionality is only available via a category.
> 
> I tidy up the code a bit and improve the test coverage.
> 
> I then move the methods from the category into DGM and add a page to  
> the wiki describing the functionality(probably two weeks from now)
> 
> Users then do usability tests and we resolve issues like the  
> treatment of java.sql.Date.
> 
> Comments?
> 
> 
> 
> John Wilson
> The Wilson Partnership
> web http://www.wilson.co.uk
> blog http://eek.ook.org
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
> 
>     http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Re: [groovy-dev] Date and Time support in Groovy 1.1

Re: [groovy-dev] JIRA client

I'm not going to speak about Mylar, but at least, I'll mention that I
tried the JIRA client I mentioned successfully with the Groovy
project, and that I have a license I can share for those interested.

On 2/1/07, Scott Hickey <jshickey@...> wrote:
> I tried (just once) to setup access to JIRA through mylar without success. Could you post a quick step-by-step?
>
> Scott
>
> ----- Original Message ----
> From: Edward Povazan <epovazan@...>
> To: dev@...
> Sent: Wednesday, January 31, 2007 12:56:07 PM
> Subject: Re: [groovy-dev] JIRA client
>
> Interesting. For the Eclipse users among us, I have been playing with
> Mylar in Eclipse, and have connected and retrieved issues assigned to
> me from JIRA. I also created a new issue. I have only started using
> Mylar so I don't know much more, though it is a nice tool in many
> other ways.
>
> -Ed
>
> On 31-Jan-07, at 1:03 AM, Guillaume Laforge wrote:
>
> > Hi,
> >
> > It seems that some progress has been made on a JIRA desktop client:
> > http://www.theserverside.com/news/thread.tss?thread_id=44045
> >
> > This tool offers a nice client interface over JIRA.
> > And they also seem to provide a special license for OSS projects:
> > http://almworks.com/opensource.html?product=jiraclient
> >
> > Look at some of the screenshots here:
> > http://almworks.com/jiraclient/screenshots.html
> >
> > We might probably ask for an OSS license?
> >
> > --
> > Guillaume Laforge
> > Groovy Project Manager
> > http://glaforge.free.fr/blog/groovy
> >
> > ---------------------------------------------------------------------
> > To unsubscribe from this list please visit:
> >
> >    http://xircles.codehaus.org/manage_email
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>     http://xircles.codehaus.org/manage_email
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>     http://xircles.codehaus.org/manage_email
>
>

--

-- 
Guillaume Laforge
Groovy Project Manager
http://glaforge.free.fr/blog/groovy

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Re: [groovy-dev] Date and Time support in Groovy 1.1

Go ahead 

On 2/1/07, John Wilson <tug@...> wrote:
> At the Paris meeting we discussed moving the work I have started on
> Date and Duration support into the main development tree for release
> as part of Groovy 1.1.
>
> I would propose the following process.
>
> I move the code and unit test into the SVN Trunk "as is" (i.e. there
> are some  classes in the new package groovy.time and a class that
> goes in org.codehaus.groovy.runtime)
>
> At this point the functionality is only available via a category.
>
> I tidy up the code a bit and improve the test coverage.
>
> I then move the methods from the category into DGM and add a page to
> the wiki describing the functionality(probably two weeks from now)
>
> Users then do usability tests and we resolve issues like the
> treatment of java.sql.Date.
>
> Comments?
>
>
>
> John Wilson
> The Wilson Partnership
> web http://www.wilson.co.uk
> blog http://eek.ook.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
>     http://xircles.codehaus.org/manage_email
>
>

--

-- 
Guillaume Laforge
Groovy Project Manager
http://glaforge.free.fr/blog/groovy

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email