headers
dvyukov | 1 Jul 2012 11:04
Picon
Favicon

Re: code review 6350062: runtime: add freemcache() function (issue 6350062)

*** Submitted as
http://code.google.com/p/go/source/detail?r=4343da022009 ***

runtime: add freemcache() function
It will be required for scheduler that maintains
GOMAXPROCS MCache's.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6350062

http://codereview.appspot.com/6350062/
Permalink | Reply | 0 comments |
headers
pieter | 1 Jul 2012 17:05
Picon
Favicon

code review 6346056: cmd/dist: Make verbose messages print to stderr (issue 6346056)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@... (cc: alex.brainman@...),

I'd like you to review this change to
https://code.google.com/p/go

Description:
cmd/dist: Make verbose messages print to stderr

Made the following changes:
  - Export errprintf() from all three OS-specific modules
  - Added errprintf() to a.h
  - Moved errprintf() in windows.c under xprintf(), since they are so
similar
  - Replaced all instances of xprintf() with errprintf() where a vflag
check is done
Fixes issue 3788.

Please review this at http://codereview.appspot.com/6346056/

Affected files:
   M src/cmd/dist/a.h
   M src/cmd/dist/build.c
   M src/cmd/dist/plan9.c
   M src/cmd/dist/unix.c
   M src/cmd/dist/windows.c

Index: src/cmd/dist/a.h
(Continue reading)

Permalink | Reply | 4 comments |
headers
dvyukov | 1 Jul 2012 19:55
Picon
Favicon

code review 6347056: test: enforce 1 proc in the test (issue 6347056)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
test: enforce 1 proc in the test
otherwise it fails spuriously with "newfunc allocated unexpectedly"
message
when run with GOMAXPROCS>1 (other goroutine allocates).

Please review this at http://codereview.appspot.com/6347056/

Affected files:
   M test/closure.go

Index: test/closure.go
===================================================================
--- a/test/closure.go
+++ b/test/closure.go
 <at>  <at>  -81,6 +81,7  <at>  <at> 
  func newfunc() func(int) int { return func(x int) int { return x } }

  func main() {
+	runtime.GOMAXPROCS(1)
  	var fail bool
(Continue reading)

Permalink | Reply | 2 comments |
headers
David Symonds | 1 Jul 2012 19:58
Favicon
Gravatar

Re: code review 6347056: test: enforce 1 proc in the test (issue 6347056)

LGTM
Permalink | Reply | 0 comments |
headers
dvyukov | 1 Jul 2012 20:00
Picon
Favicon

Re: code review 6347056: test: enforce 1 proc in the test (issue 6347056)

*** Submitted as
http://code.google.com/p/go/source/detail?r=80a55e32dec0 ***

test: enforce 1 proc in the test
otherwise it fails spuriously with "newfunc allocated unexpectedly"
message
when run with GOMAXPROCS>1 (other goroutine allocates).

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6347056

http://codereview.appspot.com/6347056/
Permalink | Reply | 0 comments |
headers
minux.ma | 2 Jul 2012 03:32
Picon

code review 6357058: image: fix doc typo (issue 6357058)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@... (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go/

Description:
image: fix doc typo

Please review this at http://codereview.appspot.com/6357058/

Affected files:
   M src/pkg/image/names.go

Index: src/pkg/image/names.go
===================================================================
--- a/src/pkg/image/names.go
+++ b/src/pkg/image/names.go
 <at>  <at>  -20,7 +20,7  <at>  <at> 
  )

  // Uniform is an infinite-sized Image of uniform color.
-// It implements the color.Color, color.ColorModel, and Image interfaces.
+// It implements the color.Color, color.Model, and Image interfaces.
  type Uniform struct {
  	C color.Color
  }
(Continue reading)

Permalink | Reply | 3 comments |
headers
minux.ma | 2 Jul 2012 03:33
Picon

Re: code review 6349064: cmd/gc: add missing case for OCOM in defaultlit() (issue 6349064)

*** Submitted as
http://code.google.com/p/go/source/detail?r=b5c4f411a852 ***

cmd/gc: add missing case for OCOM in defaultlit()
         Fixes issue 3765.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6349064

http://codereview.appspot.com/6349064/
Permalink | Reply | 0 comments |
headers
minux.ma | 2 Jul 2012 03:37
Picon

Re: code review 6357058: image: fix doc typo (issue 6357058)

Fixes issue 3789.

http://codereview.appspot.com/6357058/
Permalink | Reply | 0 comments |
headers
dave | 2 Jul 2012 04:06
Favicon
Gravatar

code review 6304087: run.bash: increase test timeout for ARMv5 systems (issue 6304087)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
run.bash: increase test timeout for ARMv5 systems

Fixes issue 3740.

Increase the test timeout by 50% for ARMv5 systems
or those using soft float math. Addresses an issue
with the 700Mhz Raspberry Pi which takes ~150s for
math/rand.

Please review this at http://codereview.appspot.com/6304087/

Affected files:
   M src/run.bash

Index: src/run.bash
===================================================================
--- a/src/run.bash
+++ b/src/run.bash
 <at>  <at>  -29,16 +29,22  <at>  <at> 
  # at least runtime/debug test will fail.
  unset GOROOT_FINAL
(Continue reading)

Permalink | Reply | 4 comments |
headers
dave | 2 Jul 2012 04:10
Favicon
Gravatar

Re: code review 6351053: cmd/go: capture SIGQUIT during go run (issue 6351053)

Hello bradfitz@... (cc: golang-dev@...),

Please take another look.

http://codereview.appspot.com/6351053/
Permalink | Reply | 0 comments |

Gmane