code review 4639083: reflect: MethodByName (issue4639083)

Reviewers: rsc,

Message:
Hello rsc (cc: golang-dev@...),

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
reflect: MethodByName
It's more common to ask for methods by name than by index, so might
as well make it easy to do so.

Please review this at http://codereview.appspot.com/4639083/

Affected files:
   M src/pkg/reflect/all_test.go
   M src/pkg/reflect/type.go
   M src/pkg/reflect/value.go

Re: code review 4639083: reflect: MethodByName (issue4639083)

some simplifications

http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):

http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go#newcode356
src/pkg/reflect/type.go:356: Func    Value
Please add

Index int

like StructField has, so that if a caller goes
to the effort of using Type.MethodByName(name)
it has the index ready to use with Value.Method(i).

http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go#newcode463
src/pkg/reflect/type.go:463: m.Func = valueFromIword(flag, m.Type,
iword(fn))
a
m.Index = i
.

http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go#newcode479
src/pkg/reflect/type.go:479: ok = true
return t.Method(i), true

http://codereview.appspot.com/4639083/diff/2001/src/pkg/reflect/type.go#newcode483
src/pkg/reflect/type.go:483: if !ok {
return

Re: How to setup a windows-amd64 build?

Re: windows-386-ec2 broken by gotest: add -test.benchtime and -test.cpu flags.

code review 4629082: runtime/cgo: fix build (issue4629082)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@... (cc: golang-dev@...),

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
runtime/cgo: fix build

Please review this at http://codereview.appspot.com/4629082/

Affected files:
   M src/pkg/runtime/cgo/darwin_386.c

Index: src/pkg/runtime/cgo/darwin_386.c
===================================================================
--- a/src/pkg/runtime/cgo/darwin_386.c
+++ b/src/pkg/runtime/cgo/darwin_386.c
 <at>  <at>  -120,7 +120,7  <at>  <at> 
  	ts->g->stackguard = size;
  	err = pthread_create(&p, &attr, threadentry, ts);
  	if (err != 0) {
-		fprintf(stderr, "runtime/cgo: pthread_create failed: %s\n",  
strerror(error));
+		fprintf(stderr, "runtime/cgo: pthread_create failed: %s\n",  
strerror(err));
  		abort();
  	}
  }

Re: Re: code review 4639077: ld: fix ELF strip by removing overlap of sections (issue4639077)

Re: code review 4629082: runtime/cgo: fix build (issue4629082)

LGTM

Re: code review 4629082: runtime/cgo: fix build (issue4629082)

*** Submitted as
http://code.google.com/p/go/source/detail?r=a1541ae18b69 ***

runtime/cgo: fix build

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4629082

Committer: Russ Cox <rsc@...>

http://codereview.appspot.com/4629082/

Re: code review 4639083: reflect: MethodByName (issue4639083)

Hello rsc@... (cc: golang-dev@...),

Please take another look.

http://codereview.appspot.com/4639083/

Re: code review 4639083: reflect: MethodByName (issue4639083)

Hello rsc@... (cc: golang-dev@...),

Please take another look.

http://codereview.appspot.com/4639083/