Dave Cheney | 23 May 02:53
Gravatar

ARM builder broken by CL 5823059

I have a growing suspicion (still bisecting) that this commit has made
the arm build unstable.

https://code.google.com/p/go/source/detail?r=b54f4da6d7be22088be0d60f5f574ee0f667f69d

gri | 23 May 02:53

code review 6228047: godoc: minor performance tuning of indexer (issue 6228047)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go

Description:
godoc: minor performance tuning of indexer

In the identifier indexing phase, we don't care about
the contents of comments. No need to traverse them.

Also: Move computation of ident kind out of inner
loop for variable and constant declarations.

Please review this at http://codereview.appspot.com/6228047/

Affected files:
   M src/cmd/godoc/index.go

Index: src/cmd/godoc/index.go
===================================================================
--- a/src/cmd/godoc/index.go
+++ b/src/cmd/godoc/index.go
@@ -457,12 +457,6 @@
  	return index
  }

(Continue reading)

andybalholm | 23 May 02:00
Picon

code review 6231043: exp/html: adjust the last few insertion modes to match ... (issue 6231043)

Reviewers: nigeltao,

Message:
Hello nigeltao@... (cc: golang-dev@...),

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
exp/html: adjust the last few insertion modes to match the spec

Handle text, comment, and doctype tokens in afterBodyIM,
afterAfterBodyIM,
and afterAfterFramesetIM.

Pass three more tests.

Please review this at http://codereview.appspot.com/6231043/

Affected files:
   M src/pkg/exp/html/parse.go
   M src/pkg/exp/html/testlogs/tests18.dat.log
   M src/pkg/exp/html/testlogs/tests19.dat.log
   M src/pkg/exp/html/testlogs/webkit01.dat.log

Index: src/pkg/exp/html/parse.go
===================================================================
--- a/src/pkg/exp/html/parse.go
+++ b/src/pkg/exp/html/parse.go
@@ -1597,6 +1597,12 @@
(Continue reading)

gri | 23 May 01:46

code review 6230047: go/parser: minor cleanup (issue 6230047)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go

Description:
go/parser: minor cleanup

- there is no label scope at package level
- open/close all scopes symmetrically now
   that there is only one parse entry point
   (parseFile)

Please review this at http://codereview.appspot.com/6230047/

Affected files:
   M src/pkg/go/parser/parser.go

Index: src/pkg/go/parser/parser.go
===================================================================
--- a/src/pkg/go/parser/parser.go
+++ b/src/pkg/go/parser/parser.go
@@ -56,7 +56,7 @@
  	unresolved []*ast.Ident      // unresolved identifiers
  	imports    []*ast.ImportSpec // list of imports

-	// Label scope
(Continue reading)

bradfitz | 23 May 01:42

code review 6218069: cmd/api: add api/next.txt (issue 6218069)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://go.googlecode.com/hg

Description:
cmd/api: add api/next.txt

This quiets all.bash noise for upcoming features we know about.

The all.bash warnings will now only print for things not in next.txt
(or in next.txt but not in the API).

Once an API is frozen, we rename next.txt to a new frozen file
(like go1.txt)

Fixes issue 3651

Please review this at http://codereview.appspot.com/6218069/

Affected files:
   A api/README
   A api/next.txt
   M src/cmd/api/goapi.go
   M src/run.bash
   M src/run.bat

(Continue reading)

gri | 23 May 00:33

code review 6211079: math/big: implement JSON un/marshaling support for Ints (issue 6211079)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go

Description:
math/big: implement JSON un/marshaling support for Ints

No support for Rats for now because the precision-preserving
default notation (fractions of the form a/b) is not a valid
JSON value.

Fixes issue 3657.

Please review this at http://codereview.appspot.com/6211079/

Affected files:
   M src/pkg/math/big/int.go
   M src/pkg/math/big/int_test.go
   M src/pkg/math/big/rat_test.go

Index: src/pkg/math/big/int.go
===================================================================
--- a/src/pkg/math/big/int.go
+++ b/src/pkg/math/big/int.go
@@ -894,3 +894,19 @@
  	z.abs = z.abs.setBytes(buf[1:])
(Continue reading)

gri | 22 May 23:03

code review 6213065: go/parser: resolve all parameter types (issue 6213065)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go

Description:
go/parser: resolve all parameter types

Fixes issue 3655.

Please review this at http://codereview.appspot.com/6213065/

Affected files:
   M src/pkg/go/parser/parser.go
   M src/pkg/go/parser/parser_test.go

Index: src/pkg/go/parser/parser.go
===================================================================
--- a/src/pkg/go/parser/parser.go
+++ b/src/pkg/go/parser/parser.go
@@ -627,10 +627,10 @@

  	doc := p.leadComment

-	// fields
+	// FieldDecl
  	list, typ := p.parseVarList(false)
(Continue reading)

bradfitz | 22 May 22:55

code review 6213064: net/http: fix response Connection: close, close client ... (issue 6213064)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://go.googlecode.com/hg

Description:
net/http: fix response Connection: close, close client connections

Fixes issue 3663
Updates issue 3540 (fixes it more)
Updates issue 1967 (fixes it more, re-enables a test)

Please review this at http://codereview.appspot.com/6213064/

Affected files:
   M src/pkg/net/http/serve_test.go
   M src/pkg/net/http/server.go
   M src/pkg/net/http/transport.go
   M src/pkg/net/http/transport_test.go

Index: src/pkg/net/http/serve_test.go
===================================================================
--- a/src/pkg/net/http/serve_test.go
+++ b/src/pkg/net/http/serve_test.go
@@ -386,17 +386,18 @@
  	}

(Continue reading)

minux.ma | 22 May 21:53
Picon

code review 6208077: cmd/ld, cmd/5l, cmd/go: a workaound to support linking ... (issue 6208077)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@... (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go/

Description:
cmd/ld, cmd/5l, cmd/go: a workaound to support linking thumb library
      we pass -mlong-call to gcc so that we don't need to worry about
generating mode changing veneers. But, we still need to address this
problem later.
      In preparation of CL 5822049.
(Ubuntu uses a thumb libgcc, so without this CL, the new libgcc test
in CL 5822049 will break the build)

Please review this at http://codereview.appspot.com/6208077/

Affected files:
   M src/cmd/5l/5.out.h
   M src/cmd/5l/asm.c
   M src/cmd/go/build.go
   M src/cmd/ld/ldelf.c

Index: src/cmd/5l/5.out.h
===================================================================
--- a/src/cmd/5l/5.out.h
+++ b/src/cmd/5l/5.out.h
@@ -260,6 +260,7 @@
(Continue reading)

minux.ma | 22 May 20:32
Picon

Re: code review 5823055: cmd/ld, cmd/6l, cmd/8l: fix hidden/local symbol import for ELF systems (issue 5823055)

*** Submitted as
http://code.google.com/p/go/source/detail?r=046668c6315e ***

cmd/ld, cmd/6l, cmd/8l, cmd/5l: fix hidden/local symbol import for ELF
systems
    Introduce a newsym() to cmd/lib.c to add a symbol but don't add
them to hash table.
    Introduce a new bit flag SHIDDEN and bit mask SMASK to handle hidden
and/or local symbols in ELF symbol tables. Though we still need to order
the symbol table entries correctly.
    Fix for issue 3261 comment #9.
    For CL 5822049.

R=iant, rsc
CC=golang-dev
http://codereview.appspot.com/5823055

http://codereview.appspot.com/5823055/

minux.ma | 22 May 20:27
Picon

Re: code review 5823059: cmd/ld: take section symbols' value into account for PE (issue 5823059)

*** Submitted as
http://code.google.com/p/go/source/detail?r=b54f4da6d7be ***

cmd/ld: take section symbols' value into account for PE
     ld -r could generate multiple section symbols for the same section,
but with different values, we have to take that into account.
     Fixes issue 3322.
     Part of issue 3261.
     For CL 5822049.

R=golang-dev, iant, rsc, iant
CC=golang-dev
http://codereview.appspot.com/5823059

http://codereview.appspot.com/5823059/


Gmane