headers
campoy | 22 May 2013 02:11
Favicon

code review 9631043: test (issue 9631043)

Reviewers: campoy,

Message:
Hello campoy@... (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/google-api-go-client/

Description:
test

Please review this at https://codereview.appspot.com/9631043/

Affected files:
   M plus/v1/plus-gen.go

Index: plus/v1/plus-gen.go
===================================================================
--- a/plus/v1/plus-gen.go
+++ b/plus/v1/plus-gen.go
 <at>  <at>  -1,3 +1,4  <at>  <at> 
+
  // Package plus provides access to the Google+ API.
  //
  // See https://developers.google.com/+/api/

--

-- 

--- 
You received this message because you are subscribed to the Google Groups "golang-dev" group.
(Continue reading)

Permalink | Reply | 3 comments |
headers
adg | 22 May 2013 02:09
Favicon

Re: code review 8603045: go.talks/present: allow playground output panel resizing (issue 8603045)

Looks good

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js
File present/js/play.js (right):

https://codereview.appspot.com/8603045/diff/16001/present/js/play.js#newcode38
present/js/play.js:38: $(output).resizable({handles: "n,w,nw",
minHeight: 27, minWidth: 135, maxHeight: 608, maxWidth: 990});
Can you expand this so each field is on a separate line?

https://codereview.appspot.com/8603045/

--

-- 

--- 
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@...
For more options, visit https://groups.google.com/groups/opt_out.
Permalink | Reply | 3 comments |
headers
adg | 22 May 2013 02:02
Favicon

code review 9517047: go.talks: fix Advanced Concurrency Patterns imports (issue 9517047)

Reviewers: golang-dev1,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go.talks

Description:
go.talks: fix Advanced Concurrency Patterns imports

Doesn't fix the build, but at least makes the programs correct.

Please review this at https://codereview.appspot.com/9517047/

Affected files:
   M 2013/advconc/dedupermain.go
   M 2013/advconc/fakemain.go
   M 2013/advconc/fakemainnomerge.go
   M 2013/advconc/naivemain.go
   M 2013/advconc/naivemainnomerge.go

Index: 2013/advconc/dedupermain.go
===================================================================
--- a/2013/advconc/dedupermain.go
+++ b/2013/advconc/dedupermain.go
 <at>  <at>  -5,7 +5,7  <at>  <at> 
  	"math/rand"
  	"time"
(Continue reading)

Permalink | Reply | 2 comments |
headers
adg | 22 May 2013 00:26
Favicon

code review 9626044: go.talks: add Advanced Go Concurrency Patterns (issue 9626044)

Reviewers: Sameer,

Message:
Hello snanda@... (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go.talks

Description:
go.talks: add Advanced Go Concurrency Patterns

Please review this at https://codereview.appspot.com/9626044/

Affected files:
   A 2013/advconc.slide
   A 2013/advconc/buffer.go
   A 2013/advconc/dedupermain.go
   A 2013/advconc/fakemain.go
   A 2013/advconc/fakemainnomerge.go
   A 2013/advconc/gopherhat.jpg
   A 2013/advconc/gopherrunning.jpg
   A 2013/advconc/gopherswim.jpg
   A 2013/advconc/gopherswrench.jpg
   A 2013/advconc/naivemain.go
   A 2013/advconc/naivemainnomerge.go
   A 2013/advconc/nilselect.go
   A 2013/advconc/pingpong1.go
   A 2013/advconc/pingpong2.go
   A 2013/advconc/pingpongdeadlock.go
   A 2013/advconc/pingpongpanic.go
(Continue reading)

Permalink | Reply | 3 comments |
headers
cw | 22 May 2013 00:21

Re: code review 6445105: net: allow ReadFrom on IPConn to receive IPv4 header an... (issue 6445105)

Is this almost ready as it stands?

https://codereview.appspot.com/6445105/

--

-- 

--- 
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@...
For more options, visit https://groups.google.com/groups/opt_out.
Permalink | Reply | 1 comment |
headers
r | 22 May 2013 00:05
Favicon

code review 9611048: cmd/go: support new location for vet (issue 9611048)

Reviewers: rsc,

Message:
Hello rsc (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go/

Description:
cmd/go: support new location for vet
Also delete the special case for exp, which isn't necessary any more.

Please review this at https://codereview.appspot.com/9611048/

Affected files:
   M src/cmd/go/pkg.go
   M src/cmd/go/tool.go

Index: src/cmd/go/pkg.go
===================================================================
--- a/src/cmd/go/pkg.go
+++ b/src/cmd/go/pkg.go
 <at>  <at>  -272,11 +272,11  <at>  <at> 
  // isGoTool is the list of directories for Go programs that are installed  
in
  // $GOROOT/pkg/tool.
  var isGoTool = map[string]bool{
-	"cmd/api":  true,
-	"cmd/cgo":  true,
-	"cmd/fix":  true,
(Continue reading)

Permalink | Reply | 3 comments |
headers
adg | 21 May 2013 23:48
Favicon

code review 9592045: go-tour: link to French translation (issue 9592045)

Reviewers: golang-dev1,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go-tour

Description:
go-tour: link to French translation

Fixes issue 61.

Please review this at https://codereview.appspot.com/9592045/

Affected files:
   M tour.article

Index: tour.article
===================================================================
--- a/tour.article
+++ b/tour.article
 <at>  <at>  -45,6 +45,7  <at>  <at> 
  - [[http://go-tour-br.appspot.com/][Brazilian Portuguese — Português do  
Brasil]]
  - [[http://go-tour-ca.appspot.com/][Catalan — Català]]
  - [[http://go-tour-es.appspot.com/][Spanish — Español]]
+- [[http://go-tour-fr.appspot.com/][French - Français]]
  - [[http://go-tour-he.appspot.com/][Hebrew — עִבְרִית]]
  - [[http://go-tour-jp.appspot.com/][Japanese — 日本語]]
(Continue reading)

Permalink | Reply | 2 comments |
headers
bradfitz | 21 May 2013 23:32
Favicon

code review 9462049: time: remove Time.FormatAppend (issue 9462049)

Reviewers: r,

Message:
Hello r <at> golang.org (cc: golang-dev@...),

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
time: remove Time.FormatAppend

undo CL 8478044 / 0d28fd55e721

Lack of consensus.

««« original CL description
time: add Time.FormatAppend

This is a version of Time.Format that doesn't require allocation.

Fixes Issue 5192
Update Issue 5195

R=r
CC=gobot, golang-dev
https://codereview.appspot.com/8478044
»»»

Please review this at https://codereview.appspot.com/9462049/
(Continue reading)

Permalink | Reply | 2 comments |
headers
bradfitz | 21 May 2013 23:31
Favicon

code review 9627043: net/http: don't send Accept-Encoding on HEAD requests (issue 9627043)

Reviewers: golang-dev1,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://go.googlecode.com/hg/

Description:
net/http: don't send Accept-Encoding on HEAD requests

Works around a bug in nginx: http://trac.nginx.org/nginx/ticket/358

Fixes Issue 5522

Please review this at https://codereview.appspot.com/9627043/

Affected files:
   M src/pkg/net/http/transport.go
   M src/pkg/net/http/transport_test.go

Index: src/pkg/net/http/transport.go
===================================================================
--- a/src/pkg/net/http/transport.go
+++ b/src/pkg/net/http/transport.go
 <at>  <at>  -831,10 +831,15  <at>  <at> 
  	// uncompress the gzip stream if we were the layer that
  	// requested it.
  	requestedGzip := false
-	if !pc.t.DisableCompression && req.Header.Get("Accept-Encoding") == "" {
(Continue reading)

Permalink | Reply | 3 comments |
headers
minux.ma | 21 May 2013 23:30
Picon

code review 9392049: include: add a README file (issue 9392049)

Reviewers: golang-dev1,

Message:
Hello golang-dev@... (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go/

Description:
include: add a README file

Please review this at https://codereview.appspot.com/9392049/

Affected files:
   A include/README

Index: include/README
===================================================================
new file mode 100644
--- /dev/null
+++ b/include/README
 <at>  <at>  -0,0 +1,6  <at>  <at> 
+The header files under this directory are strictly internal to the gc
+toolchain, so please don't install these files to system include file
+directory (e.g. /usr/include or /usr/local/include).
+
+Also note that they must be kept as is in $GOROOT/include, or cmd/dist
+will malfunction.

--

--
(Continue reading)

Permalink | Reply | 3 comments |
headers
minux.ma | 21 May 2013 22:57
Picon

code review 9251043: runtime: make arm signal handler call runtime.badsignal (issue 9251043)

Reviewers: golang-dev1,

Message:
Hello golang-dev@... (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go/

Description:
runtime: make arm signal handler call runtime.badsignal
In preparation for CL 9249043.

Please review this at https://codereview.appspot.com/9251043/

Affected files:
   M src/pkg/runtime/sys_freebsd_arm.s
   M src/pkg/runtime/sys_linux_arm.s
   M src/pkg/runtime/sys_netbsd_arm.s

Index: src/pkg/runtime/sys_freebsd_arm.s
===================================================================
--- a/src/pkg/runtime/sys_freebsd_arm.s
+++ b/src/pkg/runtime/sys_freebsd_arm.s
 <at>  <at>  -154,12 +154,17  <at>  <at> 
  	// this might be called in external code context,
  	// where g and m are not set.
  	// first save R0, because _cgo_load_gm will clobber it
-	// TODO(adonovan): call runtime·badsignal if m=0, like other platforms?
  	MOVW	R0, 4(R13) // signum
  	MOVW	_cgo_load_gm(SB), R0
(Continue reading)

Permalink | Reply | 1 comment |

Gmane