Luigi Toscano | 18 Oct 17:50 2014
Picon

Review Request 120649: Encode the URIs which end up in DTD files

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/

Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, and kdewin.
By Luigi Toscano.
Repository: kdelibs4support

Description

The URI need to be encoded, because some valid characters for filenames are not valid according RFC 2396. Easy way to trigger the issue: when the path contains spaces, as it happens on MacOSX builds.

The function is duplicated from the matching functions in kdoctools because: - this module will go away in the not far future; - the function is not generic enough to be used outside (yet)

See also https://git.reviewboard.kde.org/r/120648/ for the twin review on kdoctools.

Testing

It compiles, but I can't properly test Mac and Windows scenarios

Diffs

  • cmake/uriencode.cmake (PRE-CREATION)
  • src/CMakeLists.txt (4a1d80d)

View Diff

_______________________________________________
Kde-windows mailing list
Kde-windows@...
https://mail.kde.org/mailman/listinfo/kde-windows
Dominik Haumann | 15 Oct 21:03 2014
Picon

Compiling on Windows

Hi,

I'm setting up my kdesettings.ini, and have set
KDECOMPILER = msvc2013

Further down, it says 
[QtSDK]
Enabled = False
Path = C:\Qt
Version = 5.3
Compiler = mingw482_32

Since Enabled=False, is this of interest at all? I was confused because I set 
KDECOMPILER to msvc2013, and here it says something about mingw. Can I just 
ignore this and continue with the howto ?

Greetings
Dominik
Patrick Spendrin | 25 Sep 16:23 2014
Picon
Picon

Review Request 120368: replace export headers w. generate_export_headers

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120368/

Review request for KDevelop, kdewin and Denis Steckelmacher.
By Patrick Spendrin.
Repository: kdev-qmljs

Description

replace export headers w. generate_export_headers

Testing

windows msvc 2013

Diffs

  • codecompletion/CMakeLists.txt (3a1c071eb32eb50b13e4469d1029a8cb9fb427a1)
  • codecompletion/codecompletionexport.h (9761699217d04f1e96283a3056edd14f25ef37e3)
  • duchain/CMakeLists.txt (583f37f3651366490467a95716df52d632cb4a57)
  • duchain/duchainexport.h (3447989cdc43260a7c1d07a8165f4d4a77f5efea)
  • duchain/frameworks/nodejs.h (7f00d01a900c0d53a435794f80de513e06c0c6d3)
  • duchain/navigation/navigationwidget.h (0d462223f81aacf2f920503d7c064c338b16c05e)

View Diff

_______________________________________________
Kde-windows mailing list
Kde-windows@...
https://mail.kde.org/mailman/listinfo/kde-windows
Patrick Spendrin | 25 Sep 16:13 2014
Picon
Picon

Review Request 120367: replace export headers w. generate_export_headers

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120367/

Review request for KDevelop, kdewin, Milian Wolff, and Niko Sams.
By Patrick Spendrin.
Repository: kdev-php

Description

replace export headers w. generate_export_headers

the include_directories are needed because it isn't possible to reference the build directory from inside the source files.

Testing

windows msvc 2013

Diffs

  • duchain/CMakeLists.txt (d57c45224fe3d5ece78ac432489becd1b3d1ce02)
  • completion/CMakeLists.txt (e68290b59acf5882d315d44da117ca66778fac02)
  • completion/phpcompletionexport.h (5958009d3429a8154f26c37b10b0ea4521f71a54)
  • completion/tests/CMakeLists.txt (749ae72e0c1932a5d502b29a957daa9aef8c54e6)
  • parser/CMakeLists.txt (d658dff79e8a536015def29077fafeed1aae72e3)
  • parser/parserexport.h (42820da8f22ca4b127e64bf8288af645af10ed83)
  • duchain/navigation/navigationwidget.h (56b4dc3d66b1660d9d23cfe47eac02a40cfdc3ad)
  • duchain/phpduchainexport.h (0b8328239d768dbf5e898e8e5c3b9037b88ba08b)
  • duchain/tests/CMakeLists.txt (524466d985a4fe0c80e4c1315c34258eb3cd976e)

View Diff

_______________________________________________
Kde-windows mailing list
Kde-windows@...
https://mail.kde.org/mailman/listinfo/kde-windows
Alexander Richardson | 22 Sep 16:36 2014
Picon

Re: Question about Win32 CMake code in KDocTools and kdelibs4support

2014-09-21 16:41 GMT+02:00 Luigi Toscano <luigi.toscano@...>:
> Hi!
> I was checking back two pieces of CMake code which you fixed for Win32
> (https://git.reviewboard.kde.org/r/115744/) and I have few questions.
>
> The code was originally only in kdoctools, but part of it was moved to
> kdelibs4support:
> http://quickgit.kde.org/?p=kdoctools.git&a=blob&h=341ecf4de48c994b930c800bbc936616aca2f6ea&hb=f3971c58066b9f495c614b7c9bd5dfbeb9bf482f&f=src%2FCMakeLists.txt#l7
>
> http://quickgit.kde.org/?p=kdelibs4support.git&a=blob&h=4a1d80dfff7a54af4441ea64020caaada387759e&hb=a6f6b3e7eed7b08914c9674bf22961f4cc203530&f=src%2FCMakeLists.txt#l629
>
> My goal here: I need to insert another command before the configure_file in
> order to percent-encode the URI (changeing DocBookXML4_DTD_DIR) before feeding
> it to configure_file, as the simple file path could be an invalid URI if it
> contains, for example, a space (it was found by our Mac porters).
>
> Now, I was wondering if I could unify more the two code branches, so that I
> can insert just one call to this external program (it needs to be done before
> configure_file) instead of two.
>
> Question time then :)
> - is the install(CODE part really needed? Can't we call the two lines (
> file(RELATIVE... and configure_file...) directly?  All the variables are know,
> for what I see.
> - the file ${_custom_dtd_kdex}.cmake is transformed as
> ${_custom_dtd_kdex}.install and then renamed back as ${_custom_dtd_kdex}. Is
> this double step needed? If not, the output file of configure_file in the
> WIN32 branch could be just called ${_custom_dtd_kdex} like in the non-Win32
> part of the code and the
> install(FILES ....
> part could be common to both branches
>
> What do you think ?

Hi,

I don't think the CODE part is needed, I just did it like that because
that's the way it was before.
However I am not sure, and I haven't got the complete history on my
machine so I don't know why it was introduced.

I'm forwarding this to kde-windows, I hope someone knows why it was
done like that.

Regards,
Alex
morrisb | 11 Sep 20:06 2014
Picon

[Bug 339016] New: Emerge searches after kdesettings.ini in the wrong folder

https://bugs.kde.org/show_bug.cgi?id=339016

            Bug ID: 339016
           Summary: Emerge searches after kdesettings.ini in the wrong
                    folder
           Product: kde-windows
           Version: unspecified
          Platform: MS Windows
                OS: MS Windows
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: buildsystem
          Assignee: kde-windows@...
          Reporter: systemshock2@...

Emerge cloned from git://anongit.kde.org/emerge.git with Git 1.9.4.

This is what happens after any "emerge x" call:

kdesettings.bat executed
KDEROOT     : C:\kderoot
KDECOMPILER : mingw4
KDESVNDIR   : C:\kderoot\svn
KDEGITDIR   : C:\kderoot\git
DOWNLOADDIR : C:\kderoot\download

C:\kderoot>emerge
Traceback (most recent call last):
  File "C:\kderoot\emerge\bin\emerge.py", line 22, in <module>
    import portage
  File "C:\kderoot\emerge\bin\portage.py", line 494, in <module>
    PortageInstance = Portage()
  File "C:\kderoot\emerge\bin\portage.py", line 216, in __init__
    self._readIgnores()
  File "C:\kderoot\emerge\bin\portage.py", line 233, in _readIgnores
    with open(iniPath, 'w') as configfile:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\kderoot\\
etc\\kdesettings.ini'

In the file portage.py in %KDEROOT%\emerge\bin:

  Lines 218 & 219:  def _readIgnores(self):
        iniPath = os.path.join(ROOTDIR, "etc", "kdesettings.ini")
        ...

Should be:

  Lines 218 & 219:  def _readIgnores(self):
        iniPath = os.path.join(ROOTDIR, "kdesettings.ini")
        ...

Which seems to fix the problem.

This is my first bug report, so I apologize for any errors.

--

-- 
You are receiving this mail because:
You are the assignee for the bug.
Patrick von Reth | 30 Aug 12:25 2014
Picon

Re: Proposal: support only one version of libraries

+1

Cheers

Patrick
From: Cristian Oneț
Sent: ‎Saturday‎, ‎30‎ ‎August‎ ‎2014 ‎11‎:‎01
To: KDE on Windows

2014-08-30 5:45 GMT+03:00 Nicolás Alvarez <nicolas.alvarez <at> gmail.com>:
> 2014-07-07 21:23 GMT-03:00 Nicolás Alvarez <nicolas.alvarez <at> gmail.com>:
>> Currently many library packages in emerge contain rules in the .py
>> script to download multiple library versions, and there are
>> corresponding patches for all those versions. Sometimes those patches
>> are even identical.
>>
>> For example, assuan2 has download URLs, digests, and cmake patches for
>> 2.0.1, 2.0.2, 2.0.3, and 2.1.1. The 2.0.x versions date to 2011. Any
>> reason to keep them? I'd just delete everything except 2.1.1, which is
>> the default target.
>>
>> I hereby propose keeping only the latest version and deleting any old patches.

+1, having multiple versions only makes sense if we do some kind of
release management (track what's stable and what's not) but we don't
do that right now.

Regards,
Cristian

>
> Bump?
>
> --
> Nicolás
> _______________________________________________
> Kde-windows mailing list
> Kde-windows <at> kde.org
> https://mail.kde.org/mailman/listinfo/kde-windows
_______________________________________________
Kde-windows mailing list
Kde-windows <at> kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
_______________________________________________
Kde-windows mailing list
Kde-windows@...
https://mail.kde.org/mailman/listinfo/kde-windows
Bob S | 16 Aug 02:45 2014
Picon
Picon

emerge\kdesettings-example.bat does not exist

Hi,

 

I just followed the directions at https://techbase.kde.org/Getting_Started/Build/Windows/emerge#Configure_the_emerge_tool

but I found no %KDEROOT%\emerge\kdesettings-example.bat file.

 

The contents of my %KDEROOT%\emerge\ directory are as follows:

Directory of c:\kderoot\emerge

08/15/2014  05:20 PM    <DIR>          .

08/15/2014  05:20 PM    <DIR>          ..

08/15/2014  05:20 PM                67 .gitattributes

08/15/2014  05:20 PM               161 .gitignore

08/15/2014  05:20 PM    <DIR>          .idea

08/15/2014  05:20 PM    <DIR>          bin

08/15/2014  05:20 PM                43 createdoc.bat

08/15/2014  05:20 PM    <DIR>          doc

08/15/2014  05:20 PM                92 kdeenv-user.bat

08/15/2014  05:20 PM             1,379 kdeenv.bat

08/15/2014  05:20 PM             2,048 kdeenv.ps1

08/15/2014  05:20 PM             4,296 kdesettings.ini

08/15/2014  05:20 PM               459 package.bat

08/15/2014  05:20 PM    <DIR>          portage

08/15/2014  05:20 PM    <DIR>          portage_examples

08/15/2014  05:20 PM             9,874 pylintrc

08/15/2014  05:20 PM             5,024 README

08/15/2014  05:20 PM               963 release-split-kdesdk-tarballs.pl

08/15/2014  05:20 PM    <DIR>          server

08/15/2014  05:20 PM    <DIR>          setup

08/15/2014  05:20 PM             3,114 TODO

              12 File(s)         27,520 bytes

               9 Dir(s)  150,904,381,440 bytes free

 

 

Can you offer any suggestions about what went wrong and how I should proceed?

 

Thx,

Bob

 

_______________________________________________
Kde-windows mailing list
Kde-windows@...
https://mail.kde.org/mailman/listinfo/kde-windows
Timo Steuerwald | 18 Aug 23:13 2014
Picon
Picon

Download of old versions?

Hi all,
where can I find old versions of kde for windows?
At http://windows.kde.org/download.php it's only possible to download 
the latest version.
However I would like to download a previous version, where can I find these?

Best wishes
Timo
BobSCA | 16 Aug 21:07 2014
Picon
Picon

[Bug 338319] New: kde-4.13 build fails on win32-mscv2013 due to old qt

https://bugs.kde.org/show_bug.cgi?id=338319

            Bug ID: 338319
           Summary: kde-4.13 build fails on win32-mscv2013 due to old qt
           Product: kde-windows
           Version: unspecified
          Platform: MS Windows
                OS: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: buildsystem
          Assignee: kde-windows@...
          Reporter: bobs_spam_0@...

Build of kde-4.13 fails during configure of qt-everywhere-opensource-src-4.8.5
as that package does not support the platform win32-msvc2013.

kde-4.13 should be updated to include qt 4.8.6 (or later) which appears to be
the first version to support that platform.

--

-- 
You are receiving this mail because:
You are the assignee for the bug.
BobSCA | 16 Aug 20:56 2014
Picon
Picon

[Bug 338318] New: kdesettings-example.bat missing from kde-4.13

https://bugs.kde.org/show_bug.cgi?id=338318

            Bug ID: 338318
           Summary: kdesettings-example.bat missing from kde-4.13
           Product: kde-windows
           Version: unspecified
          Platform: MS Windows
                OS: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: buildsystem
          Assignee: kde-windows@...
          Reporter: bobs_spam_0@...

In kde-4.12 kdesettings-example.bat is present as expected in %KDEROOT%/emerge.

In kde-4.13 that file is no longer present, although it is referred to in
emerge/README.

--

-- 
You are receiving this mail because:
You are the assignee for the bug.

Gmane