headers
David Faure | 1 Dec 01:10
Picon
Favicon
Gravatar

Re: KDE/kdelibs/kdecore/sonnet

On Tuesday 01 December 2009, Zack Rusin wrote:
>On Tuesday 01 December 2009, David Faure wrote:
> > Yep, seems to work now.
> > 
> > BUT: this code was committed at the worst possible time (*very* close to
> > beta1 tagging) and without review, breaking the freeze.
> > And obviously (from your own words) it's impossible to be sure the code
> > doesn't introduce any regressions. Can you revert it for now and commit it
> > again a month from now when trunk is open for kde-4.5?
> > I don't want to think about what will happen if we ship 4.4 with infinite
> > loops in some languages :/
>
> To be honest I'm not sure if that makes much sense. If the code breaks
> something, then well it breaks something and if you don't have enough tests
> you most likely have to wait for a beta for it to be tested by general
>  public. So yea, we can revert it and then let it sit and wait for kde-4.5
>  beta so that it's tested then or we can let it be tested with kde-4.4
>  beta. The code was broken for years, it just happened to work in enough
>  cases for english, german and other latin languges which meant that no one
>  cared enough about the other few billion people on the planet to fix it,
>  at least now breakage in this breaks all languages equally.
> Of course at the end of the day it's your call and if it will make you
>  sleep better at night then sure revert it.

What the above logic skips over, is the large period of testing between
"kde 4.5 is open for commits" (a month from now or so) and "kde-4.5-beta1".
In general, the reason for freezes like the current one, is that code 
committed in the above interval will get also a lot of testing by us (kde 
developers) before it gets to users. But I can see how locale-dependent code 
is a bit of a special case since we won't test all languages ourselves (I
(Continue reading)

Permalink | Reply | 9 comments |
headers
Dirk Mueller | 1 Dec 02:48
Picon
Favicon

KDE 4.4.0 Beta1 (4.3.80) uploaded


Hi, 

first run of tarballs uploaded - kde-l10n still generating, 

Greetings,
Dirk
Permalink | Reply | 0 comments |
headers
Tom Albers | 1 Dec 10:12
Picon
Favicon

Fwd: Re: KDE/kdelibs/nepomuk/rcgen

Op Tuesday 1 December 2009 08:58 schreef Volker Krause <vkrause@...>:
> Sebastian Trueg wrote:
> 
> > SVN commit 1056485 by trueg:
> > 
> > Fixed pseudo-inheritance implementation for the fast classes
> 
> This seems to break the build of kdepim:
> http://my.cdash.org/index.php?project=kdepim
> 
> It apparently creates a class (NepomukFast::Attachment) that inherits from
> itself. Reverting this change fixes it.
> 
> regards
> Volker

Althoug kdepim is no part of beta1, a fix or revert should be included in the beta1.

I really hate people breaking stuff on different area's the last couple of days. 

I suggest we act firmer. For example 2 days before tagging we call out a general commit freeze until tagging
is over. During that time only release-team reviewed commits are possible.

Best,

Toma
Permalink | Reply | 0 comments |
headers
Dirk Mueller | 1 Dec 11:36
Picon
Favicon

Re: KDE/kdelibs/kdecore/sonnet

On Tuesday 01 December 2009, Zack Rusin wrote:

> > What the above logic skips over, is the large period of testing between
> > "kde 4.5 is open for commits" (a month from now or so) and
> > "kde-4.5-beta1". In general, the reason for freezes like the current one,
> > is that code committed in the above interval will get also a lot of
> > testing by us (kde developers) before it gets to users. But I can see how
> > locale-dependent code is a bit of a special case since we won't test all
> > languages ourselves (I don't even use kde in french myself...), so the
> > code has to get to end users in order to be tested. From a practical
> > point of view I'm ok with letting this in then. But I can also understand
> > if the
> >  release-team decides it should be reverted because it didn't play by the
> >  rules and sets a bad example.
> Sounds like a good plan to me.
> If you'll decide to revert it, fire me an email when the trunk opens to
>  remind of it.

Hi, 

Yes, it was a violation of the tagging freeze. 

BUT ;) honestly I don't see this as a big issue - we need more testing here, 
thats what Beta is for. Zack was confident that the change is an improvement. 
There is a testsuite, which can be improved. Zack fixed the hang that you 
found. 

I've decided (for myself) to include Zacks change and the followup fix into 4.4 
beta1.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Michel Ludwig | 1 Dec 11:49
Picon

Re: KDE/kdelibs/kdecore/sonnet

On Tuesday 01 December 2009 10:36:52 Dirk Mueller wrote:
> I've decided (for myself) to include Zacks change and the followup fix into
> 4.4 beta1.
>
> I don't have a clear picture of the report that the change breaks kate. is
> this true? then I would like to remove it from the beta1.

Well, the latest fixes seem to improve the situation but there are still 
problems, especially with automated spell checking. If you want to see for 
yourself, just open KWrite, activate automated spell checking and type in 
some misspelled words. You'll see that some words are suddenly flagged to be 
spelled correctly. The issue is here that words which are only followed by a 
space character are not recognised as misspelled.

However, if this is fixed, then from my point of view the changes could 
remain.

Michel

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________
Permalink | Reply | 2 comments |
headers
Sebastian Kügler | 1 Dec 12:27
Picon
Favicon
Gravatar

Re: KDE 4.4 Beta1 Tagging ahead

On Monday 30 November 2009 16:02:28 Allen Winter wrote:
> On Monday 30 November 2009 09:29:58 Sebastian Kügler wrote:
> > On Monday 30 November 2009 15:04:05 Allen Winter wrote:
> > > On Monday 30 November 2009 08:44:28 Dirk Mueller wrote:
> > > > On Thursday 26 November 2009, Tom Albers wrote:
> > > > > > want to ship outdated betas, since that makes bughunting less
> > > > > > fun.
> > > >
> > > > ok, I'll tag tonight Beta1. Okay with everyone?
> > >
> > > Not ok with me.
> > > Not until we have a fix for qtbug-5588 in kde-qt and I have a little
> > > bit of time to make sure KOrganizer can work again with that fix.
> > >
> > > Ordinarily I wouldn't be such a pain about an upstream bug, but in this
> > > case I need the warm-fuzzy of seeing KOrganizer run again before
> > > calling it "beta".
> >
> > 
> > I think an upstream bug should not hold up our beta release. We can add
> >  this information to the announcement, so it's clear that korganizer
> >  doesn't work. As it's one relatively isolated issue, the patch is
> > already queued in Qt (ha!) and we clearly say "this eats kittens
> > (cittens)", I think that it's OK to move forward. Holding up the beta
> > doesn't buy us anything at this point, it will just get us less testing.
> > 
> 
> Then hold all of kdepim from the beta please

Again, why? Can't we just point packagers to the patch that would fix it?
(Continue reading)

Permalink | Reply | 5 comments |
headers
Sebastian Kügler | 1 Dec 13:30
Picon
Favicon
Gravatar

Re: KDE/kdelibs/kdecore/sonnet

On Tuesday 01 December 2009 01:10:31 David Faure wrote:
> On Tuesday 01 December 2009, Zack Rusin wrote:
> >On Tuesday 01 December 2009, David Faure wrote:
> > > Yep, seems to work now.
> > >
> > > BUT: this code was committed at the worst possible time (*very* close
> > > to beta1 tagging) and without review, breaking the freeze.
> > > And obviously (from your own words) it's impossible to be sure the code
> > > doesn't introduce any regressions. Can you revert it for now and commit
> > > it again a month from now when trunk is open for kde-4.5?
> > > I don't want to think about what will happen if we ship 4.4 with
> > > infinite loops in some languages :/
> >
> > To be honest I'm not sure if that makes much sense. If the code breaks
> > something, then well it breaks something and if you don't have enough
> > tests you most likely have to wait for a beta for it to be tested by
> > general public. So yea, we can revert it and then let it sit and wait for
> > kde-4.5 beta so that it's tested then or we can let it be tested with
> > kde-4.4 beta. The code was broken for years, it just happened to work in
> > enough cases for english, german and other latin languges which meant
> > that no one cared enough about the other few billion people on the planet
> > to fix it, at least now breakage in this breaks all languages equally.
> > Of course at the end of the day it's your call and if it will make you
> >  sleep better at night then sure revert it.
> 
> What the above logic skips over, is the large period of testing between
> "kde 4.5 is open for commits" (a month from now or so) and "kde-4.5-beta1".
> In general, the reason for freezes like the current one, is that code
> committed in the above interval will get also a lot of testing by us (kde
> developers) before it gets to users. But I can see how locale-dependent
(Continue reading)

Permalink | Reply | 0 comments |
headers
David Faure | 1 Dec 13:40
Picon
Favicon
Gravatar

Re: KDE/kdelibs/kdecore/sonnet

On Tuesday 01 December 2009, you wrote:
> On Tuesday 01 December 2009 10:36:52 Dirk Mueller wrote:
> > I've decided (for myself) to include Zacks change and the followup fix
> > into 4.4 beta1.
> >
> > I don't have a clear picture of the report that the change breaks kate.
> > is this true? then I would like to remove it from the beta1.
> 
> Well, the latest fixes seem to improve the situation but there are still
> problems, especially with automated spell checking. If you want to see for
> yourself, just open KWrite, activate automated spell checking and type in
> some misspelled words. You'll see that some words are suddenly flagged to
>  be spelled correctly. The issue is here that words which are only followed
>  by a space character are not recognised as misspelled.

If you don't report this to Zack, there are few chances of it getting fixed ;)

--

-- 
David Faure, faure@..., http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
Permalink | Reply | 1 comment |
headers
Michel Ludwig | 1 Dec 14:14
Picon

Re: KDE/kdelibs/kdecore/sonnet

On Tuesday 01 December 2009 12:40:58 David Faure wrote:
> On Tuesday 01 December 2009, you wrote:
> > Well, the latest fixes seem to improve the situation but there are still
> > problems, especially with automated spell checking. If you want to see
> > for yourself, just open KWrite, activate automated spell checking and
> > type in some misspelled words. You'll see that some words are suddenly
> > flagged to be spelled correctly. The issue is here that words which are
> > only followed by a space character are not recognised as misspelled.
>
> If you don't report this to Zack, there are few chances of it getting fixed
> ;)

Of course, this has been reported to him already.

Michel

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________
Permalink | Reply | 0 comments |
headers
Sebastian Kügler | 1 Dec 15:17
Picon
Favicon
Gravatar

Re: KDE 4.4 Beta1 Tagging ahead

On Tuesday 01 December 2009 12:27:50 Sebastian Kügler wrote:
> On Monday 30 November 2009 16:02:28 Allen Winter wrote:
> > On Monday 30 November 2009 09:29:58 Sebastian Kügler wrote:
> > > On Monday 30 November 2009 15:04:05 Allen Winter wrote:
> > > > On Monday 30 November 2009 08:44:28 Dirk Mueller wrote:
> > > > > On Thursday 26 November 2009, Tom Albers wrote:
> > > > > > > want to ship outdated betas, since that makes bughunting less
> > > > > > > fun.
> > > > >
> > > > > ok, I'll tag tonight Beta1. Okay with everyone?
> > > >
> > > > Not ok with me.
[...]
Qt 4.6.0 was released today and contains a workaround for this problem. A more proper 
fix went into 4.6.1, so we're peachy. Right? :)
--

-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
Permalink | Reply | 4 comments |

Gmane