Re: Thumbnail Bar

Hello,

Thumbnail Bar:
-- Tested new "smooth scroll" feature. That's nice but only with
increased scroll duration time  = 800ms or so, with 250ms value
centering is instant on my system.

-- What do you think about Fish Eye effect? Personally I don't think
that fish eye is a good idea.
Probably making just one picture a little bigger (selected / hovered)?

-- About resizing thumbnails. Do you think it is needed?
About making view resizable as mentioned in one of comments in your blog:
"drag the edge of the thumbnail bar to resize it, and have all
thumbnails all grow or shrink accordingly".
Maybe not the edge of the bar, but the edge of a thumbnail. But that
is not obvious too.
It also can be a slider, but don't know where it can be placed. Maybe
hidden vertical one on left or right side of the bar?
Or somehow use thumbnail size of browse view?

-- Also found wish to remove "vertical dividing lines between the
pictures". Since style sheets is used, probably we can look for
external file and it exists try to load style sheet from it instead of
making one. So anyone can style thumbnails and the view as he wants.

Maybe that looks like an attempt to satisfy everyone and all of this
should be just leaved as is...

Fullscreen UI:

Re: Thumbnail Bar

Ilya Konkov a écrit :
> Hello.
> 
> 1. Scrollbar's arrows.
> Seems that I have to specify url for image. How and into what dir
> should I put images of arrows?

Hum... this is a bit tedious, because the Qt stylesheet system looks at 
relative urls from the current working directories. I suggest creating a 
  "pics" dir at the top level, and putting your images in it.
Then you can create a CMakeLists.txt similar to the one in "cursors/" to 
get your images installed.
Your code should use the full path to the images. Assuming you have a 
scroll-left.png file in pics, you can get its full path with: 
KStandardDirs::locate("appdata", "pics/scroll-left.png");

> 2. Hiding dirs/archives.
> I tried to make proxy model on top of existed SortedDirModel, but
> there were problems with syncing thumbnail views.
> So I added mime exclude filter to existed model. "Exclude" because it
> feels to be faster, but not sure -- it's just feeling.

Nice idea, just applied it.

Aurélien

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.

Feedback wanted on two recent changes

Hello,

I recently made a few changes to Gwenview for which I would like to have 
your feedback:

# Centering and smooth scrolling in the thumbnail bars
(I saw Ilya already commented about it, will reply)
The idea is to try to keep the current item centered in the thumbnail 
bar, this way you always get to see what's coming next. The problem is 
that if you click an item, it magically "jumps" to the center location, 
which is a bit surprising. To work around this, I added a smooth 
scrolling effect, which progressively scrolls the item to the center to 
avoid the abrupt jump.
The current scrolling time is 250 milliseconds. I wanted a longer time, 
but it conflicted with the loading of the image: Gwenview starts to load 
the image while the item is moving, which causes slowdown. The scrolling 
is not smooth at all anymore. It would be nice to have your feedback 
because I think this behavior varies depending on your machine power.
An alternative could be to start loading the image only after the item 
has been centered.

# View mode keyboard shortcuts
I added support for easily switching between view modes from the keyboard:
- "Return" key gives you more details: browse -> view -> fullscreen
- "Escape" key gives you less details: fullscreen -> view -> browse
How do you feel about these shortcuts?

Aurélien

-------------------------------------------------------------------------

Re: Thumbnail Bar

Ilya Konkov a écrit :
> Hello,
> 
> Thumbnail Bar:
> -- Tested new "smooth scroll" feature. That's nice but only with
> increased scroll duration time  = 800ms or so, with 250ms value
> centering is instant on my system.

As I said in my message asking for feedback, this is probably system 
dependent: on my machine, 1000ms causes the scrolling to be jerky 
because Gwenview starts loading the image.

> -- What do you think about Fish Eye effect? Personally I don't think
> that fish eye is a good idea.
> Probably making just one picture a little bigger (selected / hovered)?

I don't like Fish Eye effects and I don't like making picture bigger on 
mouse hover. I think it's good enough the way it is, but if you want to 
work on it I suggest tinting the picture a bit on hover by painting over 
the thumbnail with an almost transparent white (make sure you test it 
with pictures which aren't fully opaque too).

> -- About resizing thumbnails. Do you think it is needed?
> About making view resizable as mentioned in one of comments in your blog:
> "drag the edge of the thumbnail bar to resize it, and have all
> thumbnails all grow or shrink accordingly".
> Maybe not the edge of the bar, but the edge of a thumbnail. But that
> is not obvious too.
> It also can be a slider, but don't know where it can be placed. Maybe
> hidden vertical one on left or right side of the bar?

Re: Thumbnail Bar

> > 1. Scrollbar's arrows.
> > Seems that I have to specify url for image. How and into what dir
> > should I put images of arrows?
>
> Hum... this is a bit tedious, because the Qt stylesheet system looks at
> relative urls from the current working directories. I suggest creating a
>   "pics" dir at the top level, and putting your images in it.
> Then you can create a CMakeLists.txt similar to the one in "cursors/" to
> get your images installed.
> Your code should use the full path to the images. Assuming you have a
> scroll-left.png file in pics, you can get its full path with:
> KStandardDirs::locate("appdata", "pics/scroll-left.png");

Screenshot:
http://img249.imageshack.us/img249/7686/gwenview02040lb9.png

--
Ilya Konkov

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

_______________________________________________

Re: Feedback wanted on two recent changes

Hello,

> # Centering and smooth scrolling in the thumbnail bars
> The current scrolling time is 250 milliseconds. I wanted a longer time,
> but it conflicted with the loading of the image: Gwenview starts to load
> the image while the item is moving, which causes slowdown. The scrolling
> is not smooth at all anymore.

Actually I can see slowdowns too with a longer time.

> # View mode keyboard shortcuts
> How do you feel about these shortcuts?

I like the shortcuts.

--
Ilya Konkov

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Fullscreen themes

Hello,

I just introduced a new "hidden feature" in Gwenview: the ability to 
create themes for the fullscreen bar. It's not finished yet, I still 
have to move some of Ilya styling code to the theme stylesheet, but it's 
coming there (BTW Ilya, I integrated your scrolling buttons, but using 
the theme system).

If you are curious enough, have a look at the new fullscreenthemes/ dir 
in Gwenview source. Adding a theme is as easy as making a copy of the 
current theme dir (blackglass, for lack of a better name) to a new dir 
and adding the new dir to the CMakeLists.txt file. To enable your theme, 
edit ~/.kde/share/config/gwenviewrc, locate the [FullScreen] section and 
define the FullScreenTheme key to the name of your theme.

I think it would be a good idea to organize a theme contest after KDE 
4.1 alpha 1 is out to get some themes to include for the stable release.

Aurélien

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Re: Fullscreen themes

Hello,

> It's not finished yet, I still  have to move some of Ilya styling code to the theme > stylesheet, but it's
coming there (BTW Ilya, I integrated your scrolling buttons, > but using the theme system).

I tried to do it myself yesterday, but at the end decided to wait
until you finish theme code.
I added parent to QPushButton selectors in style.css to avoid styling
meta information dialog, it was okay yesterday because stylesheet was
applied only for configDialog.

--
Ilya Konkov

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

_______________________________________________
Gwenview-general mailing list
Gwenview-general@...
https://lists.sourceforge.net/lists/listinfo/gwenview-general

Re: Fullscreen themes

Ilya Konkov a écrit :
> Hello,
> 
>> It's not finished yet, I still  have to move some of Ilya styling code to the theme > stylesheet, but it's
coming there (BTW Ilya, I integrated your scrolling buttons, > but using the theme system).
> 
> I tried to do it myself yesterday, but at the end decided to wait
> until you finish theme code.
> I added parent to QPushButton selectors in style.css to avoid styling
> meta information dialog, it was okay yesterday because stylesheet was
> applied only for configDialog.

Good catch, I just applied it.

Since you are getting more and more involved in Gwenview, you may want 
to ask for a KDE svn account so that you can commit your work yourself.

It would still be a good idea to post large patches for review before 
committing, but having your own account should make your life easier.

For more information about getting an svn account, follow this link:
http://techbase.kde.org/index.php?title=Contribute/Get_a_SVN_Account

Aurélien

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

Re: Fullscreen themes

Aurélien Gâteau a écrit :
> To enable your theme, 
> edit ~/.kde/share/config/gwenviewrc, locate the [FullScreen] section and 
> define the FullScreenTheme key to the name of your theme.

No need for this anymore, I just added a list view to select your theme 
from the config dialog. Now we need more than one theme 

Aurélien

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace