1 Mar 2005 13:21
[PATCH] Problems with rotating
Hello, when one rotates an image using Ctrl+R, the image size is not updated, so the viewed image appears to be cut on sides. The problem is that code in rather many places calls setImage() without following it with sizeUpdated() and/or rectUpdated(). The attached src.patch fixes that by adding another bool argument to setImage() which should avoid forgetting doing so. Please check. Another problem caused by this patch is that now even things like rotating cause the frame which is show during loading to be shown. The possibilities are either src_sizeknown.patch, which adds sizeKnown() call which is used only by the loader when the size of the image is known, or (my preferred) gvscrollpixmapview.cpp.patch, which simply removes the frame. I've personally never like the frame much, other image viewers don't have it, and IMHO it adds perceived flicker when quickly changing images. Note that there are even more problems with rotating. When using the KIPI plugin for that the image is not updated. Moreover the lossless transformation seems to be broken, at least here on SUSE, so rotating jpeg's causes shifts in the images :(. No patches for that. -- -- Lubos Lunak KDE developer --------------------------------------------------------------------- SuSE CR, s.r.o. e-mail: l.lunak@... , l.lunak@... Drahobejlova 27 tel: +420 2 9654 2373 190 00 Praha 9 fax: +420 2 9654 2374 Czech Republic http://www.suse.cz/(Continue reading)
.
> Note that there are even more problems with rotating. When using the KIPI
> plugin for that the image is not updated. Moreover the lossless
> transformation seems to be broken, at least here on SUSE, so rotating
> jpeg's causes shifts in the images :(. No patches for that.
Argh... the JPEG bug really need to be fixed before releasing 1.2.0. I'm going
to investigate.
RSS Feed