Lubos Lunak | 1 Jan 15:45 2005
Picon

Re: [PATCH] Animated pictures (#80132)

Dne pá 31. prosince 2004 4:36 Steven Karp napsal(a):
> On Wednesday 29 December 2004 3:12 pm, Lubos Lunak wrote:
> >  last one this year. The attached src.patch kind of implements support
> > for animated pictures. 'Kind of' because it more or less works, but there
> > are still some rough edges.
>
> I've only tried a couple of files so far, but I agree that it does at least
> "more or less" work.  So far the only issue I've noticed is that if the
> image uses a transparent background color it doesn't honor the Gwenview
> background color setting, but instead shows a standard pattern of grey
> squares.  I consider this annoying but largely unimportant.

 ??? Either I don't get what you mean, or that's simply how all transparent 
images are displayed, being animated or not. I don't see any problem specific 
to animated transparent images.

> If I see any significant issues, I'll report them appropriately.
>
> > - Qt has no support for writing multiframe images. Which means one can
> > e.g. rotate them as much as they want, but then it cannot be saved. To
> > make this worse, Gwenview currently overwrites(=destroys) the original
> > file when saving fails. See gvdocumentloadedimpl.cpp.patch , that should
> > fix this problem. I seem to recall seeing here something about problems
> > with formats which can be only read but are without write support, maybe
> > there's the same problem.
>
> After applying this patch, my compile fails:
> gvdocumentloadedimpl.cpp: In member function `virtual QString
>    GVDocumentLoadedImpl::save(const KURL&, const QCString&) const':
> gvdocumentloadedimpl.cpp:93: error: `::unlink' undeclared (first use here)
(Continue reading)

Steven Karp | 1 Jan 20:34 2005

Re: [PATCH] Animated pictures (#80132)

Happy New Year!

On Saturday 01 January 2005 6:45 am, Lubos Lunak wrote:
>  ??? Either I don't get what you mean, or that's simply how all transparent
> images are displayed, being animated or not. I don't see any problem
> specific to animated transparent images.

I went looking through my image collection and realized that the only 
transparent images I have are animated.  So I threw together a quick 
non-animated transparent GIF and took a look.  You are correct -- animation 
has nothing to do with the handling of transparency.

Personally, I'd still consider that a bug, but I could see it as a legitimate 
design decision.

> > Do I need some other patch in addition?
>
>  #include <unistd.h> missing, some other .h file pulled it in here
> apparently. I'll fix it.

Thanks.  I think I'll wait for the next official build to try it, and spend 
the time until then testing animated GIFs.

	S.

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
(Continue reading)

Lubos Lunak | 1 Jan 23:53 2005
Picon

Re: [PATCH] Animated pictures (#80132)

Dne pá 31. prosince 2004 19:32 Aurelien Gateau napsal(a):
> Le Jeudi 30 Décembre 2004 00:12, Lubos Lunak a écrit :
> > - I think that the class GVDocumentDecodeImpl (boy, I hate these long
> > GVDocument* names) is a small design flaw. Other GVDocument*Impl classes
> > hold the actual loaded image (or null image), and take care of it, but
> > this one is different, and does different things. If you look at the
> > GVDocumentImpl base class, there are virtual methods that don't make
> > sense in the decode class, or in the others.
>
> [snip]
>
> >  Aurelien, would it be ok to rewamp this a bit, if I get to it somewhen
> > (definitely not for this stable), or are there reasons why it is this
> > way?
>
> Yes, it's ok to revamp it. The current implementation is the first attempt
> to something more complicated than QImage::load(), so it can be improved.
> DecodeImpl is quite complicated. Having both threaded and non-threaded
> loading does not make it easy to simplify, though.

 It probably doesn't need that big revamp, it just shouldn't be 
GVDocument*Impl, so that the matching GVDocument*Impl can step in already 
while loading - so that animated pictures can start animating already while 
loading next frames, or so that the JPEG orientation is applied already while 
loading and showing the image (#96005). It's probably rather the stuff around 
that'll need changes.

>
> >  Hmm, that's all I guess. Unless there are some comments, I intend to
> > commit this, and fix possible problems as they arise. It's better than
(Continue reading)

Aurelien Gateau | 2 Jan 00:06 2005
Picon

Re: [PATCH] Animated pictures (#80132)

Le Samedi 1 Janvier 2005 23:53, Lubos Lunak a écrit :
> > I would just request one thing: If possible, instead of using two
> > QValueVectors for the frame image and the frame time, create a
> > GVImageFrame to store both and use a single QValueVector to store them.
> > It would make the code nicer.
>
>  Ok, done. I'm afraid the app description at kde-apps/freshmeat now needs
> an update ;).

Let's wait until 1.1.8 is out to do so :-). Thank you very much for this great 
work, Lubos!

Aurélien

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
Aurélien Gâteau | 2 Jan 00:47 2005
Picon

kdeextragear-1/gwenview

CVS commit by gateau: 

Make sure the dock configuration is correctly handled when upgrading from
previous version of Gwenview where it was possible to undock the file view.

Since the way KDockWidget store its settings is quite opaque, I just added a
"Gwenview version" entry to the dock group in the configuration file. If this
version is not the expected one, Gwenview will not load the dock settings and
display a warning instead.
I'm not very satisfied about the information message telling the user his
configuration has been lost. Feel free to rephrase.

CCMAIL: gwenview-general@...

  M +2 -0      NEWS   1.206
  M +24 -2     src/gvmainwindow.cpp   1.153

--- kdeextragear-1/gwenview/NEWS  #1.205:1.206
 <at>  <at>  -10,4 +10,6  <at>  <at> 
  - "Lock zoom"/"Auto zoom" options fixed
  - Fixed "Clear location"/"Location" shortcuts.
+ - Make it impossible to undock the file view. It should be easier for new
+   users to use it this way.

 2004.12.19 - v1.1.7

--- kdeextragear-1/gwenview/src/gvmainwindow.cpp  #1.152:1.153
 <at>  <at>  -50,4 +50,5  <at>  <at>  Foundation, Inc., 59 Temple Place - Suit
 #include <klocale.h>
 #include <kmenubar.h>
(Continue reading)

Aurelien Gateau | 2 Jan 18:17 2005
Picon

New build fix release

Just to let you know, I just released version 1.1.7a, which is just like 1.1.7 
with the build fix.

Aurélien

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
Aurelien Gateau | 7 Jan 00:26 2005
Picon

Next release

Just a quick note to remind you 1.1.8 will be released this week end.

Regards,
  Aurélien

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
Lubos Lunak | 7 Jan 12:52 2005
Picon

Fwd: Poor print quality with KDE apps


 Hello,

 I noticed this discussion on one SUSE list, and it seems possible the 
Konqueror case is actually the Gwenview KPart, because it's the default in 
the latest release. I had a quick look at GVDocument::doPaint() and it looks 
to me like Gwenview has the below-mentioned problem, but I'm not sure. Could 
you please check it? I'll file this as a bugreport if needed if it's valid.

----------  Forwarded Message  ----------

On Thu, Jan 06, 2005 at 09:23:48PM +0100, Waldo Bastian wrote:
> On Thursday 06 of January 2005 2:21, Kurt Garloff wrote:
> > Hi,
> >
> > my HP inkjet colour printer is able to print decent quality pictures.
> > I use the IJS drivers and am happy with the results.
> >
> > However, the quality strongly depends on the application that I use
> > to print:
> > * Use print menu from konqueror or kuickshow:
> >   -> very bad quality
> > * Use gimp print menu
> >   -> good quality (but a bit low saturation)
> > * Drag and drop .png to Printer icon
> >   -> good quality
> >
> > When I use print to .ps, I see the difference in filesize clearly.
> > Test done with a 2000x2800 .png file to an A4 page ...
> >
(Continue reading)

Aurélien Gâteau | 7 Jan 13:29 2005
Picon

Regression when loading PNG or GIF images

I just noticed that since the anim patch was merged,non animated PNG and GIF
images are not always displayed. I think it's a cache issue, because if I click
image A.png: it's not visible, but if I select B.png then come back to A.png it
is displayed.
Lubos, can you have a look at this? I would like to avoid releasing 1.1.8 with
this bug.

Regards,
  Aurélien

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
Lubos Lunak | 7 Jan 15:35 2005
Picon

Re: Regression when loading PNG or GIF images

On Friday 07 of January 2005 13:29, Aurélien Gâteau wrote:
> I just noticed that since the anim patch was merged,non animated PNG and
> GIF images are not always displayed. I think it's a cache issue, because if
> I click image A.png: it's not visible, but if I select B.png then come back
> to A.png it is displayed.
> Lubos, can you have a look at this? I would like to avoid releasing 1.1.8
> with this bug.

 Fixed.

--

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@... , l.lunak@...
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/

-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Gmane