Sebastian Stein | 3 Jan 2011 08:13
Picon
Picon

: Re: [patch] build applications standalone

Niko Sams <niko.sams <at> gmail.com> [101227 21:00]:
> did this patch reach reach the list?

It might be that this patch was caught by a spam filter, but I have not seen
it in my inbox. Should we submit it anyway to trunk anyway?

Regards,

Sebastian
--

-- 
http://sebstein.hpfsc.de/
Alexander Rieder | 3 Jan 2011 21:23
Picon

: Re: Review Request: Cantor: Use default backend if pressing "New" and provide a menu "New" to create worksheet with specific backend

This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6121/

Ship it!

trunk is open again. Can you commit this, or should I do it for you?

- Alexander


On December 15th, 2010, 6:12 p.m., Jan Gerrit Marker wrote:

Review request for KDE-Edu.
By Jan Gerrit Marker.

Updated 2010-12-15 18:12:50

Description

1) Use the default backend when creating a new worksheet. It only asks for the default backend if no default backend is given (changed that to the default in the config file, to ask for the backend when Cantor is started the first time). 2) Change addWorksheet() to display the newly created tab. 3) Add a menu to the file menu with a list of the available and enabled backends to create a new worksheet with a specific backend.

Testing

Tested and it was fine.
Bugs: 225726

Diffs

  • trunk/KDE/kdeedu/cantor/src/cantor.cpp (1206532)
  • trunk/KDE/kdeedu/cantor/src/cantor.kcfg (1206532)
  • trunk/KDE/kdeedu/cantor/src/cantor_shell.rc (1206532)

View Diff

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Aleix Pol | 3 Jan 2011 23:06
Picon
Favicon
Gravatar

: Re: Review Request: KAlgebra: avoid the calculation of derivatives for draw tangents

This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6268/

Regarding explicit plots, as I said to you I think it's good to stick with symbolic derivation because it highlights the missing features. Note that the printed slope is just visual sugar but not any extracted information. That leads to my next point: it makes no sense to add the new interface to function.h, the slope should be given 1 point, not an interval. You're extracting it from the last mouse position, that's not what we are providing semantically. If the only way to provide a slope for implicit plots is to draw a line across the two closer points, that should be done in functionimplicit.cpp exclusively. (you can get the last position received by saving it in ::calc, for instance)

- Aleix


On January 3rd, 2011, 9:14 p.m., Percy Camilo Triveño Aucahuasi wrote:

Review request for KDE-Edu, Aleix Pol and Percy Camilo Triveño Aucahuasi.
By Percy Camilo Triveño Aucahuasi.

Updated 2011-01-03 21:14:26

Description

Currently KAlgebra needs to calculate the derivative of the function for draw its tangent line, this calculation is done each time the mouse is moving inside the 2d area. The drawbacks for this method are: - KAlgebra can't draw the tangent on any case, becouse the parser doesn't know how to calculate the derivative for all types of functions and operators. - The derivative of many functions can't be calculated becouse the function could have a singular point or may be non-smooth. - This approach need to use numerical methods, so the complexity (and time) for such a simple task like draw the tangent, is the combination of 2 opperations: calculate the derivative and apply a numerical method to find the tangent ... if the derivative fails then the numerical method will fail. - Fails for implicit curves. This patch made possible to calculate the line tangent by a simple geometric method, the pros over the current state are: - It works on any case, even if the parser can't obtain/evaluate the derivative. - Doesn't need numerical methods. - The complexity and the time would be: two subtractions and one division ... - It works for implicit curves or even if the function have a singular point or isn't smooth. This patch doesn't add new features but improves the behaviour and scope of KAlgebra ;) Cheers, Percy ;)

Testing

(x, y)->x-y^sin(y) power(x, sin(x))

Diffs

  • /trunk/KDE/kdeedu/kalgebra/analitzagui/function.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/function.cpp (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionimpl.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionimpl.cpp (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionsmodel.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionsmodel.cpp (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/graph2d.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/graph2d.cpp (1211228)

View Diff

Screenshots

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Picon

: Re: Review Request: KAlgebra: avoid the calculation of derivatives for draw tangents

This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6268/

On January 3rd, 2011, 10:06 p.m., Aleix Pol wrote:

Regarding explicit plots, as I said to you I think it's good to stick with symbolic derivation because it highlights the missing features. Note that the printed slope is just visual sugar but not any extracted information. That leads to my next point: it makes no sense to add the new interface to function.h, the slope should be given 1 point, not an interval. You're extracting it from the last mouse position, that's not what we are providing semantically. If the only way to provide a slope for implicit plots is to draw a line across the two closer points, that should be done in functionimplicit.cpp exclusively. (you can get the last position received by saving it in ::calc, for instance)
As you say, the same idea behind the patch could be apply only on functionimpl*, what I'm saying is that is not necesary to have a high and complex way to do this "visual suguar", if we can do this with less operations, fastter and more robust, then there is no need to stick to the idea to calculate the derivatives and employ numerical methods instead a couple of operactiones. Please note that with polar and parametric curves will be more difficult to draw a tangent line using derivatives, it would be more easy and fast through a geometrically approach ... this isn't an improvement only for implicit curves, but all the plane curves. If is need it, I can try to port the same patch on functionimpl*, in any case isn't a matter of where to place this code, we can work on this subject ;) Percy

- Percy Camilo


On January 3rd, 2011, 9:14 p.m., Percy Camilo Triveño Aucahuasi wrote:

Review request for KDE-Edu, Aleix Pol and Percy Camilo Triveño Aucahuasi.
By Percy Camilo Triveño Aucahuasi.

Updated 2011-01-03 21:14:26

Description

Currently KAlgebra needs to calculate the derivative of the function for draw its tangent line, this calculation is done each time the mouse is moving inside the 2d area. The drawbacks for this method are: - KAlgebra can't draw the tangent on any case, becouse the parser doesn't know how to calculate the derivative for all types of functions and operators. - The derivative of many functions can't be calculated becouse the function could have a singular point or may be non-smooth. - This approach need to use numerical methods, so the complexity (and time) for such a simple task like draw the tangent, is the combination of 2 opperations: calculate the derivative and apply a numerical method to find the tangent ... if the derivative fails then the numerical method will fail. - Fails for implicit curves. This patch made possible to calculate the line tangent by a simple geometric method, the pros over the current state are: - It works on any case, even if the parser can't obtain/evaluate the derivative. - Doesn't need numerical methods. - The complexity and the time would be: two subtractions and one division ... - It works for implicit curves or even if the function have a singular point or isn't smooth. This patch doesn't add new features but improves the behaviour and scope of KAlgebra ;) Cheers, Percy ;)

Testing

(x, y)->x-y^sin(y) power(x, sin(x))

Diffs

  • /trunk/KDE/kdeedu/kalgebra/analitzagui/function.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/function.cpp (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionimpl.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionimpl.cpp (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionsmodel.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/functionsmodel.cpp (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/graph2d.h (1211228)
  • /trunk/KDE/kdeedu/kalgebra/analitzagui/graph2d.cpp (1211228)

View Diff

Screenshots

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Niko Sams | 4 Jan 2011 08:02
Picon
Gravatar

: Re: [patch] build applications standalone

On Mon, Jan 3, 2011 at 18:13, Sebastian Stein <seb_stein <at> gmx.de> wrote:
> Niko Sams <niko.sams <at> gmail.com> [101227 21:00]:
>> did this patch reach reach the list?
>
> It might be that this patch was caught by a spam filter, but I have not seen
> it in my inbox. Should we submit it anyway to trunk anyway?
>
>
well, you shou carefully review first.

But I hope this gets submitted, as else split repositories won't be possible.

I uploaded it here a second time, to avoid anz problems:
http://paste.kde.org/1766/

Niko
Matteo Agostinelli | 4 Jan 2011 15:28
Picon

: Qalculate backend for Cantor - Help system

Hello,

I am currently working on the Qalculate backend for Cantor, trying to get it 
in shape for inclusion in the next release. I have started with the existing 
code in playground (thanks to Millian Wolff) and you can check the progress in 
svn trunk. 

I have already committed some work, basically introducing new options and the 
corresponding configuration dialog.

For the moment I have one question (I guess more will follow :). How do I get 
the Help system to work? If I understood the code correctly, I think I have to 
do a 

setResult(new Cantor::HelpResult(text))

in the QalculateExpression class somewhere. Right now I am trying to put it in 
the evaluate() method and call it when "help" is detected in the command, but 
nothing seems to happen. What am I doing wrong?

Thanks,
Matteo
Albert Astals Cid | 4 Jan 2011 21:32
Picon
Favicon
Gravatar

: Re: [patch] build applications standalone

A Dimarts, 4 de gener de 2011, Niko Sams va escriure:
> On Mon, Jan 3, 2011 at 18:13, Sebastian Stein <seb_stein <at> gmx.de> wrote:
> > Niko Sams <niko.sams <at> gmail.com> [101227 21:00]:
> >> did this patch reach reach the list?
> > 
> > It might be that this patch was caught by a spam filter, but I have not
> > seen it in my inbox. Should we submit it anyway to trunk anyway?
> 
> well, you shou carefully review first.
> 
> But I hope this gets submitted, as else split repositories won't be
> possible.
> 
> I uploaded it here a second time, to avoid anz problems:
> http://paste.kde.org/1766/

I see you removing the cmake files but not adding them anywhere.
It also seems that you want to put that missing files in cmake/ but i think 
they should go to cmake/modules

Also i'm not sure 
-include_directories( ${CMAKE_SOURCE_DIR}/libkdeedu/keduvocdocument/   )
+include_directories( .. )
is correct.

But basically i would not bother about breaking stuff, it's trunk after all, 
if you are fairly confident that it works and will be around to fix any 
problem that might arise, I'd say that you just commit the patch ;-)

Albert

> 
> Niko
> _______________________________________________
> kde-edu mailing list
> kde-edu <at> mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu
Aleix Pol | 4 Jan 2011 21:42
Picon
Favicon
Gravatar

: Re: [patch] build applications standalone

On Tue, Jan 4, 2011 at 9:32 PM, Albert Astals Cid <aacid <at> kde.org> wrote:
A Dimarts, 4 de gener de 2011, Niko Sams va escriure:
> On Mon, Jan 3, 2011 at 18:13, Sebastian Stein <seb_stein <at> gmx.de> wrote:
> > Niko Sams <niko.sams <at> gmail.com> [101227 21:00]:
> >> did this patch reach reach the list?
> >
> > It might be that this patch was caught by a spam filter, but I have not
> > seen it in my inbox. Should we submit it anyway to trunk anyway?
>
> well, you shou carefully review first.
>
> But I hope this gets submitted, as else split repositories won't be
> possible.
>
> I uploaded it here a second time, to avoid anz problems:
> http://paste.kde.org/1766/

I see you removing the cmake files but not adding them anywhere.
It also seems that you want to put that missing files in cmake/ but i think
they should go to cmake/modules

Also i'm not sure
-include_directories( ${CMAKE_SOURCE_DIR}/libkdeedu/keduvocdocument/   )
+include_directories( .. )
is correct.

But basically i would not bother about breaking stuff, it's trunk after all,
if you are fairly confident that it works and will be around to fix any
problem that might arise, I'd say that you just commit the patch ;-)

Albert

>
> Niko
> _______________________________________________
> kde-edu mailing list
> kde-edu <at> mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

I'd say let's commit something that's somewhat working and ask the teams to organize themselves to get the projects working until a date. I think that would help, to have it there and start being able to fiddle with it.

Aleix
_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
Sebastian Stein | 4 Jan 2011 21:58
Picon
Picon

: Re: [patch] build applications standalone

Albert Astals Cid <aacid <at> kde.org> [110104 21:56]:
> But basically i would not bother about breaking stuff, it's trunk after all, 
> if you are fairly confident that it works and will be around to fix any 
> problem that might arise, I'd say that you just commit the patch ;-)

Yes, I like to second this view. Please submit the patch so that we can fix
it directly :-)

Regards,

Sebastian
--

-- 
http://sebstein.hpfsc.de/
Alexander Rieder | 5 Jan 2011 00:36
Picon

: Re: Qalculate backend for Cantor - Help system

On Tuesday 04 January 2011 15:28:25 Matteo Agostinelli wrote:
> Hello,
> 
> I am currently working on the Qalculate backend for Cantor, trying to get it
> in shape for inclusion in the next release. I have started with the
> existing code in playground (thanks to Millian Wolff) and you can check the
> progress in svn trunk.
> 
> I have already committed some work, basically introducing new options and
> the corresponding configuration dialog.
> 
> For the moment I have one question (I guess more will follow :). How do I
> get the Help system to work? If I understood the code correctly, I think I
> have to do a
> 
> setResult(new Cantor::HelpResult(text))
> 
> in the QalculateExpression class somewhere. Right now I am trying to put it
> in the evaluate() method and call it when "help" is detected in the
> command, but nothing seems to happen. What am I doing wrong?
> 
> Thanks,
> Matteo
> 

Hi,
you were doing anything right, it was a bug in the Cantor code.
Should be fixed in trunk with r1211783. Thanks for working on this backend.

regards,
Alexander

Gmane