Re: : Review Request: [Cantor] Improved Script editor window

> On 2010-05-03 21:43:17, Alexander Rieder wrote:
> > Hi,
> > I'll do a more in depth review tomorrow, but here are the first problems:
> > I've tried to compile Cantor with your patch applied, and it failed.
> > I had to adjust the following things:
> > - cantor_part.cpp line 558: change KAction to QAction
> > - scripteditorwidget.cpp line 50: change KTextEditor to KTextEditor::Editor
> > 
> > From a first glance the functionality looks nice, but again I'll do more testing tomorrow probably.

Of course, that should KTextEditor::Editor, I missed it when I addded it as a member and then removed again. 

I really thought actionCollection()->action() returns a KAction, and it worked this way. I'll fix it and
update as soon as I get home.

- Miha

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3878/#review5382
-----------------------------------------------------------

On 2010-05-03 21:12:26, Miha Cancula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3878/
> -----------------------------------------------------------
> 

Re: : Review Request: [Cantor] Improved Script editor window

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3878/#review5412
-----------------------------------------------------------

Hi,

overall the patch seems good, and the functionality is definately an improvement. so thanks for working on this.
There are still some issues left though:
- dont use KDE/ prefix in your includes, it isn't used anywhere else and this should stay consistent
- use the <kdename.h> includes for kde-headers, e.g. <kxmlguifactory.h> instead of <KXMLGUIFactory> (I
may not be completely consistent with this myself, but it should be a guideline)
- The caption correctly updates if I open a file, but it doesn't when saving. You should have a look at your
connections, and probably completely remove the parameter, as Qt is smart enough to connect to a slot
which takes fewer parameters than the signal.

- Alexander

On 2010-05-04 20:34:30, Miha Cancula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3878/
> -----------------------------------------------------------
> 
> (Updated 2010-05-04 20:34:30)
> 
> 
> Review request for KDE-Edu and Alexander Rieder.

: parley doesn't build on Solaris

Hi,

Parley currently doesn't build on Solaris with the Sun Studio compiler:
http://my.cdash.org/viewBuildError.php?buildid=64774

Can you please have a look and fix it ?

These builds are executed every day on Linux and Solaris, and hopefully soon 
also on other platforms.
If you want to receive automatic emails if the build of kdeedu breaks, go to 
http://my.cdash.org, get a login, and then subscribe to the "kdeedu" project.

Alex

Re: : Review Request: [Cantor] Improved Script editor window

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3878/#review5496
-----------------------------------------------------------

Ship it!

Looks really good, and now as I think of it it shouldn't interfere with the soft-freeze, as its no new feature
afterall, just an improvement on the old(just make sure we don't hit the hard-freeze on tuesday).
Do you have an svn account to commit this? If not I suggest you to apply for one (see
http://techbase.kde.org/Contribute/Get_a_SVN_Account), as I hope you'll do more work during your
Season of KDE.

Thank you for your work.

- Alexander

On 2010-05-07 13:00:53, Miha Cancula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3878/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 13:00:53)
> 
> 
> Review request for KDE-Edu and Alexander Rieder.
> 

: BoF Session at Akademy

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

Re: : Review Request: [Cantor] Improved Script editor window

> On 2010-05-07 14:18:02, Alexander Rieder wrote:
> > Looks really good, and now as I think of it it shouldn't interfere with the soft-freeze, as its no new
feature afterall, just an improvement on the old(just make sure we don't hit the hard-freeze on tuesday).
> > Do you have an svn account to commit this? If not I suggest you to apply for one (see
http://techbase.kde.org/Contribute/Get_a_SVN_Account), as I hope you'll do more work during your
Season of KDE.
> > 
> > Thank you for your work.

Thank you, I already got the account, I committed the patch as r1124106.

- Miha

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3878/#review5496
-----------------------------------------------------------

On 2010-05-07 13:00:53, Miha Cancula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3878/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 13:00:53)
> 
> 
> Review request for KDE-Edu and Alexander Rieder.
> 
> 
> Summary
> -------
> 
> Change the script editor to use XmlGui for actions, with complete KTextEditor toolbars and menus.
> 
> The patch is a little rough still, with unneeded whitespace changes, I will probably update it soon. There
are also some leftover debug calls and error checks. You can see the code and comment on it. I will also
explain and/or correct any wtf-moments that may have occured. 
> 
> I realize that trunk is in a soft treeze right now, and that this isn't a killer feature, so I think there's no
rush to get it commited. I would like some feedback on it.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/cantor/src/scripteditorwidget.cpp 1123901 
>   /trunk/KDE/kdeedu/cantor/src/CMakeLists.txt 1123901 
>   /trunk/KDE/kdeedu/cantor/src/cantor.cpp 1123901 
>   /trunk/KDE/kdeedu/cantor/src/cantor_part.h 1123901 
>   /trunk/KDE/kdeedu/cantor/src/cantor_part.cpp 1123901 
>   /trunk/KDE/kdeedu/cantor/src/cantor_scripteditor.rc PRE-CREATION 
>   /trunk/KDE/kdeedu/cantor/src/scripteditorwidget.h 1123901 
> 
> Diff: http://reviewboard.kde.org/r/3878/diff
> 
> 
> Testing
> -------
> 
> The GUI looks and behaves properly. I tried some different ways of closing the script editor and the
running session and it behaved as expected in all of them. 
> 
> It was tested with last week's trunk.
> 
> 
> Screenshots
> -----------
> 
> Script editor with KTextEditor's menus
>   http://reviewboard.kde.org/r/3878/s/385/
> 
> 
> Thanks,
> 
> Miha
> 
>

Re: : parley doesn't build on Solaris

Hi,

On Thursday 06 May 2010 21:45:17 Alexander Neundorf wrote:
> Parley currently doesn't build on Solaris with the Sun Studio compiler:
> http://my.cdash.org/viewBuildError.php?buildid=64774
> 
> Can you please have a look and fix it ?

I think Pino already fixed, it, now I moved the class into the proper namespace 
in addition. Hope that fixes all trouble. Thanks for the hint!

> 
> These builds are executed every day on Linux and Solaris, and hopefully
> soon also on other platforms.
> If you want to receive automatic emails if the build of kdeedu breaks, go
> to http://my.cdash.org, get a login, and then subscribe to the "kdeedu"
> project.
will do

Frederik

> 
> Alex
> _______________________________________________
> kde-edu mailing list
> kde-edu <at> mail.kde.org
> https://mail.kde.org/mailman/listinfo/kde-edu

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

: Open source quizzes

Hi all,

I'm the Windows maintainer of Childsplay, Schoolsplay en Cognitionplay
(see www.schoolsplay.org)
Recently we have been working with a company that makes training
computers for elderly people based on our software.
Quizzes are an important part of their version for the Dutch market.
In the open source version we have the framework but not the content.
So we are looking for quizzes that we can use in our version.
Do anybody have any links to open source quizzes in different languages?

Greets,

Chris

: Review Request: Implicit curves in KAlgebra

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3956/
-----------------------------------------------------------

Review request for KDE-Edu, Aleix Pol and Percy Camilo Triveño Aucahuasi.

Summary
-------

This feature is in the list:
http://techbase.kde.org/Schedules/KDE4/4.5_Feature_Plan#kdeedu

It add to KAlgebra basic support for drawing implicit curves.

Diffs
-----

  /trunk/KDE/kdeedu/kalgebra/src/function.cpp 1125717 
  /trunk/KDE/kdeedu/kalgebra/src/functionimplicit.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3956/diff

Testing
-------

Some tests were done with curves like:

x**2+y**2-16
x**2+y**2-25*x
y+x
(2*x+y)*(x^2+y^2)^4+2*y*(5*x^4+10*x^2*y^2-3*y^4)-2*x+y

Screenshots
-----------

implicit curve
  http://reviewboard.kde.org/r/3956/s/387/

Thanks,

Percy Camilo

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

: Crossword puzzles

_______________________________________________
kde-edu mailing list
kde-edu <at> mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu