Renchi Raju | 3 Jun 00:08 2004
Picon

kdeextragear-3/digikam

CVS commit by pahlibar: 

CCMAIL: Ralf Hoelzer <ralf <at> well.com>, digikam-devel <at> lists.sourceforge.net

added checks for getting the version of libexif and do conditional 
compiling for kexifentry. hopefully should work both with 0.6.9 and
0.5.12 versions of libexif. can anyone with libexif >= 0.6.9 confirm
that. additionally the configure script should not barf if 
libexif can't be found

renchi

  M +7 -0      configure.in.bot   1.3
  M +10 -1     utilities/configure.in.in   1.5
  M +4 -0      utilities/kexif/kexifentry.cpp   1.4

--- kdeextragear-3/digikam/configure.in.bot  #1.2:1.3
 <at>  <at>  -15,2 +15,9  <at>  <at> 
   echo ""
 fi
+
+if test "$NO_LIBEXIF" = "yes"; then
+  echo ""
+  echo "DigiKam needs libexif. You need to install libexif, e.g. from"
+  echo "http://libexif.sourceforge.net"
+  echo ""
+fi

--- kdeextragear-3/digikam/utilities/configure.in.in  #1.4:1.5
 <at>  <at>  -66,5 +66,14  <at>  <at> 
(Continue reading)

Renchi Raju | 3 Jun 04:44 2004
Picon

kdeextragear-3/digikam

CVS commit by pahlibar: 

CCMAIL: Ralf Hoelzer <ralf <at> well.com>, digikam-devel <at> lists.sourceforge.net
more subdued highlighting for thumbnails. 
load the metainfo only if its requested (showing the initial screen with
filenames and empty thumbnails should be much faster now if file comments
and/or resolution is not requested). fix memory leak if file metainfo is
requested multiple times.
in setup warn users that above two makes things slower.

  M +95 -73    digikam/albumiconitem.cpp   1.18
  M +11 -7     digikam/albumiconview.cpp   1.22
  M +14 -23    interfaces/thumbnailjob.cpp   1.3
  M +2 -2      utilities/setup/setupgeneral.cpp   1.16

Richard Taylor | 3 Jun 11:01 2004
Picon

Re: kdeextragear-3/digikam

Renchi

This may be just because I have broken something but ...

I have libexif-0.6.9 installed. The latest CVS builds fine, but when I run the 
executable it is still looking for libexif.so.9. I get this error:

rjt@... kdeextragear-3 $ digikam/digikam/digikam
/home/rjt/devel/digikam/kdeextragear-3/digikam/digikam/.libs/lt-digikam: error 
while loading shared libraries: libexif.so.9: cannot open shared object file: 
No such file or directory

I am not sure whether this is a problem with my setup or the configure stuff.

Regards

Richard

On Wednesday 02 June 2004 23:08, Renchi Raju wrote:
> CVS commit by pahlibar:
>
>
> CCMAIL: Ralf Hoelzer <ralf@...>, digikam-devel@...
>
> added checks for getting the version of libexif and do conditional
> compiling for kexifentry. hopefully should work both with 0.6.9 and
> 0.5.12 versions of libexif. can anyone with libexif >= 0.6.9 confirm
> that. additionally the configure script should not barf if
> libexif can't be found
>
(Continue reading)

Renchi Raju | 3 Jun 15:49 2004
Picon

Re: kdeextragear-3/digikam


On Thu, 3 Jun 2004, Richard Taylor wrote:

> Renchi
>
> This may be just because I have broken something but ...
>
> I have libexif-0.6.9 installed. The latest CVS builds fine, but when I run the
> executable it is still looking for libexif.so.9. I get this error:
>
> rjt@... kdeextragear-3 $ digikam/digikam/digikam
> /home/rjt/devel/digikam/kdeextragear-3/digikam/digikam/.libs/lt-digikam: error
> while loading shared libraries: libexif.so.9: cannot open shared object file:
> No such file or directory
>
> I am not sure whether this is a problem with my setup or the configure stuff.

are both 0.5.12 and 0.6.9 installed? try running a make distclean and
recompiling from scratch.

renchi

-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
Richard Taylor | 3 Jun 19:29 2004
Picon

Re: kdeextragear-3/digikam

On Thursday 03 June 2004 14:49, Renchi Raju wrote:
> On Thu, 3 Jun 2004, Richard Taylor wrote:
> > Renchi
> >
> > This may be just because I have broken something but ...
> >
> > I have libexif-0.6.9 installed. The latest CVS builds fine, but when I
> > run the executable it is still looking for libexif.so.9. I get this
> > error:
> >
> > rjt@... kdeextragear-3 $ digikam/digikam/digikam
> > /home/rjt/devel/digikam/kdeextragear-3/digikam/digikam/.libs/lt-digikam:
> > error while loading shared libraries: libexif.so.9: cannot open shared
> > object file: No such file or directory
> >
> > I am not sure whether this is a problem with my setup or the configure
> > stuff.
>
> are both 0.5.12 and 0.6.9 installed? try running a make distclean and
> recompiling from scratch.
>

I have only 0.6.9 installed. I have tried:

	make distclean && make -f Makefile.cvs && ./configure && make

and I have tried:

	for i in `find . -name ".libs" -type d -print`; do rm -r $i ; done
	make distclean && make -f Makefile.cvs && ./configure && make
(Continue reading)

Renchi Raju | 3 Jun 19:38 2004
Picon

Re: kdeextragear-3/digikam

On Thu, 3 Jun 2004 18:29:42 +0100
Richard Taylor <rjt-digikam-devel@...> wrote:

> On Thursday 03 June 2004 14:49, Renchi Raju wrote:
>
> > are both 0.5.12 and 0.6.9 installed? try running a make distclean
> > and recompiling from scratch.
> >
> 
> I have only 0.6.9 installed. I have tried:
> 
> 	make distclean && make -f Makefile.cvs && ./configure && make
> 
> and I have tried:
> 
> 	for i in `find . -name ".libs" -type d -print`; do rm -r $i ;
> 	done make distclean && make -f Makefile.cvs && ./configure &&
> 	make
> 
> Just to make sure.
> 
> I still get the error. Could it be because another library is still
> expected to find 0.5.12? Should I just go back to 0.5.12 for now?

configure should not pick up 0.5.12 is 0.5.12 is not installed. you
might want to check if you have stale pkg-config files hanging around.

> PS. I have a patch that converts digikam to using KDockWindows.
> Unfortunately I can't test it against the current CVS code because
> of the libexif problem. It worked before the libexif change. 
(Continue reading)

Renchi Raju | 4 Jun 03:49 2004
Picon

indentation...

please don't change the indentation and comment style in existing code.
for eg, here
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdeextragear-3/digikam/digikam/digikamapp.cpp.diff?r1=1.11&r2=1.12&f=h

i had put the coding style for digikam earlier and i would like everyone
to follow that.
Coding style:
http://digikam.sourceforge.net/contrib.html

renchi

PS: if you are using emacs/xemacs kdesdk comes with a initialization file
which helps in consistent coding standards

-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
Caulier Gilles | 4 Jun 11:41 2004
Picon

Re: indentation...

Le vendredi 4 Juin 2004 03:49, Renchi Raju a écrit :
> please don't change the indentation and comment style in existing code.
> for eg, here
> http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdeextragear-3/digikam/digikam/dig
>ikamapp.cpp.diff?r1=1.11&r2=1.12&f=h
>
> i had put the coding style for digikam earlier and i would like everyone
> to follow that.
> Coding style:
> http://digikam.sourceforge.net/contrib.html

This is a problem with my new kdevelop intallation on my new laptop. I will 
fixed that

regards

>
> renchi
>
> PS: if you are using emacs/xemacs kdesdk comes with a initialization file
> which helps in consistent coding standards

I use only kdevelop or mc (:=)

-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
(Continue reading)

Renchi Raju | 4 Jun 16:10 2004
Picon

kdeextragear-3/digikam/kioslave

CVS commit by pahlibar: 

CCMAIL: digikam-devel <at> lists.sourceforge.net

Endianess fix. be very careful when dealing with image data at low level.
Qimage low-level data especially has to be handled specially for both
endian case. since we seem to be doing so much work converting from imlib2
image to qimage, it most likely doesn't make sense to use imlib2 loader
in the thumbnail loading routine

DATA32 *data = imlib_image_get_data();
if (!data)
    return false;

uint a,r,g,b;
uint* imgData = (uint*) image.bits();

for (int i = 0; i < new_width_*new_height_; i++) {

      a = (*data & 0xff000000) >> 24;
      r = (*data & 0xff0000)   >> 16;
      g = (*data & 0xff00)     >> 8;
      b = (*data & 0xff);

      *imgData = qRgba(r,g,b,a);

      data++;
      imgData++;
}

(Continue reading)

Renchi Raju | 4 Jun 17:15 2004
Picon

kdeextragear-3/digikam/kioslave

CVS commit by pahlibar: 

CCMAIL: digikam-devel <at> lists.sourceforge.net

seems i was wrong about the last commit. had a look at qt's color handling,
and they seem to be using the exact same color format (ARGB stored as an
unsigned int) as imlib2. thats good news as we can blast bytes from imlib2 
to qimage and back. reverted back to old code with slight improvement. 
removed x11 dependencies. indentation fixes

  M +24 -37    digikamthumbnail.cpp   1.6

--- kdeextragear-3/digikam/kioslave/digikamthumbnail.cpp  #1.5:1.6
 <at>  <at>  -58,8 +58,5  <at>  <at>  extern "C" 
 #include "digikamthumbnail.h"

-// X11 includes.
-
-#include <X11/Xlib.h>
-#include <X11/Xutil.h>
+#define X_DISPLAY_MISSING 1
 #include <Imlib2.h>

 <at>  <at>  -92,9 +89,12  <at>  <at>  void kio_digikamthumbnailProtocol::get(c
     QImage img;

-    if ( !loadJPEG(img, url.path()) )      // Try JPEG loading...
+    // Try JPEG loading...
+    if ( !loadJPEG(img, url.path()) )
        {
(Continue reading)


Gmane