Milian Wolff | 13 Dec 12:43

Re: Review Request: Add more php example code to show the formatters impact

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/

Ship it!

Ship It!

- Milian

On December 11th, 2011, 6:11 p.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 11, 2011, 6:11 p.m.

Description

Added some more php example code to show the impact of the formatter if applied

Diffs

languages/xml/formatter/formatterplugin.h (dbe183a)
languages/xml/formatter/formatterplugin.cpp (4e62a1e)
plugins/phpformatter/formatterplugin.h (6dc7028)
plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

headers

Milian Wolff | 13 Dec 12:43

Re: Review Request: Fix compiling of quanta master

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103386/

Ship it!

Ship It!

- Milian

On December 11th, 2011, 7:09 p.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 11, 2011, 7:09 p.m.

Description

Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile. This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter. During the testing it looked to me that there are two different options storing the indentation value for a formatter: "INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.

Diffs

languages/xml/formatter/formatterplugin.h (dbe183a)
languages/xml/formatter/formatterplugin.cpp (4e62a1e)
plugins/phpformatter/formatterplugin.h (6dc7028)
plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

headers

Milian Wolff | 13 Dec 18:55

Re: Review Request: Add more php example code to show the formatters impact

On Tuesday 13 December 2011 11:43:38 Milian Wolff wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103388/#review8906
> -----------------------------------------------------------
> 
> Ship it!

as I said on irc: please send the patch as created by "git format-patch"

thanks
--

-- 
Milian Wolff
mail <at> milianw.de
http://milianw.de

headers

Florian Zumkeller-Quast | 15 Dec 02:07

Re: Review Request: Fix compiling of quanta master

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103386/

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 15, 2011, 1:07 a.m.

Changes

Patch created by git format-patch as requested

Description

Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile. This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter. During the testing it looked to me that there are two different options storing the indentation value for a formatter: "INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.

Diffs (updated)

languages/xml/formatter/formatterplugin.h (dbe183a)
languages/xml/formatter/formatterplugin.cpp (4e62a1e)
plugins/phpformatter/formatterplugin.h (6dc7028)
plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

headers

Florian Zumkeller-Quast | 15 Dec 02:08

Re: Review Request: Add more php example code to show the formatters impact

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 15, 2011, 1:08 a.m.

Changes

Patch created by git format-patch as requested

Description

Added some more php example code to show the impact of the formatter if applied

Diffs (updated)

plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

headers

Milian Wolff | 23 Dec 21:17

Re: Review Request: Fix compiling of quanta master

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103386/

Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such. please try again

- Milian

On December 15th, 2011, 1:07 a.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 15, 2011, 1:07 a.m.

Description

Since the last changes of ISourceFormatter from KDevPlatform Quanta was broken and did not compile. This patch fixes the compiling issues by changing phpformatterplugin and xmlformatterplugin to the new interface of ISourceFormatter. During the testing it looked to me that there are two different options storing the indentation value for a formatter: "INDENT" and "indent_size". Because only the latter contained a non-zero value, i changed the behaviour to use the latter one.

Diffs

languages/xml/formatter/formatterplugin.h (dbe183a)
languages/xml/formatter/formatterplugin.cpp (4e62a1e)
plugins/phpformatter/formatterplugin.h (6dc7028)
plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

headers

Milian Wolff | 23 Dec 21:17

Re: Review Request: Add more php example code to show the formatters impact

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/

Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such. please try again

- Milian

On December 15th, 2011, 1:08 a.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 15, 2011, 1:08 a.m.

Description

Added some more php example code to show the impact of the formatter if applied

Diffs

plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

headers

Milian Wolff | 23 Dec 21:17

Re: Review Request: Add more php example code to show the formatters impact

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103388/

Uhm sorry, but when I download the diff it is still not in the "format-patch" format. Just look at the downloaded file, it directly starts with the patch and gives no information about you, nor any commit message or such. please try again

- Milian

On December 15th, 2011, 1:08 a.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.

By Florian Zumkeller-Quast.

Updated Dec. 15, 2011, 1:08 a.m.

Description

Added some more php example code to show the impact of the formatter if applied

Diffs

plugins/phpformatter/formatterplugin.cpp (f1ca6fd)

View Diff

_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel

Mon	Tue	Wed	Thu	Fri	Sat	Sun

			1	2	3	4
5	6	7	8	9	10	11
12	13	14	15	16	17	18
19	20	21	22	23	24	25
26	27	28	29	30	31

1	May 2012
3	April 2012
8	December 2011
5	November 2011
1	August 2011
2	March 2011
5	January 2011
2	July 2010
1	May 2010
4	March 2010
14	February 2010
1	January 2010
9	December 2009
1	October 2009
4	September 2009
7	August 2009
32	July 2009
8	May 2009
2	April 2009
6	March 2009
3	February 2009
2	January 2009
2	December 2008
4	October 2008
4	September 2008
2	July 2008
8	June 2008
7	May 2008
13	April 2008
12	March 2008
33	February 2008
6	January 2008
2	December 2007
8	November 2007
1	October 2007
21	June 2007
3	May 2007
14	April 2007
23	March 2007
27	February 2007
5	January 2007
22	December 2006
6	November 2006
1	October 2006
11	September 2006
22	August 2006
6	July 2006
2	June 2006
7	May 2006
58	April 2006
34	March 2006
11	February 2006
26	January 2006
43	December 2005
35	November 2005
1	October 2005
66	September 2005
101	August 2005
59	July 2005
78	June 2005
110	May 2005
138	April 2005
103	March 2005
183	February 2005
118	January 2005
156	December 2004
134	November 2004
152	October 2004
237	September 2004
57	August 2004
402	July 2004
279	June 2004
428	May 2004
597	April 2004
683	March 2004
531	February 2004
243	January 2004
171	December 2003
356	November 2003
621	October 2003
181	September 2003
253	August 2003
684	July 2003
346	June 2003
278	May 2003
185	April 2003
400	March 2003
83	February 2003