headers
Khudyakov Alexey | 1 Aug 17:57
Picon
Gravatar

Strange crash in FOV dialog

Hello. 

While testing FOV dialog I run into very strange crash bug. For me it's 100% 
reproducible. Go to FOV dialog and press 'Remove' button repeatedly. At some 
point KStars will crash with message:
  ASSERT failure in QList<T>::operator[]: "index out of range"

This happens when element is removed from KListBox with list of names. However 
index is within range so item should be deleted without problems. This look 
suspiciously like memory corruption.

Could anyone reproduce this?

--
  Khudyakov Alexey
Permalink | Reply | 0 comments |
headers
Khudyakov Alexey | 1 Aug 20:09
Picon
Gravatar

Use of uninitialized value

Hello 

in void KStarsData::syncUpdateIDs() , line 352
data member m_updateNumID could be used uninitialised. 

Could anyone who know how it works fix it?

--
  Khudyakov Alexey
Permalink | Reply | 1 comment |
headers
Akarsh Simha | 1 Aug 20:37
Picon
Gravatar

Re: Use of uninitialized value

On Sat, Aug 01, 2009 at 10:09:05PM +0400, Alexey Khudyakov wrote:
> Hello 
> 
> in void KStarsData::syncUpdateIDs() , line 352
> data member m_updateNumID could be used uninitialised. 
> 
> Could anyone who know how it works fix it?

I guess you could just try initializing it to zero? I don't know this
bit of code - you must ask James Bowlin.

Regards
Akarsh
Permalink | Reply | 0 comments |
headers
Khudyakov Alexey | 2 Aug 00:33
Picon
Gravatar

UID for comets

Hello

I've implemented UIDs for all objects but comets. So is there some unique 
designation for every comet so it could be used for UID?

As for AuxInfo. It should be stored in some kind of hash global hash. I 
believe inside KStarsData. Following API is proposed:

## KstarsData 

/** Return reference to object with UID equal to uid. Always return valid 
reference. if object doesn't exist in list creates empty object and return 
reference to it.
 */
AuxInfo& KStarsData::getAuxInfo(const SkyObject::UID& uid);

/** Check if AuxInfo for object present with such UID present in list. */
bool KStarData::hasAuxInfo(const SkyObject::UID& uid);

## SkyObject 
Add two proxy methods for SkyObject.

AuxInfo& SkyObject::getAuxInfo()
bool SktObject::hasAuxInfo() const;

Remove all old AuxObject related function from SkyObject. 
--
  Khudyakov Alexey
Permalink | Reply | 1 comment |
headers
Khudyakov Alexey | 2 Aug 00:29
Picon
Gravatar

Re: widgets/timebox.{h,cpp} are not used

On Среда 29 июля 2009 15:41:55 Khudyakov Alexey wrote:
> Hello.
>
> files widgets/timebox.{h,cpp} are not used anywhere and class timeBox which
> is defined there is not used either.
>
> Any objections against deletion?
> 
No one cares about little widgets. 

May they rest in peas.

_______________________________________________
Kstars-devel mailing list
Kstars-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
Permalink | Reply | 0 comments |
headers
Prakash Mohan | 2 Aug 09:49
Picon
Gravatar

branches/kstars/summer/kstars/kstars/comast

SVN commit 1005793 by prakash:

Creating a better form of the Execute UI. This displays a list of objects to be observed in the bottom, which
makes it quite convenient for the observers.

CCMAIL: kstars-devel <at> kde.org

 M  +69 -15    execute.cpp  
 M  +9 -1      execute.h  
 M  +462 -366  execute.ui  

http://websvn.kde.org/?view=rev&revision=1005793
Permalink | Reply | 0 comments |
headers
Prakash Mohan | 2 Aug 09:53
Picon
Gravatar

branches/kstars/summer/kstars/kstars/comast

SVN commit 1005794 by prakash:

Changing the label of the Next Button according to the page of the stackedWidget.

CCMAIL: kstars-devel <at> kde.org

 M  +2 -0      execute.cpp  

--- branches/kstars/summer/kstars/kstars/comast/execute.cpp #1005793:1005794
@@ -236,6 +236,7 @@
 void Execute::loadObservationTab() {
    ui.Time->setTime( KStarsDateTime::currentDateTime().time() );
    ui.stackedWidget->setCurrentIndex( 2 );
+   ui.NextButton->setText( i18n( "Next Target >" ) );
 }

 bool Execute::addObservation() {
@@ -346,6 +347,7 @@
         ui.AddObject->show();
         ui.stackedWidget->setCurrentIndex( 1 );
         ui.NextButton->show();
+        ui.NextButton->setText( i18n( "Next Page >" ) );
     }
 }
Permalink | Reply | 0 comments |
headers
Prakash Mohan | 2 Aug 09:56
Picon
Gravatar

branches/kstars/summer/kstars/kstars/comast

SVN commit 1005795 by prakash:

Changing the text of the KURLlabels in the Execute UI.

CCMAIL: kstars-devel <at> kde.org

 M  +3 -3      execute.ui  

--- branches/kstars/summer/kstars/kstars/comast/execute.ui #1005794:1005795
@@ -19,14 +19,14 @@
      <item>
       <widget class="KUrlLabel" name="SessionURL">
        <property name="text">
-        <string>Edit Session Details</string>
+        <string>Step 1: Session Details</string>
        </property>
       </widget>
      </item>
      <item>
       <widget class="KUrlLabel" name="ObservationsURL">
        <property name="text">
-        <string>Observations</string>
+        <string>Step 2: Observations</string>
        </property>
       </widget>
      </item>
@@ -49,7 +49,7 @@
      <item>
       <widget class="KUrlLabel" name="ConclusionsURL">
        <property name="text">
(Continue reading)

Permalink | Reply | 0 comments |
headers
Alexey Khudyakov | 2 Aug 12:57
Picon
Gravatar

KDE/kdeedu/kstars/kstars

SVN commit 1005835 by khudyakov:

Remove widgets/timebox.{h,cpp} they are not used 

CCMAIL: kstars-devel <at> kde.org

 M  +0 -1      CMakeLists.txt  
 D             widgets/timebox.cpp  
 D             widgets/timebox.h  

--- trunk/KDE/kdeedu/kstars/kstars/CMakeLists.txt #1005834:1005835
@@ -226,7 +226,6 @@
 	widgets/magnitudespinbox.cpp 
 	widgets/mapcanvas.cpp 
 	widgets/thumbimage.cpp 
-	widgets/timebox.cpp 
 	widgets/timespinbox.cpp 
 	widgets/timestepbox.cpp 
 	widgets/timeunitbox.cpp
Permalink | Reply | 0 comments |
headers
Alexey Khudyakov | 2 Aug 13:01
Picon
Gravatar

KDE/kdeedu/kstars/kstars

SVN commit 1005837 by khudyakov:

remove unneeded friends in  KStarsData class

CCMAIL: kstars-devel <at> kde.org

 M  +4 -15     kstarsdata.h  
 M  +1 -1      tools/wutdialog.cpp  

--- trunk/KDE/kdeedu/kstars/kstars/kstarsdata.h #1005836:1005837
@@ -89,20 +89,15 @@
     friend class KStars;
     friend class KSWizard;
     friend class LocationDialog;
-    friend class FOVDialog;
     friend class MapCanvas;
     friend class SkyMap;
     friend class FileSource;
-    friend class StarDataSink;
     friend class LCGenerator;
     friend class DetailDialog;
-    friend class AltVsTime;
-    friend class WUTDialog;
     friend class INDIDriver;
     friend class INDI_P;
     friend class INDIStdProperty;
     friend class PlanetViewer;
-    friend class JMoonTool;
     friend class telescopeWizardProcess;
     friend class ObsListWizard;
(Continue reading)

Permalink | Reply | 0 comments |

Gmane